[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-21 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596001#comment-15596001 ] Mikhail Antonov commented on HBASE-16664: - [~Apache9] [~chenheng] acked, thanks. labeled as in

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574102#comment-15574102 ] Heng Chen commented on HBASE-16664: --- I see it. If so, i suggest we just leave operationTimeout

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574081#comment-15574081 ] Phil Yang commented on HBASE-16664: --- I added them in HBASE-15645, but it broke compatibility that

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574072#comment-15574072 ] Heng Chen commented on HBASE-16664: --- I think we should add the setXXTimeout interface in Table for

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574057#comment-15574057 ] Phil Yang commented on HBASE-16664: --- HTable is a Private interface since 1.0, in theory users should

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574052#comment-15574052 ] Heng Chen commented on HBASE-16664: --- branch-1.1 and branch-1.2 patch seems not fix "setXXXTimeout not

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574033#comment-15574033 ] Heng Chen commented on HBASE-16664: --- OH, sorry, miss the two patch, let me commit them. > Timeout

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574031#comment-15574031 ] Phil Yang commented on HBASE-16664: --- Thanks [~chenheng], branch-1.1 and 1.2 have also bug-2 in the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573659#comment-15573659 ] Duo Zhang commented on HBASE-16664: --- Thanks [~chenheng]. And yeah this patch contains behavior changes

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572738#comment-15572738 ] Hudson commented on HBASE-16664: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #44 (See

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572711#comment-15572711 ] Hudson commented on HBASE-16664: FAILURE: Integrated in Jenkins build HBase-1.4 #467 (See

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572501#comment-15572501 ] stack commented on HBASE-16664: --- Thanks for pushing [~chenheng] ([~mantonov] -- pinging because you wanted

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572242#comment-15572242 ] Hudson commented on HBASE-16664: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #38 (See

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571706#comment-15571706 ] Heng Chen commented on HBASE-16664: --- push to branch-1.3 > Timeout logic in AsyncProcess is broken >

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571682#comment-15571682 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571650#comment-15571650 ] Hudson commented on HBASE-16664: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1778 (See

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571636#comment-15571636 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-13 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571399#comment-15571399 ] Heng Chen commented on HBASE-16664: --- Failed testcase of patch v2 on branch-1 is not related. Most of

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570746#comment-15570746 ] Heng Chen commented on HBASE-16664: --- Failed test cases for v7 seems not related. If you are not hurry,

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569413#comment-15569413 ] stack commented on HBASE-16664: --- Patch looks good to me. Default operational timeout is forever in essence

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569387#comment-15569387 ] stack commented on HBASE-16664: --- Sorry. Rereading the patch, I see BufferedMutator does have its own

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569089#comment-15569089 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568294#comment-15568294 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568177#comment-15568177 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568165#comment-15568165 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568089#comment-15568089 ] Phil Yang commented on HBASE-16664: --- Although the tracker in MultiServerCallable has been called

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567915#comment-15567915 ] Heng Chen commented on HBASE-16664: --- remove the line in MultiServerCallable.call in branch-1 patch

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567826#comment-15567826 ] Heng Chen commented on HBASE-16664: --- As for operationTimeout meaning, yeah, the operation should from

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-12 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567778#comment-15567778 ] Heng Chen commented on HBASE-16664: --- it should be better for tracker.start() moved into

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567711#comment-15567711 ] Heng Chen commented on HBASE-16664: --- OK. If all your guys agree with operation timeout should be

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567630#comment-15567630 ] stack commented on HBASE-16664: --- Operation timeout has always been a murky story full of surprises

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567527#comment-15567527 ] Heng Chen commented on HBASE-16664: --- {quote} Then just set operation timeout to Long.MAX_VALUE and use

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567473#comment-15567473 ] Phil Yang commented on HBASE-16664: --- {quote} My understanding is single-get is one operation and one

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567469#comment-15567469 ] Duo Zhang commented on HBASE-16664: --- Then just set operation timeout to Long.MAX_VALUE and use retry

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567465#comment-15567465 ] Heng Chen commented on HBASE-16664: --- {quote} We can not tell users "some operations don't support a

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567451#comment-15567451 ] Heng Chen commented on HBASE-16664: --- {quote} And I think for a user, I call the batch method, or the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567420#comment-15567420 ] Heng Chen commented on HBASE-16664: --- The typical case in our application is something like

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567407#comment-15567407 ] Phil Yang commented on HBASE-16664: --- I think the best practice is using different Table instances for

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567389#comment-15567389 ] Duo Zhang commented on HBASE-16664: --- {noformat} * This class is NOT thread safe for reads nor writes.

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567379#comment-15567379 ] Heng Chen commented on HBASE-16664: --- Normally we share one HTable object in our application. It is

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567348#comment-15567348 ] Duo Zhang commented on HBASE-16664: --- There is a setOperationTimeout method in the Table interface, you

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567343#comment-15567343 ] Heng Chen commented on HBASE-16664: --- For example, in our production cluster, we set operation timeout

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567335#comment-15567335 ] Duo Zhang commented on HBASE-16664: --- Multi get also uses batch, and it will be executed with

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567319#comment-15567319 ] Heng Chen commented on HBASE-16664: --- I think the reason we did not set total timeout for batch is that

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567296#comment-15567296 ] Duo Zhang commented on HBASE-16664: --- {quote} i think it is reasonable because operationTimeout should

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566707#comment-15566707 ] stack commented on HBASE-16664: --- Patch LGTM. Needs a fat release note. Good by you [~chenheng]? > Timeout

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565885#comment-15565885 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565512#comment-15565512 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565373#comment-15565373 ] Phil Yang commented on HBASE-16664: --- Patches for all branches uploaded, 1.1 and 1.2 is simpler because

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565364#comment-15565364 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564911#comment-15564911 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564908#comment-15564908 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564611#comment-15564611 ] Duo Zhang commented on HBASE-16664: --- +1 on the latest patch. [~yangzhe1991] Are you sure the failed UTs

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-09 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561351#comment-15561351 ] Phil Yang commented on HBASE-16664: --- upload patch to https://reviews.apache.org/r/52674/ > Timeout

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-09 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561201#comment-15561201 ] Duo Zhang commented on HBASE-16664: --- Could you please upload the patch to reviewboard? I can not find

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15560011#comment-15560011 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559670#comment-15559670 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558436#comment-15558436 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-08 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557945#comment-15557945 ] Phil Yang commented on HBASE-16664: --- The callable has some states which may be changed for each

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-08 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557544#comment-15557544 ] Phil Yang commented on HBASE-16664: --- {code} CancellableRegionServerCallable callable = currentCallable;

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-10-04 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545472#comment-15545472 ] Phil Yang commented on HBASE-16664: --- {quote} Now we use remaining==0 to check whether the timeout is

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529144#comment-15529144 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529035#comment-15529035 ] Heng Chen commented on HBASE-16664: --- Yes, the timeout logic has conflicts. After HBASE-16607,

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528946#comment-15528946 ] Heng Chen commented on HBASE-16664: --- So we could modify the operation timeout judgement logic in

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528826#comment-15528826 ] Phil Yang commented on HBASE-16664: --- We will never get operation timeout and each time we will retry

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528761#comment-15528761 ] Heng Chen commented on HBASE-16664: --- {quote} As I said, we can not use RetryingTimeTracker because it

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528739#comment-15528739 ] Phil Yang commented on HBASE-16664: --- As I said, we can not use RetryingTimeTracker because it will not

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528654#comment-15528654 ] Phil Yang commented on HBASE-16664: --- In the patch we pass a deadline(operation timeout) when init and

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528636#comment-15528636 ] Heng Chen commented on HBASE-16664: --- {quote} one is we use remaining time as the rpc timeout in

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528625#comment-15528625 ] Phil Yang commented on HBASE-16664: --- I think we have two bugs, one is we use remaining time as the rpc

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528624#comment-15528624 ] Phil Yang commented on HBASE-16664: --- I think we have two bugs, one is we use remaining time as the rpc

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-28 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528595#comment-15528595 ] Heng Chen commented on HBASE-16664: --- Just skim the patch, not see the big difference with the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526617#comment-15526617 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-25 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520300#comment-15520300 ] Heng Chen commented on HBASE-16664: --- Not sure what is your patch want to do. But if you want the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-25 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520289#comment-15520289 ] Heng Chen commented on HBASE-16664: --- {quote} The tracker must be started from beginning, not each call.

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517062#comment-15517062 ] Hadoop QA commented on HBASE-16664: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-23 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515633#comment-15515633 ] Phil Yang commented on HBASE-16664: --- Current we use RpcRetryingCaller's callWithoutRetries in AP, and

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-23 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515594#comment-15515594 ] Phil Yang commented on HBASE-16664: --- And for some operations, like append, we use

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-23 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515576#comment-15515576 ] Phil Yang commented on HBASE-16664: --- The current CancellableRegionServerCallable's logic is wrong, I

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509227#comment-15509227 ] Heng Chen commented on HBASE-16664: --- {quote} We don't considier rpc timeout any where... {quote} Yes,

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509217#comment-15509217 ] Phil Yang commented on HBASE-16664: --- Thanks [~chenheng] I think I find a bug. We use

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509008#comment-15509008 ] Heng Chen commented on HBASE-16664: --- yes, the default one in ap is rpcTimeout, but you could see

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508993#comment-15508993 ] Phil Yang commented on HBASE-16664: --- So the timeout in submitAll is the total time with retires

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508974#comment-15508974 ] Heng Chen commented on HBASE-16664: --- {quote} And AP is complicated so I have not found where is the

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508957#comment-15508957 ] Phil Yang commented on HBASE-16664: --- And after HBASE-16592 we use AP in delete. But on submit we pass

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508919#comment-15508919 ] Phil Yang commented on HBASE-16664: --- Oh, we have more than one AP for each HTable... In

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508911#comment-15508911 ] Phil Yang commented on HBASE-16664: --- I think maybe all branche-1.x have the bug. The difference of

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508894#comment-15508894 ] Heng Chen commented on HBASE-16664: --- Let me try it. > Timeout logic in AsyncProcess is broken >

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Phil Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508874#comment-15508874 ] Phil Yang commented on HBASE-16664: --- Master, I'm checking 1.x branches > Timeout logic in AsyncProcess

[jira] [Commented] (HBASE-16664) Timeout logic in AsyncProcess is broken

2016-09-21 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508872#comment-15508872 ] Mikhail Antonov commented on HBASE-16664: - Which branches does it affect? > Timeout logic in