[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195086#comment-16195086
]
Hudson commented on HBASE-16769:
Results for branch HBASE-18467, done in 4 hr 24 min and counting
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180452#comment-16180452
]
Hudson commented on HBASE-16769:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3781 (See
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180434#comment-16180434
]
Hudson commented on HBASE-16769:
FAILURE: Integrated in Jenkins build HBase-2.0 #580 (See
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180213#comment-16180213
]
Josh Elser commented on HBASE-16769:
bq. I can not close this issue as the subtask is still open. Can
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180208#comment-16180208
]
Anoop Sam John commented on HBASE-16769:
Pushed to master and branch-2. Thanks all for the
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179406#comment-16179406
]
Chia-Ping Tsai commented on HBASE-16769:
+1
> Deprecate/remove PB references from MasterObserver
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179227#comment-16179227
]
stack commented on HBASE-16769:
---
+1 [~anoop.hbase] Thanks.
> Deprecate/remove PB references from
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178599#comment-16178599
]
Anoop Sam John commented on HBASE-16769:
Tks Ram.
[~stack] waiting for ur +1 for committing
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176121#comment-16176121
]
Hadoop QA commented on HBASE-16769:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175959#comment-16175959
]
ramkrishna.s.vasudevan commented on HBASE-16769:
+1.
> Deprecate/remove PB references
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175264#comment-16175264
]
stack commented on HBASE-16769:
---
Sounds good to me [~anoop.hbase] Put up patch so I can +1 it. Add that the
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175192#comment-16175192
]
Anoop Sam John commented on HBASE-16769:
I prefer for this pre and post hooks
1. Add deprecation
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175185#comment-16175185
]
stack commented on HBASE-16769:
---
ok. so, you need to add to the patch "DON'T USE"?...
> Deprecate/remove
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175177#comment-16175177
]
Anoop Sam John commented on HBASE-16769:
Yes we do have default impl in the interface
default
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175167#comment-16175167
]
stack commented on HBASE-16769:
---
bq. That time the hook was added as general purpose thing.. But ya may be
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175121#comment-16175121
]
Anoop Sam John commented on HBASE-16769:
That time the hook was added as general purpose thing..
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175109#comment-16175109
]
stack commented on HBASE-16769:
---
[~anoop.hbase] Thanks for pointing me at the original JIRA that added this
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175105#comment-16175105
]
Anoop Sam John commented on HBASE-16769:
This method of listing snapshot is used from another
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174951#comment-16174951
]
ramkrishna.s.vasudevan commented on HBASE-16769:
Comment on withCpCall already been said
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174426#comment-16174426
]
Anoop Sam John commented on HBASE-16769:
bq.AC should be internal, not as a CP?
That would be
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174232#comment-16174232
]
stack commented on HBASE-16769:
---
Thanks [~anoop.hbase]
AC should be internal, not as a CP?
Which issue
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174224#comment-16174224
]
Anoop Sam John commented on HBASE-16769:
For getting the edits/cells which are getting
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173793#comment-16173793
]
stack commented on HBASE-16769:
---
Thanks for working on this ugly one [~anoop.hbase]
What about this:
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173593#comment-16173593
]
Hadoop QA commented on HBASE-16769:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173472#comment-16173472
]
Anoop Sam John commented on HBASE-16769:
Ping [~ram_krish], [~st...@gmail.com] for reviews
>
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173469#comment-16173469
]
Anoop Sam John commented on HBASE-16769:
Thanks for the review.. Will fix...
Ya I was trying to
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173409#comment-16173409
]
Chia-Ping Tsai commented on HBASE-16769:
{code}
+withCpCall = withCpCall && cpHost != null;
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164824#comment-16164824
]
Josh Elser commented on HBASE-16769:
bq. Sorry I dont mean any change in the impl way
We're on the
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164189#comment-16164189
]
Anoop Sam John commented on HBASE-16769:
bq. I'll leave the implementation as is and update the
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163648#comment-16163648
]
Josh Elser commented on HBASE-16769:
bq. One req is supposed to have only one of these 3 settings
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163561#comment-16163561
]
Anoop Sam John commented on HBASE-16769:
At client side, when user called any of the method in
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163545#comment-16163545
]
Josh Elser commented on HBASE-16769:
Came across something that's a bit ambiguous.
Regarding the
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163401#comment-16163401
]
Josh Elser commented on HBASE-16769:
Thanks [~anoop.hbase]! I see now what the goal is (prevent
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161423#comment-16161423
]
Josh Elser commented on HBASE-16769:
[~anoop.hbase], sure! Thanks for the ping. Let me try to get up
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161202#comment-16161202
]
Anoop Sam John commented on HBASE-16769:
[~elserj] Will you be interested to work on the Quota
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159813#comment-16159813
]
Anoop Sam John commented on HBASE-16769:
The Master side CP hooks are around Quota and Snapshot..
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159720#comment-16159720
]
stack commented on HBASE-16769:
---
Sorry. Took me a while. I know you lads have been in here a while but this
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552573#comment-15552573
]
Anoop Sam John commented on HBASE-16769:
Atleast in the RSO pre/postReplicateLogEntries, we can
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552282#comment-15552282
]
stack commented on HBASE-16769:
---
In the past we talked about not unmarshalling pb objects and making POJOs
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551425#comment-15551425
]
ramkrishna.s.vasudevan commented on HBASE-16769:
Going thro those RegionServerObserver
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551142#comment-15551142
]
Anoop Sam John commented on HBASE-16769:
Ya I am getting ur point.. If u see, the convertion of
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551132#comment-15551132
]
Anoop Sam John commented on HBASE-16769:
Ping [~apurtell] also.
> Deprecate/remove PB references
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549426#comment-15549426
]
Anoop Sam John commented on HBASE-16769:
We should continue passing the PB objects as CP params?
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549381#comment-15549381
]
stack commented on HBASE-16769:
---
I think -1 on any convertion of an object just to make a CP call.
>
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549374#comment-15549374
]
Anoop Sam John commented on HBASE-16769:
Master CP hooks are around snapshot and quota features.
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549233#comment-15549233
]
stack commented on HBASE-16769:
---
Actually, thinking on it, the only way to put back the unshaded arguments
[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547969#comment-15547969
]
Anoop Sam John commented on HBASE-16769:
After the shading of PB, we break the BC of these APIs
47 matches
Mail list logo
