[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205666#comment-16205666
]
ramkrishna.s.vasudevan commented on HBASE-18945:
[~chia7712], [~Apache9],
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205489#comment-16205489
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Oh sorry. I did not add the new file
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205482#comment-16205482
]
Hadoop QA commented on HBASE-18945:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203747#comment-16203747
]
Hadoop QA commented on HBASE-18945:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203381#comment-16203381
]
Hadoop QA commented on HBASE-18945:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201693#comment-16201693
]
Chia-Ping Tsai commented on HBASE-18945:
bq. 'ramkrishna vasudevan got a fish trophy!' -
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201600#comment-16201600
]
ramkrishna.s.vasudevan commented on HBASE-18945:
'ramkrishna vasudevan got a fish
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200521#comment-16200521
]
stack commented on HBASE-18945:
---
I am arguing elsewhere AGAINST CoprocessorRegionServerServices; that
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200442#comment-16200442
]
Chia-Ping Tsai commented on HBASE-18945:
If the {{compareKeyBasedOnColHint}} and
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200290#comment-16200290
]
Anoop Sam John commented on HBASE-18945:
bq.Or that it is OK for us to also use the interface in
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200254#comment-16200254
]
Duo Zhang commented on HBASE-18945:
---
I think CellComparator as the interface name is better than
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199940#comment-16199940
]
Chia-Ping Tsai commented on HBASE-18945:
Adding the prefix "CP" is ok to me, but the one thing i
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199815#comment-16199815
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Ping [~saint@gmail.com] and
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199398#comment-16199398
]
Hadoop QA commented on HBASE-18945:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198169#comment-16198169
]
ramkrishna.s.vasudevan commented on HBASE-18945:
bq.That is really weird...If avoiding
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197425#comment-16197425
]
Chia-Ping Tsai commented on HBASE-18945:
bq. existing CellComparator remain and will introduce
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197341#comment-16197341
]
ramkrishna.s.vasudevan commented on HBASE-18945:
I finally thought let the existing
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196590#comment-16196590
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Yes. That is what am trying now. Name
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196586#comment-16196586
]
Anoop Sam John commented on HBASE-18945:
Can we some way keep the name of the impl class as
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196521#comment-16196521
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Can we name it as HCellComparator? Or
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196509#comment-16196509
]
ramkrishna.s.vasudevan commented on HBASE-18945:
bq.Can you make the case in the
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196505#comment-16196505
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Thanks for the reviews.
Oh. I think we
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195000#comment-16195000
]
Chia-Ping Tsai commented on HBASE-18945:
bq. You have to strike @InterfaceStability.Evolving from
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194841#comment-16194841
]
stack commented on HBASE-18945:
---
You have to strike @InterfaceStability.Evolving from CellComparator
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194452#comment-16194452
]
Hadoop QA commented on HBASE-18945:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194182#comment-16194182
]
ramkrishna.s.vasudevan commented on HBASE-18945:
bq.Even if Store and StoreFile also
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194179#comment-16194179
]
Anoop Sam John commented on HBASE-18945:
What I mean is the Comparator that we return from Store
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194150#comment-16194150
]
ramkrishna.s.vasudevan commented on HBASE-18945:
bq.We have it in Region, Store,
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193007#comment-16193007
]
Chia-Ping Tsai commented on HBASE-18945:
Should we purge the Serializable if we prepare to make
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192862#comment-16192862
]
Anoop Sam John commented on HBASE-18945:
+1
Also see whether we need this getComparator from many
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192829#comment-16192829
]
ramkrishna.s.vasudevan commented on HBASE-18945:
So for this issue also shall we use the
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192475#comment-16192475
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Ya did it. I forgot to make it as a
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192469#comment-16192469
]
Anoop Sam John commented on HBASE-18945:
Move it as a sub task for HBASE-18169?
> Make a Public
[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192464#comment-16192464
]
ramkrishna.s.vasudevan commented on HBASE-18945:
Ping [~Apache9] and [~anoop.hbase].
>
34 matches
Mail list logo
