[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283877#comment-16283877
]
stack commented on HBASE-19301:
---
Link to issue to implement suggestion by [~zghaobac] that we block CP
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283879#comment-16283879
]
stack commented on HBASE-19301:
---
Good idea [~zghaobac] I linked new issue.
> Provide way for CPs to create
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283493#comment-16283493
]
Guanghao Zhang commented on HBASE-19301:
Sorry for reply late because my personal stuff... +1 for
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282408#comment-16282408
]
Hudson commented on HBASE-19301:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4185 (See
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281385#comment-16281385
]
Anoop Sam John commented on HBASE-19301:
Nice warns and clear messages to user.. +1 Stack.
>
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281213#comment-16281213
]
stack commented on HBASE-19301:
---
.001 subsumes [~anoop.hbase] addendum beefing up the warning and dangers
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279700#comment-16279700
]
stack commented on HBASE-19301:
---
Yeah, CoreCoprocessors may make heavy-use of the RS Connection. I suppose
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279675#comment-16279675
]
Anoop Sam John commented on HBASE-19301:
On removing the getConnection() - the issue is our CPs
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279640#comment-16279640
]
stack commented on HBASE-19301:
---
To be clear, suggestion:
* Leave getConfiguration in place. Add
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279186#comment-16279186
]
stack commented on HBASE-19301:
---
[~zghaobac], [~anoop.hbase], and I fell into an off-list conversation on
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268274#comment-16268274
]
Guanghao Zhang commented on HBASE-19301:
bq. Not just doc..
Yes. I mean we can only fix the
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268256#comment-16268256
]
Anoop Sam John commented on HBASE-19301:
Not just doc.. This will be really strange. Again one
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268227#comment-16268227
]
Guanghao Zhang commented on HBASE-19301:
bq. But the effective user as seen by the code paths may
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268223#comment-16268223
]
Anoop Sam John commented on HBASE-19301:
Ys. We can not really say here the user.
On short
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268190#comment-16268190
]
Guanghao Zhang commented on HBASE-19301:
bq. the RPC user within the connection will always be
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268182#comment-16268182
]
stack commented on HBASE-19301:
---
This one is almost done then [~anoop.hbase]? Just add doc on commit sir?
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263578#comment-16263578
]
Guanghao Zhang commented on HBASE-19301:
bq. we need to add doc that it will be a short-circuited
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263576#comment-16263576
]
Guanghao Zhang commented on HBASE-19301:
Open a HBASE-19334 for the ACL problem. The ACL problem
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263569#comment-16263569
]
stack commented on HBASE-19301:
---
[~zghaobac] Ok. Thanks. Your issue that we need to add doc that it will be
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263536#comment-16263536
]
Guanghao Zhang commented on HBASE-19301:
Sorry, sir. This issue is great to resolve what the
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263287#comment-16263287
]
stack commented on HBASE-19301:
---
[~anoop.hbase] I am not following what the [~zghaobac] comment is about
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263258#comment-16263258
]
Anoop Sam John commented on HBASE-19301:
Will give a doc patch and get it in.
bq. You suggesting
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263210#comment-16263210
]
stack commented on HBASE-19301:
---
Yep to doc. We can only get the ACL region if it is local. You suggesting
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262952#comment-16262952
]
Anoop Sam John commented on HBASE-19301:
Good points. The created connection having the same
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262819#comment-16262819
]
stack commented on HBASE-19301:
---
Or [~zghaobac], just doc that createConnection is short-circuit and will
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262050#comment-16262050
]
Guanghao Zhang commented on HBASE-19301:
Check the code for AccessController. Even we use
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261418#comment-16261418
]
Hudson commented on HBASE-19301:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4093 (See
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261333#comment-16261333
]
Hudson commented on HBASE-19301:
FAILURE: Integrated in Jenkins build HBase-2.0 #891 (See
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261106#comment-16261106
]
Anoop Sam John commented on HBASE-19301:
Ya.. That will be very difficult to maintain.. We can
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261079#comment-16261079
]
stack commented on HBASE-19301:
---
Seeing the patch, createConnection is better than getConnection. +1 on
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260697#comment-16260697
]
Guanghao Zhang commented on HBASE-19301:
+1.
> Provide way for CPs to create short circuited
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260673#comment-16260673
]
Hadoop QA commented on HBASE-19301:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260466#comment-16260466
]
Hadoop QA commented on HBASE-19301:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260324#comment-16260324
]
stack commented on HBASE-19301:
---
Go for it.
> Provide way for CPs to create short circuited connection
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260319#comment-16260319
]
Anoop Sam John commented on HBASE-19301:
Ok I will change it. I hope Stack is not really against
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260318#comment-16260318
]
Guanghao Zhang commented on HBASE-19301:
bq. We can do in another issue?
Agree.
bq. Ya
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260304#comment-16260304
]
Guanghao Zhang commented on HBASE-19301:
What I care about is how to avoid user misuse these
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260302#comment-16260302
]
Anoop Sam John commented on HBASE-19301:
bq.I left a "TODO: Use Table.put(Put) instead." in
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260294#comment-16260294
]
stack commented on HBASE-19301:
---
Good stuff [~anoop.hbase] See the [~zghaobac] comment. [~zghaobac] I hear
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260290#comment-16260290
]
Anoop Sam John commented on HBASE-19301:
Thanks for the detailed comment Stack. Ya agree to all..
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260288#comment-16260288
]
Guanghao Zhang commented on HBASE-19301:
How about name it to createConnection(conf)? This will
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259598#comment-16259598
]
stack commented on HBASE-19301:
---
bq. Only the connection created within RS will use this way.
Yeah. Calls
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259538#comment-16259538
]
Anoop Sam John commented on HBASE-19301:
So u were suggesting that the normal way of connection
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258883#comment-16258883
]
Anoop Sam John commented on HBASE-19301:
bq.A Connection accessing local Server will
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258836#comment-16258836
]
stack commented on HBASE-19301:
---
bq. he only disadvantage will be that it will NOT be a short circuit
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258832#comment-16258832
]
Anoop Sam John commented on HBASE-19301:
CPs can create own connection with custom configs as how
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258827#comment-16258827
]
stack commented on HBASE-19301:
---
Thinking about this, do we need to add this to CpEnv [~anoop.hbase]? What
[
https://issues.apache.org/jira/browse/HBASE-19301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258582#comment-16258582
]
Hadoop QA commented on HBASE-19301:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
48 matches
Mail list logo