[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379796#comment-16379796
]
Chia-Ping Tsai commented on HBASE-20069:
Your message beat me by one second. That is a good news
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379793#comment-16379793
]
Chia-Ping Tsai commented on HBASE-20069:
What error the amendment want to fix? Trying to follow
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379791#comment-16379791
]
stack commented on HBASE-20069:
---
I just put this back. Chatting w/ [~appy] it was a bad nightly build that
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379782#comment-16379782
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379507#comment-16379507
]
stack commented on HBASE-20069:
---
Retry the amendment. Was reverted because suspect responsible for our
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378489#comment-16378489
]
Hudson commented on HBASE-20069:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #4657 (See
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378158#comment-16378158
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378008#comment-16378008
]
stack commented on HBASE-20069:
---
Thanks [~chia7712]. Let me fix the newly reported findbugs while I'm
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377997#comment-16377997
]
Hudson commented on HBASE-20069:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4655 (See
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377925#comment-16377925
]
Chia-Ping Tsai commented on HBASE-20069:
+1 to addendum
> fix existing findbugs errors in
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377918#comment-16377918
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377828#comment-16377828
]
stack commented on HBASE-20069:
---
bq. The "==" work well even if we use anonymous class.
Ok. Let me do this
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377820#comment-16377820
]
Chia-Ping Tsai commented on HBASE-20069:
{quote}We cannot have WakeupFlushThread be anonymous as
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377814#comment-16377814
]
stack commented on HBASE-20069:
---
Or, let me push this. I want it in so we have chance of a successful
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377809#comment-16377809
]
stack commented on HBASE-20069:
---
Any +1s?
> fix existing findbugs errors in hbase-server
>
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377602#comment-16377602
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377376#comment-16377376
]
stack commented on HBASE-20069:
---
.004 addresses feedback by [~chia7712], [~Apache9], and help from
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377305#comment-16377305
]
stack commented on HBASE-20069:
---
Thanks for helpful review [~chia7712].
Let me see if fb complains about
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376514#comment-16376514
]
Chia-Ping Tsai commented on HBASE-20069:
The change introduced by
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376510#comment-16376510
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376404#comment-16376404
]
stack commented on HBASE-20069:
---
.003 address checkstyle (all but an ordering issue... that seems right to
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376028#comment-16376028
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375981#comment-16375981
]
stack commented on HBASE-20069:
---
[~eshcar] If you get a chance, check out what this patch does to
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375980#comment-16375980
]
stack commented on HBASE-20069:
---
.002 addresses [~mdrob] review and more sketchyness on my part was found
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375883#comment-16375883
]
stack commented on HBASE-20069:
---
Thanks for the review [~mdrob]
You are right... Looks like I need to
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375857#comment-16375857
]
Hadoop QA commented on HBASE-20069:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375839#comment-16375839
]
Mike Drob commented on HBASE-20069:
---
I think the dead store in MutliButeBuf needs to be addressed by
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375773#comment-16375773
]
stack commented on HBASE-20069:
---
.001 Try to fix all findbugs extant. Looks like findbugs has been off for
[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375639#comment-16375639
]
Sean Busbey commented on HBASE-20069:
-
attached report for the hbase-server module from recent
29 matches
Mail list logo
