[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306294#comment-14306294
]
stack commented on HBASE-4605:
--
This went into trunk here:
063fa64 HBASE-4605 Constraints,
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172753#comment-13172753
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172774#comment-13172774
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172781#comment-13172781
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172785#comment-13172785
]
Zhihong Yu commented on HBASE-4605:
---
I created HBASE-5070 where further code changes
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172979#comment-13172979
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172978#comment-13172978
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172993#comment-13172993
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172996#comment-13172996
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171708#comment-13171708
]
stack commented on HBASE-4605:
--
Ok. Thanks lads. Good there is not extra dependency
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171462#comment-13171462
]
stack commented on HBASE-4605:
--
Did this patch add guava as a client-side dependency in the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171466#comment-13171466
]
Zhihong Yu commented on HBASE-4605:
---
Guava dependency has been removed.
Feel free to
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171468#comment-13171468
]
Jesse Yates commented on HBASE-4605:
@Stack: yeah, we can definitely made mods later.
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171469#comment-13171469
]
Jesse Yates commented on HBASE-4605:
@stack: and we kept guava out still and basically
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170371#comment-13170371
]
Zhihong Yu commented on HBASE-4605:
---
Integrated to TRUNK.
Thanks for the patch Jesse.
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170720#comment-13170720
]
Hudson commented on HBASE-4605:
---
Integrated in HBase-TRUNK #2548 (See
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170777#comment-13170777
]
Hudson commented on HBASE-4605:
---
Integrated in HBase-TRUNK-security #33 (See
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169570#comment-13169570
]
Jesse Yates commented on HBASE-4605:
I'd like to get the comments updated as per the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169645#comment-13169645
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169648#comment-13169648
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169764#comment-13169764
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168752#comment-13168752
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168763#comment-13168763
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168926#comment-13168926
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169025#comment-13169025
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169032#comment-13169032
]
Jesse Yates commented on HBASE-4605:
Hmm, didn't touch any of the admin code, but it
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169075#comment-13169075
]
Zhihong Yu commented on HBASE-4605:
---
TestHTableDescriptor misses category.
Other than
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168145#comment-13168145
]
Gary Helmling commented on HBASE-4605:
--
{quote}
Guava- I didn't know about the effort
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164765#comment-13164765
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163923#comment-13163923
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163926#comment-13163926
]
Jesse Yates commented on HBASE-4605:
@Gary:
Guava- I didn't know about the effort to
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163939#comment-13163939
]
Ted Yu commented on HBASE-4605:
---
Renaming IntegrationTestConstraint as described above makes
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163944#comment-13163944
]
Zhihong Yu commented on HBASE-4605:
---
w.r.t. atomicity, it is outside the initial scope
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162559#comment-13162559
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162565#comment-13162565
]
Ted Yu commented on HBASE-4605:
---
Thanks Gary for the detailed review.
For the check() API:
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159153#comment-13159153
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159508#comment-13159508
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159513#comment-13159513
]
Jesse Yates commented on HBASE-4605:
Latest patch does _not_ have labeling of tests
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159516#comment-13159516
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158947#comment-13158947
]
Ted Yu commented on HBASE-4605:
---
About the changes to book.xml:
{code}
+Constraints
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158121#comment-13158121
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158126#comment-13158126
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158139#comment-13158139
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158215#comment-13158215
]
Jesse Yates commented on HBASE-4605:
Hmmm, so it looks like most of them failed. So
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158227#comment-13158227
]
Ted Yu commented on HBASE-4605:
---
From
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156280#comment-13156280
]
Ted Yu commented on HBASE-4605:
---
@Jesse:
Patch v6 doesn't apply cleanly:
{code}
Hunk #13
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156287#comment-13156287
]
Jesse Yates commented on HBASE-4605:
Yeah, sure. I actually just ran into the same
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156290#comment-13156290
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156411#comment-13156411
]
Hadoop QA commented on HBASE-4605:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152148#comment-13152148
]
Ted Yu commented on HBASE-4605:
---
I got compilation error trying to run integration test:
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152166#comment-13152166
]
Ted Yu commented on HBASE-4605:
---
I went through HTableDescriptor where the
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152226#comment-13152226
]
Jesse Yates commented on HBASE-4605:
bq. I got compilation error trying to run
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152233#comment-13152233
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152312#comment-13152312
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152368#comment-13152368
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152381#comment-13152381
]
Ted Yu commented on HBASE-4605:
---
I got the following for patch v5:
{code}
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152390#comment-13152390
]
Jesse Yates commented on HBASE-4605:
Sorry about the quality of these patches Ted,
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152400#comment-13152400
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151892#comment-13151892
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145266#comment-13145266
]
Jesse Yates commented on HBASE-4605:
@Ted:
{quote}
I only see synchronized keyword on
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140503#comment-13140503
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139709#comment-13139709
]
Jesse Yates commented on HBASE-4605:
@Ted: ok, fair enough. I'm just trying to work
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139842#comment-13139842
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139843#comment-13139843
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139854#comment-13139854
]
Ted Yu commented on HBASE-4605:
---
In the above patch, why do we need two loops in
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139858#comment-13139858
]
Ted Yu commented on HBASE-4605:
---
I think the name of table should be added to the following
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139887#comment-13139887
]
Ted Yu commented on HBASE-4605:
---
@Jesse:
I only see synchronized keyword on
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139313#comment-13139313
]
Ted Yu commented on HBASE-4605:
---
Should we add method for enabling/disabling individual
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139380#comment-13139380
]
Jesse Yates commented on HBASE-4605:
{quote}
w.r.t. performance after several rounds
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139054#comment-13139054
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139099#comment-13139099
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139100#comment-13139100
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
bq. On
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139101#comment-13139101
]
Ted Yu commented on HBASE-4605:
---
To preserve order of constraints, we can embed their
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139104#comment-13139104
]
Ted Yu commented on HBASE-4605:
---
To enable/disable a constraint, the value (a Configuration
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139110#comment-13139110
]
Jesse Yates commented on HBASE-4605:
bq. To preserve order of constraints, we can
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139113#comment-13139113
]
Ted Yu commented on HBASE-4605:
---
w.r.t. performance after several rounds of
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137329#comment-13137329
]
Ted Yu commented on HBASE-4605:
---
See HBASE-4554 which can be used as example for setting
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136498#comment-13136498
]
Ted Yu commented on HBASE-4605:
---
@Jesse:
Can you publish your patch on review board ?
I see
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136531#comment-13136531
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136563#comment-13136563
]
jirapos...@reviews.apache.org commented on HBASE-4605:
--
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136729#comment-13136729
]
Jesse Yates commented on HBASE-4605:
Also, this patch (clearly) does not include
[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131937#comment-13131937
]
Gary Helmling commented on HBASE-4605:
--
Summarizing some comments from a related
82 matches
Mail list logo
