[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566499#comment-13566499
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566695#comment-13566695
]
Hudson commented on HBASE-7503:
---
Integrated in HBase-TRUNK #3827 (See
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567264#comment-13567264
]
Hudson commented on HBASE-7503:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #385 (See
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565767#comment-13565767
]
Sergey Shelukhin commented on HBASE-7503:
-
+1
Add exists(List)
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565866#comment-13565866
]
Ted Yu commented on HBASE-7503:
---
TestAdmin failed in the last QA run.
Mind attaching the
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566057#comment-13566057
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566082#comment-13566082
]
Ted Yu commented on HBASE-7503:
---
We're really close.
@Jean-Marc:
If you can find out the 3
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564725#comment-13564725
]
Sergey Shelukhin commented on HBASE-7503:
-
bq. MapInteger, ListGet getsByRegion =
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564729#comment-13564729
]
Sergey Shelukhin commented on HBASE-7503:
-
Actually, nevermind about the array, I
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562663#comment-13562663
]
Jean-Marc Spaggiari commented on HBASE-7503:
Hi Ted,
To detect the complexiti
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562674#comment-13562674
]
Ted Yu commented on HBASE-7503:
---
You don't need to sort the regions in the table. The start
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562680#comment-13562680
]
Jean-Marc Spaggiari commented on HBASE-7503:
I was wondering for the regions
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562950#comment-13562950
]
Ted Yu commented on HBASE-7503:
---
@Jean-Marc:
Can you attach latest patch here ?
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13563007#comment-13563007
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561667#comment-13561667
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561671#comment-13561671
]
Jean-Marc Spaggiari commented on HBASE-7503:
I ran
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561689#comment-13561689
]
Ted Yu commented on HBASE-7503:
---
@Jean-Marc:
Mind attaching your patch again ?
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561693#comment-13561693
]
Jean-Marc Spaggiari commented on HBASE-7503:
The same version? Or should I
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561703#comment-13561703
]
Ted Yu commented on HBASE-7503:
---
Hadoop QA looks at attachment Id, not file name. Meaning,
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561777#comment-13561777
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561832#comment-13561832
]
Sergey Shelukhin commented on HBASE-7503:
-
+1 on latest patch...
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562124#comment-13562124
]
Ted Yu commented on HBASE-7503:
---
{code}
+for (final Get get : gets) {
+ Integer
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562205#comment-13562205
]
Ted Yu commented on HBASE-7503:
---
Suppose there're G Get's and R regions in the table, the
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562294#comment-13562294
]
Jean-Marc Spaggiari commented on HBASE-7503:
I totally agree with your
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562306#comment-13562306
]
Ted Yu commented on HBASE-7503:
---
@Jean-Marc:
As you said, we don't always need to sort.
A
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559835#comment-13559835
]
Sergey Shelukhin commented on HBASE-7503:
-
Btw my above comments (other than on
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560200#comment-13560200
]
Ted Yu commented on HBASE-7503:
---
From
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560206#comment-13560206
]
Sergey Shelukhin commented on HBASE-7503:
-
Can closestRowBefore then be added to
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560208#comment-13560208
]
Sergey Shelukhin commented on HBASE-7503:
-
Btw, I mentioned working patch because
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560233#comment-13560233
]
Jean-Marc Spaggiari commented on HBASE-7503:
@Sergey, do you mean something
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560242#comment-13560242
]
Ted Yu commented on HBASE-7503:
---
Patch v12 is of 815KB which is significantly larger than
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557615#comment-13557615
]
Ted Yu commented on HBASE-7503:
---
From
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557633#comment-13557633
]
Jean-Marc Spaggiari commented on HBASE-7503:
I forgot the ClientProto.java :(
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557650#comment-13557650
]
Jean-Marc Spaggiari commented on HBASE-7503:
Will take a bit more time.
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557732#comment-13557732
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557736#comment-13557736
]
Sergey Shelukhin commented on HBASE-7503:
-
It's still not clear if
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557738#comment-13557738
]
Sergey Shelukhin commented on HBASE-7503:
-
{code}
Input: ListGet gets;
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557745#comment-13557745
]
Sergey Shelukhin commented on HBASE-7503:
-
also, = i should be .add(i)
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554978#comment-13554978
]
Jean-Marc Spaggiari commented on HBASE-7503:
I will update the proposed patch
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555072#comment-13555072
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555380#comment-13555380
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555443#comment-13555443
]
Jean-Marc Spaggiari commented on HBASE-7503:
I ran TestColumnSeeking locally
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555448#comment-13555448
]
Ted Yu commented on HBASE-7503:
---
You can wait for more review comments.
Then you would have
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1304#comment-1304
]
Jean-Marc Spaggiari commented on HBASE-7503:
Ok. Thanks. I will wait and see.
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555695#comment-13555695
]
Sergey Shelukhin commented on HBASE-7503:
-
bq. optional bool closestRowBefore =
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555718#comment-13555718
]
Ted Yu commented on HBASE-7503:
---
bq. are region boundaries in HBase [] or [)? It would seem
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555747#comment-13555747
]
Jean-Marc Spaggiari commented on HBASE-7503:
Thanks for the comments/review.
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554403#comment-13554403
]
Jean-Marc Spaggiari commented on HBASE-7503:
Hi Ted,
I have some time to
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554424#comment-13554424
]
Ted Yu commented on HBASE-7503:
---
I once tried 'repeated optionnal' but protoc wouldn't
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554449#comment-13554449
]
Devaraj Das commented on HBASE-7503:
bq. Is there a way to put repeated optionnal? Or
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554515#comment-13554515
]
Ted Yu commented on HBASE-7503:
---
@Jean-Marc:
You need to run protoc and include the diff for
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554529#comment-13554529
]
Ted Yu commented on HBASE-7503:
---
{code}
+ * @param regionName the name of the region to
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554607#comment-13554607
]
Jean-Marc Spaggiari commented on HBASE-7503:
I never heard about the Review
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554671#comment-13554671
]
Ted Yu commented on HBASE-7503:
---
Here is the review request:
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554678#comment-13554678
]
Ted Yu commented on HBASE-7503:
---
There is compilation error for latest patch:
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552094#comment-13552094
]
Jean-Marc Spaggiari commented on HBASE-7503:
About the Client.proto, should it
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552102#comment-13552102
]
Hadoop QA commented on HBASE-7503:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552109#comment-13552109
]
Ted Yu commented on HBASE-7503:
---
For the following:
{code}
repeated GetRequest get = 2;
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552124#comment-13552124
]
Jean-Marc Spaggiari commented on HBASE-7503:
The idea is the following.
We
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552126#comment-13552126
]
Ted Yu commented on HBASE-7503:
---
For the implementation I was thinking of, MultiGetRequest
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545870#comment-13545870
]
Jean-Marc Spaggiari commented on HBASE-7503:
Hi Ted,
Thanks for your
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545962#comment-13545962
]
Ted Yu commented on HBASE-7503:
---
For #1, I meant adding the following call:
{code}
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545581#comment-13545581
]
Hadoop QA commented on HBASE-7503:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545586#comment-13545586
]
Ted Yu commented on HBASE-7503:
---
Consider adding the new test to TestFromClientSide3.java -
64 matches
Mail list logo