[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832508#comment-13832508 ] Hudson commented on HBASE-8465: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #852 (Se

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832254#comment-13832254 ] Hudson commented on HBASE-8465: --- FAILURE: Integrated in HBase-TRUNK #4698 (See [https://bui

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832184#comment-13832184 ] Hudson commented on HBASE-8465: --- SUCCESS: Integrated in hbase-0.96-hadoop2 #132 (See [https

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831873#comment-13831873 ] Hudson commented on HBASE-8465: --- SUCCESS: Integrated in hbase-0.96 #204 (See [https://build

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826968#comment-13826968 ] Ted Yu commented on HBASE-8465: --- Patch v6 is good to go. > Auto-drop rollback snapshot for

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826131#comment-13826131 ] Hadoop QA commented on HBASE-8465: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824296#comment-13824296 ] Ted Yu commented on HBASE-8465: --- lgtm Please check findbugs. > Auto-drop rollback snapshot

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823329#comment-13823329 ] Hadoop QA commented on HBASE-8465: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822777#comment-13822777 ] Ted Yu commented on HBASE-8465: --- {code} +"hbase-failsafe-{snapshot.name}-{restore.ti

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822016#comment-13822016 ] Ted Yu commented on HBASE-8465: --- {code} + failSafeSnapshotSnapshotName = conf.get("hba

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-11-07 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816930#comment-13816930 ] Enis Soztutar commented on HBASE-8465: -- I was reading the restore code for something

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648072#comment-13648072 ] Ted Yu commented on HBASE-8465: --- Looking through http://dev.mysql.com/doc/refman/5.1/en/poi

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-02 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647997#comment-13647997 ] Jonathan Hsieh commented on HBASE-8465: --- If we only have opinions let's look to how

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647672#comment-13647672 ] Ted Yu commented on HBASE-8465: --- bq. and if we have the ability to specify the name of the f

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647067#comment-13647067 ] Jonathan Hsieh commented on HBASE-8465: --- bq. Table being bad can mean two things: hb

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647064#comment-13647064 ] Jonathan Hsieh commented on HBASE-8465: --- bq. wait... instead of doing this at this p

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647060#comment-13647060 ] Jonathan Hsieh commented on HBASE-8465: --- bq. I tought you were against this one... a

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647057#comment-13647057 ] Ted Yu commented on HBASE-8465: --- bq. it is more likely to have a bad table than a bad snapsh

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647047#comment-13647047 ] Jonathan Hsieh commented on HBASE-8465: --- Also since we have the table disabled, thes

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647045#comment-13647045 ] Jonathan Hsieh commented on HBASE-8465: --- This is why I wrote this comment: https://i

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647035#comment-13647035 ] Matteo Bertozzi commented on HBASE-8465: {quote}With this option we dropRollback b

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647028#comment-13647028 ] Ted Yu commented on HBASE-8465: --- Suppose we introduce takeSnapshot for the rollback snapshot

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-05-01 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647024#comment-13647024 ] Jonathan Hsieh commented on HBASE-8465: --- bq. The name of rollback snapshot is not re

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646012#comment-13646012 ] Ted Yu commented on HBASE-8465: --- [~jmhsieh]: Are you Okay with patch v2 ? >

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646000#comment-13646000 ] Matteo Bertozzi commented on HBASE-8465: +1 on v2 patch. > Auto-d

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645739#comment-13645739 ] Ted Yu commented on HBASE-8465: --- The test passed locally: Running org.apache.hadoop.hbase.r

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645710#comment-13645710 ] Hadoop QA commented on HBASE-8465: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645688#comment-13645688 ] Hadoop QA commented on HBASE-8465: -- {color:red}-1 overall{color}. Here are the results o

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645652#comment-13645652 ] Matteo Bertozzi commented on HBASE-8465: patch looks good to me, we have already

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645621#comment-13645621 ] Ted Yu commented on HBASE-8465: --- bq. we have the ability to do this with existing commands d

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645603#comment-13645603 ] Jonathan Hsieh commented on HBASE-8465: --- +1 for the runtime/xml conf behavior Matteo

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645575#comment-13645575 ] Ted Yu commented on HBASE-8465: --- bq. adding a flag "take snapshot" instead of the "drop roll

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645571#comment-13645571 ] Ted Yu commented on HBASE-8465: --- bq. make this a runtime restore snapshot parameter instead

[jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore

2013-04-30 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645570#comment-13645570 ] Matteo Bertozzi commented on HBASE-8465: my guess is that we could add a new resto