[jira] [Commented] (HBASE-20368) Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared

2019-06-28 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874702#comment-16874702 ] Guanghao Zhang commented on HBASE-20368: I did't follow this. Why this patch works and the old

[jira] [Commented] (HBASE-20368) Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared

2019-06-28 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874770#comment-16874770 ] HBase QA commented on HBASE-20368: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-28 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874710#comment-16874710 ] leizhang commented on HBASE-22620: -- not only the pressure on zk.consider when there is a large amount

[jira] [Updated] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-28 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leizhang updated HBASE-22620: - Fix Version/s: (was: 2.1.0) > When a cluster open replication,regionserver will not clean up the

[jira] [Commented] (HBASE-22640) Random init hstore lastFlushTime

2019-06-28 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874733#comment-16874733 ] HBase QA commented on HBASE-22640: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Checkstyle changes for Zookeeper Utility classes

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Checkstyle changes for Zookeeper Utility classes URL: https://github.com/apache/hbase/pull/345#discussion_r298483616 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

[jira] [Comment Edited] (HBASE-20368) Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared

2019-06-28 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874786#comment-16874786 ] Xiaolin Ha edited comment on HBASE-20368 at 6/28/19 9:08 AM: - [~zghaobac],

[GitHub] [hbase] Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#issuecomment-506624326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298167920 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298478373 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298479013 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298478772 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298475160 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298479037 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298477783 ## File path:

[GitHub] [hbase] HorizonNet merged pull request #316: HBASE-22595 Changed suppressions to full qualified class name

2019-06-28 Thread GitBox
HorizonNet merged pull request #316: HBASE-22595 Changed suppressions to full qualified class name URL: https://github.com/apache/hbase/pull/316 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] mymeiyi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
mymeiyi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r298509508 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506665568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] HorizonNet commented on a change in pull request #316: HBASE-22595 Changed suppressions to full qualified class name

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #316: HBASE-22595 Changed suppressions to full qualified class name URL: https://github.com/apache/hbase/pull/316#discussion_r298485017 ## File path: hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml ##

[jira] [Commented] (HBASE-20368) Fix RIT stuck when a rsgroup has no online servers but AM's pendingAssginQueue is cleared

2019-06-28 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874786#comment-16874786 ] Xiaolin Ha commented on HBASE-20368: {quote}Why this patch works and the old implemenation stucked

[GitHub] [hbase] infraio commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-28 Thread GitBox
infraio commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#discussion_r298511931 ## File path:

[GitHub] [hbase] infraio commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-28 Thread GitBox
infraio commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#discussion_r298511805 ## File path:

[jira] [Created] (HBASE-22642) Move operations of RSGroup should allow retry and correct region assignments

2019-06-28 Thread Xiaolin Ha (JIRA)
Xiaolin Ha created HBASE-22642: -- Summary: Move operations of RSGroup should allow retry and correct region assignments Key: HBASE-22642 URL: https://issues.apache.org/jira/browse/HBASE-22642 Project:

[GitHub] [hbase] virajjasani commented on a change in pull request #345: HBASE-22638 : Checkstyle changes for Zookeeper Utility classes

2019-06-28 Thread GitBox
virajjasani commented on a change in pull request #345: HBASE-22638 : Checkstyle changes for Zookeeper Utility classes URL: https://github.com/apache/hbase/pull/345#discussion_r298548371 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

[jira] [Work started] (HBASE-22637) fix flaky TestMetaTableMetrics test

2019-06-28 Thread Szalay-Beko Mate (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22637 started by Szalay-Beko Mate. > fix flaky TestMetaTableMetrics test >

[GitHub] [hbase] symat commented on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
symat commented on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346#issuecomment-506681924 if the test is fixed on the master branch, then I also plan to create an other pull request for branch 1 and 1.4 (as this patch an not be

[jira] [Commented] (HBASE-19893) restore_snapshot is broken in master branch when region splits

2019-06-28 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874836#comment-16874836 ] Toshihiro Suzuki commented on HBASE-19893: -- [~jatsakthi] Not sure the reason actually.. I think

[jira] [Commented] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874876#comment-16874876 ] Hudson commented on HBASE-22595: Results for branch master [build #1181 on

[jira] [Resolved] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Jan Hentschel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22595. --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.1.6

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506681016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506689913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] openinx commented on a change in pull request #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-06-28 Thread GitBox
openinx commented on a change in pull request #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table URL: https://github.com/apache/hbase/pull/336#discussion_r298539875 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506694258 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] symat edited a comment on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
symat edited a comment on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346#issuecomment-506681924 if the test is fixed on the master branch, then I also plan to create an other pull request for branch 1 and 1.4 (as this patch can

[GitHub] [hbase] symat opened a new pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
symat opened a new pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346 the problem was seen only on branch 2.0 and 2.1, but it should be unrelated to the minor version of the branches and the same fix can be applied on all

[GitHub] [hbase] petersomogyi commented on issue #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support

2019-06-28 Thread GitBox
petersomogyi commented on issue #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support URL: https://github.com/apache/hbase/pull/239#issuecomment-506723714 @busbey Can we merge this change?

[GitHub] [hbase] petersomogyi merged pull request #340: HBASE-22633 : remove redundant substring call with append for ZKRepli…

2019-06-28 Thread GitBox
petersomogyi merged pull request #340: HBASE-22633 : remove redundant substring call with append for ZKRepli… URL: https://github.com/apache/hbase/pull/340 This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#issuecomment-506739462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-28 Thread GitBox
Apache-HBase commented on issue #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#issuecomment-506745012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506720561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-22633) Remove redundant call to substring for ZKReplicationQueueStorage

2019-06-28 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22633: -- Resolution: Fixed Fix Version/s: 2.1.6 2.2.1

[jira] [Commented] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874937#comment-16874937 ] Hudson commented on HBASE-22595: Results for branch branch-2 [build #2033 on

[jira] [Work started] (HBASE-20405) Update website to meet foundation recommendations

2019-06-28 Thread Szalay-Beko Mate (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-20405 started by Szalay-Beko Mate. > Update website to meet foundation recommendations >

[jira] [Assigned] (HBASE-20405) Update website to meet foundation recommendations

2019-06-28 Thread Szalay-Beko Mate (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szalay-Beko Mate reassigned HBASE-20405: Assignee: Szalay-Beko Mate > Update website to meet foundation recommendations >

[GitHub] [hbase] petersomogyi commented on a change in pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
petersomogyi commented on a change in pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346#discussion_r298576702 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMetaTableMetrics.java

[GitHub] [hbase] petersomogyi commented on a change in pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
petersomogyi commented on a change in pull request #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346#discussion_r298576844 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMetaTableMetrics.java

[GitHub] [hbase] syedmurtazahassan commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found

2019-06-28 Thread GitBox
syedmurtazahassan commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-506733734 @HorizonNet I have resolved the merge conflicts. Kindly have a look when you have time.

[GitHub] [hbase] Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found

2019-06-28 Thread GitBox
Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-506734716 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874936#comment-16874936 ] Hudson commented on HBASE-22595: Results for branch branch-2.2 [build #394 on

[GitHub] [hbase] busbey commented on issue #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support

2019-06-28 Thread GitBox
busbey commented on issue #239: HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support URL: https://github.com/apache/hbase/pull/239#issuecomment-506885591 yep! I think I was just waiting to get the sign-offs in place? I'll push this evening.

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759725 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298758585 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1400,9

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298758992 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1400,9

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759556 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -2135,7

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759037 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1400,9

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759162 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1400,9

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759522 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@

[jira] [Commented] (HBASE-22633) Remove redundant call to substring for ZKReplicationQueueStorage

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875074#comment-16875074 ] Hudson commented on HBASE-22633: Results for branch branch-2.2 [build #395 on

[GitHub] [hbase] Apache-HBase commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag

2019-06-28 Thread GitBox
Apache-HBase commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#issuecomment-506813306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Comment Edited] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875277#comment-16875277 ] Xu Cang edited comment on HBASE-22349 at 6/28/19 10:55 PM: --- This is a very

[jira] [Commented] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875277#comment-16875277 ] Xu Cang commented on HBASE-22349: - This is very good observation. One of my co-worker observed and

[jira] [Comment Edited] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875277#comment-16875277 ] Xu Cang edited comment on HBASE-22349 at 6/28/19 10:55 PM: --- This is a very

[jira] [Comment Edited] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875277#comment-16875277 ] Xu Cang edited comment on HBASE-22349 at 6/28/19 11:06 PM: --- This is a very

[jira] [Commented] (HBASE-22633) Remove redundant call to substring for ZKReplicationQueueStorage

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875137#comment-16875137 ] Hudson commented on HBASE-22633: Results for branch branch-2 [build #2034 on

[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875128#comment-16875128 ] Hudson commented on HBASE-21879: Results for branch HBASE-21879 [build #161 on

[GitHub] [hbase] Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found

2019-06-28 Thread GitBox
Apache-HBase commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-506877758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-22349: Affects Version/s: 1.3.0 > Stochastic Load Balancer skips balancing when node is replaced in cluster >

[jira] [Updated] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated HBASE-22349: Affects Version/s: 3.0.0 2.0.0 > Stochastic Load Balancer skips balancing when

[GitHub] [hbase] Apache-HBase commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
Apache-HBase commented on issue #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#issuecomment-506851305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
Apache-HBase commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-506845021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22633) Remove redundant call to substring for ZKReplicationQueueStorage

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875171#comment-16875171 ] Hudson commented on HBASE-22633: Results for branch branch-2.1 [build #1311 on

[GitHub] [hbase] HorizonNet commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag

2019-06-28 Thread GitBox
HorizonNet commented on issue #302: HBASE-22571 Javadoc Warnings related to @return tag URL: https://github.com/apache/hbase/pull/302#issuecomment-506882494 @syedmurtazahassan It seems that you added new Checkstyle issues. Would be great if you could resolve them.

[jira] [Commented] (HBASE-22640) Random init hstore lastFlushTime

2019-06-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875051#comment-16875051 ] stack commented on HBASE-22640: --- [~luffy123] question above for you sir. Thanks. > Random init hstore

[GitHub] [hbase] HorizonNet commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found

2019-06-28 Thread GitBox
HorizonNet commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-506883586 There seems to be a build running. Let's wait for the results.

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298756773 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298757207 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java ##

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298755302 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java ## @@ -54,7

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298755435 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298756531 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298755245 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/HealthChecker.java ## @@ -54,7

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298756857 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298755869 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298756975 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298756676 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298757583 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java ## @@

[GitHub] [hbase] HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #322: HBASE-22586 Javadoc Warnings related to @param tag URL: https://github.com/apache/hbase/pull/322#discussion_r298757372 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java ##

[GitHub] [hbase] virajjasani commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
virajjasani commented on issue #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#issuecomment-506845859 Some additional enhancements added. Please review @jatsakthi @HorizonNet

[GitHub] [hbase] HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements

2019-06-28 Thread GitBox
HorizonNet commented on a change in pull request #345: HBASE-22638 : Zookeeper Utility enhancements URL: https://github.com/apache/hbase/pull/345#discussion_r298759262 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java ## @@ -1400,9

[jira] [Comment Edited] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2019-06-28 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875277#comment-16875277 ] Xu Cang edited comment on HBASE-22349 at 6/28/19 11:28 PM: --- This is a very

[jira] [Commented] (HBASE-20405) Update website to meet foundation recommendations

2019-06-28 Thread Szalay-Beko Mate (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874971#comment-16874971 ] Szalay-Beko Mate commented on HBASE-20405: -- I updated the web site locally (see the

[GitHub] [hbase] syedmurtazahassan commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found

2019-06-28 Thread GitBox
syedmurtazahassan commented on issue #306: HBASE-22572 Javadoc Warnings: @link reference not found URL: https://github.com/apache/hbase/pull/306#issuecomment-506760497 @HorizonNet Solved the " #306 does not apply to master" problem. Kindly review.

[GitHub] [hbase] Apache-HBase commented on issue #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-28 Thread GitBox
Apache-HBase commented on issue #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#issuecomment-506772831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics

2019-06-28 Thread GitBox
Apache-HBase commented on issue #346: HBASE-22637 fix flaky test in TestMetaTableMetrics URL: https://github.com/apache/hbase/pull/346#issuecomment-506772720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506778361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-28 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506758327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-20405) Update website to meet foundation recommendations

2019-06-28 Thread Szalay-Beko Mate (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szalay-Beko Mate updated HBASE-20405: - Attachment: HBASE-20405.png > Update website to meet foundation recommendations >

[GitHub] [hbase] symat opened a new pull request #347: HBASE-20405 Update website to meet foundation recommendations

2019-06-28 Thread GitBox
symat opened a new pull request #347: HBASE-20405 Update website to meet foundation recommendations URL: https://github.com/apache/hbase/pull/347 there are 5 checks failing on https://whimsy.apache.org/site/project/hbase so I added the following information to the main page on the

[jira] [Commented] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874978#comment-16874978 ] Hudson commented on HBASE-22595: Results for branch branch-2.0 [build #1708 on

[jira] [Commented] (HBASE-22595) Use full qualified name in Checkstyle suppressions

2019-06-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874981#comment-16874981 ] Hudson commented on HBASE-22595: Results for branch branch-2.1 [build #1309 on

[GitHub] [hbase] Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table

2019-06-28 Thread GitBox
Apache-HBase commented on issue #336: HBASE-22580 Add a table attribute to make user scan snapshot feature configurable for table URL: https://github.com/apache/hbase/pull/336#issuecomment-506774314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

  1   2   >