[jira] [Commented] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945438#comment-16945438 ] HBase QA commented on HBASE-22969: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-23106) WAL tools doc cleanup; talk of WAL Reader/Verifier; link WALPlayer

2019-10-06 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945458#comment-16945458 ] Wellington Chevreuil commented on HBASE-23106: -- LGTM, +1. > WAL tools doc cleanup; talk of

[jira] [Resolved] (HBASE-23106) WAL tools doc cleanup; talk of WAL Reader/Verifier; link WALPlayer

2019-10-06 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23106. --- Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed. Thanks

[GitHub] [hbase] Apache-HBase commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
Apache-HBase commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538814951 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[jira] [Commented] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread Udai Bhan Kashyap (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945490#comment-16945490 ] Udai Bhan Kashyap commented on HBASE-22969: --- Added following three end-to-end test cases as

[jira] [Updated] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-06 Thread Karthik Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Palanisamy updated HBASE-23115: --- Summary: Unit change for StoreFileSize and MemStoreSize (was: Unit change for

[GitHub] [hbase] ankitsinghal commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting

2019-10-06 Thread GitBox
ankitsinghal commented on issue #661: HBASE-15519 Add per-user metrics with lossy counting URL: https://github.com/apache/hbase/pull/661#issuecomment-538848515 > now that HBASE-23054 has landed, can you rebase onto the current master branch? Done. Sorry for the delay..

[GitHub] [hbase] karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538811475 @Apache9 @virajjasani I included test case for merge_region. By the way, my test case for TestAdminShell was failing on my MAC is due to

[jira] [Created] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-23125: - Summary: TestRSGroupsAdmin2 is flaky Key: HBASE-23125 URL: https://issues.apache.org/jira/browse/HBASE-23125 Project: HBase Issue Type: Bug Reporter:

[GitHub] [hbase-site] brfrn169 opened a new pull request #3: HBASE-22986 Add documentation for hbtop

2019-10-06 Thread GitBox
brfrn169 opened a new pull request #3: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] Apache-HBase commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature

2019-10-06 Thread GitBox
Apache-HBase commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature URL: https://github.com/apache/hbase/pull/691#issuecomment-538716732 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Updated] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread Udai Bhan Kashyap (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Bhan Kashyap updated HBASE-22969: -- Attachment: HBASE-22969.0010.patch Status: Patch Available (was: Open) > A

[jira] [Updated] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread Udai Bhan Kashyap (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Bhan Kashyap updated HBASE-22969: -- Status: Open (was: Patch Available) > A new binary component

[jira] [Assigned] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23125: - Assignee: Duo Zhang > TestRSGroupsAdmin2 is flaky > --- > >

[jira] [Work started] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23125 started by Duo Zhang. - > TestRSGroupsAdmin2 is flaky > --- > > Key:

[jira] [Commented] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Frederick Ayala (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945267#comment-16945267 ] Frederick Ayala commented on HBASE-23031: - Hi,  This is my first time contributing and I'm

[jira] [Assigned] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-23031: - Assignee: Frederick Ayala (was: Peter Somogyi) > Upgrade Yetus version in RM scripts

[jira] [Commented] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945268#comment-16945268 ] Peter Somogyi commented on HBASE-23031: --- Sure! I assigned the issue to you. > Upgrade Yetus

[jira] [Created] (HBASE-23126) IntegrationTestRSGroup is useless now

2019-10-06 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-23126: - Summary: IntegrationTestRSGroup is useless now Key: HBASE-23126 URL: https://issues.apache.org/jira/browse/HBASE-23126 Project: HBase Issue Type: Bug

[GitHub] [hbase-operator-tools] frederickayala opened a new pull request #42: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
frederickayala opened a new pull request #42: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase-operator-tools/pull/42 The latest version of Apache Yetus is 0.11.0 This is an automated

[GitHub] [hbase-operator-tools] asf-ci commented on issue #42: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
asf-ci commented on issue #42: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase-operator-tools/pull/42#issuecomment-538723865 Refer to this link for build results (access rights to CI server needed):

[GitHub] [hbase-operator-tools] petersomogyi merged pull request #42: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
petersomogyi merged pull request #42: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase-operator-tools/pull/42 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945274#comment-16945274 ] Peter Somogyi commented on HBASE-23031: --- Thanks [~frederickayala] for the pull request! Would you

[jira] [Commented] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Frederick Ayala (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945275#comment-16945275 ] Frederick Ayala commented on HBASE-23031: - I can do that :) > Upgrade Yetus version in RM

[GitHub] [hbase] frederickayala opened a new pull request #692: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
frederickayala opened a new pull request #692: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase/pull/692 The latest version of Apache Yetus is 0.11.0 This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on issue #692: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
Apache-HBase commented on issue #692: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase/pull/692#issuecomment-538726277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-18570) use hbase-spark without HBaseContext runs into NPE

2019-10-06 Thread Frederick Ayala (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945282#comment-16945282 ] Frederick Ayala commented on HBASE-18570: - Hi, I'm participating into Hacktoberfest and I'm new

[jira] [Resolved] (HBASE-23031) Upgrade Yetus version in RM scripts

2019-10-06 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23031. --- Fix Version/s: 3.0.0 Resolution: Fixed Thanks [~frederickayala] for contributing.

[GitHub] [hbase] petersomogyi merged pull request #692: HBASE-23031 Upgrade Yetus version in RM scripts

2019-10-06 Thread GitBox
petersomogyi merged pull request #692: HBASE-23031 Upgrade Yetus version in RM scripts URL: https://github.com/apache/hbase/pull/692 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-23055) Alter hbase:meta

2019-10-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945291#comment-16945291 ] Hudson commented on HBASE-23055: Results for branch HBASE-23055 [build #5 on

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-10-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945302#comment-16945302 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #139 on

[jira] [Updated] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23125: -- Status: Patch Available (was: In Progress) > TestRSGroupsAdmin2 is flaky >

[jira] [Updated] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23125: -- Attachment: HBASE-23125.patch > TestRSGroupsAdmin2 is flaky > --- > >

[jira] [Updated] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23125: -- Component/s: test > TestRSGroupsAdmin2 is flaky > --- > >

[GitHub] [hbase] PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule

2019-10-06 Thread GitBox
PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#discussion_r331789339 ## File path:

[jira] [Commented] (HBASE-23012) Release 1.3.6

2019-10-06 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945358#comment-16945358 ] Sean Busbey commented on HBASE-23012: - Will attaching the files here work? Then I could put them

[GitHub] [hbase] petersomogyi commented on a change in pull request #691: HBASE-23081 Add an option to enable/disable rs group feature

2019-10-06 Thread GitBox
petersomogyi commented on a change in pull request #691: HBASE-23081 Add an option to enable/disable rs group feature URL: https://github.com/apache/hbase/pull/691#discussion_r331792387 ## File path:

[jira] [Commented] (HBASE-23094) Wrong log message in simpleRegionNormaliser while checking if merge is enabled.

2019-10-06 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945305#comment-16945305 ] Peter Somogyi commented on HBASE-23094: --- Can you attach a patch targeted for master branch? >

[jira] [Commented] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945322#comment-16945322 ] Duo Zhang commented on HBASE-23125: --- Should be a test issue. The RegionMetrics in the ClusterStatus is

[GitHub] [hbase] PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule

2019-10-06 Thread GitBox
PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#discussion_r331788980 ## File path:

[GitHub] [hbase] PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule

2019-10-06 Thread GitBox
PierreZ commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#discussion_r331789179 ## File path:

[jira] [Updated] (HBASE-22986) Add documentation for hbtop

2019-10-06 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-22986: - Fix Version/s: 3.0.0 > Add documentation for hbtop > --- > >

[GitHub] [hbase] brfrn169 opened a new pull request #693: HBASE-22986 Add documentation for hbtop

2019-10-06 Thread GitBox
brfrn169 opened a new pull request #693: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase/pull/693 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945359#comment-16945359 ] Duo Zhang commented on HBASE-23125: --- Pushed to master. Let's see how it works. > TestRSGroupsAdmin2

[GitHub] [hbase] Apache-HBase commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature

2019-10-06 Thread GitBox
Apache-HBase commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature URL: https://github.com/apache/hbase/pull/691#issuecomment-538734573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature

2019-10-06 Thread GitBox
Apache9 commented on issue #691: HBASE-23081 Add an option to enable/disable rs group feature URL: https://github.com/apache/hbase/pull/691#issuecomment-538740768 OK, good. All green. This is an automated message from the

[jira] [Commented] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945328#comment-16945328 ] HBase QA commented on HBASE-22969: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-23126) IntegrationTestRSGroup is useless now

2019-10-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945329#comment-16945329 ] Duo Zhang commented on HBASE-23126: --- Ping [~apurtell]. > IntegrationTestRSGroup is useless now >

[GitHub] [hbase-site] brfrn169 merged pull request #3: HBASE-22986 Add documentation for hbtop

2019-10-06 Thread GitBox
brfrn169 merged pull request #3: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-22992) Blog post for hbtop on hbase.apache.org

2019-10-06 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945342#comment-16945342 ] Toshihiro Suzuki commented on HBASE-22992: -- [~stack] I'm sorry, I need you to change the image

[jira] [Commented] (HBASE-23125) TestRSGroupsAdmin2 is flaky

2019-10-06 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945347#comment-16945347 ] HBase QA commented on HBASE-23125: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #693: HBASE-22986 Add documentation for hbtop

2019-10-06 Thread GitBox
Apache-HBase commented on issue #693: HBASE-22986 Add documentation for hbtop URL: https://github.com/apache/hbase/pull/693#issuecomment-538753133 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] Apache9 commented on a change in pull request #691: HBASE-23081 Add an option to enable/disable rs group feature

2019-10-06 Thread GitBox
Apache9 commented on a change in pull request #691: HBASE-23081 Add an option to enable/disable rs group feature URL: https://github.com/apache/hbase/pull/691#discussion_r331792687 ## File path:

[jira] [Updated] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread Udai Bhan Kashyap (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Bhan Kashyap updated HBASE-22969: -- Attachment: HBASE-22969.0011.patch Status: Patch Available (was: Open) > A

[jira] [Updated] (HBASE-22460) Reopen a region if store reader references may have leaked

2019-10-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22460: - Fix Version/s: (was: 1.5.0) 1.6.0 > Reopen a region if store reader

[jira] [Updated] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-10-06 Thread Udai Bhan Kashyap (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Bhan Kashyap updated HBASE-22969: -- Status: Open (was: Patch Available) > A new binary component

[GitHub] [hbase] virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#discussion_r331800472 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -533,9 +533,12 @@ def

[GitHub] [hbase] virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#discussion_r331800472 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -533,9 +533,12 @@ def

[GitHub] [hbase] virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani commented on a change in pull request #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#discussion_r331800472 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -533,9 +533,12 @@ def

[GitHub] [hbase] virajjasani commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-06 Thread GitBox
virajjasani commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-538771988 Since impl of cloneUncompressedBufferWithHeader() is to be changed, do you think it is better to keep the method

[GitHub] [hbase] karthikhw edited a comment on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538773133 @Apache9 @virajjasani It looks to me no test method defined for merge_region. I see only few test from admin_test.rb but not all

[GitHub] [hbase] karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538773133 @Apache9 @virajjasani It looks to me no test method defined for merge_region. I see only few test from admin_test.rb but not all shell

[GitHub] [hbase] karthikhw edited a comment on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538773133 @Apache9 @virajjasani It looks to me no test method defined for merge_region. I see only few test from admin_test.rb but not all

[GitHub] [hbase] Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule

2019-10-06 Thread GitBox
Apache-HBase commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-538774321 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hbase] virajjasani edited a comment on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538774132 > I directly return nil in script because the method mergeRegionsAsync returns void. Correct, just realized by default async

[GitHub] [hbase] virajjasani edited a comment on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538774132 > I directly return nil in script because the method mergeRegionsAsync returns void. Correct, just realized by default async

[GitHub] [hbase] virajjasani commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
virajjasani commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538774132 > I directly return nil in script because the method mergeRegionsAsync returns void. Correct, just realized by default async method's

[GitHub] [hbase] karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538776350 Great @virajjasani I will add merge_region testcase. I am very curious that why would we need to run hbase-shell test cases manually, Sorry.

[GitHub] [hbase] karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell

2019-10-06 Thread GitBox
karthikhw commented on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538777683 I got @virajjasani. I see TestAdminShell runs