Apache-HBase commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779685200
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
virajjasani commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779671714
So far, we are starting off with terminating core worker threads if no tasks
arrive in keepAlive time only for EventTypes:
`RS_LOG_REPLAY_OPS`, `RS_PARALLEL_SEEK`,
bharathv commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779682472
> Let's also add same comment for other 3 EventTypes?
Instead moved it to the actual method. Copy-pasting it to multiple places
seems redundant.
> If the core
shahrs87 commented on a change in pull request #2945:
URL: https://github.com/apache/hbase/pull/2945#discussion_r576837115
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceLogQueue.java
##
@@ -0,0 +1,83 @@
+/*
+ *
shahrs87 commented on a change in pull request #2945:
URL: https://github.com/apache/hbase/pull/2945#discussion_r576839923
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLogQueue.java
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed
virajjasani commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779862038
@bharathv When you commit, can you please mention 4 EventTypes for which
this commit is going to consider releasing unused core threads in thread pools?
Maybe you can mention
Apache-HBase commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779850080
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on pull request #2953:
URL: https://github.com/apache/hbase/pull/2953#issuecomment-779841473
It is the new year holiday in China. Will take a look this week.
Sorry for the delay.
This is an automated
Iuliia Emelianova created HBASE-25581:
-
Summary: BUG - HBase native client memory leak - threads keep
running after connection is closed
Key: HBASE-25581
URL: https://issues.apache.org/jira/browse/HBASE-25581
Apache-HBase commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779722778
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285180#comment-17285180
]
Hudson commented on HBASE-23887:
Results for branch master
[build #212 on
Apache-HBase commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779755977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779686322
Oh Great, you are right. Thread creation should be considered only if
necessary for tasks like merge regions (recent change), where we are certain
that it might happen for
Anoop Sam John created HBASE-25582:
--
Summary: Support setting scan ReadType to be STREAM at cluster
level
Key: HBASE-25582
URL: https://issues.apache.org/jira/browse/HBASE-25582
Project: HBase
brfrn169 commented on pull request #2953:
URL: https://github.com/apache/hbase/pull/2953#issuecomment-779696281
@Apache9 Can you please review it when you have time? Thanks.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HBASE-25582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-25582:
---
Affects Version/s: 2.0.0
> Support setting scan ReadType to be STREAM at cluster level
>
[
https://issues.apache.org/jira/browse/HBASE-25582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-25582:
---
Fix Version/s: 2.5.0
3.0.0-alpha-1
> Support setting scan ReadType to be
virajjasani commented on a change in pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#discussion_r576650821
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
##
@@ -207,6 +207,11 @@ public boolean
Apache-HBase commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-779816536
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285330#comment-17285330
]
Pankaj Kumar commented on HBASE-25568:
--
Thanks [~apurtell]. will contact the dev@thrift to check
Apache-HBase commented on pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#issuecomment-780047088
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
sandeepvinayak opened a new pull request #2959:
URL: https://github.com/apache/hbase/pull/2959
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285430#comment-17285430
]
Bharath Vissapragada commented on HBASE-25541:
--
[~anoop.hbase] I believe the issue is this.
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285387#comment-17285387
]
Hudson commented on HBASE-23887:
Results for branch branch-2
[build #177 on
bharathv commented on a change in pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#discussion_r577063386
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##
@@ -252,6 +252,7 @@ private void
anmolnar commented on a change in pull request #2931:
URL: https://github.com/apache/hbase/pull/2931#discussion_r577021789
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
##
@@ -203,5 +213,21 @@ public double
[
https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285500#comment-17285500
]
Sandeep Pal commented on HBASE-25541:
-
Thanks for putting this [~bharathv]. You are right, on
bharathv merged pull request #2922:
URL: https://github.com/apache/hbase/pull/2922
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#issuecomment-780114374
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
bharathv commented on pull request #2922:
URL: https://github.com/apache/hbase/pull/2922#issuecomment-780065150
I just figured that I missed the commit that rolls the op-code into the
ExecutorConfig, let me create an addendum.
[
https://issues.apache.org/jira/browse/HBASE-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25343:
Fix Version/s: (was: 2.4.2)
2.4.3
> Avoid the failed meta
Apache-HBase commented on pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#issuecomment-780144013
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285606#comment-17285606
]
Reid Chan commented on HBASE-21674:
---
ping [~apurtell], [~busbey]
could you spare some cycles to take
[
https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25541 started by Sandeep Pal.
---
> In WALEntryStream, set the current path to null while dequeing the log
>
brfrn169 commented on pull request #2953:
URL: https://github.com/apache/hbase/pull/2953#issuecomment-780209085
@Apache9 Thank you for your reply! No problem at all. Enjoy your holiday!
This is an automated message from the
[
https://issues.apache.org/jira/browse/HBASE-25575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Toshihiro Suzuki updated HBASE-25575:
-
Description: Currently, we don't validate the key value sizes of Puts in
RowMutations.
virajjasani commented on a change in pull request #2959:
URL: https://github.com/apache/hbase/pull/2959#discussion_r577334939
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##
@@ -252,6 +252,7 @@ private void
37 matches
Mail list logo