[GitHub] [hbase] Apache-HBase commented on pull request #3228: Backport "HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http" to branch-2

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3228: URL: https://github.com/apache/hbase/pull/3228#issuecomment-832275728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-25842) Move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25842: - Resolution: Fixed Status: Resolved (was: Patch Available) > Move regionserver

[jira] [Updated] (HBASE-25842) Move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25842: - Fix Version/s: 2.5.0 > Move regionserver http-related code into o.a.h.h.regionserver.http >

[GitHub] [hbase] ndimiduk commented on pull request #3226: HBASE-25843 move master http-related code into o.a.h.h.master.http

2021-05-04 Thread GitBox
ndimiduk commented on pull request #3226: URL: https://github.com/apache/hbase/pull/3226#issuecomment-832304833 > Is it possible to also move some UTs to hbase-http? Same as with the region server http code, there's not much explicit test coverage over master info page. I didn't

[GitHub] [hbase] Apache-HBase commented on pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3204: URL: https://github.com/apache/hbase/pull/3204#issuecomment-832243382 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] ndimiduk merged pull request #3228: Backport "HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http" to branch-2

2021-05-04 Thread GitBox
ndimiduk merged pull request #3228: URL: https://github.com/apache/hbase/pull/3228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-25844) Fix Jersey for hbase-server processes

2021-05-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339341#comment-17339341 ] Nick Dimiduk commented on HBASE-25844: -- {{jersey-server-1.19}} is on our {{compile}} path by way of

[jira] [Created] (HBASE-25846) RSGroupBasedLoadBalancer does not allow dynamic config setting

2021-05-04 Thread Caroline Zhou (Jira)
Caroline Zhou created HBASE-25846: - Summary: RSGroupBasedLoadBalancer does not allow dynamic config setting Key: HBASE-25846 URL: https://issues.apache.org/jira/browse/HBASE-25846 Project: HBase

[GitHub] [hbase] ndimiduk opened a new pull request #3229: Backport "HBASE-25843 move master http-related code into o.a.h.h.master.http" to branch-2

2021-05-04 Thread GitBox
ndimiduk opened a new pull request #3229: URL: https://github.com/apache/hbase/pull/3229 Signed-off-by: Duo Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Commented] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-04 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339242#comment-17339242 ] Rushabh Shah commented on HBASE-25612: -- Thank you [~reidchan] for getting the build running again

[jira] [Comment Edited] (HBASE-25797) Batch version of checkAndMutate on AsyncTable always returns false

2021-05-04 Thread Hochul Shin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339316#comment-17339316 ] Hochul Shin edited comment on HBASE-25797 at 5/4/21, 9:56 PM: -- Hi

[jira] [Comment Edited] (HBASE-25797) Batch version of checkAndMutate on AsyncTable always returns false

2021-05-04 Thread Hochul Shin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339316#comment-17339316 ] Hochul Shin edited comment on HBASE-25797 at 5/4/21, 9:56 PM: -- Hi

[GitHub] [hbase] ndimiduk merged pull request #3225: HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread GitBox
ndimiduk merged pull request #3225: URL: https://github.com/apache/hbase/pull/3225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (HBASE-25842) Move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25842: - Fix Version/s: 3.0.0-alpha-1 > Move regionserver http-related code into

[jira] [Commented] (HBASE-25838) Use double instead of Double in StochasticLoadBalancer

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339253#comment-17339253 ] Hudson commented on HBASE-25838: Results for branch branch-2.4 [build #109 on

[jira] [Commented] (HBASE-25836) RegionStates#getAssignmentsForBalancer should only care about OPEN or OPENING regions

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339255#comment-17339255 ] Hudson commented on HBASE-25836: Results for branch branch-2.4 [build #109 on

[jira] [Commented] (HBASE-25840) CatalogJanitor warns about skipping gc of regions during RIT, but does not actually skip

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339254#comment-17339254 ] Hudson commented on HBASE-25840: Results for branch branch-2.4 [build #109 on

[GitHub] [hbase] Apache-HBase commented on pull request #3225: HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3225: URL: https://github.com/apache/hbase/pull/3225#issuecomment-832198919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3225: HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3225: URL: https://github.com/apache/hbase/pull/3225#issuecomment-832206161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3226: HBASE-25843 move master http-related code into o.a.h.h.master.http

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3226: URL: https://github.com/apache/hbase/pull/3226#issuecomment-832317001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25846) RSGroupBasedLoadBalancer does not allow dynamic config setting

2021-05-04 Thread Caroline Zhou (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline Zhou updated HBASE-25846: -- Description: In branch-1, 

[GitHub] [hbase] bharathv commented on a change in pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
bharathv commented on a change in pull request #3204: URL: https://github.com/apache/hbase/pull/3204#discussion_r626122263 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ## @@ -653,6 +653,22 @@ public

[jira] [Commented] (HBASE-25797) Batch version of checkAndMutate on AsyncTable always returns false

2021-05-04 Thread Hochul Shin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339316#comment-17339316 ] Hochul Shin commented on HBASE-25797: - Hi Toshihiro, sorry for confusing you. The put operation was

[GitHub] [hbase] Apache-HBase commented on pull request #3228: Backport "HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http" to branch-2

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3228: URL: https://github.com/apache/hbase/pull/3228#issuecomment-832295887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25846) RSGroupBasedLoadBalancer does not allow dynamic config setting

2021-05-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25846. --- Resolution: Duplicate Thanks for reporting this [~caroliney14]. It has already been fixed by

[GitHub] [hbase] Apache-HBase commented on pull request #3229: Backport "HBASE-25843 move master http-related code into o.a.h.h.master.http" to branch-2

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3229: URL: https://github.com/apache/hbase/pull/3229#issuecomment-832365611 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25847: --- Summary: More DEBUG and TRACE level logging in CatalogJanitor and HbckChore Key: HBASE-25847 URL: https://issues.apache.org/jira/browse/HBASE-25847

[GitHub] [hbase] apurtell commented on a change in pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
apurtell commented on a change in pull request #3230: URL: https://github.com/apache/hbase/pull/3230#discussion_r626219018 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java ## @@ -223,15 +223,37 @@ private void

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339377#comment-17339377 ] Reid Chan commented on HBASE-25831: --- There's no hbase-thrift module. Not sure whether I should merge

[GitHub] [hbase] Apache-HBase commented on pull request #3226: HBASE-25843 move master http-related code into o.a.h.h.master.http

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3226: URL: https://github.com/apache/hbase/pull/3226#issuecomment-832377894 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3217: HBASE-25834 Remove balanceTable method from LoadBalancer interface

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3217: URL: https://github.com/apache/hbase/pull/3217#issuecomment-832378118 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3230: URL: https://github.com/apache/hbase/pull/3230#issuecomment-832385925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] caroliney14 commented on pull request #3231: HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-

2021-05-04 Thread GitBox
caroliney14 commented on pull request #3231: URL: https://github.com/apache/hbase/pull/3231#issuecomment-832386268 @Apache9 @d-c-manning please review when you get the chance, thanks:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] apurtell commented on a change in pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
apurtell commented on a change in pull request #3230: URL: https://github.com/apache/hbase/pull/3230#discussion_r626219664 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java ## @@ -317,11 +329,19 @@ static boolean

[GitHub] [hbase] apurtell commented on a change in pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
apurtell commented on a change in pull request #3230: URL: https://github.com/apache/hbase/pull/3230#discussion_r626219557 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java ## @@ -252,14 +265,11 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3217: HBASE-25834 Remove balanceTable method from LoadBalancer interface

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3217: URL: https://github.com/apache/hbase/pull/3217#issuecomment-832393242 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] caroliney14 commented on pull request #3231: HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-

2021-05-04 Thread GitBox
caroliney14 commented on pull request #3231: URL: https://github.com/apache/hbase/pull/3231#issuecomment-832399534 thanks @Reidd. can either you or @Apache9 merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #3229: Backport "HBASE-25843 move master http-related code into o.a.h.h.master.http" to branch-2

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3229: URL: https://github.com/apache/hbase/pull/3229#issuecomment-832329535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3204: URL: https://github.com/apache/hbase/pull/3204#issuecomment-832343917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25846) RSGroupBasedLoadBalancer does not allow dynamic config setting

2021-05-04 Thread Caroline Zhou (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339379#comment-17339379 ] Caroline Zhou commented on HBASE-25846: --- Thanks [~zhangduo], I wasn't aware of HBASE-25825 before

[GitHub] [hbase] caroliney14 opened a new pull request #3231: HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-

2021-05-04 Thread GitBox
caroliney14 opened a new pull request #3231: URL: https://github.com/apache/hbase/pull/3231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (HBASE-25835) Ignore duplicate split requests from regionserver reports

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339387#comment-17339387 ] Hudson commented on HBASE-25835: Results for branch branch-2 [build #241 on

[jira] [Commented] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339373#comment-17339373 ] Andrew Kyle Purtell commented on HBASE-25847: - Mostly just logging, but this is also a real

[GitHub] [hbase] Apache-HBase commented on pull request #3217: HBASE-25834 Remove balanceTable method from LoadBalancer interface

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3217: URL: https://github.com/apache/hbase/pull/3217#issuecomment-832376991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3218: HBASE-25835 Ignore duplicate split requests from regionserver reports

2021-05-04 Thread GitBox
Apache9 commented on pull request #3218: URL: https://github.com/apache/hbase/pull/3218#issuecomment-832382784 A bit late, it is still holiday in China, not always online outside... +1. Thanks @apurtell , the comment is great. -- This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3204: URL: https://github.com/apache/hbase/pull/3204#issuecomment-832389769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3231: HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3231: URL: https://github.com/apache/hbase/pull/3231#issuecomment-832397379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[GitHub] [hbase] Reidddddd commented on pull request #3231: HBASE-25846 Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1

2021-05-04 Thread GitBox
Reidd commented on pull request #3231: URL: https://github.com/apache/hbase/pull/3231#issuecomment-832397892 Could ignore the check failure. I'm still working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] Apache-HBase commented on pull request #3229: Backport "HBASE-25843 move master http-related code into o.a.h.h.master.http" to branch-2

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3229: URL: https://github.com/apache/hbase/pull/3229#issuecomment-832363928 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339373#comment-17339373 ] Andrew Kyle Purtell edited comment on HBASE-25847 at 5/5/21, 2:24 AM:

[GitHub] [hbase] apurtell opened a new pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
apurtell opened a new pull request #3230: URL: https://github.com/apache/hbase/pull/3230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache9 commented on pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
Apache9 commented on pull request #3230: URL: https://github.com/apache/hbase/pull/3230#issuecomment-832378369 Some background https://issues.apache.org/jira/browse/HBASE-24942 I've found a bug when refactoring CatalogJanitor because of we may clean the merge qualifiers in

[jira] [Commented] (HBASE-25846) Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1

2021-05-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339381#comment-17339381 ] Duo Zhang commented on HBASE-25846: --- Sure, let's just use issue to do the backport. > Backport

[jira] [Updated] (HBASE-25846) Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1

2021-05-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25846: -- Summary: Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the

[jira] [Reopened] (HBASE-25846) RSGroupBasedLoadBalancer does not allow dynamic config setting

2021-05-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-25846: --- > RSGroupBasedLoadBalancer does not allow dynamic config setting >

[GitHub] [hbase] Apache-HBase commented on pull request #3230: HBASE-25847 More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3230: URL: https://github.com/apache/hbase/pull/3230#issuecomment-832422235 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3217: HBASE-25834 Remove balanceTable method from LoadBalancer interface

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3217: URL: https://github.com/apache/hbase/pull/3217#issuecomment-832431433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3226: HBASE-25843 move master http-related code into o.a.h.h.master.http

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3226: URL: https://github.com/apache/hbase/pull/3226#issuecomment-832358891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #3217: HBASE-25834 Remove balanceTable method from LoadBalancer interface

2021-05-04 Thread GitBox
Apache9 commented on a change in pull request #3217: URL: https://github.com/apache/hbase/pull/3217#discussion_r626212599 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -610,13 +610,35 @@ private void

[jira] [Commented] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339385#comment-17339385 ] Reid Chan commented on HBASE-25612: --- Known issue, working on it.. > HMaster should abort if

[GitHub] [hbase-operator-tools] petersomogyi merged pull request #85: HBASE-25794: Fix checkstyle violations in hbase-table-reporter module

2021-05-04 Thread GitBox
petersomogyi merged pull request #85: URL: https://github.com/apache/hbase-operator-tools/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3212: HBASE-25831 [branch-1] remove thrift examples out of hbase-examples m…

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3212: URL: https://github.com/apache/hbase/pull/3212#issuecomment-831788968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25845) [branch-1] Precommit fails to build docker due to python-dateutil

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25845: -- Component/s: build > [branch-1] Precommit fails to build docker due to python-dateutil >

[jira] [Resolved] (HBASE-25845) [branch-1] Precommit fails to build docker due to python-dateutil

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-25845. --- Fix Version/s: 1.7.0 Resolution: Fixed > [branch-1] Precommit fails to build docker due to

[jira] [Commented] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338824#comment-17338824 ] Reid Chan commented on HBASE-25612: --- could you update the branch-1 pull request again, I think the

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338861#comment-17338861 ] Reid Chan commented on HBASE-25831: --- Not really understand: {code} [INFO]

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-04 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338863#comment-17338863 ] Reid Chan commented on HBASE-25831: --- Oh, i spot that the thrift.version in hbase root pom.xml is still

[GitHub] [hbase] Reidddddd merged pull request #3227: HBASE-25845 [branch-1] Precommit fails to build docker due to python-…

2021-05-04 Thread GitBox
Reidd merged pull request #3227: URL: https://github.com/apache/hbase/pull/3227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3212: HBASE-25831 [branch-1] remove thrift examples out of hbase-examples m…

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3212: URL: https://github.com/apache/hbase/pull/3212#issuecomment-831744746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-25794) Fix checkstyle violations in hbase-table-reporter module

2021-05-04 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25794: -- Fix Version/s: hbase-operator-tools-1.2.0 Resolution: Fixed Status: Resolved

[jira] [Commented] (HBASE-25839) Bulk Import fails with java.io.IOException: Type mismatch in value from map

2021-05-04 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338869#comment-17338869 ] ZFabrik commented on HBASE-25839: - I'm still debugging the problem because now I run into another

[GitHub] [hbase] Apache-HBase commented on pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3204: URL: https://github.com/apache/hbase/pull/3204#issuecomment-831858488 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3220: URL: https://github.com/apache/hbase/pull/3220#issuecomment-831883467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25845) [branch-1] Precommit fails to build docker due to python-dateutil

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338973#comment-17338973 ] Hudson commented on HBASE-25845: Results for branch branch-1 [build #120 on

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-04 Thread GitBox
nyl3532016 commented on a change in pull request #3220: URL: https://github.com/apache/hbase/pull/3220#discussion_r625692451 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java ## @@ -230,6 +230,8 @@ private void

[jira] [Commented] (HBASE-25340) Protobuf Mesage Incompatibility Detector

2021-05-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339121#comment-17339121 ] Nick Dimiduk commented on HBASE-25340: -- [~jwjwyoung] do you have a link to the newer version? Does

[GitHub] [hbase] bharathv commented on pull request #3204: HBASE-25741: Replication Source still having the replication metrics for peer ID which doesn't exist

2021-05-04 Thread GitBox
bharathv commented on pull request #3204: URL: https://github.com/apache/hbase/pull/3204#issuecomment-832079095 @sandeepvinayak Test failure seems legit, can you please double check? Earlier runs were failing because of #3227, looks like you already rebased/ ```

[GitHub] [hbase] ndimiduk commented on a change in pull request #3225: HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread GitBox
ndimiduk commented on a change in pull request #3225: URL: https://github.com/apache/hbase/pull/3225#discussion_r625941193 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -6687,6 +6687,13 @@ public int getReadLockCount() {

[GitHub] [hbase] ndimiduk commented on pull request #3225: HBASE-25842 move regionserver http-related code into o.a.h.h.regionserver.http

2021-05-04 Thread GitBox
ndimiduk commented on pull request #3225: URL: https://github.com/apache/hbase/pull/3225#issuecomment-832089938 > Is it possible to also move some UTs to hbase-http? The only test for RegionServer is `TestRSStatusServlet`, and all it does is verify that the template renders. Thus,

[GitHub] [hbase] apurtell commented on pull request #3218: HBASE-25835 Ignore duplicate split requests from regionserver reports

2021-05-04 Thread GitBox
apurtell commented on pull request #3218: URL: https://github.com/apache/hbase/pull/3218#issuecomment-832098333 There are approvals and I believe all feedback has been addressed. Merging. We can reopen/revert/improve if necessary. -- This is an automated message from the Apache Git

[jira] [Updated] (HBASE-25835) Ignore duplicate split requests from regionserver reports

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25835: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] apurtell merged pull request #3218: HBASE-25835 Ignore duplicate split requests from regionserver reports

2021-05-04 Thread GitBox
apurtell merged pull request #3218: URL: https://github.com/apache/hbase/pull/3218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Comment Edited] (HBASE-25829) SPLIT state detritus

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338650#comment-17338650 ] Andrew Kyle Purtell edited comment on HBASE-25829 at 5/4/21, 5:06 PM:

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339147#comment-17339147 ] Andrew Kyle Purtell commented on HBASE-25831: - [~reidchan] Change directory into the module

[jira] [Comment Edited] (HBASE-25829) SPLIT state detritus

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338650#comment-17338650 ] Andrew Kyle Purtell edited comment on HBASE-25829 at 5/4/21, 5:08 PM:

[jira] [Updated] (HBASE-25829) SPLIT state detritus

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25829: Priority: Minor (was: Major) > SPLIT state detritus > > >

[jira] [Commented] (HBASE-25829) SPLIT state detritus

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339149#comment-17339149 ] Andrew Kyle Purtell commented on HBASE-25829: - Downgraded severity to minor. Analyzed nits

[jira] [Commented] (HBASE-25829) SPLIT state detritus

2021-05-04 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339151#comment-17339151 ] Andrew Kyle Purtell commented on HBASE-25829: - I have a patch that adds DEBUG and TRACE

[jira] [Commented] (HBASE-25836) RegionStates#getAssignmentsForBalancer should only care about OPEN or OPENING regions

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338994#comment-17338994 ] Hudson commented on HBASE-25836: Results for branch master [build #281 on

[jira] [Commented] (HBASE-25824) IntegrationTestLoadCommonCrawl

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338991#comment-17338991 ] Hudson commented on HBASE-25824: Results for branch master [build #281 on

[jira] [Commented] (HBASE-25840) CatalogJanitor warns about skipping gc of regions during RIT, but does not actually skip

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338993#comment-17338993 ] Hudson commented on HBASE-25840: Results for branch master [build #281 on

[jira] [Commented] (HBASE-25838) Use double instead of Double in StochasticLoadBalancer

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338992#comment-17338992 ] Hudson commented on HBASE-25838: Results for branch master [build #281 on

[GitHub] [hbase] virajjasani commented on pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-04 Thread GitBox
virajjasani commented on pull request #3222: URL: https://github.com/apache/hbase/pull/3222#issuecomment-831978375 Triggered another run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (HBASE-25839) Bulk Import fails with java.io.IOException: Type mismatch in value from map

2021-05-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil reassigned HBASE-25839: Assignee: ZFabrik > Bulk Import fails with java.io.IOException: Type

[jira] [Commented] (HBASE-25340) Protobuf Mesage Incompatibility Detector

2021-05-04 Thread junwen yang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339036#comment-17339036 ] junwen yang commented on HBASE-25340: - Hi, [~pankajkumar], just a quick update that we have

[jira] [Commented] (HBASE-25774) TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is flaky

2021-05-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338990#comment-17338990 ] Hudson commented on HBASE-25774: Results for branch master [build #281 on

[jira] [Commented] (HBASE-25839) Bulk Import fails with java.io.IOException: Type mismatch in value from map

2021-05-04 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338997#comment-17338997 ] ZFabrik commented on HBASE-25839: - It seems to me that the inner class

[GitHub] [hbase] Apache-HBase commented on pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-04 Thread GitBox
Apache-HBase commented on pull request #3220: URL: https://github.com/apache/hbase/pull/3220#issuecomment-831962668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25839) Bulk Import fails with java.io.IOException: Type mismatch in value from map

2021-05-04 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339019#comment-17339019 ] ZFabrik commented on HBASE-25839: - Suggested patch: {noformat} Index:

[jira] [Commented] (HBASE-25844) Fix Jersey for hbase-server processes

2021-05-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338986#comment-17338986 ] Sean Busbey commented on HBASE-25844: - bq. We cannot override what version of these classes are

  1   2   >