[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469179#comment-13469179
 ] 

Hudson commented on HBASE-6439:
---

Integrated in HBase-TRUNK #3420 (See 
[https://builds.apache.org/job/HBase-TRUNK/3420/])
HBASE-6439 Ignore .archive directory as a table (Revision 1393916)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HFileArchiveUtil.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHFileArchiveUtil.java


 Ignore .archive directory as a table
 

 Key: HBASE-6439
 URL: https://issues.apache.org/jira/browse/HBASE-6439
 Project: HBase
  Issue Type: Bug
  Components: io, regionserver
Affects Versions: 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
  Labels: newbie
 Fix For: 0.96.0

 Attachments: hbase-6439-r0.patch


 From a recent test run:
 {quote}
 2012-07-22 02:27:30,699 WARN  [IPC Server handler 0 on 47087] 
 util.FSTableDescriptors(168): The following folder is in HBase's root 
 directory and doesn't contain a table descriptor, do consider deleting it: 
 .archive
 {quote}
 With the addition of HBASE-5547, table-level folders are no-longer all table 
 folders. FSTableDescriptors needs to then have a 'gold-list' that we can 
 update with directories that aren't tables so we don't have this kind of 
 thing showing up in the logs.
 Currently, we have the following block:
 {quote}
 invocations++;
 if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) {
   cachehits++;
   return HTableDescriptor.ROOT_TABLEDESC;
 }
 if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) {
   cachehits++;
   return HTableDescriptor.META_TABLEDESC;
 }
 {quote}
 to handle special cases, but that's a bit clunky and not clean in terms of 
 table-level directories that need to be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469183#comment-13469183
 ] 

Jesse Yates commented on HBASE-6707:


bq.  If it passes hadoopqa, that is enough up to this. 

I think that's reasonable. If we want to support both 1.6 and 1.7 that should 
be part of the official test process. Wanna file a ticket Ted?

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6928) TestStoreFile sometimes fails with 'Column family prefix used twice'

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469190#comment-13469190
 ] 

Hudson commented on HBASE-6928:
---

Integrated in HBase-TRUNK #3421 (See 
[https://builds.apache.org/job/HBase-TRUNK/3421/])
HBASE-6928 TestStoreFile sometimes fails with 'Column family prefix used 
twice' -- ATTEMPTED FIX (Revision 1393923)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java


 TestStoreFile sometimes fails with 'Column family prefix used twice'
 

 Key: HBASE-6928
 URL: https://issues.apache.org/jira/browse/HBASE-6928
 Project: HBase
  Issue Type: Bug
Reporter: Ted Yu
 Attachments: 6928_attempted_fix.txt, 6928-debug.txt


 In build #3406, I saw:
 {code}
 java.lang.AssertionError: Column family prefix used twice: 
 cf.cf.bt.Data.fsReadnumops
   at 
 org.apache.hadoop.hbase.regionserver.metrics.SchemaMetrics.validateMetricChanges(SchemaMetrics.java:822)
   at 
 org.apache.hadoop.hbase.regionserver.TestStoreFile.tearDown(TestStoreFile.java:89)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6942) Endpoint implementation for bulk delete

2012-10-04 Thread Anoop Sam John (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-6942:
--

Description: 
We can provide an end point implementation for doing a bulk delete (based on a 
scan) at the server side. This can reduce the time taken for such an operation 
as right now it need to do a scan to client and issue delete(s) using rowkeys.

Query like  delete from table1 where...

  was:We can provide an end point implementation for doing a bulk delete (based 
on a scan) at the server side. This can reduce the time taken for such an 
operation as right now it need to do a scan to client and issue delete(s) using 
rowkeys.


 Endpoint implementation for bulk delete
 ---

 Key: HBASE-6942
 URL: https://issues.apache.org/jira/browse/HBASE-6942
 Project: HBase
  Issue Type: Improvement
  Components: Coprocessors, Performance
Reporter: Anoop Sam John
Assignee: Anoop Sam John

 We can provide an end point implementation for doing a bulk delete (based on 
 a scan) at the server side. This can reduce the time taken for such an 
 operation as right now it need to do a scan to client and issue delete(s) 
 using rowkeys.
 Query like  delete from table1 where...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469194#comment-13469194
 ] 

Jesse Yates commented on HBASE-6707:


bq. Why the addition of 3 above ?

So it checks each of the directories on the way down - tablename/region/family 
- hence the plus three. 

The way CleanerChore works is that it looks at the main directory, and then if 
it has files under it, attempts to see if those files are deleteable. If they 
aren't deletable, it skips checking the directory and continues on to the next 
directory to check. If all the files are deletable, then if checks to see if 
the directory is deletable.

bq. The above change deviates from original assumption. Please explain why a 
directory can be deleted regardless of whether it has files under it.

Therefore, we can always consider directories deletable because there is 
nothing special about a directory, but only the files under the directory. 
Perhaps that was a flaw in the design, but we should file another ticket to 
change that behavior such that we only check for files and delete directories 
when there are no files for that directory.

Further note, for the original quote, that we need only have +3 for the 
non-archived table's directories, but not an extra +3 (which would make a total 
of +6) for the archived table because we don't attempt to delete the directory 
containing hfiles that are retained.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-6939:
---

Attachment: 6939.v2.patch

 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469205#comment-13469205
 ] 

nkeywal commented on HBASE-6939:


Committed revision 1393940.
With the fixed space. Thanks for the review!


 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-6939:
---

   Resolution: Fixed
Fix Version/s: 0.96.0
 Release Note: In HBaseTestingUtility class, a new property 
(test.hbase.zookeeper.property.clientPort) allows to launch the mini 
ZooKeeper on a predefined port.
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469214#comment-13469214
 ] 

Hadoop QA commented on HBASE-6939:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547691/6939.v2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3002//console

This message is automatically generated.

 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6943) [89-fbDo not catch certain exceptions trying

2012-10-04 Thread Mikhail Bautin (JIRA)
Mikhail Bautin created HBASE-6943:
-

 Summary: [89-fbDo not catch certain exceptions trying 
 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Mikhail Bautin (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Bautin updated HBASE-6943:
--

Description: When getting a regionserver connection in 0.89-fb in 
HBaseClient, we catch all types of Throwable. I have observed a real case when 
the client looked stuck. On debugging it turned out that a NoSuchMethodError 
was thrown and caught, leaving the connection in an inconsistent state 
(initialized socket but null streams). All following attempts resulted in NPEs 
that were also caught, and no errors were logged. From the user's perspective 
the client was just stuck. The root cause was the absence of a required jar 
(hence the NoSuchMethodError) but it was not reported properly.
Summary: [89-fb] Do not catch certain exceptions trying to get an RS 
connection  (was: [89-fbDo not catch certain exceptions trying )

 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin

 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6872) Number of records written/read per second on regionserver level

2012-10-04 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469222#comment-13469222
 ] 

Phabricator commented on HBASE-6872:


mbautin has closed the revision [jira] [HBASE-6872] [89-fb] Fix 
TestRegionServerMetrics.testNumReadsAndWrites.

CHANGED PRIOR TO COMMIT
  https://reviews.facebook.net/D5853?vs=19311id=19359#differential-review-toc

REVISION DETAIL
  https://reviews.facebook.net/D5853

COMMIT
  https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1393955

To: Kannan, Karthik, JIRA, Liyin, mbautin
Cc: adela, Liyin, aaiyer, avf


 Number of records written/read per second on regionserver level
 ---

 Key: HBASE-6872
 URL: https://issues.apache.org/jira/browse/HBASE-6872
 Project: HBase
  Issue Type: New Feature
  Components: regionserver
Reporter: Adela Maznikar
Priority: Minor
 Attachments: D5853.1.patch, D5853.2.patch, D5853.3.patch


 Regionserver level metrics that shows the number of records written/read per 
 second. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6944) Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-6944:
--

Issue Type: Task  (was: Bug)

 Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7
 -

 Key: HBASE-6944
 URL: https://issues.apache.org/jira/browse/HBASE-6944
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu

 Currently test-patch.sh only runs against jdk 1.6
 However trunk build is using jdk 1.7
 test-patch.sh should be enhanced to run against both jdk versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6944) Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7

2012-10-04 Thread Ted Yu (JIRA)
Ted Yu created HBASE-6944:
-

 Summary: Enhance test-patch.sh to run against both jdk 1.6 and jdk 
1.7
 Key: HBASE-6944
 URL: https://issues.apache.org/jira/browse/HBASE-6944
 Project: HBase
  Issue Type: Bug
Reporter: Ted Yu


Currently test-patch.sh only runs against jdk 1.6
However trunk build is using jdk 1.7

test-patch.sh should be enhanced to run against both jdk versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469227#comment-13469227
 ] 

Ted Yu commented on HBASE-6707:
---

bq. If we want to support both 1.6 and 1.7 that should be part of the official 
test process. Wanna file a ticket Ted?
Done. I logged HBASE-6944

bq. Perhaps that was a flaw in the design, but we should file another ticket to 
change that behavior such that we only check for files and delete directories 
when there are no files for that directory.
Want to file a ticket Jesse ?

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469228#comment-13469228
 ] 

Hudson commented on HBASE-6939:
---

Integrated in HBase-TRUNK #3422 (See 
[https://builds.apache.org/job/HBase-TRUNK/3422/])
HBASE-6939 Add the possibility to set the ZK port in HBaseTestingUtility 
(Revision 1393940)

 Result = FAILURE
nkeywal : 
Files : 
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HBASE-6943:
---

Attachment: D5877.1.patch

mbautin requested code review of [jira] [HBASE-6943] [89-fb] Do not catch 
certain exceptions trying to get an RS connection.
Reviewers: Kannan, Liyin, Karthik, JIRA

  When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
all types of Throwable. I have observed a real case when the client looked 
stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
caught, leaving the connection in an inconsistent state (initialized socket but 
null streams). All following attempts resulted in NPEs that were also caught, 
and no errors were logged. From the user's perspective the client was just 
stuck. The root cause was the absence of a required jar (hence the 
NoSuchMethodError) but it was not reported properly.

TEST PLAN
  Run a client with the same configuration as before and verify it does not get 
stuck.

REVISION DETAIL
  https://reviews.facebook.net/D5877

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/13929/

To: Kannan, Liyin, Karthik, JIRA, mbautin


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6939) Add the possibility to set the ZK port in HBaseTestingUtility

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469300#comment-13469300
 ] 

Hudson commented on HBASE-6939:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/])
HBASE-6939 Add the possibility to set the ZK port in HBaseTestingUtility 
(Revision 1393940)

 Result = SUCCESS
nkeywal : 
Files : 
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


 Add the possibility to set the ZK port in HBaseTestingUtility
 -

 Key: HBASE-6939
 URL: https://issues.apache.org/jira/browse/HBASE-6939
 Project: HBase
  Issue Type: Improvement
  Components: test
Affects Versions: 0.94.1, 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 6939.094.v1.patch, 6939.v1.patch, 6939.v1.patch, 
 6939.v2.patch


 It's useful when embedding the HBaseTestingUtility into another test server: 
 fixing the ZK port allows it to put it simply into a shared instance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6562) Fake KVs are sometimes passed to filters

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469301#comment-13469301
 ] 

Hudson commented on HBASE-6562:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/])
HBASE-6912 Filters are not properly applied in certain cases (revert 
HBASE-6562) (Revision 1393853)

 Result = SUCCESS
larsh : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFakeKeyInFilter.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java


 Fake KVs are sometimes passed to filters
 

 Key: HBASE-6562
 URL: https://issues.apache.org/jira/browse/HBASE-6562
 Project: HBase
  Issue Type: Bug
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
 Fix For: 0.94.3, 0.96.0

 Attachments: 6562.txt, 6562-v2.txt, 6562-v3.txt, minimalTest.java


 In internal tests at Salesforce we found that fake row keys sometimes are 
 passed to filters (Filter.filterRowKey(...) specifically).
 The KVs are eventually filtered by the StoreScanner/ScanQueryMatcher, but the 
 row key is passed to filterRowKey in RegionScannImpl *before* that happens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469302#comment-13469302
 ] 

Hudson commented on HBASE-6439:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/])
HBASE-6439 Ignore .archive directory as a table (Revision 1393916)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HFileArchiveUtil.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHFileArchiveUtil.java


 Ignore .archive directory as a table
 

 Key: HBASE-6439
 URL: https://issues.apache.org/jira/browse/HBASE-6439
 Project: HBase
  Issue Type: Bug
  Components: io, regionserver
Affects Versions: 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
  Labels: newbie
 Fix For: 0.96.0

 Attachments: hbase-6439-r0.patch


 From a recent test run:
 {quote}
 2012-07-22 02:27:30,699 WARN  [IPC Server handler 0 on 47087] 
 util.FSTableDescriptors(168): The following folder is in HBase's root 
 directory and doesn't contain a table descriptor, do consider deleting it: 
 .archive
 {quote}
 With the addition of HBASE-5547, table-level folders are no-longer all table 
 folders. FSTableDescriptors needs to then have a 'gold-list' that we can 
 update with directories that aren't tables so we don't have this kind of 
 thing showing up in the logs.
 Currently, we have the following block:
 {quote}
 invocations++;
 if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) {
   cachehits++;
   return HTableDescriptor.ROOT_TABLEDESC;
 }
 if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) {
   cachehits++;
   return HTableDescriptor.META_TABLEDESC;
 }
 {quote}
 to handle special cases, but that's a bit clunky and not clean in terms of 
 table-level directories that need to be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6912) Filters are not properly applied in certain cases

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469303#comment-13469303
 ] 

Hudson commented on HBASE-6912:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/])
HBASE-6912 Filters are not properly applied in certain cases (revert 
HBASE-6562) (Revision 1393853)

 Result = SUCCESS
larsh : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFakeKeyInFilter.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java


 Filters are not properly applied in certain cases
 -

 Key: HBASE-6912
 URL: https://issues.apache.org/jira/browse/HBASE-6912
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.1
Reporter: Alex Newman
Assignee: Lars Hofhansl
 Fix For: 0.94.2, 0.96.0

 Attachments: 6912-0.94.txt, 6912-0.96.txt, minimalTest.java


 Steps to reproduce:
 Create a table, load data into it. Flush the table.
 Do a scan with
 1. Some filter which should not match the first entry in the scan
 2. Where one specifies a family and column.
 You will notice that the first entry is returned even though it doesn't match 
 the filter.
 It looks like the when the first KeyValue of a scan in the column from the 
 point of view of the code
 HRegion.java
 {code}
 } else if (kv != null  !kv.isInternal()  filterRowKey(currentRow)) {
 {code}
 Is generated by
 {code}
 public static KeyValue createLastOnRow(final byte [] row,
 final int roffset, final int rlength, final byte [] family,
 final int foffset, final int flength, final byte [] qualifier,
 final int qoffset, final int qlength) { return new KeyValue(row, roffset, 
 rlength, family, foffset, flength, qualifier, qoffset, qlength, 
 HConstants.OLDEST_TIMESTAMP, Type.Minimum, null, 0, 0); }
 {code}
 So it is always internal from that point of the code.
 Only later from within
 StoreScanner.java
 {code}
 public synchronized boolean next(ListKeyValue outResult, int limit, String 
 metric) throws IOException {
 
 LOOP: while((kv = this.heap.peek()) != null) {
 {code}
 ( The second time through)
 Do we get the actual kv, with a proper type and timestamp. This seems to mess 
 with filtering.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6928) TestStoreFile sometimes fails with 'Column family prefix used twice'

2012-10-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469304#comment-13469304
 ] 

Hudson commented on HBASE-6928:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/])
HBASE-6928 TestStoreFile sometimes fails with 'Column family prefix used 
twice' -- ATTEMPTED FIX (Revision 1393923)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java


 TestStoreFile sometimes fails with 'Column family prefix used twice'
 

 Key: HBASE-6928
 URL: https://issues.apache.org/jira/browse/HBASE-6928
 Project: HBase
  Issue Type: Bug
Reporter: Ted Yu
 Attachments: 6928_attempted_fix.txt, 6928-debug.txt


 In build #3406, I saw:
 {code}
 java.lang.AssertionError: Column family prefix used twice: 
 cf.cf.bt.Data.fsReadnumops
   at 
 org.apache.hadoop.hbase.regionserver.metrics.SchemaMetrics.validateMetricChanges(SchemaMetrics.java:822)
   at 
 org.apache.hadoop.hbase.regionserver.TestStoreFile.tearDown(TestStoreFile.java:89)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Assigned] (HBASE-6944) Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu reassigned HBASE-6944:
-

Assignee: Ted Yu

 Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7
 -

 Key: HBASE-6944
 URL: https://issues.apache.org/jira/browse/HBASE-6944
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.96.0

 Attachments: 6944.txt


 Currently test-patch.sh only runs against jdk 1.6
 However trunk build is using jdk 1.7
 test-patch.sh should be enhanced to run against both jdk versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6944) Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-6944:
--

Attachment: 6944.txt

First attempt.
test-patch.sh now runs against both jdk's

 Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7
 -

 Key: HBASE-6944
 URL: https://issues.apache.org/jira/browse/HBASE-6944
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
 Fix For: 0.96.0

 Attachments: 6944.txt


 Currently test-patch.sh only runs against jdk 1.6
 However trunk build is using jdk 1.7
 test-patch.sh should be enhanced to run against both jdk versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6944) Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-6944:
--

Fix Version/s: 0.96.0

 Enhance test-patch.sh to run against both jdk 1.6 and jdk 1.7
 -

 Key: HBASE-6944
 URL: https://issues.apache.org/jira/browse/HBASE-6944
 Project: HBase
  Issue Type: Task
Reporter: Ted Yu
Assignee: Ted Yu
 Fix For: 0.96.0

 Attachments: 6944.txt


 Currently test-patch.sh only runs against jdk 1.6
 However trunk build is using jdk 1.7
 test-patch.sh should be enhanced to run against both jdk versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469463#comment-13469463
 ] 

Lars Hofhansl commented on HBASE-6900:
--

Thanks for explaining Ram.

Are you sure you care for the return value of checkReseek?
After you explanation it seems like you can just call checkReseek always, and 
then always seek to the kv passed it. Like this:

{code}
  @Override
  public synchronized boolean reseek(KeyValue kv) throws IOException {
//Heap will not be null, if this is called from next() which.
//If called from RegionScanner.reseek(...) make sure the scanner
//stack is reset if needed.
checkReseek();
if (explicitColumnQuery  lazySeekEnabledGlobally) {
  return heap.requestSeek(kv, true, useRowColBloom);
} else {
  return heap.reseek(kv);
}
  }
{code}

 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)
Kumar Ravi created HBASE-6945:
-

 Summary: Compilation errors when using non-Sun JDKs to build 
HBase-0.94
 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1


When using IBM Java 7 to build HBase-0.94.1, the following comilation error is 
seen. 

[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
 error: package com.sun.management does not exist
[ERROR] 
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
 error: cannot find symbol
[ERROR]   symbol:   class UnixOperatingSystemMXBean
  location: class ResourceAnalyzer
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
 error: cannot find symbol
[ERROR]   symbol:   class UnixOperatingSystemMXBean
  location: class ResourceAnalyzer
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
 error: cannot find symbol
[INFO] 4 errors 
[INFO] -
[INFO] 
[INFO] BUILD FAILURE
[INFO] 

 I have a patch available which should work for all JDKs including Sun.
 I am in the process of testing this patch. Preliminary tests indicate the 
build is working fine with this patch. I will post this patch when I am done 
testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Ravi updated HBASE-6945:
--

Attachment: OSMXBean.java

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1

 Attachments: OSMXBean.java


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)
Lars Hofhansl created HBASE-6946:


 Summary: JavaDoc missing from release tarballs
 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6946:
-

Attachment: 6946.txt

0.94 patch

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469487#comment-13469487
 ] 

Ted Yu commented on HBASE-6946:
---

Looks like your comment for HBASE-6900 leaked into the patch :-)

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Work started] (HBASE-3661) Handle empty qualifier better in shell for increments

2012-10-04 Thread Michael Drzal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-3661 started by Michael Drzal.

 Handle empty qualifier better in shell for increments
 -

 Key: HBASE-3661
 URL: https://issues.apache.org/jira/browse/HBASE-3661
 Project: HBase
  Issue Type: Improvement
  Components: shell
Affects Versions: 0.92.0
Reporter: Lars George
Assignee: Michael Drzal
Priority: Minor
 Attachments: HBASE-3661.patch


 When trying to increment a counter using the examples, which specify no 
 *explicit* qualifier you get an error:
 {code}
 hbase(main):014:0 incr 'testtable', 'cnt1', 'colfam1', 1
 ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Trying to 
 contact region server 10.0.0.57:51640 for region 
 testtable,,1300267113942.cd2e7925140eb414d519621e384fb654., row 'cnt1', but 
 failed after 7 attempts.
 Exceptions:
 java.io.IOException: java.io.IOException: java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.ColumnCount.init(ColumnCount.java:47)
 at 
 org.apache.hadoop.hbase.regionserver.ExplicitColumnTracker.init(ExplicitColumnTracker.java:69)
 at 
 org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.init(ScanQueryMatcher.java:93)
 at 
 org.apache.hadoop.hbase.regionserver.StoreScanner.init(StoreScanner.java:65)
 at 
 org.apache.hadoop.hbase.regionserver.Store.getScanner(Store.java:1436)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.init(HRegion.java:2412)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.instantiateInternalScanner(HRegion.java:1185)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1171)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1155)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getLastIncrement(HRegion.java:3087)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.incrementColumnValue(HRegion.java:3312)
 at 
 org.apache.hadoop.hbase.regionserver.HRegionServer.incrementColumnValue(HRegionServer.java:2570)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at 
 org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:309)
 at 
 org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1060)
 Here is some help for this command:
 Increments a cell 'value' at specified table/row/column coordinates.
 To increment a cell value in table 't1' at row 'r1' under column
 'c1' by 1 (can be omitted) or 10 do:
   hbase incr 't1', 'r1', 'c1'
   hbase incr 't1', 'r1', 'c1', 1
   hbase incr 't1', 'r1', 'c1', 10
 {code}
 Handle this more gracefully (printing 5 stacktraces is ugly), improve the 
 help to specify what is needed more clearly. Or fix the server side to 
 support this, if this makes sense, and therefore never triggering this issue.
 Adding a qualifier makes it work:
 {code}
 hbase(main):015:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 1
 hbase(main):016:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 2
 {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-3661) Handle empty qualifier better in shell for increments

2012-10-04 Thread Michael Drzal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Drzal updated HBASE-3661:
-

Attachment: HBASE-3661.patch

Initial stab at this.  Tested with mvn test and mvn test -P localTests 
-Dtest=TestFromClientSide.

 Handle empty qualifier better in shell for increments
 -

 Key: HBASE-3661
 URL: https://issues.apache.org/jira/browse/HBASE-3661
 Project: HBase
  Issue Type: Improvement
  Components: shell
Affects Versions: 0.92.0
Reporter: Lars George
Assignee: Michael Drzal
Priority: Minor
 Attachments: HBASE-3661.patch


 When trying to increment a counter using the examples, which specify no 
 *explicit* qualifier you get an error:
 {code}
 hbase(main):014:0 incr 'testtable', 'cnt1', 'colfam1', 1
 ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Trying to 
 contact region server 10.0.0.57:51640 for region 
 testtable,,1300267113942.cd2e7925140eb414d519621e384fb654., row 'cnt1', but 
 failed after 7 attempts.
 Exceptions:
 java.io.IOException: java.io.IOException: java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.ColumnCount.init(ColumnCount.java:47)
 at 
 org.apache.hadoop.hbase.regionserver.ExplicitColumnTracker.init(ExplicitColumnTracker.java:69)
 at 
 org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.init(ScanQueryMatcher.java:93)
 at 
 org.apache.hadoop.hbase.regionserver.StoreScanner.init(StoreScanner.java:65)
 at 
 org.apache.hadoop.hbase.regionserver.Store.getScanner(Store.java:1436)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.init(HRegion.java:2412)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.instantiateInternalScanner(HRegion.java:1185)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1171)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1155)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getLastIncrement(HRegion.java:3087)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.incrementColumnValue(HRegion.java:3312)
 at 
 org.apache.hadoop.hbase.regionserver.HRegionServer.incrementColumnValue(HRegionServer.java:2570)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at 
 org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:309)
 at 
 org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1060)
 Here is some help for this command:
 Increments a cell 'value' at specified table/row/column coordinates.
 To increment a cell value in table 't1' at row 'r1' under column
 'c1' by 1 (can be omitted) or 10 do:
   hbase incr 't1', 'r1', 'c1'
   hbase incr 't1', 'r1', 'c1', 1
   hbase incr 't1', 'r1', 'c1', 10
 {code}
 Handle this more gracefully (printing 5 stacktraces is ugly), improve the 
 help to specify what is needed more clearly. Or fix the server side to 
 support this, if this makes sense, and therefore never triggering this issue.
 Adding a qualifier makes it work:
 {code}
 hbase(main):015:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 1
 hbase(main):016:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 2
 {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469514#comment-13469514
 ] 

Lars Hofhansl commented on HBASE-6946:
--

Whoops... Thanks Ted. Will upload a new version soon :)
Pom change is OK, though?

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6946:
-

Attachment: 6946-v2.txt

Patch with only the pom change.

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469517#comment-13469517
 ] 

ramkrishna.s.vasudevan commented on HBASE-6900:
---

I was just seeing what if the lastTop was null so that checkReseek doesn't 
reset the heap.  If that will not happen then the above change should be fine 
Lars. :)
Thank you.

 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3661) Handle empty qualifier better in shell for increments

2012-10-04 Thread Michael Drzal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469520#comment-13469520
 ] 

Michael Drzal commented on HBASE-3661:
--

Review up on reviewboard, https://reviews.apache.org/r/7446/

 Handle empty qualifier better in shell for increments
 -

 Key: HBASE-3661
 URL: https://issues.apache.org/jira/browse/HBASE-3661
 Project: HBase
  Issue Type: Improvement
  Components: shell
Affects Versions: 0.92.0
Reporter: Lars George
Assignee: Michael Drzal
Priority: Minor
 Attachments: HBASE-3661.patch


 When trying to increment a counter using the examples, which specify no 
 *explicit* qualifier you get an error:
 {code}
 hbase(main):014:0 incr 'testtable', 'cnt1', 'colfam1', 1
 ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Trying to 
 contact region server 10.0.0.57:51640 for region 
 testtable,,1300267113942.cd2e7925140eb414d519621e384fb654., row 'cnt1', but 
 failed after 7 attempts.
 Exceptions:
 java.io.IOException: java.io.IOException: java.lang.NullPointerException
 at 
 org.apache.hadoop.hbase.regionserver.ColumnCount.init(ColumnCount.java:47)
 at 
 org.apache.hadoop.hbase.regionserver.ExplicitColumnTracker.init(ExplicitColumnTracker.java:69)
 at 
 org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.init(ScanQueryMatcher.java:93)
 at 
 org.apache.hadoop.hbase.regionserver.StoreScanner.init(StoreScanner.java:65)
 at 
 org.apache.hadoop.hbase.regionserver.Store.getScanner(Store.java:1436)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.init(HRegion.java:2412)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.instantiateInternalScanner(HRegion.java:1185)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1171)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1155)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.getLastIncrement(HRegion.java:3087)
 at 
 org.apache.hadoop.hbase.regionserver.HRegion.incrementColumnValue(HRegion.java:3312)
 at 
 org.apache.hadoop.hbase.regionserver.HRegionServer.incrementColumnValue(HRegionServer.java:2570)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at 
 org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:309)
 at 
 org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1060)
 Here is some help for this command:
 Increments a cell 'value' at specified table/row/column coordinates.
 To increment a cell value in table 't1' at row 'r1' under column
 'c1' by 1 (can be omitted) or 10 do:
   hbase incr 't1', 'r1', 'c1'
   hbase incr 't1', 'r1', 'c1', 1
   hbase incr 't1', 'r1', 'c1', 10
 {code}
 Handle this more gracefully (printing 5 stacktraces is ugly), improve the 
 help to specify what is needed more clearly. Or fix the server side to 
 support this, if this makes sense, and therefore never triggering this issue.
 Adding a qualifier makes it work:
 {code}
 hbase(main):015:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 1
 hbase(main):016:0 incr 'testtable', 'cnt1', 'colfam1:test', 1
 COUNTER VALUE = 2
 {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469524#comment-13469524
 ] 

Lars Hofhansl commented on HBASE-6900:
--

Even if that happens, don't you always want to reseek to the kv that passed in?


 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Ravi updated HBASE-6945:
--

Attachment: ResourceChecker.patch

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1

 Attachments: OSMXBean.java, ResourceChecker.patch


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Ravi updated HBASE-6945:
--

Attachment: (was: ResourceChecker.patch)

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Assigned] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal reassigned HBASE-6945:
--

Assignee: nkeywal

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
Assignee: nkeywal
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Ravi updated HBASE-6945:
--

Attachment: (was: OSMXBean.java)

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
Assignee: nkeywal
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469535#comment-13469535
 ] 

Phabricator commented on HBASE-6943:


Kannan has added CCs to the revision [jira] [HBASE-6943] [89-fb] Do not catch 
certain exceptions trying to get an RS connection.
Added CCs: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc

  Let's try to cc individually until we can figure out how to more easily email 
the group automatically.

REVISION DETAIL
  https://reviews.facebook.net/D5877

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-6945:
---

Assignee: (was: nkeywal)

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469537#comment-13469537
 ] 

Phabricator commented on HBASE-6943:


Kannan has accepted the revision [jira] [HBASE-6943] [89-fb] Do not catch 
certain exceptions trying to get an RS connection.

  lgtm! good catch...

REVISION DETAIL
  https://reviews.facebook.net/D5877

BRANCH
  stuck_client_v4

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469536#comment-13469536
 ] 

nkeywal commented on HBASE-6945:


Hi Kumar,

Note that the implementation is slightly different on 0.96/trunk (but still 
relies on sun jvm). There are as well some optimizations linked to the sun jvm 
that makes it more interesting in the general case (see HBASE-4012). 
For this Jira it's mainly an helper function, so it's easier. Imho, it would be 
as well acceptable to simply deactivate the metric if we can't get it easily. 
But it would make the ibm build less powerful than the sun/oracle one.

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
Assignee: nkeywal
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Kumar Ravi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469548#comment-13469548
 ] 

Kumar Ravi commented on HBASE-6945:
---

Hello,

 I am pretty close to having a patch done - Can you pl. assign this to me? 
(kumarr)

Thanks,
Kumar 

Kumar Ravi
IBM Linux Technology Center 

11501 Burnet Road,
Austin, TX 78758

Tel.: (512)286-8179



From:
nkeywal (JIRA) j...@apache.org
To:
Kumar Ravi/Austin/IBM@IBMUS, 
Date:
10/04/2012 12:30 PM
Subject:
[jira] [Assigned] (HBASE-6945) Compilation errors when using non-Sun JDKs 
to build HBase-0.94



 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 
]

nkeywal reassigned HBASE-6945:
--

Assignee: nkeywal
 
error is seen. 
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
 
error: package com.sun.management does not exist
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
 
error: cannot find symbol
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
 
error: cannot find symbol
/home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
 
error: cannot find symbol


the build is working fine with this patch. I will post this patch when I 
am done testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA 
administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira




 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Assigned] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Jimmy Xiang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang reassigned HBASE-6945:
--

Assignee: Kumar Ravi

Done.

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
Assignee: Kumar Ravi
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469554#comment-13469554
 ] 

nkeywal commented on HBASE-6945:


For whatever technical reason, I can't. Likely another committer will be able 
to do it.

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
 Fix For: 0.94.1


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6945) Compilation errors when using non-Sun JDKs to build HBase-0.94

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6945:
-

Fix Version/s: (was: 0.94.1)
   0.94.3

 Compilation errors when using non-Sun JDKs to build HBase-0.94
 --

 Key: HBASE-6945
 URL: https://issues.apache.org/jira/browse/HBASE-6945
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.1
 Environment: RHEL 6.3, IBM Java 7 
Reporter: Kumar Ravi
Assignee: Kumar Ravi
 Fix For: 0.94.3


 When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
 is seen. 
 [INFO] -
 [ERROR] COMPILATION ERROR : 
 [INFO] -
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
  error: package com.sun.management does not exist
 [ERROR] 
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
  error: cannot find symbol
 [ERROR]   symbol:   class UnixOperatingSystemMXBean
   location: class ResourceAnalyzer
 /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
  error: cannot find symbol
 [INFO] 4 errors 
 [INFO] -
 [INFO] 
 
 [INFO] BUILD FAILURE
 [INFO] 
 
  I have a patch available which should work for all JDKs including Sun.
  I am in the process of testing this patch. Preliminary tests indicate the 
 build is working fine with this patch. I will post this patch when I am done 
 testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6947) TestZooKeeperScanPolicyObserver#testScanPolicyObserver occasionally fails in trunk

2012-10-04 Thread Ted Yu (JIRA)
Ted Yu created HBASE-6947:
-

 Summary: TestZooKeeperScanPolicyObserver#testScanPolicyObserver 
occasionally fails in trunk
 Key: HBASE-6947
 URL: https://issues.apache.org/jira/browse/HBASE-6947
 Project: HBase
  Issue Type: Bug
Reporter: Ted Yu


From trunk build #3421 
(https://builds.apache.org/job/HBase-TRUNK/3421/testReport/junit/org.apache.hadoop.hbase.coprocessor.example/TestZooKeeperScanPolicyObserver/testScanPolicyObserver/
 and 
https://builds.apache.org/job/HBase-TRUNK/3414/testReport/junit/org.apache.hadoop.hbase.coprocessor.example/TestZooKeeperScanPolicyObserver/testScanPolicyObserver/):
{code}
java.lang.AssertionError: expected:2 but was:0
at org.junit.Assert.fail(Assert.java:93)
at org.junit.Assert.failNotEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:128)
at org.junit.Assert.assertEquals(Assert.java:472)
at org.junit.Assert.assertEquals(Assert.java:456)
at 
org.apache.hadoop.hbase.coprocessor.example.TestZooKeeperScanPolicyObserver.testScanPolicyObserver(TestZooKeeperScanPolicyObserver.java:105)
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6948) shell create table script cannot handle split key which is expressed in raw bytes

2012-10-04 Thread Ted Yu (JIRA)
Ted Yu created HBASE-6948:
-

 Summary: shell create table script cannot handle split key which 
is expressed in raw bytes
 Key: HBASE-6948
 URL: https://issues.apache.org/jira/browse/HBASE-6948
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.2
Reporter: Ted Yu




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469597#comment-13469597
 ] 

Jesse Yates commented on HBASE-6707:


bq. only check for files and delete directories when there are no files for 
that directory.
Done - HBASE-6949

Are we happy with the latest addendum?

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)
Jesse Yates created HBASE-6949:
--

 Summary: Automatically delete empty directories in CleanerChore
 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
 Fix For: 0.94.3, 0.96.0


Currently the CleanerChore asks cleaner delegates if both directories and files 
should be deleted. However, this leads to somewhat odd behavior in some 
delegates - you don't actually care if the directory hierarchy is preserved, 
the files; this means you always will delete directories and then implement the 
logic you actually want for preserving files. Instead we can handle this logic 
one layer higher in the CleanerChore and let the delegates just worry about 
preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6619) Do no unregister and re-register interest ops in RPC

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6619:
-

Fix Version/s: (was: 0.94.3)
   (was: 0.96.0)

Actually this change (or a version of it) is in 0.94 and 0.96 already.

 Do no unregister and re-register interest ops in RPC
 

 Key: HBASE-6619
 URL: https://issues.apache.org/jira/browse/HBASE-6619
 Project: HBase
  Issue Type: Bug
  Components: IPC/RPC, Performance
Reporter: Karthik Ranganathan
Assignee: Michal Gregorczyk
Priority: Critical
 Attachments: 
 0001-jira-HBASE-6619-89-fb-Do-no-unregister-and-re-regist.patch


 While investigating perf of HBase, Michal noticed that we could cut about 
 5-40% (depending on number of threads) from the total get time in the RPC on 
 the server side if we eliminated re-registering for interest ops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469607#comment-13469607
 ] 

Phabricator commented on HBASE-6943:


aaiyer has commented on the revision [jira] [HBASE-6943] [89-fb] Do not catch 
certain exceptions trying to get an RS connection.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java:1383 Do 
we need to do this in other places as well? -- getRegionServer with/without 
retries?

  Perhaps a good place to do this is to do it in translateException. If we see 
that the throwable is one of these bad ones. we can just throw ie again.

REVISION DETAIL
  https://reviews.facebook.net/D5877

BRANCH
  stuck_client_v4

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (HBASE-6619) Do no unregister and re-register interest ops in RPC

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl resolved HBASE-6619.
--

Resolution: Implemented

 Do no unregister and re-register interest ops in RPC
 

 Key: HBASE-6619
 URL: https://issues.apache.org/jira/browse/HBASE-6619
 Project: HBase
  Issue Type: Bug
  Components: IPC/RPC, Performance
Reporter: Karthik Ranganathan
Assignee: Michal Gregorczyk
Priority: Critical
 Attachments: 
 0001-jira-HBASE-6619-89-fb-Do-no-unregister-and-re-regist.patch


 While investigating perf of HBase, Michal noticed that we could cut about 
 5-40% (depending on number of threads) from the total get time in the RPC on 
 the server side if we eliminated re-registering for interest ops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Assigned] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates reassigned HBASE-6949:
--

Assignee: Jesse Yates

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HBASE-6943:
---

Attachment: D5877.2.patch

mbautin updated the revision [jira] [HBASE-6943] [89-fb] Do not catch certain 
exceptions trying to get an RS connection.
Reviewers: Kannan, Liyin, Karthik, JIRA

  Addressing Amit's feedback

REVISION DETAIL
  https://reviews.facebook.net/D5877

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch, D5877.2.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6900:
-

Attachment: 6900-test.txt

Attaching this as a test patch (to see what HadoopQA has to say)

 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: 6900-test.txt, HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates updated HBASE-6949:
---

Attachment: hbase-6949-v0.patch

Attaching patch to refactor CleanerChore to accommodate the above description. 
The refactor is pretty minor - mostly just a cleaner version of what's there 
already. 

However, I took the time to throw a couple of tests in there to cover the 
current functionality, rather than having subclasses inherently test that 
functionaliy.

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates updated HBASE-6949:
---

Status: Patch Available  (was: Open)

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469637#comment-13469637
 ] 

Jesse Yates commented on HBASE-6949:


Attached is the 0.96 version. The 0.94.3 version is part of the backport of 
HBASE-5547 and will be rolled into that backport, just marking it for some 
history there.

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469645#comment-13469645
 ] 

Ted Yu commented on HBASE-6707:
---

I think this hunk is not needed:
{code}
@@ -50,16 +50,14 @@ public class LongTermArchivingHFileCleaner extends 
BaseHFileCleanerDelegate {
   @Override
   public boolean isFileDeletable(Path file) {
 try {
+  // if its a directory, then it can be deleted
+  if (!fs.isFile(file)) return true;

+  // check to see if
   FileStatus[] deleteStatus = FSUtils.listStatus(this.fs, file, null);
   // if the file doesn't exist, then it can be deleted (but should never
   // happen since deleted files shouldn't get passed in)
   if (deleteStatus == null) return true;
-  // if its a directory with stuff in it, don't delete
-  if (deleteStatus.length  1) return false;
-
-  // if its an empty directory, we can definitely delete
-  if (deleteStatus[0].isDir()) return true;

   // otherwise, we need to check the file's table and see its being 
archived
   Path family = file.getParent();
{code}
I placed breakpoint on the following line in the debugger:
{code}
+  if (!fs.isFile(file)) return true;
{code}
file turned out to be empty every time when it was a directory.

Without the above hunk, test still passed in a loop (on jdk 1.7).

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6948) shell create table script cannot handle split key which is expressed in raw bytes

2012-10-04 Thread Tianying Chang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tianying Chang updated HBASE-6948:
--


I found this bug whiling working on migrating data into a table with less 
regions. HBase shell create table passed the wrong splt key. I have the patch 
ready and tested on my cluster. 

 shell create table script cannot handle split key which is expressed in raw 
 bytes
 -

 Key: HBASE-6948
 URL: https://issues.apache.org/jira/browse/HBASE-6948
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.2
Reporter: Ted Yu



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469650#comment-13469650
 ] 

Hadoop QA commented on HBASE-6900:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547805/6900-test.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3003//console

This message is automatically generated.

 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: 6900-test.txt, HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Jesse Yates (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse Yates updated HBASE-6949:
---

Attachment: hbase-6949-v1.patch

Attaching updated version - forgot to add test for not deleting directories 
when a file is added after all children files have been cleaned (if this were 
not the expected behaviour, the 'late added' file would be deleted without a 
chance to run it through the delegates).

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch, hbase-6949-v1.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469665#comment-13469665
 ] 

Jesse Yates commented on HBASE-6707:


bq. file turned out to be empty every time when it was a directory.

What do you mean by this? What are you proposing the method should look like? 
The intention was to always delete directories (which can later be removed by 
HBASE-6949), but that it does need to check if the table for those hfiles is 
being archived.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6619) Do no unregister and re-register interest ops in RPC

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469673#comment-13469673
 ] 

Lars Hofhansl commented on HBASE-6619:
--

Was that an issue for the .89fb branch? If so, I'm sorry I closed it (and 
obviously feel free to reopen and retarget).


 Do no unregister and re-register interest ops in RPC
 

 Key: HBASE-6619
 URL: https://issues.apache.org/jira/browse/HBASE-6619
 Project: HBase
  Issue Type: Bug
  Components: IPC/RPC, Performance
Reporter: Karthik Ranganathan
Assignee: Michal Gregorczyk
Priority: Critical
 Attachments: 
 0001-jira-HBASE-6619-89-fb-Do-no-unregister-and-re-regist.patch


 While investigating perf of HBase, Michal noticed that we could cut about 
 5-40% (depending on number of threads) from the total get time in the RPC on 
 the server side if we eliminated re-registering for interest ops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469675#comment-13469675
 ] 

Ted Yu commented on HBASE-6707:
---

If the first hunk is needed by HBASE-6949, it can go into that patch.

I tried the addendum with and without the first hunk and the test failed on jdk 
1.6 at the same spot:
{code}
testMultipleTables(org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient)
  Time elapsed: 1.207 sec   ERROR!
java.lang.NullPointerException
  at 
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:259)
{code}
I can provide test output if you need it.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469676#comment-13469676
 ] 

Lars Hofhansl commented on HBASE-6900:
--

Failed test passed locally. Will leave it to Ram to decide whether to commit 
this.

 RegionScanner.reseek() creates NPE when a flush or compaction happens before 
 the reseek.
 

 Key: HBASE-6900
 URL: https://issues.apache.org/jira/browse/HBASE-6900
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
 Fix For: 0.94.2, 0.96.0

 Attachments: 6900-test.txt, HBASE-6900_1.patch, HBASE-6900.patch


 HBASE-5520 introduced reseek() on the RegionScanner.  
 Now when a scanner is created we have the StoreScanner heap.  After this if a 
 flush or compaction happens parallely all the StoreScannerObservers are 
 cleared so that whenever a new next() call happens we tend to recreate the 
 scanner based on the latest store files.
 The reseek() in StoreScanner expects the heap not to be null because always 
 reseek would be called from next()
 {code}
 public synchronized boolean reseek(KeyValue kv) throws IOException {
 //Heap cannot be null, because this is only called from next() which
 //guarantees that heap will never be null before this call.
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   return heap.requestSeek(kv, true, useRowColBloom);
 } else {
   return heap.reseek(kv);
 }
   }
 {code}
 Now when we call RegionScanner.reseek() directly using CPs we tend to get a 
 NPE.  In our case it happened when a major compaction was going on.  I will 
 also attach a testcase to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469677#comment-13469677
 ] 

Lars Hofhansl commented on HBASE-6946:
--

Will commit soon, unless somebody objects.

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469682#comment-13469682
 ] 

Lars Hofhansl commented on HBASE-6946:
--

Actually with this change, should the javadoc step be removed from the rpm 
profile?

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469683#comment-13469683
 ] 

Jesse Yates commented on HBASE-6707:


[~te...@apache.org] what do you mean by first and second hunk? Can you please 
provide the code? Thanks!

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469691#comment-13469691
 ] 

Ted Yu commented on HBASE-6707:
---

The first hunk is from line 5 to line 24 in the addendum.

I didn't mention second hunk.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, 
 hbase-6707-v2.patch, hbase-6707-v3.patch, hbase-6707-v4-addendum.patch, 
 hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3656) Merging flush; merge a flush with one of the existing store files (the smallest?) so we skip creating a new store file on each flush

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469697#comment-13469697
 ] 

Lars Hofhansl commented on HBASE-3656:
--

This would (potentially) make certain backup solution more difficult.

Imagine a backup scheme that backs up each HFile resulting from a major 
compaction and each HFile resulting from a flush (HFiles from minor compactions 
are not needed and just complicate things).
This would no longer be possible since the flushed KVs would then be 
intermingled with other KVs, which may or may not be in an HFile that was 
copied already.

Not saying this is a reason for not doing this.

 Merging flush; merge a flush with one of the existing store files (the 
 smallest?) so we skip creating a new store file on each flush
 

 Key: HBASE-3656
 URL: https://issues.apache.org/jira/browse/HBASE-3656
 Project: HBase
  Issue Type: Task
Reporter: stack

 This behavior is described in the BT paper.  Years ago I had a go at it but 
 at the time it slowed flushing significantly -- and IIRC we had no barriers 
 on writes when the memory pressue was high -- so it brought on OOMEs... so 
 punted on it.  Its time to consider this feature again.
 Would we always do it?  Maybe not if its a close?  If a close we want stuff 
 to run quickly so we should skip the merge.  But any other time, we should do 
 it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3646) When mapper writes multiple values for a key keep chronological order of values

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469703#comment-13469703
 ] 

Lars Hofhansl commented on HBASE-3646:
--

Any update on this?

 When mapper writes multiple values for a key keep chronological order of 
 values
 ---

 Key: HBASE-3646
 URL: https://issues.apache.org/jira/browse/HBASE-3646
 Project: HBase
  Issue Type: New Feature
  Components: Client
Affects Versions: 0.90.1
 Environment: Cloudera 3.5 VM 
 TableMapperImmutableBytesWritable,IntWritable
 TableReducerImmutableBytesWritable,IntWritable, ImmutableBytesWritable
Reporter: Bob Cummins
Priority: Minor

 When mapper writes multiple values for a key, the underlying collection class 
 maps each of the values to the key, but not always in chronological order. If 
 chronological order were guaranteed each of the values mapped to the key, 
 each of the values could be understood as specific and different parameters 
 between the mapper and the reducer.
 I've done little tricks like having the mapper flag one a the values by 
 making it a negative number, which the reducer recognizes and can write it to 
 hbase as a unique column value.This is a kluge workaround which it would be 
 nice to not have to do.
 Used to formulate this suggestion:
 TableMapperImmutableBytesWritable,IntWritable
 TableReducerImmutableBytesWritable,IntWritable, ImmutableBytesWritable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3645) Before running each shell command, check zk session and if not present, reestablish it

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469705#comment-13469705
 ] 

Lars Hofhansl commented on HBASE-3645:
--

This might no longer be an issue, which the client changes I have done over 
time. I will double check.

 Before running each shell command, check zk session and if not present, 
 reestablish it
 --

 Key: HBASE-3645
 URL: https://issues.apache.org/jira/browse/HBASE-3645
 Project: HBase
  Issue Type: Improvement
  Components: shell
Reporter: stack
Assignee: Lars Hofhansl

 Dmitriy was getting whack responses from his shell... NoSuchMethodException, 
 etc., and it turned out that it was a long running shell that had run over a 
 cluster restart.  We should at least fail if we've lost our zk session or 
 reconnect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-6707:
--

Attachment: 6707-v4-addendum.txt

6707-v4-addendum.txt is my version of addendum.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: 6707-v4-addendum.txt, hbase-6707-v0.patch, 
 hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch, 
 hbase-6707-v4-addendum.patch, hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Assigned] (HBASE-3645) Before running each shell command, check zk session and if not present, reestablish it

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl reassigned HBASE-3645:


Assignee: Lars Hofhansl

 Before running each shell command, check zk session and if not present, 
 reestablish it
 --

 Key: HBASE-3645
 URL: https://issues.apache.org/jira/browse/HBASE-3645
 Project: HBase
  Issue Type: Improvement
  Components: shell
Reporter: stack
Assignee: Lars Hofhansl

 Dmitriy was getting whack responses from his shell... NoSuchMethodException, 
 etc., and it turned out that it was a long running shell that had run over a 
 cluster restart.  We should at least fail if we've lost our zk session or 
 reconnect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6916) HBA logs at info level errors that won't show in the shell

2012-10-04 Thread Elliott Clark (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469717#comment-13469717
 ] 

Elliott Clark commented on HBASE-6916:
--

+1 lgtm

 HBA logs at info level errors that won't show in the shell
 --

 Key: HBASE-6916
 URL: https://issues.apache.org/jira/browse/HBASE-6916
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 0.90.6, 0.92.1, 0.94.1, 0.96.0
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Minor
 Fix For: 0.92.2, 0.94.3, 0.96.0

 Attachments: HBASE-6916-0.94.patch, HBASE-6916.patch, 
 HBASE-6916-v2.patch


 There is a weird interaction between the shell and HBA. When you try to close 
 a region that doesn't exist, it doesn't throw any error:
 {noformat}
 hbase(main):029:0 close_region 'thisisaninvalidregion'
 0 row(s) in 0.0580 seconds
 {noformat}
 Normally one should get UnknownRegionException. Starting the shell with -d 
 I see what a non-shell user would see along with a ton of logging from ZK 
 (skipped here):
 {noformat}
 INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
 pair=null
 {noformat}
 But again this is not the right message, it should have shown
 {noformat}
 INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
 pair=null
 {noformat}
 And this is because that part of the code treats both UnknownRegionException 
 and NoServerForRegionException like if it was the same thing.
 There is also some ugliness in flush, compact, and split but it normally 
 doesn't show since the code treats everything like it's a table and sends a 
 TableNotFoundException.
 This jira is about making sure that the exceptions are correctly coming out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469718#comment-13469718
 ] 

Hadoop QA commented on HBASE-6949:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547809/hbase-6949-v0.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3004//console

This message is automatically generated.

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch, hbase-6949-v1.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3646) When mapper writes multiple values for a key keep chronological order of values

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469720#comment-13469720
 ] 

Jesse Yates commented on HBASE-3646:


Nope  - I have no idea what Bob was after with this. I'm okay if we want to 
close this as won't fix/can't reproduce.

 When mapper writes multiple values for a key keep chronological order of 
 values
 ---

 Key: HBASE-3646
 URL: https://issues.apache.org/jira/browse/HBASE-3646
 Project: HBase
  Issue Type: New Feature
  Components: Client
Affects Versions: 0.90.1
 Environment: Cloudera 3.5 VM 
 TableMapperImmutableBytesWritable,IntWritable
 TableReducerImmutableBytesWritable,IntWritable, ImmutableBytesWritable
Reporter: Bob Cummins
Priority: Minor

 When mapper writes multiple values for a key, the underlying collection class 
 maps each of the values to the key, but not always in chronological order. If 
 chronological order were guaranteed each of the values mapped to the key, 
 each of the values could be understood as specific and different parameters 
 between the mapper and the reducer.
 I've done little tricks like having the mapper flag one a the values by 
 making it a negative number, which the reducer recognizes and can write it to 
 hbase as a unique column value.This is a kluge workaround which it would be 
 nice to not have to do.
 Used to formulate this suggestion:
 TableMapperImmutableBytesWritable,IntWritable
 TableReducerImmutableBytesWritable,IntWritable, ImmutableBytesWritable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6950) TestAcidGuarantees system test now flushes too aggressively

2012-10-04 Thread Gregory Chanan (JIRA)
Gregory Chanan created HBASE-6950:
-

 Summary: TestAcidGuarantees system test now flushes too 
aggressively
 Key: HBASE-6950
 URL: https://issues.apache.org/jira/browse/HBASE-6950
 Project: HBase
  Issue Type: Bug
  Components: test
Affects Versions: 0.92.2, 0.94.2, 0.96.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Minor
 Fix For: 0.96.0


HBASE-6552 caused the TestAcidGuarantees system test to flush more 
aggressively, because flushes are where ACID problems have occurred in the past.

After some more cluster testing, it seems like this too aggressive; my clusters 
eventually can't keep up with the number of flushes/compactions and start 
getting SocketTimeoutExceptions.  We could try to optimize the 
flushes/compactions, but since this workload would never occur in practice, I 
don't think it is worth the effort.  Instead, let's just only flush once a 
minute.  This is arbitrary, but seems to work.

Here is my comment in the (upcoming) patch:
{code}
// Flushing has been a source of ACID violations previously (see HBASE-2856), 
so ideally,
// we would flush as often as possible.  On a running cluster, this isn't 
practical:
// (1) we will cause a lot of load due to all the flushing and compacting
// (2) we cannot change the flushing/compacting related Configuration options 
to try to
// alleviate this
// (3) it is an unrealistic workload, since no one would actually flush that 
often.
// Therefore, let's flush every minute to have more flushes than usual, but not 
overload
// the running cluster.
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6916) HBA logs at info level errors that won't show in the shell

2012-10-04 Thread Jean-Daniel Cryans (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Daniel Cryans updated HBASE-6916:
--

   Resolution: Fixed
Fix Version/s: (was: 0.94.3)
   (was: 0.92.2)
   0.94.2
   0.92.3
 Release Note: The close_region shell command won't fail silently anymore, 
code relying on this behavior will now get UnknownRegionException
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to .92, .94, and trunk. Thanks for the reviews guys.

 HBA logs at info level errors that won't show in the shell
 --

 Key: HBASE-6916
 URL: https://issues.apache.org/jira/browse/HBASE-6916
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 0.90.6, 0.92.1, 0.94.1, 0.96.0
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Minor
 Fix For: 0.92.3, 0.94.2, 0.96.0

 Attachments: HBASE-6916-0.94.patch, HBASE-6916.patch, 
 HBASE-6916-v2.patch


 There is a weird interaction between the shell and HBA. When you try to close 
 a region that doesn't exist, it doesn't throw any error:
 {noformat}
 hbase(main):029:0 close_region 'thisisaninvalidregion'
 0 row(s) in 0.0580 seconds
 {noformat}
 Normally one should get UnknownRegionException. Starting the shell with -d 
 I see what a non-shell user would see along with a ton of logging from ZK 
 (skipped here):
 {noformat}
 INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
 pair=null
 {noformat}
 But again this is not the right message, it should have shown
 {noformat}
 INFO client.HBaseAdmin: No server in .META. for thisisaninvalidregion; 
 pair=null
 {noformat}
 And this is because that part of the code treats both UnknownRegionException 
 and NoServerForRegionException like if it was the same thing.
 There is also some ugliness in flush, compact, and split but it normally 
 doesn't show since the code treats everything like it's a table and sends a 
 TableNotFoundException.
 This jira is about making sure that the exceptions are correctly coming out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Jesse Yates (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469724#comment-13469724
 ] 

Jesse Yates commented on HBASE-6707:


bq. If the first hunk is needed by HBASE-6949, it can go into that patch.

That can be removed in HBASE-6949 - it just depends on which order things are 
applied.

bq. I didn't mention second hunk.

Oops.

bq. I tried the addendum with and without the first hunk and the test failed on 
jdk 1.6 at the same spot:

I'm trying the test on jdk 1.6 with the first hunk applied (and not) and its 
working fine. 

Your comment above would imply that the test isn't working either way, so your 
patch would then not be correct, unless I'm missing something? 




 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: 6707-v4-addendum.txt, hbase-6707-v0.patch, 
 hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch, 
 hbase-6707-v4-addendum.patch, hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6950) TestAcidGuarantees system test now flushes too aggressively

2012-10-04 Thread Gregory Chanan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-6950:
--

Attachment: HBASE-6950.patch

 TestAcidGuarantees system test now flushes too aggressively
 ---

 Key: HBASE-6950
 URL: https://issues.apache.org/jira/browse/HBASE-6950
 Project: HBase
  Issue Type: Bug
  Components: test
Affects Versions: 0.92.2, 0.94.2, 0.96.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Minor
 Fix For: 0.96.0

 Attachments: HBASE-6950.patch


 HBASE-6552 caused the TestAcidGuarantees system test to flush more 
 aggressively, because flushes are where ACID problems have occurred in the 
 past.
 After some more cluster testing, it seems like this too aggressive; my 
 clusters eventually can't keep up with the number of flushes/compactions and 
 start getting SocketTimeoutExceptions.  We could try to optimize the 
 flushes/compactions, but since this workload would never occur in practice, I 
 don't think it is worth the effort.  Instead, let's just only flush once a 
 minute.  This is arbitrary, but seems to work.
 Here is my comment in the (upcoming) patch:
 {code}
 // Flushing has been a source of ACID violations previously (see HBASE-2856), 
 so ideally,
 // we would flush as often as possible.  On a running cluster, this isn't 
 practical:
 // (1) we will cause a lot of load due to all the flushing and compacting
 // (2) we cannot change the flushing/compacting related Configuration options 
 to try to
 // alleviate this
 // (3) it is an unrealistic workload, since no one would actually flush that 
 often.
 // Therefore, let's flush every minute to have more flushes than usual, but 
 not overload
 // the running cluster.
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6950) TestAcidGuarantees system test now flushes too aggressively

2012-10-04 Thread Gregory Chanan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Chanan updated HBASE-6950:
--

Status: Patch Available  (was: Open)

 TestAcidGuarantees system test now flushes too aggressively
 ---

 Key: HBASE-6950
 URL: https://issues.apache.org/jira/browse/HBASE-6950
 Project: HBase
  Issue Type: Bug
  Components: test
Affects Versions: 0.92.2, 0.94.2, 0.96.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Minor
 Fix For: 0.96.0

 Attachments: HBASE-6950.patch


 HBASE-6552 caused the TestAcidGuarantees system test to flush more 
 aggressively, because flushes are where ACID problems have occurred in the 
 past.
 After some more cluster testing, it seems like this too aggressive; my 
 clusters eventually can't keep up with the number of flushes/compactions and 
 start getting SocketTimeoutExceptions.  We could try to optimize the 
 flushes/compactions, but since this workload would never occur in practice, I 
 don't think it is worth the effort.  Instead, let's just only flush once a 
 minute.  This is arbitrary, but seems to work.
 Here is my comment in the (upcoming) patch:
 {code}
 // Flushing has been a source of ACID violations previously (see HBASE-2856), 
 so ideally,
 // we would flush as often as possible.  On a running cluster, this isn't 
 practical:
 // (1) we will cause a lot of load due to all the flushing and compacting
 // (2) we cannot change the flushing/compacting related Configuration options 
 to try to
 // alleviate this
 // (3) it is an unrealistic workload, since no one would actually flush that 
 often.
 // Therefore, let's flush every minute to have more flushes than usual, but 
 not overload
 // the running cluster.
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6951) Allow the master info server to be started in a read only mode.

2012-10-04 Thread Elliott Clark (JIRA)
Elliott Clark created HBASE-6951:


 Summary: Allow the master info server to be started in a read only 
mode.
 Key: HBASE-6951
 URL: https://issues.apache.org/jira/browse/HBASE-6951
 Project: HBase
  Issue Type: Improvement
  Components: UI
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Critical


There are some cases that a user could want a web ui to be accessible but might 
not want the split and compact functionality to be usable.

Allowing the web ui to start in a readOnly mode would be good.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6951) Allow the master info server to be started in a read only mode.

2012-10-04 Thread Elliott Clark (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-6951:
-

Labels: noob  (was: )

 Allow the master info server to be started in a read only mode.
 ---

 Key: HBASE-6951
 URL: https://issues.apache.org/jira/browse/HBASE-6951
 Project: HBase
  Issue Type: Improvement
  Components: UI
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Critical
  Labels: noob

 There are some cases that a user could want a web ui to be accessible but 
 might not want the split and compact functionality to be usable.
 Allowing the web ui to start in a readOnly mode would be good.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469727#comment-13469727
 ] 

Ted Yu commented on HBASE-6707:
---

My addendum fixes NullPointerException.
But it failed again on jdk 1.6 with:
{code}
testMultipleTables(org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient)
  Time elapsed: 1.186 sec   FAILURE!
java.lang.AssertionError: Not all archived files for the primary table were 
retained. expected:2 but was:0
  at org.junit.Assert.fail(Assert.java:93)
  at org.junit.Assert.failNotEquals(Assert.java:647)
  at org.junit.Assert.assertEquals(Assert.java:128)
  at org.junit.Assert.assertEquals(Assert.java:472)
  at 
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:266){code}
On jdk 1.7 I didn't see test failure.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: 6707-v4-addendum.txt, hbase-6707-v0.patch, 
 hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch, 
 hbase-6707-v4-addendum.patch, hbase-6707-v4.patch


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6943) [89-fb] Do not catch certain exceptions trying to get an RS connection

2012-10-04 Thread Phabricator (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HBASE-6943:
---

Attachment: D5877.3.patch

mbautin updated the revision [jira] [HBASE-6943] [89-fb] Do not catch certain 
exceptions trying to get an RS connection.
Reviewers: Kannan, Liyin, Karthik, JIRA

  Catching an arbitrary throwable and wrapping it with an IOException in 
setupIOstreams.

REVISION DETAIL
  https://reviews.facebook.net/D5877

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

To: Kannan, Liyin, Karthik, JIRA, mbautin
Cc: avf, adela, pritamdamania, aaiyer, nspiegelberg, amirshim, mycnyc


 [89-fb] Do not catch certain exceptions trying to get an RS connection
 --

 Key: HBASE-6943
 URL: https://issues.apache.org/jira/browse/HBASE-6943
 Project: HBase
  Issue Type: Bug
Reporter: Mikhail Bautin
 Attachments: D5877.1.patch, D5877.2.patch, D5877.3.patch


 When getting a regionserver connection in 0.89-fb in HBaseClient, we catch 
 all types of Throwable. I have observed a real case when the client looked 
 stuck. On debugging it turned out that a NoSuchMethodError was thrown and 
 caught, leaving the connection in an inconsistent state (initialized socket 
 but null streams). All following attempts resulted in NPEs that were also 
 caught, and no errors were logged. From the user's perspective the client was 
 just stuck. The root cause was the absence of a required jar (hence the 
 NoSuchMethodError) but it was not reported properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-6707:
--

Attachment: testZooKeeperTableArchiveClient-output.txt

I tried with the first hunk applied (and not) on jdk 1.6, same error.
The test output is for the test run without first hunk.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: 6707-v4-addendum.txt, hbase-6707-v0.patch, 
 hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch, 
 hbase-6707-v4-addendum.patch, hbase-6707-v4.patch, 
 testZooKeeperTableArchiveClient-output.txt


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-6946:
-

Component/s: build

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6946) JavaDoc missing from release tarballs

2012-10-04 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469739#comment-13469739
 ] 

Lars Hofhansl commented on HBASE-6946:
--

[~jesse_yates] Mr. Build expert. Any comment? :)

 JavaDoc missing from release tarballs
 -

 Key: HBASE-6946
 URL: https://issues.apache.org/jira/browse/HBASE-6946
 Project: HBase
  Issue Type: Bug
  Components: build
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
 Fix For: 0.94.2

 Attachments: 6946.txt, 6946-v2.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6949) Automatically delete empty directories in CleanerChore

2012-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469740#comment-13469740
 ] 

Hadoop QA commented on HBASE-6949:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12547816/hbase-6949-v1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
81 warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3005//console

This message is automatically generated.

 Automatically delete empty directories in CleanerChore
 --

 Key: HBASE-6949
 URL: https://issues.apache.org/jira/browse/HBASE-6949
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.96.0
Reporter: Jesse Yates
Assignee: Jesse Yates
 Fix For: 0.94.3, 0.96.0

 Attachments: hbase-6949-v0.patch, hbase-6949-v1.patch


 Currently the CleanerChore asks cleaner delegates if both directories and 
 files should be deleted. However, this leads to somewhat odd behavior in some 
 delegates - you don't actually care if the directory hierarchy is preserved, 
 the files; this means you always will delete directories and then implement 
 the logic you actually want for preserving files. Instead we can handle this 
 logic one layer higher in the CleanerChore and let the delegates just worry 
 about preserving files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6952) Clean up some of the Client tests for exceptions.

2012-10-04 Thread Elliott Clark (JIRA)
Elliott Clark created HBASE-6952:


 Summary: Clean up some of the Client tests for exceptions.
 Key: HBASE-6952
 URL: https://issues.apache.org/jira/browse/HBASE-6952
 Project: HBase
  Issue Type: Improvement
Reporter: Elliott Clark
Assignee: Aleksandr Shulman




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-6953) Incorrect javadoc description of HFileOutputFormat regarding multiple column families

2012-10-04 Thread Gabriel Reid (JIRA)
Gabriel Reid created HBASE-6953:
---

 Summary: Incorrect javadoc description of HFileOutputFormat 
regarding multiple column families
 Key: HBASE-6953
 URL: https://issues.apache.org/jira/browse/HBASE-6953
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Reporter: Gabriel Reid
Priority: Minor


The javadoc for HFileOutputFormat states that the class does not support 
writing multiple column families; however, this hasn't been the case since 
HBASE-1861 was resolved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps

2012-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469744#comment-13469744
 ] 

Hadoop QA commented on HBASE-6707:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12547830/testZooKeeperTableArchiveClient-output.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 149 
new or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3007//console

This message is automatically generated.

 TEST 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
  flaps
 

 Key: HBASE-6707
 URL: https://issues.apache.org/jira/browse/HBASE-6707
 Project: HBase
  Issue Type: Bug
  Components: test
Reporter: Sameer Vaishampayan
Assignee: Jesse Yates
Priority: Critical
 Fix For: 0.96.0

 Attachments: 6707-v4-addendum.txt, hbase-6707-v0.patch, 
 hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch, 
 hbase-6707-v4-addendum.patch, hbase-6707-v4.patch, 
 testZooKeeperTableArchiveClient-output.txt


 https://builds.apache.org/job/HBase-TRUNK/3293/
 Error Message
 Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
 Stacktrace
 java.lang.AssertionError: Archived HFiles 
 (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
  should have gotten deleted, but didn't, remaining 
 files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
   at org.junit.Assert.fail(Assert.java:93)
   at org.junit.Assert.assertTrue(Assert.java:43)
   at org.junit.Assert.assertNull(Assert.java:551)
   at 
 org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6953) Incorrect javadoc description of HFileOutputFormat regarding multiple column families

2012-10-04 Thread Gabriel Reid (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gabriel Reid updated HBASE-6953:


Attachment: HBASE-6953.patch

Attached patch removes the incorrect statement about multiple column families, 
as well as providing a pointer to the configureIncrementalLoad convenience 
method (as this is what most users of the class will be interested in).

 Incorrect javadoc description of HFileOutputFormat regarding multiple column 
 families
 -

 Key: HBASE-6953
 URL: https://issues.apache.org/jira/browse/HBASE-6953
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Reporter: Gabriel Reid
Priority: Minor
 Attachments: HBASE-6953.patch


 The javadoc for HFileOutputFormat states that the class does not support 
 writing multiple column families; however, this hasn't been the case since 
 HBASE-1861 was resolved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


  1   2   3   >