date:20171026


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221755#comment-16221755
 ] 

ramkrishna.s.vasudevan commented on HBASE-19092:


bq.You fellows going to make a Builder then for Tags?
But not part of this patch.
bq.The problem is CellUtil and the internal one. PrivateCellUtil works better 
there.
Yes. So I think first let HBASE-18995 go in.
bq.Let TagUtils be for CP. If you have to do Private Tag work, put it in 
PrivateCellUtil. Tags are part of Cells.
Ok sure. 

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221756#comment-16221756
 ] 

Hadoop QA commented on HBASE-18905:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
24s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
53s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
49m 56s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 22s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}166m  8s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18905 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894271/HBASE-18905-addendum.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux dfb43c02ca35 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 660ead0118 |
| Default Java | 1.8.0_141 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9437/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9437/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9437/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Allow CPs to request flush on Region and know the completion of the requested 
> flush
>

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Status: Patch Available  (was: Open)

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch, 
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221753#comment-16221753
 ] 

stack commented on HBASE-18995:
---

Thanks for name change Ram.

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch, 
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Status: Open  (was: Patch Available)

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch, 
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Attachment: HBASE-18995-branch-2.002.patch

Rename the patch file to see if it picks up against branch-2.

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch, 
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221752#comment-16221752
 ] 

stack commented on HBASE-19092:
---

You fellows going to make a Builder then for Tags?

Lets worry about different names for TagUtil later. The problem is CellUtil and 
the internal one. PrivateCellUtil works better there.

Let TagUtils be for CP. If you have to do Private Tag work, put it in 
PrivateCellUtil. Tags are part of Cells.

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221748#comment-16221748
 ] 

Hadoop QA commented on HBASE-18995:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} 
| {color:red} HBASE-18995 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18995 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894281/HBASE-18995-branch-2_2.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9441/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API


[ 
https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221747#comment-16221747
 ] 

stack commented on HBASE-18906:
---

I've not seen that fail before [~anoop.hbase] and it passes locally for me. 
Suggest you commit this and we'll keep an eye on it from here on out.

> Provide Region#waitForFlushes API
> -
>
> Key: HBASE-18906
> URL: https://issues.apache.org/jira/browse/HBASE-18906
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18906.patch, HBASE-18906_V2.patch, 
> HBASE-18906_V2.patch
>
>
> Expose an API for the CPs to wait for all on going flushes in a Region. The 
> API should support taking a time out.
> Background
> While reviewing HBASE-18183, Andy pointed out that Phoenix uses 
> waitForFlushesAndCompactions and/or waitForFlushes for diff reasons.  This 
> issue is to see why they need them and whether alternate ways are possible. 
> This seems to be too much internal stuff and a normal CP hook calling these 
> would be dangerous.
> If there are alternate ways for Phoenix not to use this and not landing in 
> issues (As said by Andy) we should suggest/fix for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g


 [ 
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-13346:
---
  Resolution: Fixed
Hadoop Flags: Reviewed
  Status: Resolved  (was: Patch Available)

Pushed to branch-2+.  Thanks for the nice work and perseverance. Much 
appreciate.  

> Clean up Filter package for post 1.0 s/KeyValue/Cell/g
> --
>
> Key: HBASE-13346
> URL: https://issues.apache.org/jira/browse/HBASE-13346
> Project: HBase
>  Issue Type: Bug
>  Components: API, Filters
>Affects Versions: 2.0.0
>Reporter: Lars George
>Assignee: Tamas Penzes
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-13346.master.001.patch, 
> HBASE-13346.master.002.patch, HBASE-13346.master.003.patch, 
> HBASE-13346.master.003.patch, HBASE-13346.master.004.patch, 
> HBASE-13346.master.005.patch, HBASE-13346.master.006.patch, 
> HBASE-13346.master.007.patch, HBASE-13346.master.008.patch, 
> HBASE-13346.master.009.patch, HBASE-13346.master.010.patch, 
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch, 
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch
>
>
> Since we have a bit of a messy Filter API with KeyValue vs Cell reference 
> mixed up all over the place, I recommend cleaning this up once and for all. 
> There should be no {{KeyValue}} (or {{kv}}, {{kvs}} etc.) in any method or 
> parameter name.
> This includes deprecating and renaming filters too, for example 
> {{FirstKeyOnlyFilter}}, which really should be named {{FirstKeyValueFilter}} 
> as it does _not_ just return the key, but the entire cell. It should be 
> deprecated and renamed to {{FirstCellFilter}} (or {{FirstColumnFilter}} if 
> you prefer).
> In general we should clarify and settle on {{KeyValue}} vs {{Cell}} vs 
> {{Column}} in our naming. The latter two are the only ones going forward with 
> the public API, and are used synonymous. We should carefully check which is 
> better suited (is it really a specific cell, or the newest cell, aka the 
> newest column value) and settle on a naming schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Attachment: HBASE-18995-branch-2_2.patch

Try QA once again against branch-2. The same patch is not applying on master 
cleanly. I think I will commit this to branch-2 then with that reference will 
prepare a patch for master so that it is easy to apply on master. 

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Status: Patch Available  (was: Open)

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g


[ 
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221738#comment-16221738
 ] 

Anoop Sam John commented on HBASE-13346:


+1.  QA  seems fine.

> Clean up Filter package for post 1.0 s/KeyValue/Cell/g
> --
>
> Key: HBASE-13346
> URL: https://issues.apache.org/jira/browse/HBASE-13346
> Project: HBase
>  Issue Type: Bug
>  Components: API, Filters
>Affects Versions: 2.0.0
>Reporter: Lars George
>Assignee: Tamas Penzes
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-13346.master.001.patch, 
> HBASE-13346.master.002.patch, HBASE-13346.master.003.patch, 
> HBASE-13346.master.003.patch, HBASE-13346.master.004.patch, 
> HBASE-13346.master.005.patch, HBASE-13346.master.006.patch, 
> HBASE-13346.master.007.patch, HBASE-13346.master.008.patch, 
> HBASE-13346.master.009.patch, HBASE-13346.master.010.patch, 
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch, 
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch
>
>
> Since we have a bit of a messy Filter API with KeyValue vs Cell reference 
> mixed up all over the place, I recommend cleaning this up once and for all. 
> There should be no {{KeyValue}} (or {{kv}}, {{kvs}} etc.) in any method or 
> parameter name.
> This includes deprecating and renaming filters too, for example 
> {{FirstKeyOnlyFilter}}, which really should be named {{FirstKeyValueFilter}} 
> as it does _not_ just return the key, but the entire cell. It should be 
> deprecated and renamed to {{FirstCellFilter}} (or {{FirstColumnFilter}} if 
> you prefer).
> In general we should clarify and settle on {{KeyValue}} vs {{Cell}} vs 
> {{Column}} in our naming. The latter two are the only ones going forward with 
> the public API, and are used synonymous. We should carefully check which is 
> better suited (is it really a specific cell, or the newest cell, aka the 
> newest column value) and settle on a naming schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18601) Update Htrace to 4.2


[ 
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221737#comment-16221737
 ] 

Hadoop QA commented on HBASE-18601:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 8 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  9m 
 0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  9m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green}  0m  
3s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
23s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
54s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
48m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}298m 36s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
26s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}427m 19s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
|   | hadoop.hbase.client.TestAsyncSnapshotAdminApi |
|   | hadoop.hbase.regionserver.wal.TestSecureWALReplay |
|   | hadoop.hbase.regionserver.TestSplitWalDataLoss |
|   | hadoop.hbase.master.TestTableStateManager |
|   | hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
|   | 
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL
 |
|   | hadoop.hbase.client.TestMvccConsistentScanner |
|

[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


 [ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-18995:
---
Status: Open  (was: Patch Available)

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19096) Add RowMutions batch support in AsyncTable

2017-10-26 Thread Jerry He (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry He updated HBASE-19096:
-
Attachment: (was: HBASE-19096-master.patch)

> Add RowMutions batch support in AsyncTable
> --
>
> Key: HBASE-19096
> URL: https://issues.apache.org/jira/browse/HBASE-19096
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jerry He
>Assignee: Jerry He
> Fix For: 2.0.0
>
> Attachments: HBASE-19096-master.patch
>
>
> Batch support for RowMutations has been added in the Table interface, but is 
> not in AsyncTable. This JIRA will add it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221735#comment-16221735
 ] 

Hudson commented on HBASE-19098:


SUCCESS: Integrated in Jenkins build HBase-1.5 #118 (See 
[https://builds.apache.org/job/HBase-1.5/118/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev 3c62612374eebb913cf7c761a2b4e8c094bfe733)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19096) Add RowMutions batch support in AsyncTable

2017-10-26 Thread Jerry He (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry He updated HBASE-19096:
-
Attachment: HBASE-19096-master.patch

> Add RowMutions batch support in AsyncTable
> --
>
> Key: HBASE-19096
> URL: https://issues.apache.org/jira/browse/HBASE-19096
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Jerry He
>Assignee: Jerry He
> Fix For: 2.0.0
>
> Attachments: HBASE-19096-master.patch, HBASE-19096-master.patch
>
>
> Batch support for RowMutations has been added in the Table interface, but is 
> not in AsyncTable. This JIRA will add it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18925) Need updated mockito for using java optional


[ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221732#comment-16221732
 ] 

Hadoop QA commented on HBASE-18925:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 56 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m  
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  5m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  7m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 19m 
 1s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  7m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
17s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
10s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
51m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  9m 19s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 10s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestHTableMultiplexerViaMocks |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18925 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894076/HBASE-18925.master.005.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  shadedjars  hadoopcheck  
xml  compile  findbugs  hbaseanti  checkstyle  |
| uname | Linux 5fcab86ce0d9 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 
18:04:35 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 660ead0118 |
| Default Java | 1.8.0_141 |
| unit |

[jira] [Updated] (HBASE-19076) Ensure findbugs jsr305 jar isn't present in hbase-error-prone module

2017-10-26 Thread Qilin Cao (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qilin Cao updated HBASE-19076:
--
Priority: Major  (was: Blocker)

> Ensure findbugs jsr305 jar isn't present in hbase-error-prone module
> 
>
> Key: HBASE-19076
> URL: https://issues.apache.org/jira/browse/HBASE-19076
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
> Attachments: HBASE-19076.patch
>
>
> After HBASE-16321 ensure findbugs jsr305 jar isn't present, we have failures 
> with the hbase-error-prone module.
> {code}
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce 
> (min-maven-min-java-banned-xerces) @ hbase-error-prone ---
> [INFO] 
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (banned-jsr305) @ 
> hbase-error-prone ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed 
> with message:
> We don't allow the JSR305 jar from the Findbugs project, see HBASE-16321.
> Found Banned Dependency: com.google.code.findbugs:jsr305:jar:1.3.9
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18906) Provide Region#waitForFlushes API


[ 
https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221721#comment-16221721
 ] 

Anoop Sam John commented on HBASE-18906:


bq.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver
Seems not related to this.  Any way related to the Maste CP clean up jira? 
[~stack]?

> Provide Region#waitForFlushes API
> -
>
> Key: HBASE-18906
> URL: https://issues.apache.org/jira/browse/HBASE-18906
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18906.patch, HBASE-18906_V2.patch, 
> HBASE-18906_V2.patch
>
>
> Expose an API for the CPs to wait for all on going flushes in a Region. The 
> API should support taking a time out.
> Background
> While reviewing HBASE-18183, Andy pointed out that Phoenix uses 
> waitForFlushesAndCompactions and/or waitForFlushes for diff reasons.  This 
> issue is to see why they need them and whether alternate ways are possible. 
> This seems to be too much internal stuff and a normal CP hook calling these 
> would be dangerous.
> If there are alternate ways for Phoenix not to use this and not landing in 
> issues (As said by Andy) we should suggest/fix for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221720#comment-16221720
 ] 

Hudson commented on HBASE-18905:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3952 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3952/])
HBASE-18905 (addendum) Ignore broken test TestFlushLifeCycleTracker. (appy: rev 
660ead0118ecce83667a21420285caade2acec2c)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushLifeCycleTracker.java


> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-addendum.patch, HBASE-18905-v1.patch, 
> HBASE-18905.patch, HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221715#comment-16221715
 ] 

ramkrishna.s.vasudevan commented on HBASE-18995:


bq.Also, let's commit this to both master and branch-2? Reason being, removing 
all this stuff now will make backports hard. Let's remove them after 2.0 
release. 
We may need another Util class just for CP and that is where the Tag related 
things may come in.
So I think it is better we push this in first as is and then work on that other 
tasks to create CPCellUtil. And regarding the commit I think we will commit now 
to branch-2 and master as is and later work on removing the deprecated methods. 
File a blocker against 3.0 and work with that JIRA?

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221712#comment-16221712
 ] 

ramkrishna.s.vasudevan commented on HBASE-18995:


[~appy] and [~saint@gmail.com]
Thanks for your comments on RB. I have replied to most of your comments. Let me 
know what you think. Patch wise nothing much to change except for renaming to 
InternalCellUtil to privateCellUtil. I am fine with any of these two names. I 
first named it as PrivatecellUtil but since already @PRivate tag was there I 
thought InternalCellUtil is better. 

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221698#comment-16221698
 ] 

ramkrishna.s.vasudevan commented on HBASE-19092:


bq.We now have CellUtil (public), InternalCellUtil(private) and then there will 
be CellUtil (LP)
But for TagUtil, the names are: TagUtil (being made LP), and if decide to do 
its cleanup in future or make things public, 
.PublicTagUtil/PrivateTagUtil?(sigh)
This is my worry now. There is an argument that TagUtil is for specific tags 
and any Cell related API to work on Tags should be in CellUtil. I thought we 
can make it unified. Other thing is if we expose Tags to CP we need to provide 
CP exposed TagUtils and internal TagUtils. 

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221697#comment-16221697
 ] 

ramkrishna.s.vasudevan commented on HBASE-19092:


Yes. Once we start exposing Tags for CPs we need to provide builders for them 
to use becuase we have two version of Tags now.
So more or less Tag creatin and tag iteration are the ones that you need. And I 
think you also need API to work on indiviudual tags when it is being read? 
Thanks [~vrushalic].

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19100) Missing break in catch block of InterruptedException in HRegion#waitForFlushesAndCompactions


[ 
https://issues.apache.org/jira/browse/HBASE-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221691#comment-16221691
 ] 

Hadoop QA commented on HBASE-19100:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m  
5s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue}  0m  
2s{color} | {color:blue} The patch file was not named according to hbase's 
naming conventions. Please see 
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for 
instructions. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
47s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
46m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}128m 27s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 52s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19100 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894214/19100.v1.txt |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 42eece271785 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 
18:04:35 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 660ead0118 |
| Default Java | 1.8.0_141 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9435/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results |

[jira] [Commented] (HBASE-19102) TestZooKeeperMainServer fails with KeeperException$ConnectionLossException


[ 
https://issues.apache.org/jira/browse/HBASE-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221686#comment-16221686
 ] 

stack commented on HBASE-19102:
---

.001 simple wait in zk main constructor.

> TestZooKeeperMainServer fails with KeeperException$ConnectionLossException
> --
>
> Key: HBASE-19102
> URL: https://issues.apache.org/jira/browse/HBASE-19102
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: HBASE-19102.master.001.patch
>
>
> I'm trying to run test suite on a local machine. I never get to the second 
> part because I fail on below test with below exception near every time (and 
> an ipv6 test... will do that next).  
> 1 
> ---
>   2 Test set: org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
>   3 
> ---
>   4 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.161 s 
> <<< FAILURE! - in org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
>   5 
> testCommandLineWorks(org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer)
>   Time elapsed: 15.848 s  <<< ERROR!
>   6 org.apache.zookeeper.KeeperException$ConnectionLossException: 
> KeeperErrorCode = ConnectionLoss for /testCommandLineWorks
>   7   at 
> org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer.testCommandLineWorks(TestZooKeeperMainServer.java:81)
> Looks like running the command before we are connected causes the above -- we 
> pause 15 seconds and then throw the above.   If I wait until connected before 
> proceding, stuff seems to work reliably. I don't have access to the watcher 
> on connections since we override the zk main class... so this seems only 
> avenue available at mo (This zk main thing is all a hack around zk main 
> because it had bugs ... but I think we have to keep the hack because folks 
> use different versions of zk. My $workplace defaults to something that is 
> years old, 3.4.5 for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19102) TestZooKeeperMainServer fails with KeeperException$ConnectionLossException


 [ 
https://issues.apache.org/jira/browse/HBASE-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-19102:
--
Attachment: HBASE-19102.master.001.patch

> TestZooKeeperMainServer fails with KeeperException$ConnectionLossException
> --
>
> Key: HBASE-19102
> URL: https://issues.apache.org/jira/browse/HBASE-19102
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: HBASE-19102.master.001.patch
>
>
> I'm trying to run test suite on a local machine. I never get to the second 
> part because I fail on below test with below exception near every time (and 
> an ipv6 test... will do that next).  
> 1 
> ---
>   2 Test set: org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
>   3 
> ---
>   4 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.161 s 
> <<< FAILURE! - in org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
>   5 
> testCommandLineWorks(org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer)
>   Time elapsed: 15.848 s  <<< ERROR!
>   6 org.apache.zookeeper.KeeperException$ConnectionLossException: 
> KeeperErrorCode = ConnectionLoss for /testCommandLineWorks
>   7   at 
> org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer.testCommandLineWorks(TestZooKeeperMainServer.java:81)
> Looks like running the command before we are connected causes the above -- we 
> pause 15 seconds and then throw the above.   If I wait until connected before 
> proceding, stuff seems to work reliably. I don't have access to the watcher 
> on connections since we override the zk main class... so this seems only 
> avenue available at mo (This zk main thing is all a hack around zk main 
> because it had bugs ... but I think we have to keep the hack because folks 
> use different versions of zk. My $workplace defaults to something that is 
> years old, 3.4.5 for instance).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction


[ 
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221684#comment-16221684
 ] 

Duo Zhang commented on HBASE-19095:
---

One way is to not drop cells when doing in memory compaction.

But think of the example in HBASE-19033, if we could do the same aggregating 
thing when doing in memory compaction, then we could keep the counter in memory 
for ever and greatly increase the performance.

So I think it worth to add the CP hooks support.

Thanks.

> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
>
> This is a hole in our CP hooks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19102) TestZooKeeperMainServer fails with KeeperException$ConnectionLossException

stack created HBASE-19102:
-

Summary: TestZooKeeperMainServer fails with
KeeperException$ConnectionLossException
Key: HBASE-19102
URL: https://issues.apache.org/jira/browse/HBASE-19102
Project: HBase
Issue Type: Bug
Reporter: stack

I'm trying to run test suite on a local machine. I never get to the second part
because I fail on below test with below exception near every time (and an ipv6
test... will do that next).

1
---
2 Test set: org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
3
---
4 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.161 s
<<< FAILURE! - in org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer
5
testCommandLineWorks(org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer)
Time elapsed: 15.848 s <<< ERROR!
6 org.apache.zookeeper.KeeperException$ConnectionLossException:
KeeperErrorCode = ConnectionLoss for /testCommandLineWorks
7 at
org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer.testCommandLineWorks(TestZooKeeperMainServer.java:81)

Looks like running the command before we are connected causes the above -- we
pause 15 seconds and then throw the above. If I wait until connected before
proceding, stuff seems to work reliably. I don't have access to the watcher on
connections since we override the zk main class... so this seems only avenue
available at mo (This zk main thing is all a hack around zk main because it had
bugs ... but I think we have to keep the hack because folks use different
versions of zk. My $workplace defaults to something that is years old, 3.4.5
for instance).

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner


 [ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19033:
--
Attachment: HBASE-19033.patch

> Allow CP users to change versions and TTL before opening StoreScanner
> -
>
> Key: HBASE-19033
> URL: https://issues.apache.org/jira/browse/HBASE-19033
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner


 [ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19033:
--
Attachment: (was: HBASE-19033.patch)

> Allow CP users to change versions and TTL before opening StoreScanner
> -
>
> Key: HBASE-19033
> URL: https://issues.apache.org/jira/browse/HBASE-19033
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner


 [ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19033:
--
Attachment: HBASE-19033.patch

It took me sometime to fix the CP hooks. Really need the HLC to solve the 
timestamp conflicts problem...

> Allow CP users to change versions and TTL before opening StoreScanner
> -
>
> Key: HBASE-19033
> URL: https://issues.apache.org/jira/browse/HBASE-19033
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner


 [ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-19033:
--
Attachment: (was: HBASE-19033.patch)

> Allow CP users to change versions and TTL before opening StoreScanner
> -
>
> Key: HBASE-19033
> URL: https://issues.apache.org/jira/browse/HBASE-19033
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221663#comment-16221663
 ] 

Duo Zhang commented on HBASE-18905:
---

Let's wait for a pre commit result since the test is disabled for now so no 
hurt :)

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-addendum.patch, HBASE-18905-v1.patch, 
> HBASE-18905.patch, HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221657#comment-16221657
 ] 

Hudson commented on HBASE-19098:


SUCCESS: Integrated in Jenkins build HBase-1.4 #975 (See 
[https://builds.apache.org/job/HBase-1.4/975/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev 50b7037e771a03ded29d574647a8750ad0f4e467)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19091) Code annotation wrote "BinaryComparator" instead of "LongComparator"


[ 
https://issues.apache.org/jira/browse/HBASE-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221650#comment-16221650
 ] 

Hudson commented on HBASE-19091:


SUCCESS: Integrated in Jenkins build HBase-2.0 #751 (See 
[https://builds.apache.org/job/HBase-2.0/751/])
HBASE-19091 Code annotation wrote BinaryComparator instead of (jan.hentschel: 
rev 9a5ab58bc18ed153243d3f67de1a3d657558f7a1)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java


> Code annotation wrote "BinaryComparator" instead of "LongComparator"
> 
>
> Key: HBASE-19091
> URL: https://issues.apache.org/jira/browse/HBASE-19091
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-19091-v1.patch
>
>
> LongComparator class code annotation wrote "BinaryComparator" instead of 
> "LongComparator"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221652#comment-16221652
 ] 

stack commented on HBASE-18905:
---

+1 Just commit I'd say if the test passes now. It was failing for me previous 
to this and with this patch it passes now. Thanks [~Apache9]

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-addendum.patch, HBASE-18905-v1.patch, 
> HBASE-18905.patch, HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221651#comment-16221651
 ] 

Hudson commented on HBASE-19098:


SUCCESS: Integrated in Jenkins build HBase-2.0 #751 (See 
[https://builds.apache.org/job/HBase-2.0/751/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev e1152afdd45dc300da691dcb38a89f059b7d06de)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case


[ 
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221641#comment-16221641
 ] 

Hadoop QA commented on HBASE-18770:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
55s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
33s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
49m 28s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 36s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 28s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncTableNoncedRetry |
|   | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
|   | hadoop.hbase.client.TestFromClientSide |
|   | hadoop.hbase.client.TestAsyncTableBatch |
|   | hadoop.hbase.mob.compactions.TestMobCompactor |
|   | hadoop.hbase.coprocessor.TestMasterObserver |
|   | hadoop.hbase.regionserver.TestHRegion |
|   | hadoop.hbase.client.TestAppendFromClientSide |
|   | hadoop.hbase.regionserver.TestRegionServerReadRequestMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18770 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894234/HBASE-18770.master.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 8f88ffb34351 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 
11:05:26 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 660ead0118 |
| Default Java | 1.8.0_141 |
| unit |

[jira] [Commented] (HBASE-18925) Need updated mockito for using java optional


[ 
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221639#comment-16221639
 ] 

Hadoop QA commented on HBASE-18925:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 56 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  8m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  6m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 16m 
28s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  5m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  8m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m 
18s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
31s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
55m 28s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  5m 
45s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m 52s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}137m 56s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestHTableMultiplexerViaMocks |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18925 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894076/HBASE-18925.master.005.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  shadedjars  hadoopcheck  
xml  compile  findbugs  hbaseanti  checkstyle  |
| uname | Linux 2f62fdae319b 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 
18:04:35 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 660ead0118 |
| Default Java | 1.8.0_141 |
| unit |

[jira] [Updated] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


 [ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18905:
--
Attachment: HBASE-18905-addendum.patch

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-addendum.patch, HBASE-18905-v1.patch, 
> HBASE-18905.patch, HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


 [ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-18905:
--
Status: Patch Available  (was: Reopened)

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-addendum.patch, HBASE-18905-v1.patch, 
> HBASE-18905.patch, HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.

2017-10-26 Thread Zheng Hu (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Hu updated HBASE-18993:
-
Attachment: HBASE-18993-branch-1.4.v1.patch

> Backport patches in HBASE-18410 to branch-1.x branches.
> ---
>
> Key: HBASE-18993
> URL: https://issues.apache.org/jira/browse/HBASE-18993
> Project: HBase
>  Issue Type: Bug
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18993-branch-1.1.v1.patch, 
> HBASE-18993-branch-1.2.v1.patch, HBASE-18993-branch-1.3.v1.patch, 
> HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, 
> HBASE-18993-branch-1.4.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.

2017-10-26 Thread Zheng Hu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221625#comment-16221625
 ] 

Zheng Hu commented on HBASE-18993:
--

The Hadoop QA seems be aborted 
(https://builds.apache.org/job/PreCommit-HBASE-Build/9408/),  Let's trigger 
again.  

> Backport patches in HBASE-18410 to branch-1.x branches.
> ---
>
> Key: HBASE-18993
> URL: https://issues.apache.org/jira/browse/HBASE-18993
> Project: HBase
>  Issue Type: Bug
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18993-branch-1.1.v1.patch, 
> HBASE-18993-branch-1.2.v1.patch, HBASE-18993-branch-1.3.v1.patch, 
> HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-13346) Clean up Filter package for post 1.0 s/KeyValue/Cell/g


[ 
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221623#comment-16221623
 ] 

Hadoop QA commented on HBASE-13346:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  4m 
33s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 18 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
 3s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 9s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
43m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
30s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m  
0s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 
21s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
20s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
57s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 24s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-13346 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894228/HBASE-13346.master.011.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 36b3dc0ddc04 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |

[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.

2017-10-26 Thread Zheng Hu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221617#comment-16221617
 ] 

Zheng Hu commented on HBASE-18993:
--

bq.  The first one, the potential for a downstream user's filter to get a 
NoSuchMethodError on super. invocation. What do you think? 

Actually,   The FilterList extend FilterBase,  and the FilterBase extend Filter 
now,   the previous version is :  FilterList extend Filter.   so all the 
methods  and fields in Filter  can be accessed by FilterBase,  also the 
FilterList.  I think it should not throw NoSuchMethodError exception. 



> Backport patches in HBASE-18410 to branch-1.x branches.
> ---
>
> Key: HBASE-18993
> URL: https://issues.apache.org/jira/browse/HBASE-18993
> Project: HBase
>  Issue Type: Bug
>  Components: Filters
>Reporter: Zheng Hu
>Assignee: Zheng Hu
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-18993-branch-1.1.v1.patch, 
> HBASE-18993-branch-1.2.v1.patch, HBASE-18993-branch-1.3.v1.patch, 
> HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-18610) Provide capability to activate chaos monkey

2017-10-26 Thread Ted Yu (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-18610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-18610:
---
Labels: fault-tolerance  (was: )

> Provide capability to activate chaos monkey
> ---
>
> Key: HBASE-18610
> URL: https://issues.apache.org/jira/browse/HBASE-18610
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>  Labels: fault-tolerance
> Attachments: 18610.v1.txt, 18610.v4.txt, 18610.v5.txt, 18610.v6.txt, 
> 18610.v7.txt, 18610.v8.txt, 18610.v9.txt
>
>
> Currently load-client runs against a cluster where region servers are stable.
> We need to introduce chaos monkey so that wider coverage for read path is 
> exercised.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper


[ 
https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221572#comment-16221572
 ] 

Anoop Sam John commented on HBASE-19047:


bq.Are we trying to hide Shipper functionality from CPs?
Yes. As Stack said.
The again assign what is returned from post hook.  This is just an over 
preventive mechanism. As per a comment fix from Duo.
" The core scanner being passed to hook is just closed and created a new using 
Region#getScanner call and that is been returned"  There is no need to do 
this way... Dont think any one will do this.Doing this below instance of 
check and assign to shipper make no harm for sure.Even if we dont do this 
shipped() call at all, there wont be functional issue. Only thing is the return 
back of blocks to BC will be delayed unless the scan is over and closed.  So we 
can even avoid this extra check and assign after post hook also.   What do u 
say [~appy], [~Apache9], [~stack]?

bq.try (RegionScannerImpl scanner = (RegionScannerImpl) REGION.getScanner(new 
Scan()))
Hmm ya.. Let me see the getScanner usages and avoid the redundant casting. Tks.

> CP exposed Scanner types should not extend Shipper
> --
>
> Key: HBASE-19047
> URL: https://issues.apache.org/jira/browse/HBASE-19047
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19047.patch, HBASE-19047_V2.patch, 
> HBASE-19047_V2.patch, HBASE-19047_V3.patch, HBASE-19047_V4.patch, 
> HBASE-19047_V4.patch, HBASE-19047_V4.patch
>
>
> Shipper is a IA.Private interface and very much internal.. 
> Right now CP exposed RegionScanner is extending this and so exposing the 
> shipped() method. This by mistake is called, can harm the correctness of the 
> cells in the Results.
> preScannerOpen() allowing to return a new Scanner is also problematic now.  
> This can allow users to create a Region scanner from Region and then wrap it 
> and return back (Well same can be done by postScannerOpen also), it can so 
> happen that the wrapper is not implementing the shipped() properly.  In any 
> way exposing the shipped () is problematic.
> Solution Steps
> 1. Remove preScannerOpen() , the use case I can think of is wrapping the 
> original scanner. The original scanner can be created by Region.getScanner 
> way only..  May be no need to remove this hook.  Just remove the ability for 
> it to return a RegionScanner instance.  Call this with the Scan object and 
> the CP can change the Scan object if they want.
> 2. Let RegionScanner not extending Shipper but only RegionScannerImpl 
> implements this
> 3. We have ref to the RegionScanner created by core and let that be used by 
> RegionScannerShippedCallBack when the post hook doing a wrap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19033) Allow CP users to change versions and TTL before opening StoreScanner


[ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221573#comment-16221573
 ] 

Duo Zhang commented on HBASE-19033:
---

{quote}
Can scan type be incorporated into scan info? We don't have scan type on flush? 
Only on compact? Thanks Duo.
{quote}
ScanInfo is immutable, and without a CP hook it will never be changed. But 
ScanType can be changed for different scans. And yes, only compact has a 
ScanType parameter, for flush, it is always COMPACT_RETAIN_DELETES, so do not 
need to mention it explicitly.

And for [~anoopsamjohn], for now I can only confirm that changing max versions 
and TTL is safe so I just provide these options in ScanOptions. Other options 
seem to be useless, or dangerous. As long as we all not sure about the safety 
of other options, let's keep the minimum set. Can add more options later I 
think?

And for [~elserj], I think equals and hashCode are not necessary, just letting 
the object identical is fine. Let me add a toString method.

Thanks all for the reviewing.

> Allow CP users to change versions and TTL before opening StoreScanner
> -
>
> Key: HBASE-19033
> URL: https://issues.apache.org/jira/browse/HBASE-19033
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221564#comment-16221564
 ] 

Anoop Sam John commented on HBASE-19092:


Tag was just a class in 0.98 and even in 1.x also I think.   
So that means we need to provide a TagBuilder (Like Cell Builder) so that Tag 
instances can be created.  Thanks for the details [~vrushalic]. Very useful.

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


 [ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang reopened HBASE-18905:
---

TestFlushLifeCycleTracker is broken.

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-v1.patch, HBASE-18905.patch, 
> HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19089) Fix the list of included moduleSets in src and binary tars

2017-10-26 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221551#comment-16221551
 ] 

Sean Busbey commented on HBASE-19089:
-

{quote}
Sean Busbey Are you referring to these tests: 
https://builds.apache.org/job/HBase%20Nightly/? But they are already red.
So far, i have been testing by running steps 3 and 4 of Making a release 
candidate and checking the contents of tarball.
{quote}

Yes. the nightly test there includes an automated test that the source tarball 
can be created and that what it makes can generate a binary.

Currently, that test is just in the Jenkinsfile, which means you need to push a 
branch to try out changes. If you'd prefer to avoid doing that, file a JIRA 
about moving the test into a script and I'll get it done.

> Fix the list of included moduleSets in src and binary tars
> --
>
> Key: HBASE-19089
> URL: https://issues.apache.org/jira/browse/HBASE-19089
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-19089.master.001.patch
>
>
> List of moduleSets included in src.xml and hadoop-two-compat.xml differ quite 
> a lot. Particularly, hadoop-two-compat.xml is missing quite a few modules.
> The core issue is duplication involved in  list. Let me try to get 
> rid of it by using a shared list and including it using 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


[ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221550#comment-16221550
 ] 

Andrew Purtell commented on HBASE-19099:


bq. I'd like to see these restored. should I make a subtask to do it, or just a 
related jira?

Or a patch here would work too.


> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> The below all relate to source level compatibility. Recompilation of a client 
> program may be terminated with the message "class C is not abstract and does 
> not override abstract method M in TYPE". According to our compatibility 
> guidelines we are allowed to add methods to interfaces, so these are ALLOWED. 
>  Please let me know if you disagree.
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterObserver 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext ) has been added to this 
> interface. 
> * Abstract method preMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method preMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method preMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method preRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface

[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1

2017-10-26 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221548#comment-16221548
 ] 

Sean Busbey commented on HBASE-19099:
-

bq. I'd like to see these restored. should I make a subtask to do it, or just a 
related jira?

Or as a proposed patch on this jira?

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> The below all relate to source level compatibility. Recompilation of a client 
> program may be terminated with the message "class C is not abstract and does 
> not override abstract method M in TYPE". According to our compatibility 
> guidelines we are allowed to add methods to interfaces, so these are ALLOWED. 
>  Please let me know if you disagree.
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterObserver 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext ) has been added to this 
> interface. 
> * Abstract method preMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method preMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method preMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method preRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface

[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1

2017-10-26 Thread Sean Busbey (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221547#comment-16221547
 ] 

Sean Busbey commented on HBASE-19099:
-

Do you happen to know if these already have release notes on the issues that 
introduced them? If not (or if we don't want to chase down the sources of the 
changes) how about just calling out the same text you have here in a release 
note on this issue?

{quote}
Two constants were removed from Public class TableInputFormatBase. I think 
these are internal implementation details and so removal is probably ok, but we 
could put them back if need be.
package org.apache.hadoop.hbase.mapreduce
class TableInputFormatBase

Removed fields
* INPUT_AUTOBALANCE_MAXSKEWRATIO
* TABLE_ROW_TEXTKEY
{quote}

I'd like to see these restored. should I make a subtask to do it, or just a 
related jira?

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> The below all relate to source level compatibility. Recompilation of a client 
> program may be terminated with the message "class C is not abstract and does 
> not override abstract method M in TYPE". According to our compatibility 
> guidelines we are allowed to add methods to interfaces, so these are ALLOWED. 
>  Please let me know if you disagree.
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterObserver 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext )

[jira] [Updated] (HBASE-12081) Considering Java 9

2017-10-26 Thread Mike Drob (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob updated HBASE-12081:
--
Fix Version/s: (was: 2.0.0)
   2.1.0

> Considering Java 9
> --
>
> Key: HBASE-12081
> URL: https://issues.apache.org/jira/browse/HBASE-12081
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 1.4.0, 2.1.0, 1.5.0
>
>
> Java 9 will ship in 2016. This will be the first Java release that makes a 
> significant compatibility departure from earlier runtimes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19091) Code annotation wrote "BinaryComparator" instead of "LongComparator"


[ 
https://issues.apache.org/jira/browse/HBASE-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221521#comment-16221521
 ] 

Hudson commented on HBASE-19091:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3951 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3951/])
HBASE-19091 Code annotation wrote BinaryComparator instead of (jan.hentschel: 
rev 459202bab096377a3a85d7525e3738b40d6ac718)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java


> Code annotation wrote "BinaryComparator" instead of "LongComparator"
> 
>
> Key: HBASE-19091
> URL: https://issues.apache.org/jira/browse/HBASE-19091
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-19091-v1.patch
>
>
> LongComparator class code annotation wrote "BinaryComparator" instead of 
> "LongComparator"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221522#comment-16221522
 ] 

Hudson commented on HBASE-19098:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3951 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3951/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev 60aa1c228a12550fe0ada873a0989323d5beab27)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19100) Missing break in catch block of InterruptedException in HRegion#waitForFlushesAndCompactions


[ 
https://issues.apache.org/jira/browse/HBASE-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221515#comment-16221515
 ] 

Hadoop QA commented on HBASE-19100:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue}  0m  
1s{color} | {color:blue} The patch file was not named according to hbase's 
naming conventions. Please see 
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for 
instructions. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
51s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
38s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
47m  9s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}100m 43s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}167m 34s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19100 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894214/19100.v1.txt |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 4c140cbbf9a7 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 60aa1c228a |
| Default Java | 1.8.0_141 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9429/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results |

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

The below all relate to source level compatibility. Recompilation of a client 
program may be terminated with the message "class C is not abstract and does 
not override abstract method M in TYPE". According to our compatibility 
guidelines we are allowed to add methods to interfaces, so these are ALLOWED.  
Please let me know if you disagree.

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

* Abstract

[jira] [Commented] (HBASE-19089) Fix the list of included moduleSets in src and binary tars


[ 
https://issues.apache.org/jira/browse/HBASE-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221504#comment-16221504
 ] 

Appy commented on HBASE-19089:
--

Manual testing so far:

Sources tarball
{noformat}
$ mvn  install -DskipTests assembly:single 
-Dassembly.file=hbase-assembly/src/main/assembly/src.xml -Prelease
...
...
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → pwd
/Users/appy/apache/hbase/hbase-assembly/target
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → tar -xzf  
hbase-3.0.0-SNAPSHOT-src.tar.gz
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → ls 
hbase-3.0.0-SNAPSHOT/
CHANGES.txt   conf  hbase-backup  
hbase-common  hbase-hadoop2-compat  hbase-metrics-api 
hbase-replication hbase-shaded  hbase-thrift
LICENSE.txt   dev-support   hbase-build-configuration 
hbase-endpointhbase-httphbase-prefix-tree 
hbase-resource-bundle hbase-shell   pom.xml
NOTICE.txthbase-annotations hbase-build-support   
hbase-exampleshbase-it  hbase-procedure   
hbase-resthbase-spark   src
README.txthbase-archetypes  hbase-checkstyle  
hbase-external-blockcache hbase-mapreduce   hbase-protocol
hbase-rsgroup hbase-spark-it
bin   hbase-assemblyhbase-client  
hbase-hadoop-compat   hbase-metrics hbase-protocol-shaded 
hbase-server  hbase-testing-util
{noformat}

Binary tarball
{noformat}
appy appy-MBP-3 ~/apache/hbase (assembly) → mvn install -DskipTests -Prelease
...
** Notice that i didn't run site since it takes long time**
appy appy-MBP-3 ~/apache/hbase (assembly) → mvn install -DskipTests 
assembly:single -Prelease -T 4
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → tar -zxf 
hbase-3.0.0-SNAPSHOT-bin.tar.gz
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → ls 
hbase-3.0.0-SNAPSHOT/
CHANGES.txt   LEGAL LICENSE.txt   NOTICE.txtREADME.txtbin   
conf  hbase-webapps lib
appy appy-MBP-3 ~/apache/hbase/hbase-assembly/target (assembly) → ls 
hbase-3.0.0-SNAPSHOT/lib/
aopalliance-1.0.jar
hadoop-mapreduce-client-hs-2.7.1.jar   
hbase-shaded-netty-1.0.1.jar   jersey-server-2.25.1.jar
aopalliance-repackaged-2.5.0-b32.jar   
hadoop-mapreduce-client-jobclient-2.7.1.jar
hbase-shaded-protobuf-1.0.1.jarjets3t-0.9.0.jar
apacheds-i18n-2.0.0-M15.jar
hadoop-mapreduce-client-shuffle-2.7.1.jar  
hbase-shell-3.0.0-SNAPSHOT.jar jettison-1.3.8.jar
apacheds-kerberos-codec-2.0.0-M15.jar  
hadoop-minicluster-2.7.1.jar   
hbase-spark-3.0.0-SNAPSHOT.jar jetty-6.1.26.jar
api-asn1-api-1.0.0-M20.jar 
hadoop-yarn-api-2.7.1.jar  
hbase-spark-it-3.0.0-SNAPSHOT.jar  
jetty-http-9.4.6.v20170531.jar
api-util-1.0.0-M20.jar 
hadoop-yarn-client-2.7.1.jar   
hbase-testing-util-3.0.0-SNAPSHOT.jar  
jetty-io-9.4.6.v20170531.jar
asm-3.1.jar
hadoop-yarn-common-2.7.1.jar   
hbase-thrift-3.0.0-SNAPSHOT.jar
jetty-jmx-9.4.6.v20170531.jar
audience-annotations-0.5.0.jar 
hadoop-yarn-server-applicationhistoryservice-2.7.1.jar hk2-api-2.5.0-b32.jar
  jetty-jsp-9.2.19.v20160908.jar
avro-1.7.7.jar 
hadoop-yarn-server-common-2.7.1.jar
hk2-locator-2.5.0-b32.jar  jetty-schemas-3.1.M0.jar
commons-beanutils-core-1.8.0.jar   
hadoop-yarn-server-nodemanager-2.7.1.jar   hk2-utils-2.5.0-b32.jar  
  jetty-security-9.4.6.v20170531.jar
commons-cli-1.4.jar
hadoop-yarn-server-resourcemanager-2.7.1.jar   
htrace-core-3.2.0-incubating.jar   
jetty-server-9.4.6.v20170531.jar
commons-codec-1.10.jar 
hadoop-yarn-server-tests-2.7.1-tests.jar   httpclient-4.5.3.jar 
  jetty-servlet-9.4.6.v20170531.jar
commons-collections-3.2.1.jar  
hadoop-yarn-server-web-proxy-2.7.1.jar httpcore-4.4.6.jar   
  jetty-util-6.1.26.jar

[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case


[ 
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221503#comment-16221503
 ] 

Andrew Purtell commented on HBASE-18770:


bq. (Sorry Andrew Purtell – I didn't have the courage to do the grand sweeping 
change.. I'm a wuss).

Eh, oh well, it's still an improvement.

> Remove bypass method in ObserverContext and implement the 'bypass' logic case 
> by case
> -
>
> Key: HBASE-18770
> URL: https://issues.apache.org/jira/browse/HBASE-18770
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18770.master.001.patch, 
> HBASE-18770.master.002.patch
>
>
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-16417) In-Memory MemStore Policy for Flattening and Compactions


[ 
https://issues.apache.org/jira/browse/HBASE-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221499#comment-16221499
 ] 

Hadoop QA commented on HBASE-16417:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 6 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
18s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 4s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
51m 30s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
44s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}139m 40s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
53s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}224m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-16417 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894203/HBASE-16417.13.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux a981321d8fe1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 459202bab0 |
| Default Java | 1.8.0_141

[jira] [Commented] (HBASE-19091) Code annotation wrote "BinaryComparator" instead of "LongComparator"


[ 
https://issues.apache.org/jira/browse/HBASE-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221497#comment-16221497
 ] 

Hudson commented on HBASE-19091:


FAILURE: Integrated in Jenkins build HBase-1.5 #117 (See 
[https://builds.apache.org/job/HBase-1.5/117/])
HBASE-19091 Code annotation wrote BinaryComparator instead of (jan.hentschel: 
rev 5376b5b1282968618285c69172f40eabe9f7fe14)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java


> Code annotation wrote "BinaryComparator" instead of "LongComparator"
> 
>
> Key: HBASE-19091
> URL: https://issues.apache.org/jira/browse/HBASE-19091
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-19091-v1.patch
>
>
> LongComparator class code annotation wrote "BinaryComparator" instead of 
> "LongComparator"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19091) Code annotation wrote "BinaryComparator" instead of "LongComparator"


[ 
https://issues.apache.org/jira/browse/HBASE-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221494#comment-16221494
 ] 

Hudson commented on HBASE-19091:


SUCCESS: Integrated in Jenkins build HBase-1.4 #974 (See 
[https://builds.apache.org/job/HBase-1.4/974/])
HBASE-19091 Code annotation wrote BinaryComparator instead of (jan.hentschel: 
rev f6a8d573734c8834b86a3eb904f5fe64ec546323)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/LongComparator.java


> Code annotation wrote "BinaryComparator" instead of "LongComparator"
> 
>
> Key: HBASE-19091
> URL: https://issues.apache.org/jira/browse/HBASE-19091
> Project: HBase
>  Issue Type: Improvement
>  Components: Client
>Affects Versions: 3.0.0
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-19091-v1.patch
>
>
> LongComparator class code annotation wrote "BinaryComparator" instead of 
> "LongComparator"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (HBASE-19101) yetus precommit is not find hanging tests

Appy created HBASE-19101:


 Summary: yetus precommit is not find hanging tests
 Key: HBASE-19101
 URL: https://issues.apache.org/jira/browse/HBASE-19101
 Project: HBase
  Issue Type: Bug
Reporter: Appy


Examples of failed QA runs with  "-1 unit" but no list of tests:
- 
https://issues.apache.org/jira/browse/HBASE-18925?focusedCommentId=16218515=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16218515
- 
https://issues.apache.org/jira/browse/HBASE-18905?focusedCommentId=16216763=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16216763

Can use findHangingTests.py to find hanging tests and report them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

The below all relate to source level compatibility. Recompilation of a client 
program may be terminated with the message "client class C is not abstract and 
does not override abstract method M in TYPE". According to our compatibility 
guidelines we are allowed to add methods to interfaces, so these are ALLOWED.  
Please let me know if you disagree.

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

*

[jira] [Comment Edited] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


[ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221480#comment-16221480
 ] 

Andrew Purtell edited comment on HBASE-19099 at 10/27/17 12:05 AM:
---

Please review. After a few days if no comment or no negative feedback I will 
close this as Fixed as agreed to by lazy consensus.

[~stack]
[~mantonov]
[~ndimiduk]
[~busbey]
[~lhofhansl]
[~elserj]
[~jamestaylor]

Please forward your at-mention as you feel appropriate.


was (Author: apurtell):
Please review. After a few days if no comment or no negative feedback I will 
close this as Fixed as agreed to by lazy consensus.

[~stack]
[~mantonov]
[~ndimiduk]
[~busbey]
[~lhofhansl]
[~elserj]

Please forward your at-mention as you feel appropriate.

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> The below all relate to source level compatibility. Recompilation of a client 
> program may be terminated with the message "client class C is not abstract 
> and does not override abstract method M in TYPE". According to our 
> compatibility guidelines we are allowed to add methods to interfaces, so 
> these are ALLOWED.  Please let me know if you disagree.
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterObserver 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext ) has been added to this 
> interface. 
> * Abstract method preMoveServers ( 
>

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

The below all relate to source level compatibility. Recompilation of a client 
program may be terminated with the message "client class C is not abstract and 
does not override abstract method M in TYPE". According to our compatibility 
guidelines we are allowed to add methods to interfaces, so these are ALLOWED.  
Please let me know if you disagree.

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

*

[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


[ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221480#comment-16221480
 ] 

Andrew Purtell commented on HBASE-19099:


Please review. After a few days if no comment or no negative feedback I will 
close this as Fixed as agreed to by lazy consensus.

[~stack]
[~mantonov]
[~ndimiduk]
[~busbey]
[~lhofhansl]
[~elserj]

Please forward your at-mention as you feel appropriate.

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterObserver 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext ) has been added to this 
> interface. 
> * Abstract method preMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method preMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method preMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method preRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface RegionCoprocessorEnvironment 
> * Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.coprocessor
> interface RegionObserver
> * Abstract method postCommitStoreFile ( 
>

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.ipc
class RpcScheduler

* Abstract method getActiveReadRpcHandlerCount ( ) has been added to this class.
* Abstract method getActiveScanRpcHandlerCount ( ) has been added to this 
class. 
* Abstract method

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221477#comment-16221477
 ] 

Hudson commented on HBASE-19098:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #261 (See 
[https://builds.apache.org/job/HBase-1.3-IT/261/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev e1f537f5ca6cd6a3e47ad83e4ef3adff0f0891ef)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.ipc
class RpcScheduler

* Abstract method getActiveReadRpcHandlerCount ( ) has been added to this class.
* Abstract method getActiveScanRpcHandlerCount ( ) has been added to this 
class. 
* Abstract method

[jira] [Comment Edited] (HBASE-19089) Fix the list of included moduleSets in src and binary tars


[ 
https://issues.apache.org/jira/browse/HBASE-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221474#comment-16221474
 ] 

Appy edited comment on HBASE-19089 at 10/26/17 11:59 PM:
-

Oh, forgot to remove common-moduleset-includes.xml. That was a failed effort to 
use common list of includes. :(
[~busbey] Are you referring to these tests: 
https://builds.apache.org/job/HBase%20Nightly/? But they are already red.
So far, i have been testing by running steps 3 and 4 of [Making a release 
candidate|http://hbase.apache.org/book.html#maven.release] and checking the 
contents of tarball.


was (Author: appy):
Oh, forgot to remove common-moduleset-includes.xml. That was a failed effort to 
use common list of includes. :(
[~busbey] Are you referring to these tests: 
https://builds.apache.org/job/HBase%20Nightly/? But they are already red.

> Fix the list of included moduleSets in src and binary tars
> --
>
> Key: HBASE-19089
> URL: https://issues.apache.org/jira/browse/HBASE-19089
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-19089.master.001.patch
>
>
> List of moduleSets included in src.xml and hadoop-two-compat.xml differ quite 
> a lot. Particularly, hadoop-two-compat.xml is missing quite a few modules.
> The core issue is duplication involved in  list. Let me try to get 
> rid of it by using a shared list and including it using 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper


[ 
https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221476#comment-16221476
 ] 

Hadoop QA commented on HBASE-19047:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 14 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  8m 
19s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 0s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
51m 56s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}141m  3s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 
41s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
43s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}232m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19047 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894199/HBASE-19047_V4.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux d3fd6f76fb63 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 459202bab0 |
| Default Java | 1.8.0_141 |
|

[jira] [Commented] (HBASE-19089) Fix the list of included moduleSets in src and binary tars


[ 
https://issues.apache.org/jira/browse/HBASE-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221474#comment-16221474
 ] 

Appy commented on HBASE-19089:
--

Oh, forgot to remove common-moduleset-includes.xml. That was a failed effort to 
use common list of includes. :(
[~busbey] Are you referring to these tests: 
https://builds.apache.org/job/HBase%20Nightly/? But they are already red.

> Fix the list of included moduleSets in src and binary tars
> --
>
> Key: HBASE-19089
> URL: https://issues.apache.org/jira/browse/HBASE-19089
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-19089.master.001.patch
>
>
> List of moduleSets included in src.xml and hadoop-two-compat.xml differ quite 
> a lot. Particularly, hadoop-two-compat.xml is missing quite a few modules.
> The core issue is duplication involved in  list. Let me try to get 
> rid of it by using a shared list and including it using 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.coprocessor
interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

package org.apache.hadoop.hbase.coprocessor
interface WALCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.ipc
class RpcScheduler

* Abstract method getActiveReadRpcHandlerCount ( ) has been added to this class.
* Abstract method getActiveScanRpcHandlerCount ( ) has been added to this 
class. 
* Abstract method

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  2 

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

interface WALCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.ipc
class RpcScheduler

* Abstract method getActiveReadRpcHandlerCount ( ) has been added to this class.
* Abstract method getActiveScanRpcHandlerCount ( ) has been added to this 
class. 
* Abstract method getActiveWriteRpcHandlerCount ( ) has been added to this 
class.   
* Abstract method getReadQueueLength ( ) has been added to this class.
* Abstract method getScanQueueLength ( ) has been added

[jira] [Issue Comment Deleted] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Comment: was deleted

(was: There are also changes to Store - add / removals. We previously discussed 
this and said they are ok, with feedback from the Phoenix project. 

 [−] interface Store  9 
Change  Effect
1   Abstract method add ( Iterable ) has been added to this 
interface.Recompilation of a client program may be terminated with the 
message: a client class C is not abstract and does not override abstract method 
add ( Iterable ) in Store.
2   Abstract method bulkLoadHFile ( byte[ ], String, Path ) has been added 
to this interface.   Recompilation of a client program may be terminated 
with the message: a client class C is not abstract and does not override 
abstract method bulkLoadHFile ( byte[ ], String, Path ) in Store.
3   Abstract method getScanners ( List, boolean, boolean, 
boolean, boolean, ScanQueryMatcher, byte[ ], byte[ ], long, boolean ) has been 
added to this interface.Recompilation of a client program may be 
terminated with the message: a client class C is not abstract and does not 
override abstract method getScanners ( List, boolean, boolean, 
boolean, boolean, ScanQueryMatcher, byte[ ], byte[ ], long, boolean ) in Store.
4   Abstract method getScanners ( boolean, boolean, boolean, boolean, 
ScanQueryMatcher, byte[ ], byte[ ], long ) has been added to this interface.  
Recompilation of a client program may be terminated with the message: a client 
class C is not abstract and does not override abstract method getScanners ( 
boolean, boolean, boolean, boolean, ScanQueryMatcher, byte[ ], byte[ ], long ) 
in Store.
5   Abstract method upsert ( Iterable, long, List ) has been 
added to this interface.   Recompilation of a client program may be terminated 
with the message: a client class C is not abstract and does not override 
abstract method upsert ( Iterable, long, List ) in Store.
6   Abstract method bulkLoadHFile ( String, long ) has been removed from 
this interface.Recompilation of a client program may be terminated with the 
message: cannot find method bulkLoadHFile ( String, long ) in interface Store.
7   Abstract method getScanners ( List, boolean, boolean, 
boolean, boolean, ScanQueryMatcher, byte[ ], byte[ ], long, boolean ) has been 
removed from this interface.Recompilation of a client program may be 
terminated with the message: cannot find method getScanners ( List, 
boolean, boolean, boolean, boolean, ScanQueryMatcher, byte[ ], byte[ ], long, 
boolean ) in interface Store.
8   Abstract method getScanners ( boolean, boolean, boolean, boolean, 
ScanQueryMatcher, byte[ ], byte[ ], long ) has been removed from this 
interface.  Recompilation of a client program may be terminated with the 
message: cannot find method getScanners ( boolean, boolean, boolean, boolean, 
ScanQueryMatcher, byte[ ], byte[ ], long ) in interface Store.
9   Abstract method upsert ( Iterable, long ) has been removed from 
this interface.

I will come back and edit this later to clean it up.)

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> package org.apache.hadoop.hbase.client
> interface Admin 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  2 
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout (

[jira] [Updated] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Description: 
For discussion, here are the remaining compatibility concerns you will 
encounter upon moving up from 1.3 to 1.4:

package org.apache.hadoop.hbase.client
interface Admin 

* Abstract method clearDeadServers ( List ) has been added to this 
interface.
* Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
to this interface.
* Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
* Abstract method isMasterInMaintenanceMode ( ) has been added to this 
interface.
* Abstract method listDeadServers ( ) has been added to this interface.
* Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
to this interface.
* Abstract method runCleanerChore ( ) has been added to this interface.
* Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
interface.

package org.apache.hadoop.hbase.client
interface ResultScanner  2 

* Abstract method renewLease ( ) has been added to this interface. 
* Abstract method getScanMetrics ( ) has been added to this interface.

package org.apache.hadoop.hbase.client
interface Table

* Abstract method getReadRpcTimeout ( ) has been added to this interface.
* Abstract method getWriteRpcTimeout ( ) has been added to this interface.
* Abstract method setReadRpcTimeout ( int ) has been added to this interface.
* Abstract method setWriteRpcTimeout ( int ) has been added to this interface.

package org.apache.hadoop.hbase.replication
interface ReplicationPeer

* Abstract method getPeerBandwidth ( ) has been added to this interface.
* Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) has 
been added to this interface.

package org.apache.hadoop.hbase.coprocessor
interface MasterCoprocessorEnvironment

* Abstract method getMetricRegistryForMaster ( ) has been added to this 
interface.

interface MasterObserver 

* Abstract method postAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method postBalanceRSGroup ( 
ObserverContext, String, boolean ) has been added 
to this interface.
* Abstract method postClearDeadServers ( 
ObserverContext ) has been added to this 
interface.  
* Abstract method postListDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method postMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface.
* Abstract method postMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method postMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface. 
* Abstract method postRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preAddRSGroup ( 
ObserverContext, String ) has been added to this 
interface. 
* Abstract method preBalanceRSGroup ( 
ObserverContext, String ) has been added to this 
interface.
* Abstract method preClearDeadServers ( 
ObserverContext ) has been added to this 
interface.
* Abstract method preListDeadServers ( 
ObserverContext ) has been added to this 
interface. 
* Abstract method preMoveServers ( 
ObserverContext, Set, String ) has been 
added to this interface. 
* Abstract method preMoveServersAndTables ( 
ObserverContext, Set, Set, 
String ) has been added to this interface.
* Abstract method preMoveTables ( 
ObserverContext, Set, String ) has 
been added to this interface.
* Abstract method preRemoveRSGroup ( 
ObserverContext, String ) has been added to this 
interface.

interface RegionCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

interface RegionObserver

* Abstract method postCommitStoreFile ( 
ObserverContext, byte[ ], Path, Path ) has been 
added to this interface.  
* Abstract method preCommitStoreFile ( 
ObserverContext, byte[ ], List> ) 
has been added to this interface. 
* Abstract method preCompactScannerOpen ( 
ObserverContext, Store, List, ScanType, long, 
InternalScanner, CompactionRequest, long ) has been added to this interface.
* Abstract method preFlushScannerOpen ( 
ObserverContext, Store, KeyValueScanner, 
InternalScanner, long ) has been added to this interface. 

interface WALCoprocessorEnvironment 

* Abstract method getMetricRegistryForRegionServer ( ) has been added to this 
interface.

package org.apache.hadoop.hbase.ipc
class RpcScheduler

* Abstract method getActiveReadRpcHandlerCount ( ) has been added to this class.
* Abstract method getActiveScanRpcHandlerCount ( ) has been added to this 
class. 
* Abstract method getActiveWriteRpcHandlerCount ( ) has been added to this 
class.   
* Abstract method getReadQueueLength ( ) has been added to this class.
* Abstract method getScanQueueLength ( ) has been added

[jira] [Issue Comment Deleted] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1


 [ 
https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-19099:
---
Comment: was deleted

(was: We also made a change to LP replication interface hierarchy, which is 
ALLOWED I believe because it is a source level compatibility issue and amounts 
to addition of new methods. 

package org.apache.hadoop.hbase.replication
[−] interface ReplicationEndpoint  1 
Change  Effect
1   Added super-interface ReplicationPeerConfigListener.Recompilation 
of a client program may be terminated with the message: a client class C is not 
abstract and does not override abstract method in ReplicationPeerConfigListener.
)

> Evaluate the remaining compatibility concerns between branch-1.3 and 
> branch-1.4 / branch-1
> --
>
> Key: HBASE-19099
> URL: https://issues.apache.org/jira/browse/HBASE-19099
> Project: HBase
>  Issue Type: Task
>Affects Versions: 1.4.0, 1.5.0
>Reporter: Andrew Purtell
>Priority: Blocker
> Fix For: 1.4.0, 1.5.0
>
>
> For discussion, here are the remaining compatibility concerns you will 
> encounter upon moving up from 1.3 to 1.4:
> package org.apache.hadoop.hbase.client
> interface Admin  8 
> * Abstract method clearDeadServers ( List ) has been added to 
> this interface.
> * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added 
> to this interface.
> * Abstract method isCleanerChoreEnabled ( ) has been added to this interface.
> * Abstract method isMasterInMaintenanceMode ( ) has been added to this 
> interface.
> * Abstract method listDeadServers ( ) has been added to this interface.
> * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added 
> to this interface.
> * Abstract method runCleanerChore ( ) has been added to this interface.
> * Abstract method setCleanerChoreRunning ( boolean ) has been added to this 
> interface.
> package org.apache.hadoop.hbase.client
> interface ResultScanner  2 
> * Abstract method renewLease ( ) has been added to this interface. 
> * Abstract method getScanMetrics ( ) has been added to this interface.
> package org.apache.hadoop.hbase.client
> interface Table
> * Abstract method getReadRpcTimeout ( ) has been added to this interface.
> * Abstract method getWriteRpcTimeout ( ) has been added to this interface.
> * Abstract method setReadRpcTimeout ( int ) has been added to this interface.
> * Abstract method setWriteRpcTimeout ( int ) has been added to this interface.
> package org.apache.hadoop.hbase.replication
> interface ReplicationPeer
> * Abstract method getPeerBandwidth ( ) has been added to this interface.
> * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) 
> has been added to this interface.
> package org.apache.hadoop.hbase.coprocessor
> interface MasterCoprocessorEnvironment
> * Abstract method getMetricRegistryForMaster ( ) has been added to this 
> interface.
> interface MasterObserver  16 
> * Abstract method postAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method postBalanceRSGroup ( 
> ObserverContext, String, boolean ) has been 
> added to this interface.
> * Abstract method postClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postListDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method postMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method postMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method postMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method postRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preAddRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface. 
> * Abstract method preBalanceRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> * Abstract method preClearDeadServers ( 
> ObserverContext ) has been added to this 
> interface.
> * Abstract method preListDeadServers ( 
> ObserverContext ) has been added to this 
> interface. 
> * Abstract method preMoveServers ( 
> ObserverContext, Set, String ) has 
> been added to this interface. 
> * Abstract method preMoveServersAndTables ( 
> ObserverContext, Set, Set, 
> String ) has been added to this interface.
> * Abstract method preMoveTables ( 
> ObserverContext, Set, String ) has 
> been added to this interface.
> * Abstract method preRemoveRSGroup ( 
> ObserverContext, String ) has been added to 
> this interface.
> interface RegionCoprocessorEnvironment 
> * Abstract method

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221456#comment-16221456
 ] 

Appy commented on HBASE-18905:
--

Let's just reopen this one (without reverting the commit).

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-v1.patch, HBASE-18905.patch, 
> HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'


[ 
https://issues.apache.org/jira/browse/HBASE-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221452#comment-16221452
 ] 

Hudson commented on HBASE-19098:


SUCCESS: Integrated in Jenkins build HBase-1.2-IT #995 (See 
[https://builds.apache.org/job/HBase-1.2-IT/995/])
HBASE-19098 compatibility checker should handle remotes named something 
(busbey: rev 155d2966c657b5cc241c74045f59dc251118337b)
* (edit) dev-support/checkcompatibility.py


> Python based compatiblity checker fails if git repo does not have a remote 
> named 'origin'
> -
>
> Key: HBASE-19098
> URL: https://issues.apache.org/jira/browse/HBASE-19098
> Project: HBase
>  Issue Type: Bug
>  Components: tooling
>Reporter: Andrew Purtell
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-4
>
> Attachments: HBASE-19098.0.patch
>
>
> The new Python based compatibility checker will fail if the local git repo 
> does not have a remote named "origin". I develop with multiple upstream repos 
> and rename them according to a custom convention. If the requirement that an 
> upstream named "origin" must be present could be removed, that would be good, 
> or otherwise this should be documented next to the example usage in the 
> python source. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221435#comment-16221435
 ] 

Duo Zhang commented on HBASE-18905:
---

Sorry but where is the issue for fixing it? Thanks.

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-v1.patch, HBASE-18905.patch, 
> HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache based on table name


[ 
https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221430#comment-16221430
 ] 

Hadoop QA commented on HBASE-18624:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
59s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  2m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m 
12s{color} | {color:red} The patch generated 10 new + 359 unchanged - 1 fixed = 
369 total (was 360) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red}  0m  
5s{color} | {color:red} The patch generated 5 new + 740 unchanged - 0 fixed = 
745 total (was 740) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  2m 
30s{color} | {color:red} patch has 10 errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
52m  6s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  
1m 50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
20s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m  5s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m 
12s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:red}-1{color} | {color:red}

[jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush


[ 
https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221431#comment-16221431
 ] 

Appy commented on HBASE-18905:
--

Actually the bad test here was TestFlushLifeCycleTracker. It's refusing to 
complete on master branch. While the fix is on way, let me mark it @Ignore to 
unblock other precommits.

> Allow CPs to request flush on Region and know the completion of the requested 
> flush
> ---
>
> Key: HBASE-18905
> URL: https://issues.apache.org/jira/browse/HBASE-18905
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18905-v1.patch, HBASE-18905.patch, 
> HBASE-18905.patch
>
>
> Follow up for HBASE-18183
> As per that Jira, we keep only requestCompaction API in Region.  We did not 
> have any such for flush in Region.  Only API which was there is a flush which 
> will block the callee unless flush is done. This issue has to tacke
> 1. Decide whether we need a requestFlush in Region and if so add
> 2. Whether the requestCompaction (And requestFlush too) should return a 
> Future?  Right now the former do  not return any but allow to pass a 
> CompactionLifeCycleTracker which will get notified on start and end of 
> compaction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-26 Thread Vrushali C (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221427#comment-16221427
 ] 

Vrushali C commented on HBASE-19092:


Also, yarn timeline service is using hbase 1.2.6 since that was the latest 
stable release. 

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs

2017-10-26 Thread Vrushali C (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221424#comment-16221424
 ] 

Vrushali C commented on HBASE-19092:


Hi [~stack]
So here is the code:

https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/FlowScanner.java#L500

Lines 500 and 503 both create Tags.

Also, in file 
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/common/HBaseTimelineStorageUtils.java#L144

at lines 144 and 152

thanks
Vrushali

> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class


[ 
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221416#comment-16221416
 ] 

stack commented on HBASE-18995:
---

I like the @appy review comments on Util naming. PrivateCellUtil to match the 
IA annotation sounds good.

Let me review more up on RB.

> Move methods that are for internal usage from CellUtil to Private util class
> 
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, 
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs 
> from CellUtil to internal private Util class because they are used in some 
> internal flow and does not make sense to have it in a @public exposed Util 
> class. 
> The topic again came in HBASE-18945 RB comments also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction


[ 
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221408#comment-16221408
 ] 

Duo Zhang commented on HBASE-19095:
---

Yes. In memory compaction can drop cells so we need to provide CP hooks to 
reset versions and TTL otherwise the example in HBASE-19033 will fail.

> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
>
> This is a hole in our CP hooks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs


[ 
https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221409#comment-16221409
 ] 

stack commented on HBASE-19092:
---

[~vrushalic] Pardon me, trying to use your info above. How do you do Tag(byte 
tagType, byte [] tag) Construction? Tag is an Interface. I see two 
implementations, neither match the signature above (Can just name hadoop 
file...). Thanks.



> Make Tag IA.LimitedPrivate and expose for CPs
> -
>
> Key: HBASE-19092
> URL: https://issues.apache.org/jira/browse/HBASE-19092
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19092-branch-2.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use 
> tags like timeline server. The same topic was discussed in dev@ and also in 
> HBASE-18995.
> Shall we target this for beta1 - cc [~saint@gmail.com].
> So once we do this all related Util methods and APIs should also move to 
> LimitedPrivate Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (HBASE-5617) Provide coprocessor hooks in put flow while rollbackMemstore.


 [ 
https://issues.apache.org/jira/browse/HBASE-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-5617.
--
   Resolution: Invalid
Fix Version/s: (was: 2.0.0-alpha-4)

Closing as invalid. There is no rollback of memstore anymore (as per 
[~chia7712]), not since we reordered the write path (1.2). Thanks [~mdrob] for 
putting this into consideration. Correct me if I have this wrong [~ram_krish]

> Provide coprocessor hooks in put flow while rollbackMemstore.
> -
>
> Key: HBASE-5617
> URL: https://issues.apache.org/jira/browse/HBASE-5617
> Project: HBase
>  Issue Type: Improvement
>  Components: Coprocessors
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-5617_1.patch, HBASE-5617_2.patch
>
>
> With coprocessors hooks while put happens we have the provision to create new 
> puts to other tables or regions.  These puts can be done with writeToWal as 
> false.
> In 0.94 and above the puts are first written to memstore and then to WAL.  If 
> any failure in the WAL append or sync the memstore is rollbacked.  
> Now the problem is that if the put that happens in the main flow fails there 
> is no way to rollback the 
> puts that happened in the prePut.
> We can add coprocessor hooks to like pre/postRoolBackMemStore.  Is any one 
> hook enough here?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction


[ 
https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221393#comment-16221393
 ] 

stack commented on HBASE-19095:
---

[~Apache9] comments from dev list on the 'Moving 2.0 forward' thread:

{code}
As Anoop suggested in HBASE-19001, we still need to give user the ability
to extend the max versions and TTL config, so I plan to add back the hooks
above to let CP users can change the max versions and TTL of a ScanInfo
object. But I'm not sure whether in memory compaction will also discard
expired cells, if so then we are in trouble...

OK, skimmed,  we are in trouble! The in memory compaction just use the same
constructor with normal compaction to construct a StoreScanner, and use it
to do compaction...

We have to provide several preXXX and postXXX for it, at least we should
allow user reset TTL and max versions, and also do filtering on the scanner.
{code}

So, the in-memory compaction needs to call the hooks and it is not doing this 
currenlty. Is that the concern [~Apache9]? Thanks sir.

> Add CP hooks in RegionObserver for in memory compaction
> ---
>
> Key: HBASE-19095
> URL: https://issues.apache.org/jira/browse/HBASE-19095
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
>
> This is a hole in our CP hooks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache based on table name

2017-10-26 Thread Zach York (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221387#comment-16221387
 ] 

Zach York commented on HBASE-18624:
---

Thanks for the info, I knew about the precommit jenkins job, but didn't know 
how to view the parameters before the job started.

> Added support for clearing BlockCache based on table name
> -
>
> Key: HBASE-18624
> URL: https://issues.apache.org/jira/browse/HBASE-18624
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 2.0.0, 1.3.0
>Reporter: Ajay Jadhav
>Assignee: Zach York
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18624.branch-1.001.patch, 
> HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, 
> HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, 
> HBASE-18624.master.005.patch, HBASE-18624.master.006.patch
>
>
> Bulk loading the primary HBase cluster triggers a lot of compactions 
> resulting in archival/ creation
> of multiple HFiles. This process will cause a lot of items to become stale in 
> replica’s BlockCache.
> This patch will help users to clear the block cache for a given table by 
> either using shell or API.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper


[ 
https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221386#comment-16221386
 ] 

stack commented on HBASE-19047:
---

bq. Are we trying to hide Shipper functionality from CPs?

Yes. Its pure internals. When data has been 'shipped' out the front door, we 
can decrement the count of references to the backing memory.

Good review [~appy]

> CP exposed Scanner types should not extend Shipper
> --
>
> Key: HBASE-19047
> URL: https://issues.apache.org/jira/browse/HBASE-19047
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19047.patch, HBASE-19047_V2.patch, 
> HBASE-19047_V2.patch, HBASE-19047_V3.patch, HBASE-19047_V4.patch, 
> HBASE-19047_V4.patch, HBASE-19047_V4.patch
>
>
> Shipper is a IA.Private interface and very much internal.. 
> Right now CP exposed RegionScanner is extending this and so exposing the 
> shipped() method. This by mistake is called, can harm the correctness of the 
> cells in the Results.
> preScannerOpen() allowing to return a new Scanner is also problematic now.  
> This can allow users to create a Region scanner from Region and then wrap it 
> and return back (Well same can be done by postScannerOpen also), it can so 
> happen that the wrapper is not implementing the shipped() properly.  In any 
> way exposing the shipped () is problematic.
> Solution Steps
> 1. Remove preScannerOpen() , the use case I can think of is wrapping the 
> original scanner. The original scanner can be created by Region.getScanner 
> way only..  May be no need to remove this hook.  Just remove the ability for 
> it to return a RegionScanner instance.  Call this with the Scan object and 
> the CP can change the Scan object if they want.
> 2. Let RegionScanner not extending Shipper but only RegionScannerImpl 
> implements this
> 3. We have ref to the RegionScanner created by core and let that be used by 
> RegionScannerShippedCallBack when the post hook doing a wrap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper


[ 
https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221380#comment-16221380
 ] 

Appy commented on HBASE-19047:
--

Really like the parts of patch which is changing args from RegionScanner to 
Shipper.
{code}
-private final RegionScanner scanner;
+private final Shipper shipper;
...
...
-public RegionScannerShippedCallBack(String scannerName, RegionScanner 
scanner, Lease lease) {
+public RegionScannerShippedCallBack(String scannerName, Shipper shipper, 
Lease lease) {
{code}
Nice!

bq. RegionScanner is exposed to CPs. Right now it extends Shipper means we 
expose that too (Even though Shipper is marked as private). We should remove 
this and just make the impl class only implement the SHipper interface.

Are we trying to hide Shipper functionality from CPs?


{code}
-RegionScanner scanner = null;
 if (region.getCoprocessorHost() != null) {
-  scanner = region.getCoprocessorHost().preScannerOpen(scan);
-}
-if (scanner == null) {
-  scanner = region.getScanner(scan);
+  // preScannerOpen is not allowed to return a RegionScanner. Only post 
hook can create a
+  // wrapper for the core created RegionScanner
+  region.getCoprocessorHost().preScannerOpen(scan);
 }
+RegionScannerImpl coreScanner = region.getScanner(scan);
+Shipper shipper = coreScanner;
+RegionScanner scanner = coreScanner;
 if (region.getCoprocessorHost() != null) {
   scanner = region.getCoprocessorHost().postScannerOpen(scan, scanner);
+  if (scanner instanceof Shipper) {
+shipper = (Shipper) scanner;
+  }
 }
{code}

It all made sense until i came to this. Are we trying to hide the Shipper from 
CP or not?
If we are trying to hide it, then we shouldn't be doing {{returnedScanner 
instanceOf Shipper}} and reassigning shipper.
If we are not trying to hide it, then what we have right now is just fine. 
(Actually changing things from RegionScanner *is a* Shipper to RegionScanner 
*has a* Shipper might be better - plain old composition over inheritance)

{{try (RegionScannerImpl scanner = (RegionScannerImpl) REGION.getScanner(new 
Scan())) {}}
Is casting redundant now?







> CP exposed Scanner types should not extend Shipper
> --
>
> Key: HBASE-19047
> URL: https://issues.apache.org/jira/browse/HBASE-19047
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19047.patch, HBASE-19047_V2.patch, 
> HBASE-19047_V2.patch, HBASE-19047_V3.patch, HBASE-19047_V4.patch, 
> HBASE-19047_V4.patch, HBASE-19047_V4.patch
>
>
> Shipper is a IA.Private interface and very much internal.. 
> Right now CP exposed RegionScanner is extending this and so exposing the 
> shipped() method. This by mistake is called, can harm the correctness of the 
> cells in the Results.
> preScannerOpen() allowing to return a new Scanner is also problematic now.  
> This can allow users to create a Region scanner from Region and then wrap it 
> and return back (Well same can be done by postScannerOpen also), it can so 
> happen that the wrapper is not implementing the shipped() properly.  In any 
> way exposing the shipped () is problematic.
> Solution Steps
> 1. Remove preScannerOpen() , the use case I can think of is wrapping the 
> original scanner. The original scanner can be created by Region.getScanner 
> way only..  May be no need to remove this hook.  Just remove the ability for 
> it to return a RegionScanner instance.  Call this with the Scan object and 
> the CP can change the Scan object if they want.
> 2. Let RegionScanner not extending Shipper but only RegionScannerImpl 
> implements this
> 3. We have ref to the RegionScanner created by core and let that be used by 
> RegionScannerShippedCallBack when the post hook doing a wrap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19002) Introduce more examples to show how to intercept normal region operations

2017-10-26 Thread Josh Elser (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221362#comment-16221362
 ] 

Josh Elser commented on HBASE-19002:


Will do, boss.

> Introduce more examples to show how to intercept normal region operations
> -
>
> Key: HBASE-19002
> URL: https://issues.apache.org/jira/browse/HBASE-19002
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Reporter: Duo Zhang
>Assignee: Josh Elser
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19002.001.branch-2.patch, 
> HBASE-19002.002.branch-2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19098) Python based compatiblity checker fails if git repo does not have a remote named 'origin'