[GitHub] [hbase] Apache-HBase commented on issue #344: HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure …

2019-06-26 Thread GitBox
Apache-HBase commented on issue #344: HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure … URL: https://github.com/apache/hbase/pull/344#issuecomment-506217812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506216717 @wchevreuil @saintstack Please let me know if this looks good to you This

[GitHub] [hbase] virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506197360 cc @Apache9 @busbey This is an automated message from the Apache Git Serv

[jira] [Commented] (HBASE-22628) Data loss while migrating to custom WAL directory (hbase.wal.dir)

2019-06-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873820#comment-16873820 ] Anoop Sam John commented on HBASE-22628: Exactly. If we dont clear doc this, mi

[jira] [Resolved] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-22635. -- Resolution: Invalid > Prevent NPE for WALMapper map() > --- > >

[jira] [Updated] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22635: - Fix Version/s: (was: 3.0.0) Status: Open (was: Patch Available) > Prevent NPE fo

[GitHub] [hbase] virajjasani closed pull request #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
virajjasani closed pull request #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] virajjasani commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
virajjasani commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342#issuecomment-506189430 @Apache9 @jatsakthi Thanks for your inputs. I just double checked, ran tests and realized that I was mislead by this if

[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873796#comment-16873796 ] yuhuiyang commented on HBASE-22631: --- assignProcedure.txt is my test log  > assign fai

[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: assignProcedure.txt > assign failed may make gced parent region appear again !!! > ---

[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873794#comment-16873794 ] yuhuiyang edited comment on HBASE-22631 at 6/27/19 4:13 AM:

[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873794#comment-16873794 ] yuhuiyang commented on HBASE-22631: --- [~allan163]  step1 : Region A closed due to HDFS

[GitHub] [hbase] Apache-HBase commented on issue #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-26 Thread GitBox
Apache-HBase commented on issue #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#issuecomment-506147318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] Apache9 opened a new pull request #344: HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure …

2019-06-26 Thread GitBox
Apache9 opened a new pull request #344: HBASE-22632 SplitTableRegionProcedure and MergeTableRegionsProcedure … URL: https://github.com/apache/hbase/pull/344 …should skip store files for unknown column families This is an auto

[GitHub] [hbase] virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506145362 > @virajjasani usually the best way is to check if the tests are present in the upstream flakey list. If yes, then we can usually bypass th

[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: HBASE-22631-branch-2.1.01.patch > assign failed may make gced parent region appear again !

[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873783#comment-16873783 ] Allan Yang commented on HBASE-22631: Can you describe more details about the reprodu

[GitHub] [hbase] Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
Apache-HBase commented on issue #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#issuecomment-506139858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[jira] [Commented] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873782#comment-16873782 ] Allan Yang commented on HBASE-22620: Yes, it is a valid problem, which is already fi

[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873779#comment-16873779 ] yuhuiyang edited comment on HBASE-22631 at 6/27/19 3:12 AM:

[jira] [Commented] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873779#comment-16873779 ] yuhuiyang commented on HBASE-22631: --- i will submit a correct named patch later ! > as

[jira] [Commented] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole

2019-06-26 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873776#comment-16873776 ] Xiaolin Ha commented on HBASE-22403: [~zghaobac], thanks for helping to commit, I ha

[jira] [Updated] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole

2019-06-26 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-22403: --- Attachment: HBASE-22403.master.003.patch > Balance in RSGroup should consider throttling and a failu

[jira] [Updated] (HBASE-22631) assign failed may make gced parent region appear again !!!

2019-06-26 Thread yuhuiyang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhuiyang updated HBASE-22631: -- Attachment: (was: correct-assignprocedure-handlerFailureV1.patch) > assign failed may make gced pa

[jira] [Updated] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leizhang updated HBASE-22620: - Affects Version/s: (was: 2.0.3) > When a cluster open replication,regionserver will not clean up the

[jira] [Updated] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leizhang updated HBASE-22620: - Affects Version/s: 1.2.4 > When a cluster open replication,regionserver will not clean up the walLog >

[jira] [Commented] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873771#comment-16873771 ] leizhang commented on HBASE-22620: -- Yesterday, I found the Hbase 1.2.4 also exists the

[jira] [Comment Edited] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873771#comment-16873771 ] leizhang edited comment on HBASE-22620 at 6/27/19 2:41 AM: --- Ye

[jira] [Commented] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873770#comment-16873770 ] leizhang commented on HBASE-22620: -- Sorry , I only check the code in Hbase 2.x, I find

[jira] [Commented] (HBASE-22414) Interruption of moving regions in RSGroup will cause regions on wrong rs

2019-06-26 Thread Xiaolin Ha (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873767#comment-16873767 ] Xiaolin Ha commented on HBASE-22414: hi,[~xucang],thanks for your comments, I have c

[jira] [Commented] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873766#comment-16873766 ] Zheng Hu commented on HBASE-22620: -- So the problem is actually happened in HBase1.4.9 ,

[GitHub] [hbase] sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297953890 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297952752 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297952690 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] mymeiyi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-26 Thread GitBox
mymeiyi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r297952766 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleane

[GitHub] [hbase] sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297952643 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-26 Thread GitBox
jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#discussion_r297951951 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChec

[jira] [Updated] (HBASE-22620) When a cluster open replication,regionserver will not clean up the walLog references on zk due to no wal entry need to be replicated

2019-06-26 Thread leizhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leizhang updated HBASE-22620: - Description: When I open the replication feature on my hbase cluster (20 regionserver nodes) and added a

[GitHub] [hbase] jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh…

2019-06-26 Thread GitBox
jatsakthi commented on a change in pull request #335: HBASE-22624 Should sanity check table configuration when clone snapsh… URL: https://github.com/apache/hbase/pull/335#discussion_r297950198 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestRegionReplica

[GitHub] [hbase] sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
sunhelly commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297949081 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] openinx commented on issue #341: HBASE-22582 The Compaction writer may access the lastCell whose memor…

2019-06-26 Thread GitBox
openinx commented on issue #341: HBASE-22582 The Compaction writer may access the lastCell whose memor… URL: https://github.com/apache/hbase/pull/341#issuecomment-506109371 @jatsakthi Yeah, I think we can fix the checksytle in this issue. -

[GitHub] [hbase] Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-506108285 > If i didn’t mistake BufferedMutatorImpl doesn’t exist anymore on master. I build this on my cluster on a 2.1.4 ... > […](#)

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297932029 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java ##

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297937913 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297933401 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297930078 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java ###

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297944494 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorThreadPoolExec

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297925230 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297925473 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java

[GitHub] [hbase] Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache9 commented on a change in pull request #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#discussion_r297927986 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ###

[GitHub] [hbase] Apache9 commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
Apache9 commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342#issuecomment-506101939 Mind explaining why we could hit NPE here? This is an auto

[jira] [Commented] (HBASE-22578) HFileCleaner should not delete empty ns/table directories used for user san snapshot feature

2019-06-26 Thread Sakthi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873729#comment-16873729 ] Sakthi commented on HBASE-22578: The PR has a possible typo.  > HFileCleaner should not

[GitHub] [hbase] jatsakthi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories…

2019-06-26 Thread GitBox
jatsakthi commented on a change in pull request #337: HBASE-22578 HFileCleaner should not delete empty ns/table directories… URL: https://github.com/apache/hbase/pull/337#discussion_r297919481 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileClea

[jira] [Commented] (HBASE-22403) Balance in RSGroup should consider throttling and a failure affects the whole

2019-06-26 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873725#comment-16873725 ] Guanghao Zhang commented on HBASE-22403: Reattach a patch as it cannot commit di

[jira] [Commented] (HBASE-22414) Interruption of moving regions in RSGroup will cause regions on wrong rs

2019-06-26 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873719#comment-16873719 ] Xu Cang commented on HBASE-22414: - Thanks for the new version of the patch [~Xiaolin Ha]

[GitHub] [hbase] xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297913936 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297913355 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297907435 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297908118 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[GitHub] [hbase] xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi…

2019-06-26 Thread GitBox
xcangCRM commented on a change in pull request #323: HBASE-22414 Interruption of moving regions in RSGroup will cause regi… URL: https://github.com/apache/hbase/pull/323#discussion_r297913416 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServ

[jira] [Commented] (HBASE-22606) BucketCache improvement with additional tests

2019-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873710#comment-16873710 ] Hadoop QA commented on HBASE-22606: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[GitHub] [hbase] Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506083876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873697#comment-16873697 ] Duo Zhang commented on HBASE-22634: --- Please split the patch into 3 issues? I think the

[GitHub] [hbase] jatsakthi commented on issue #341: HBASE-22582 The Compaction writer may access the lastCell whose memor…

2019-06-26 Thread GitBox
jatsakthi commented on issue #341: HBASE-22582 The Compaction writer may access the lastCell whose memor… URL: https://github.com/apache/hbase/pull/341#issuecomment-506071980 @openinx , I see some syntax/style fixes along with the "beforeShipped()" fix. I can confirm that there are other p

[GitHub] [hbase] jatsakthi commented on issue #340: HBASE-22633 : remove redundant substring call with append for ZKRepli…

2019-06-26 Thread GitBox
jatsakthi commented on issue #340: HBASE-22633 : remove redundant substring call with append for ZKRepli… URL: https://github.com/apache/hbase/pull/340#issuecomment-506071737 Verified using TestZKReplicationQueueStorage#testRegionsZNodeLayout. +1 ---

[jira] [Commented] (HBASE-22582) The Compaction writer may access the lastCell whose memory has been released when appending fileInfo in the final

2019-06-26 Thread Sakthi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873687#comment-16873687 ] Sakthi commented on HBASE-22582: Hello [~openinx], just wanted to make sure that the abs

[GitHub] [hbase] jatsakthi commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
jatsakthi commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342#issuecomment-506059958 Left a comment in the jira This is an automated message

[jira] [Commented] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Sakthi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873674#comment-16873674 ] Sakthi commented on HBASE-22635: Thanks for filing the jira Vijraj! May I ask how did yo

[jira] [Commented] (HBASE-22606) BucketCache improvement with additional tests

2019-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873669#comment-16873669 ] Hadoop QA commented on HBASE-22606: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[GitHub] [hbase] Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506054245 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hbase] jatsakthi commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
jatsakthi commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-506048005 @virajjasani usually the best way is to check if the tests are present in the upstream flakey list. If yes, then we can usually bypass this. E

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873649#comment-16873649 ] Geoffrey Jacoby commented on HBASE-22622: - [~stack] - Adding an additional, non-

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873622#comment-16873622 ] Andrew Purtell commented on HBASE-22622: For more context the use case is change

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873619#comment-16873619 ] Andrew Purtell commented on HBASE-22622: We need it in branch-1 which is why we’

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873602#comment-16873602 ] stack commented on HBASE-22622: --- Thanks [~gjacoby] for detail (Sorry, I missed the associa

[GitHub] [hbase-connectors] asfgit commented on issue #36: HBASE-22636 hbase spark module README is in txt format

2019-06-26 Thread GitBox
asfgit commented on issue #36: HBASE-22636 hbase spark module README is in txt format URL: https://github.com/apache/hbase-connectors/pull/36#issuecomment-506007282 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBAS

[GitHub] [hbase-connectors] dbist opened a new pull request #36: HBASE-22636 hbase spark module README is in txt format

2019-06-26 Thread GitBox
dbist opened a new pull request #36: HBASE-22636 hbase spark module README is in txt format URL: https://github.com/apache/hbase-connectors/pull/36 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (HBASE-22636) hbase spark module README is in txt format.

2019-06-26 Thread Artem Ervits (JIRA)
Artem Ervits created HBASE-22636: Summary: hbase spark module README is in txt format. Key: HBASE-22636 URL: https://issues.apache.org/jira/browse/HBASE-22636 Project: HBase Issue Type: Task

[GitHub] [hbase] Apache-HBase commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
Apache-HBase commented on issue #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342#issuecomment-505993729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-505989911 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|

[GitHub] [hbase] sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
sbarnoud commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-505987347 If i didn’t mistake BufferedMutatorImpl doesn’t exist anymore on master. I build this on my cluster on a 2.1.4 ... > L

[GitHub] [hbase] virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
virajjasani commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-505982558 @jatsakthi @busbey build is failing every time with some InterruptedIOException. Every time different test cases fail with IOE. How should

[GitHub] [hbase] busbey commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator

2019-06-26 Thread GitBox
busbey commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-505982253 Is there something specific to branch-2.1 for this that makes it irrelevant or substantively different for the master branch? -

[jira] [Commented] (HBASE-22606) BucketCache improvement with additional tests

2019-06-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873565#comment-16873565 ] Hadoop QA commented on HBASE-22606: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || V

[GitHub] [hbase] Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests

2019-06-26 Thread GitBox
Apache-HBase commented on issue #333: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/333#issuecomment-505980608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:---

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Sebastien Barnoud (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873563#comment-16873563 ] Sebastien Barnoud commented on HBASE-22634: --- Done, [https://github.com/apache

[GitHub] [hbase] sbarnoud opened a new pull request #343: HBASE-22634.001.branch-2.1

2019-06-26 Thread GitBox
sbarnoud opened a new pull request #343: HBASE-22634.001.branch-2.1 URL: https://github.com/apache/hbase/pull/343 As requested in the Jira HBASE-22634 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread HBase QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873557#comment-16873557 ] HBase QA commented on HBASE-22634: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Comment Edited] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873542#comment-16873542 ] Andrew Purtell edited comment on HBASE-22622 at 6/26/19 5:33 PM: -

[jira] [Commented] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873542#comment-16873542 ] Andrew Purtell commented on HBASE-22622: {quote}So now we have a Scan with both

[jira] [Comment Edited] (HBASE-22622) WALKey Extended Attributes

2019-06-26 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873542#comment-16873542 ] Andrew Purtell edited comment on HBASE-22622 at 6/26/19 5:32 PM: -

[jira] [Updated] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22635: - Fix Version/s: 3.0.0 Status: Patch Available (was: In Progress) > Prevent NPE for WA

[jira] [Work started] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Viraj Jasani (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22635 started by Viraj Jasani. > Prevent NPE for WALMapper map() > --- > >

[GitHub] [hbase] virajjasani opened a new pull request #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls

2019-06-26 Thread GitBox
virajjasani opened a new pull request #342: HBASE-22635 : Prevent NPE for WALMapper - Delete/Put add() calls URL: https://github.com/apache/hbase/pull/342 This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22635: Component/s: wal mapreduce > Prevent NPE for WALMapper map() > --

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873534#comment-16873534 ] Sean Busbey commented on HBASE-22634: - If you'd like more eyes on this, please open

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873535#comment-16873535 ] Sean Busbey commented on HBASE-22634: - Also if you want to go the route of patches o

[jira] [Created] (HBASE-22635) Prevent NPE for WALMapper map()

2019-06-26 Thread Viraj Jasani (JIRA)
Viraj Jasani created HBASE-22635: Summary: Prevent NPE for WALMapper map() Key: HBASE-22635 URL: https://issues.apache.org/jira/browse/HBASE-22635 Project: HBase Issue Type: Bug Affects V

[jira] [Commented] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Sebastien Barnoud (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873533#comment-16873533 ] Sebastien Barnoud commented on HBASE-22634: --- I finally upload the patch for th

[jira] [Updated] (HBASE-22634) Improve performance of BufferedMutator

2019-06-26 Thread Sebastien Barnoud (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastien Barnoud updated HBASE-22634: -- Attachment: (was: HBASE-22634.001.branch-2.patch) > Improve performance of Buffere

  1   2   >