[jira] [Updated] (HBASE-25575) Should validate Puts in RowMutations

2021-02-16 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25575: - Description: Currently, we don't validate the key value sizes of Puts in RowMutations.

[GitHub] [hbase] virajjasani commented on a change in pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
virajjasani commented on a change in pull request #2959: URL: https://github.com/apache/hbase/pull/2959#discussion_r577334939 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java ## @@ -252,6 +252,7 @@ private void

[jira] [Commented] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-16 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285606#comment-17285606 ] Reid Chan commented on HBASE-21674: --- ping [~apurtell], [~busbey] could you spare some cycles to take

[jira] [Work started] (HBASE-25541) In WALEntryStream, set the current path to null while dequeing the log

2021-02-16 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25541 started by Sandeep Pal. --- > In WALEntryStream, set the current path to null while dequeing the log >

[GitHub] [hbase] brfrn169 commented on pull request #2953: HBASE-25574 Revisit increment/append related RegionObserver methods

2021-02-16 Thread GitBox
brfrn169 commented on pull request #2953: URL: https://github.com/apache/hbase/pull/2953#issuecomment-780209085 @Apache9 Thank you for your reply! No problem at all. Enjoy your holiday! This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2959: URL: https://github.com/apache/hbase/pull/2959#issuecomment-780144013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25541) In WALEntryStream, set the current path to null while dequeing the log

2021-02-16 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285500#comment-17285500 ] Sandeep Pal commented on HBASE-25541: - Thanks for putting this [~bharathv]. You are right, on

[jira] [Updated] (HBASE-25343) Avoid the failed meta replica region temporarily in Load Balance mode

2021-02-16 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25343: Fix Version/s: (was: 2.4.2) 2.4.3 > Avoid the failed meta

[GitHub] [hbase] Apache-HBase commented on pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2959: URL: https://github.com/apache/hbase/pull/2959#issuecomment-780114374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] bharathv commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
bharathv commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-780065150 I just figured that I missed the commit that rolls the op-code into the ExecutorConfig, let me create an addendum.

[GitHub] [hbase] bharathv merged pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
bharathv merged pull request #2922: URL: https://github.com/apache/hbase/pull/2922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-25541) In WALEntryStream, set the current path to null while dequeing the log

2021-02-16 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285430#comment-17285430 ] Bharath Vissapragada commented on HBASE-25541: -- [~anoop.hbase] I believe the issue is this.

[GitHub] [hbase] bharathv commented on a change in pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
bharathv commented on a change in pull request #2959: URL: https://github.com/apache/hbase/pull/2959#discussion_r577063386 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java ## @@ -252,6 +252,7 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2959: URL: https://github.com/apache/hbase/pull/2959#issuecomment-780047088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sandeepvinayak opened a new pull request #2959: HBASE-25541: Setting the path to null when we dequeue the current log

2021-02-16 Thread GitBox
sandeepvinayak opened a new pull request #2959: URL: https://github.com/apache/hbase/pull/2959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HBASE-23887) New L1 cache : AdaptiveLRU

2021-02-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285387#comment-17285387 ] Hudson commented on HBASE-23887: Results for branch branch-2 [build #177 on

[GitHub] [hbase] anmolnar commented on a change in pull request #2931: HBASE-25395 Introduce PersistedStoreEngine and PersistedStoreFileManager

2021-02-16 Thread GitBox
anmolnar commented on a change in pull request #2931: URL: https://github.com/apache/hbase/pull/2931#discussion_r577021789 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java ## @@ -203,5 +213,21 @@ public double

[jira] [Commented] (HBASE-25568) Upgrade Thrift jar to fix CVE-2020-13949

2021-02-16 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285330#comment-17285330 ] Pankaj Kumar commented on HBASE-25568: -- Thanks [~apurtell]. will contact the dev@thrift to check

[GitHub] [hbase] virajjasani commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
virajjasani commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779862038 @bharathv When you commit, can you please mention 4 EventTypes for which this commit is going to consider releasing unused core threads in thread pools? Maybe you can mention

[GitHub] [hbase] shahrs87 commented on a change in pull request #2945: [HBASE-25539] Add age of oldest wal metric

2021-02-16 Thread GitBox
shahrs87 commented on a change in pull request #2945: URL: https://github.com/apache/hbase/pull/2945#discussion_r576839923 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLogQueue.java ## @@ -0,0 +1,182 @@ +/* + * Licensed

[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779850080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 commented on a change in pull request #2945: [HBASE-25539] Add age of oldest wal metric

2021-02-16 Thread GitBox
shahrs87 commented on a change in pull request #2945: URL: https://github.com/apache/hbase/pull/2945#discussion_r576837115 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceLogQueue.java ## @@ -0,0 +1,83 @@ +/* + *

[GitHub] [hbase] Apache9 commented on pull request #2953: HBASE-25574 Revisit increment/append related RegionObserver methods

2021-02-16 Thread GitBox
Apache9 commented on pull request #2953: URL: https://github.com/apache/hbase/pull/2953#issuecomment-779841473 It is the new year holiday in China. Will take a look this week. Sorry for the delay. This is an automated

[jira] [Commented] (HBASE-23887) New L1 cache : AdaptiveLRU

2021-02-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285180#comment-17285180 ] Hudson commented on HBASE-23887: Results for branch master [build #212 on

[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779816536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25582) Support setting scan ReadType to be STREAM at cluster level

2021-02-16 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-25582: --- Fix Version/s: 2.5.0 3.0.0-alpha-1 > Support setting scan ReadType to be

[jira] [Updated] (HBASE-25582) Support setting scan ReadType to be STREAM at cluster level

2021-02-16 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-25582: --- Affects Version/s: 2.0.0 > Support setting scan ReadType to be STREAM at cluster level >

[jira] [Created] (HBASE-25582) Support setting scan ReadType to be STREAM at cluster level

2021-02-16 Thread Anoop Sam John (Jira)
Anoop Sam John created HBASE-25582: -- Summary: Support setting scan ReadType to be STREAM at cluster level Key: HBASE-25582 URL: https://issues.apache.org/jira/browse/HBASE-25582 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779755977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779722778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Created] (HBASE-25581) BUG - HBase native client memory leak - threads keep running after connection is closed

2021-02-16 Thread Iuliia Emelianova (Jira)
Iuliia Emelianova created HBASE-25581: - Summary: BUG - HBase native client memory leak - threads keep running after connection is closed Key: HBASE-25581 URL: https://issues.apache.org/jira/browse/HBASE-25581

[GitHub] [hbase] brfrn169 commented on pull request #2953: HBASE-25574 Revisit increment/append related RegionObserver methods

2021-02-16 Thread GitBox
brfrn169 commented on pull request #2953: URL: https://github.com/apache/hbase/pull/2953#issuecomment-779696281 @Apache9 Can you please review it when you have time? Thanks. This is an automated message from the Apache Git

[GitHub] [hbase] virajjasani commented on a change in pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
virajjasani commented on a change in pull request #2922: URL: https://github.com/apache/hbase/pull/2922#discussion_r576650821 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java ## @@ -207,6 +207,11 @@ public boolean

[GitHub] [hbase] virajjasani commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
virajjasani commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779686322 Oh Great, you are right. Thread creation should be considered only if necessary for tasks like merge regions (recent change), where we are certain that it might happen for

[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779685200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
bharathv commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779682472 > Let's also add same comment for other 3 EventTypes? Instead moved it to the actual method. Copy-pasting it to multiple places seems redundant. > If the core

[GitHub] [hbase] virajjasani commented on pull request #2922: HBASE-25547: Thread pools should release unused resources

2021-02-16 Thread GitBox
virajjasani commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-779671714 So far, we are starting off with terminating core worker threads if no tasks arrive in keepAlive time only for EventTypes: `RS_LOG_REPLAY_OPS`, `RS_PARALLEL_SEEK`,