[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802579599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bitterfox opened a new pull request #3068: HBASE-25672 Backport HBASE-25608 to branch-1

2021-03-18 Thread GitBox
bitterfox opened a new pull request #3068: URL: https://github.com/apache/hbase/pull/3068 https://issues.apache.org/jira/browse/HBASE-25672 https://issues.apache.org/jira/browse/HBASE-25608 Backport #2988 to branch-1 -- This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3066: URL: https://github.com/apache/hbase/pull/3066#issuecomment-802573111 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 17m

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-802572378 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25671) Backport HBASE-25608 to branch-2

2021-03-18 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida reassigned HBASE-25671: -- Assignee: Shinya Yoshida > Backport HBASE-25608 to branch-2 >

[GitHub] [hbase] Apache-HBase commented on pull request #3025: HBASE-25517 Support parallel balance RSGroups

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3025: URL: https://github.com/apache/hbase/pull/3025#issuecomment-802567298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
brfrn169 commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802559646 Looks the test failure in the last QA is unrelated to this PR, but I'll re-trigger the QA just in case. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] Apache-HBase commented on pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3067: URL: https://github.com/apache/hbase/pull/3067#issuecomment-802551158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22975) Add read and write QPS metrics at server level and table level

2021-03-18 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304636#comment-17304636 ] Baiqiang Zhao commented on HBASE-22975: --- Hi [~huaxiangsun],  created a subtask to add a switch. 

[jira] [Created] (HBASE-25681) Add a switch for server/table queryMeter

2021-03-18 Thread Baiqiang Zhao (Jira)
Baiqiang Zhao created HBASE-25681: - Summary: Add a switch for server/table queryMeter Key: HBASE-25681 URL: https://issues.apache.org/jira/browse/HBASE-25681 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802543486 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3042: URL: https://github.com/apache/hbase/pull/3042#issuecomment-802541730 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3042: URL: https://github.com/apache/hbase/pull/3042#issuecomment-802541532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3042: URL: https://github.com/apache/hbase/pull/3042#issuecomment-802540058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ZhaoBQ commented on pull request #3061: HBASE-25677 Server+table counters on each scan #nextRaw invocation be…

2021-03-18 Thread GitBox
ZhaoBQ commented on pull request #3061: URL: https://github.com/apache/hbase/pull/3061#issuecomment-802536065 > @ZhaoBQ I looked at readRequestsCount over in increment/append and it seemed ok to me. The increment is done on the end after all increments/appends for a row.

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597392739 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -3053,21 +3053,22 @@ private void

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597392346 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -3053,21 +3053,22 @@ private void

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597392209 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -2958,22 +2959,22 @@ private void

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597392152 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -2958,22 +2959,22 @@ private void

[GitHub] [hbase] Reidddddd commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
Reidd commented on a change in pull request #3066: URL: https://github.com/apache/hbase/pull/3066#discussion_r597392124 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -2901,16 +2901,17 @@ private void

[GitHub] [hbase] clarax commented on pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…

2021-03-18 Thread GitBox
clarax commented on pull request #3067: URL: https://github.com/apache/hbase/pull/3067#issuecomment-802532562 This is the the fix that only update table skew cost function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] clarax opened a new pull request #3067: HBASE-25625 HBASE-25625 StochasticBalancer CostFunctions needs a bett…

2021-03-18 Thread GitBox
clarax opened a new pull request #3067: URL: https://github.com/apache/hbase/pull/3067 …er way to evaluate resource distribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode

2021-03-18 Thread GitBox
javierluca commented on a change in pull request #3054: URL: https://github.com/apache/hbase/pull/3054#discussion_r597387532 ## File path: bin/graceful_stop.sh ## @@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f` if [ "$localhostname" == "$hostname" ]; then local=true

[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode

2021-03-18 Thread GitBox
javierluca commented on a change in pull request #3054: URL: https://github.com/apache/hbase/pull/3054#discussion_r597387532 ## File path: bin/graceful_stop.sh ## @@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f` if [ "$localhostname" == "$hostname" ]; then local=true

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox
ZhaoBQ commented on a change in pull request #3042: URL: https://github.com/apache/hbase/pull/3042#discussion_r597385188 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java ## @@ -2637,19 +2648,17 @@ protected static void

[GitHub] [hbase] saintstack commented on pull request #2984: HBASE-25680 Non-idempotent test in TestReplicationHFileCleaner

2021-03-18 Thread GitBox
saintstack commented on pull request #2984: URL: https://github.com/apache/hbase/pull/2984#issuecomment-802520350 Thanks @lzx404243 I fixed the subject so it points to your new JIRA. Did you see @Apache9 's comment above? Thanks -- This is an automated message from the Apache Git

[GitHub] [hbase] lzx404243 commented on pull request #2984: Remove HFile reference in TestReplicationHFileCleaner.testIsFileDeletable

2021-03-18 Thread GitBox
lzx404243 commented on pull request #2984: URL: https://github.com/apache/hbase/pull/2984#issuecomment-802518932 @saintstack I've created a jira issue for this: https://issues.apache.org/jira/browse/HBASE-25680 Thanks! -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] lzx404243 commented on a change in pull request #2984: Remove HFile reference in TestReplicationHFileCleaner.testIsFileDeletable

2021-03-18 Thread GitBox
lzx404243 commented on a change in pull request #2984: URL: https://github.com/apache/hbase/pull/2984#discussion_r597382058 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestReplicationHFileCleaner.java ## @@ -146,6 +147,7 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802512615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25680) Non-idempotent test in TestReplicationHFileCleaner

2021-03-18 Thread Zhengxi Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhengxi Li updated HBASE-25680: --- Attachment: HBASE-25680.master.001.patch > Non-idempotent test in TestReplicationHFileCleaner >

[jira] [Updated] (HBASE-25680) Non-idempotent test in TestReplicationHFileCleaner

2021-03-18 Thread Zhengxi Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhengxi Li updated HBASE-25680: --- Status: Patch Available (was: Open) > Non-idempotent test in TestReplicationHFileCleaner >

[jira] [Created] (HBASE-25680) Non-idempotent test in TestReplicationHFileCleaner

2021-03-18 Thread Zhengxi Li (Jira)
Zhengxi Li created HBASE-25680: -- Summary: Non-idempotent test in TestReplicationHFileCleaner Key: HBASE-25680 URL: https://issues.apache.org/jira/browse/HBASE-25680 Project: HBase Issue Type:

[GitHub] [hbase] YutSean opened a new pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread GitBox
YutSean opened a new pull request #3066: URL: https://github.com/apache/hbase/pull/3066 The branch-1 backport of [https://issues.apache.org/jira/browse/HBASE-25677?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel](url) -- This is an automated message from the Apache

[jira] [Commented] (HBASE-25627) HBase replication should have a metric to represent if it cannot talk to peer's zk

2021-03-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304595#comment-17304595 ] Hudson commented on HBASE-25627: Results for branch branch-2.4 [build #76 on

[jira] [Commented] (HBASE-25643) The delayed FlushRegionEntry should be removed when we need a non-delayed one

2021-03-18 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304589#comment-17304589 ] Zheng Wang commented on HBASE-25643: Thanks all for the review. [~stack][~anoop.hbase][~vjasani] >

[jira] [Commented] (HBASE-25576) Should not use HashMap (ConcurrentHashMap) or HashSet when using byte[] as a key of Map or an element of Set

2021-03-18 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304576#comment-17304576 ] Swaroopa Kadam commented on HBASE-25576: [~brfrn169] I am slightly confused here with the

[jira] [Assigned] (HBASE-25576) Should not use HashMap (ConcurrentHashMap) or HashSet when using byte[] as a key of Map or an element of Set

2021-03-18 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swaroopa Kadam reassigned HBASE-25576: -- Assignee: Swaroopa Kadam > Should not use HashMap (ConcurrentHashMap) or HashSet

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802433885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3065: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3065: URL: https://github.com/apache/hbase/pull/3065#issuecomment-802430996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] saintstack commented on a change in pull request #3065: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
saintstack commented on a change in pull request #3065: URL: https://github.com/apache/hbase/pull/3065#discussion_r597333412 ## File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/terminal/impl/batch/BatchTerminal.java ## @@ -0,0 +1,80 @@ +/** + * Licensed to

[GitHub] [hbase] brfrn169 edited a comment on pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
brfrn169 edited a comment on pull request #2641: URL: https://github.com/apache/hbase/pull/2641#issuecomment-802407800 Closing this as the QA is failing for some reason. I'll recreate a new PR for it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] brfrn169 opened a new pull request #3065: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
brfrn169 opened a new pull request #3065: URL: https://github.com/apache/hbase/pull/3065 …ch-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] brfrn169 commented on pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
brfrn169 commented on pull request #2641: URL: https://github.com/apache/hbase/pull/2641#issuecomment-802407800 Closing this as the QS is failing for some reason. I'll recreate a new PR for it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] brfrn169 closed pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2021-03-18 Thread GitBox
brfrn169 closed pull request #2641: URL: https://github.com/apache/hbase/pull/2641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-17362) HBase Backup/Restore Phase 4

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304534#comment-17304534 ] Michael Stack commented on HBASE-17362: --- I was seeing them fail in PR test runs but not now. >

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-802377923 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25548) Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor

2021-03-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304491#comment-17304491 ] Hudson commented on HBASE-25548: Results for branch branch-2.2 [build #192 on

[jira] [Commented] (HBASE-25656) Backport to branch-2.2: [HBASE-25548 Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor]

2021-03-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304490#comment-17304490 ] Hudson commented on HBASE-25656: Results for branch branch-2.2 [build #192 on

[jira] [Updated] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-18 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25679: - Affects Version/s: 2.5.0 2.4.2 > Size of log queue metric is incorrect

[jira] [Updated] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-18 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25679: - Description: In HBASE-25539 I did some refactoring for adding a new metric "oldestWalAge" and

[jira] [Updated] (HBASE-25679) Size of log queue metric is incorrect in branch-1/branch-2

2021-03-18 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25679: - Summary: Size of log queue metric is incorrect in branch-1/branch-2 (was: Size of log queue

[jira] [Created] (HBASE-25679) Size of log queue metric is incorrect in branch-1

2021-03-18 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-25679: Summary: Size of log queue metric is incorrect in branch-1 Key: HBASE-25679 URL: https://issues.apache.org/jira/browse/HBASE-25679 Project: HBase Issue

[jira] [Assigned] (HBASE-25679) Size of log queue metric is incorrect in branch-1

2021-03-18 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah reassigned HBASE-25679: Assignee: Rushabh Shah > Size of log queue metric is incorrect in branch-1 >

[GitHub] [hbase] huaxiangsun commented on pull request #3061: HBASE-25677 Server+table counters on each scan #nextRaw invocation be…

2021-03-18 Thread GitBox
huaxiangsun commented on pull request #3061: URL: https://github.com/apache/hbase/pull/3061#issuecomment-802266244 I left a comment that this can be turned on/off as a feature. This is in the data path, people may not need this on all the time. -- This is an automated message from the

[jira] [Comment Edited] (HBASE-22975) Add read and write QPS metrics at server level and table level

2021-03-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304420#comment-17304420 ] Huaxiang Sun edited comment on HBASE-22975 at 3/18/21, 8:21 PM: As a

[jira] [Commented] (HBASE-22975) Add read and write QPS metrics at server level and table level

2021-03-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304420#comment-17304420 ] Huaxiang Sun commented on HBASE-22975: -- As a feature, I think it is better to add a config knob to

[jira] [Resolved] (HBASE-25518) Support separate child regions to different region servers

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25518. --- Fix Version/s: 2.4.3 2.5.0 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] saintstack merged pull request #3001: HBASE-25518 Support separate child regions to different region servers

2021-03-18 Thread GitBox
saintstack merged pull request #3001: URL: https://github.com/apache/hbase/pull/3001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on pull request #2984: Remove HFile reference in TestReplicationHFileCleaner.testIsFileDeletable

2021-03-18 Thread GitBox
saintstack commented on pull request #2984: URL: https://github.com/apache/hbase/pull/2984#issuecomment-802228232 @lzx404243 Please see above comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-802228019 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25622) Result#compareResults should compare tags.

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304382#comment-17304382 ] Michael Stack commented on HBASE-25622: --- I just merged the branch-1 PR too (updated the fix

[jira] [Updated] (HBASE-25622) Result#compareResults should compare tags.

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25622: -- Fix Version/s: 1.7.0 > Result#compareResults should compare tags. >

[GitHub] [hbase] saintstack merged pull request #3004: HBASE-25622 Result#compareResults should compare tags.

2021-03-18 Thread GitBox
saintstack merged pull request #3004: URL: https://github.com/apache/hbase/pull/3004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-03-18 Thread GitBox
saintstack commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-802224481 Is the complaint that thrift 0.13 has been compiled w/ jdk8? There is white space complaints, the javadoc WARNINGs we can ignore since they are in generated code, can

[GitHub] [hbase] saintstack commented on a change in pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox
saintstack commented on a change in pull request #3042: URL: https://github.com/apache/hbase/pull/3042#discussion_r594684293 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java ## @@ -2637,19 +2648,17 @@ protected static void

[jira] [Resolved] (HBASE-25643) The delayed FlushRegionEntry should be removed when we need a non-delayed one

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25643. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] saintstack merged pull request #3049: HBASE-25643 The delayed FlushRegionEntry should be removed when we ne…

2021-03-18 Thread GitBox
saintstack merged pull request #3049: URL: https://github.com/apache/hbase/pull/3049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25594. --- Resolution: Fixed I pushed the below to 2.4+ {code} I pushed this to 2.3+ commit

[jira] [Reopened] (HBASE-25594) graceful_stop.sh fails to unload regions when ran at localhost

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25594: --- Reopening to apply addendum. > graceful_stop.sh fails to unload regions when ran at localhost

[GitHub] [hbase] saintstack merged pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode

2021-03-18 Thread GitBox
saintstack merged pull request #3054: URL: https://github.com/apache/hbase/pull/3054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode

2021-03-18 Thread GitBox
saintstack commented on a change in pull request #3054: URL: https://github.com/apache/hbase/pull/3054#discussion_r595394923 ## File path: bin/graceful_stop.sh ## @@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f` if [ "$localhostname" == "$hostname" ]; then local=true

[jira] [Resolved] (HBASE-25671) Backport HBASE-25608 to branch-2

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25671. --- Fix Version/s: 2.4.3 2.5.0 Hadoop Flags: Reviewed Assignee:

[GitHub] [hbase] saintstack merged pull request #3058: HBASE-25671 Backport HBASE-25608 to branch-2

2021-03-18 Thread GitBox
saintstack merged pull request #3058: URL: https://github.com/apache/hbase/pull/3058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (HBASE-25674) RegionInfo.parseFrom(DataInputStream) sometimes fails to read the protobuf magic marker

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25674. --- Fix Version/s: 2.4.3 2.3.5 2.5.0

[jira] [Updated] (HBASE-25674) RegionInfo.parseFrom(DataInputStream) sometimes fails to read the protobuf magic marker

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25674: -- Status: In Progress (was: Patch Available) > RegionInfo.parseFrom(DataInputStream) sometimes

[GitHub] [hbase] saintstack merged pull request #3062: HBASE-25674 - RegionInfo.parseFrom(DataInputStream) sometimes fails to read the protobuf magic marker

2021-03-18 Thread GitBox
saintstack merged pull request #3062: URL: https://github.com/apache/hbase/pull/3062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on a change in pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-03-18 Thread GitBox
saintstack commented on a change in pull request #3063: URL: https://github.com/apache/hbase/pull/3063#discussion_r597154790 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java ## @@ -172,9 +172,9 @@ new

[jira] [Commented] (HBASE-25677) Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304346#comment-17304346 ] Michael Stack commented on HBASE-25677: --- Thank you for reviews [~reidchan] and [~DeanZ] >

[jira] [Resolved] (HBASE-25677) Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25677. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2.3+. > Server+table

[jira] [Updated] (HBASE-25677) Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

2021-03-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25677: -- Fix Version/s: 2.4.3 2.3.5 2.5.0

[jira] [Resolved] (HBASE-25639) meta replica state is not respected during active master switch

2021-03-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun resolved HBASE-25639. -- Fix Version/s: 2.3.5 Resolution: Fixed > meta replica state is not respected during

[jira] [Commented] (HBASE-25639) meta replica state is not respected during active master switch

2021-03-18 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304341#comment-17304341 ] Huaxiang Sun commented on HBASE-25639: -- As branch-2.2 is approaching EOL, not going to back port to

[GitHub] [hbase] huaxiangsun merged pull request #3052: HBASE-25639 meta replica state is not respected during active master …

2021-03-18 Thread GitBox
huaxiangsun merged pull request #3052: URL: https://github.com/apache/hbase/pull/3052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack merged pull request #3061: HBASE-25677 Server+table counters on each scan #nextRaw invocation be…

2021-03-18 Thread GitBox
saintstack merged pull request #3061: URL: https://github.com/apache/hbase/pull/3061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] saintstack commented on pull request #3061: HBASE-25677 Server+table counters on each scan #nextRaw invocation be…

2021-03-18 Thread GitBox
saintstack commented on pull request #3061: URL: https://github.com/apache/hbase/pull/3061#issuecomment-802189258 @ZhaoBQ I looked at readRequestsCount over in increment/append and it seemed ok to me. The increment is done on the end after all increments/appends for a row.

[jira] [Commented] (HBASE-25627) HBase replication should have a metric to represent if it cannot talk to peer's zk

2021-03-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304322#comment-17304322 ] Hudson commented on HBASE-25627: Results for branch branch-2 [build #203 on

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-802161724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802161236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-802064961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25673) Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader

2021-03-18 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304236#comment-17304236 ] Anoop Sam John commented on HBASE-25673: Thanks for the reviews. Pushed to branch-2 and master.

[jira] [Resolved] (HBASE-25673) Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader

2021-03-18 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John resolved HBASE-25673. Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[jira] [Resolved] (HBASE-25656) Backport to branch-2.2: [HBASE-25548 Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor]

2021-03-18 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25656. -- Resolution: Fixed > Backport to branch-2.2: [HBASE-25548 Optionally allow

[jira] [Updated] (HBASE-25656) Backport to branch-2.2: [HBASE-25548 Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor]

2021-03-18 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25656: - Fix Version/s: 2.2.7 > Backport to branch-2.2: [HBASE-25548 Optionally allow

[GitHub] [hbase] wchevreuil merged pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

2021-03-18 Thread GitBox
wchevreuil merged pull request #3055: URL: https://github.com/apache/hbase/pull/3055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] anoopsjohn merged pull request #3057: HBASE-25673 Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader

2021-03-18 Thread GitBox
anoopsjohn merged pull request #3057: URL: https://github.com/apache/hbase/pull/3057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] virajjasani commented on pull request #3057: HBASE-25673 Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader

2021-03-18 Thread GitBox
virajjasani commented on pull request #3057: URL: https://github.com/apache/hbase/pull/3057#issuecomment-802020568 Updated PR title to include Jira number -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #3059: HBASE-25670 Backport HBASE-25665 to branch-1

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3059: URL: https://github.com/apache/hbase/pull/3059#issuecomment-801991474 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-801984970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3064: HBASE-25678 Support nonce operations for Increment/Append in RowMutat…

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #3064: URL: https://github.com/apache/hbase/pull/3064#issuecomment-801969501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2021-03-18 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-801963343 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

  1   2   >