[GitHub] [hbase] Apache-HBase commented on pull request #3239: HBASE-25850 Fix spotbugs warnings on branch-2

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3239: URL: https://github.com/apache/hbase/pull/3239#issuecomment-834084982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] xiaozhang0319 opened a new pull request #3239: HBASE-25850 Fix spotbugs warnings on branch-2

2021-05-06 Thread GitBox
xiaozhang0319 opened a new pull request #3239: URL: https://github.com/apache/hbase/pull/3239 Fix spotbugs warnings on branch-2. cc @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340565#comment-17340565 ] Reid Chan commented on HBASE-25858: --- Thanks Andrew. I tried the optional tag then built it with both

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340551#comment-17340551 ] Duo Zhang commented on HBASE-25774: --- {quote} We can revert it in 2.3.5 and make a 2.3.5.1 with just

[GitHub] [hbase] ZhaoBQ commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-06 Thread GitBox
ZhaoBQ commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-834041587 Create an issue HBASE-25861 to resolve the problem first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-06 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340541#comment-17340541 ] Baiqiang Zhao commented on HBASE-25861: --- Assign this issue to me temporarily. Everyone is welcome

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340539#comment-17340539 ] Andrew Kyle Purtell commented on HBASE-25774: - We can revert it in 2.3.5 and make a 2.3.5.1

[jira] [Created] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-06 Thread Baiqiang Zhao (Jira)
Baiqiang Zhao created HBASE-25861: - Summary: Correct the usage of Configuration#addDeprecation Key: HBASE-25861 URL: https://issues.apache.org/jira/browse/HBASE-25861 Project: HBase Issue

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340536#comment-17340536 ] Duo Zhang commented on HBASE-25774: --- It has already been released in 2.3.5 so I do not think we could

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340534#comment-17340534 ] Andrew Kyle Purtell commented on HBASE-25774: - Better to be sure. Let’s revert and reopen

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340521#comment-17340521 ] Duo Zhang commented on HBASE-25774: --- Skimmed the code, I do not think it is easy to fix as we call

[jira] [Commented] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340519#comment-17340519 ] Hudson commented on HBASE-25847: Results for branch branch-2.4 [build #111 on

[jira] [Commented] (HBASE-25854) Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340520#comment-17340520 ] Hudson commented on HBASE-25854: Results for branch branch-2.4 [build #111 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340510#comment-17340510 ] Duo Zhang commented on HBASE-25774: --- So it does not only effect peer modification related procedures.

[jira] [Updated] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25774: -- Summary: ServerManager.getOnlineServer may miss some region servers when refreshing state in some

[jira] [Commented] (HBASE-25850) Fix spotbugs warnings on branch-2

2021-05-06 Thread Xiao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340508#comment-17340508 ] Xiao Zhang commented on HBASE-25850: Now fix > Fix spotbugs warnings on branch-2 >

[jira] [Commented] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340507#comment-17340507 ] Duo Zhang commented on HBASE-25774: --- OK, the problem is introduced by HBASE-25032, so the only

[jira] [Commented] (HBASE-25850) Fix spotbugs warnings on branch-2

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340497#comment-17340497 ] Duo Zhang commented on HBASE-25850: --- Any updates here? Thanks. > Fix spotbugs warnings on branch-2 >

[GitHub] [hbase] Apache-HBase commented on pull request #3238: HBASE-25860 Add metric for successful wal roll requests.

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3238: URL: https://github.com/apache/hbase/pull/3238#issuecomment-833942863 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-06 Thread GitBox
ndimiduk commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-833926085 > So do we need to create another issue to correct this wrong usage first? First or in addition to, I think is up to you. It looks like you've identified an issue in our

[GitHub] [hbase] Apache-HBase commented on pull request #3238: HBASE-25860 Add metric for successful wal roll requests.

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3238: URL: https://github.com/apache/hbase/pull/3238#issuecomment-833906674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3238: HBASE-25860 Add metric for successful wal roll requests.

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3238: URL: https://github.com/apache/hbase/pull/3238#issuecomment-833828283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 opened a new pull request #3238: HBASE-25860 Add metric for successful wal roll requests.

2021-05-06 Thread GitBox
shahrs87 opened a new pull request #3238: URL: https://github.com/apache/hbase/pull/3238 https://issues.apache.org/jira/browse/HBASE-25860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340352#comment-17340352 ] Hudson commented on HBASE-25847: Results for branch branch-2 [build #243 on

[jira] [Commented] (HBASE-25843) Move master http-related code into o.a.h.h.master.http

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340351#comment-17340351 ] Hudson commented on HBASE-25843: Results for branch branch-2 [build #243 on

[GitHub] [hbase] Apache-HBase commented on pull request #3236: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3236: URL: https://github.com/apache/hbase/pull/3236#issuecomment-833716373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3236: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3236: URL: https://github.com/apache/hbase/pull/3236#issuecomment-833708719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3237: HBASE-25858 [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3237: URL: https://github.com/apache/hbase/pull/3237#issuecomment-833676960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Commented] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340305#comment-17340305 ] Andrew Kyle Purtell commented on HBASE-25858: - You can make the dependency optional in the

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340304#comment-17340304 ] Andrew Kyle Purtell commented on HBASE-25831: - Thanks for seeing this through [~reidchan] >

[jira] [Comment Edited] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340302#comment-17340302 ] Andrew Kyle Purtell edited comment on HBASE-25774 at 5/6/21, 4:40 PM:

[jira] [Commented] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340302#comment-17340302 ] Andrew Kyle Purtell commented on HBASE-25774: - Sure, 2.4.3 hasn't gone out yet and I'm going

[jira] [Commented] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340297#comment-17340297 ] Duo Zhang commented on HBASE-25774: --- [~apurtell] Do you think we should include this fix in 2.4.3? Or

[jira] [Commented] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340294#comment-17340294 ] Duo Zhang commented on HBASE-25774: --- Wrote a UT to reproduce the problem.

[jira] [Resolved] (HBASE-25829) SPLIT state detritus

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25829. - Fix Version/s: (was: 2.4.3) (was: 2.5.0)

[jira] [Updated] (HBASE-25854) Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-06 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25854: Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was:

[GitHub] [hbase] apurtell merged pull request #3234: HBASE-25854 Remove redundant AM in-memory state changes in CatalogJanitor

2021-05-06 Thread GitBox
apurtell merged pull request #3234: URL: https://github.com/apache/hbase/pull/3234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Reidddddd opened a new pull request #3237: HBASE-25858 [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread GitBox
Reidd opened a new pull request #3237: URL: https://github.com/apache/hbase/pull/3237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3220: URL: https://github.com/apache/hbase/pull/3220#issuecomment-833640565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340274#comment-17340274 ] Reid Chan commented on HBASE-25858: --- maven profile seems possible, let me try. > [branch-1]

[jira] [Commented] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340271#comment-17340271 ] Rushabh Shah commented on HBASE-25612: -- Thank you [~reidchan] for the review and commit ! Thank you

[jira] [Updated] (HBASE-25851) Make LoadBalancer not extend Configurable interface

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25851: -- Component/s: Balancer > Make LoadBalancer not extend Configurable interface >

[jira] [Resolved] (HBASE-25851) Make LoadBalancer not extend Configurable interface

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25851. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~niuyulin]

[jira] [Updated] (HBASE-25851) Make LoadBalancer not extend Configurable interface

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25851: -- Environment: (was: M) > Make LoadBalancer not extend Configurable interface >

[GitHub] [hbase] Apache9 merged pull request #3235: HBASE-25851 Make LoadBalancer not extend Configurable interface (#3233)

2021-05-06 Thread GitBox
Apache9 merged pull request #3235: URL: https://github.com/apache/hbase/pull/3235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340266#comment-17340266 ] Hudson commented on HBASE-25831: Results for branch branch-1 [build #122 on

[jira] [Commented] (HBASE-25741) Deadlock during peer cleanup with NoNodeException

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340265#comment-17340265 ] Hudson commented on HBASE-25741: Results for branch branch-1 [build #122 on

[jira] [Updated] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25612: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hbase] Reidddddd merged pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
Reidd merged pull request #3222: URL: https://github.com/apache/hbase/pull/3222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340262#comment-17340262 ] Reid Chan commented on HBASE-25858: --- Is it possible to include dependency when satisfying some

[GitHub] [hbase] Apache9 commented on a change in pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-06 Thread GitBox
Apache9 commented on a change in pull request #3220: URL: https://github.com/apache/hbase/pull/3220#discussion_r627521865 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java ## @@ -230,6 +230,10 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3236: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3236: URL: https://github.com/apache/hbase/pull/3236#issuecomment-833605160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-06 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-25860: Summary: Add metric for successful wal roll requests. Key: HBASE-25860 URL: https://issues.apache.org/jira/browse/HBASE-25860 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3222: URL: https://github.com/apache/hbase/pull/3222#issuecomment-833602595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3220: URL: https://github.com/apache/hbase/pull/3220#issuecomment-833573320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] catalin-luca opened a new pull request #3236: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread GitBox
catalin-luca opened a new pull request #3236: URL: https://github.com/apache/hbase/pull/3236 ` DataInputStream.read(byte[lengthOfPBMagic])`Does not guarantee to read `lengthOfPBMagic` bytes. Multiple read calls need to be issued. -- This is an automated message from the Apache

[jira] [Resolved] (HBASE-25856) sorry for my mistake, could someone delete it.

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-25856. --- Resolution: Invalid > sorry for my mistake, could someone delete it. >

[jira] [Reopened] (HBASE-25856) sorry for my mistake, could someone delete it.

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan reopened HBASE-25856: --- > sorry for my mistake, could someone delete it. > -- > >

[GitHub] [hbase] Apache-HBase commented on pull request #3235: HBASE-25851 Make LoadBalancer not extend Configurable interface (#3233)

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3235: URL: https://github.com/apache/hbase/pull/3235#issuecomment-833540707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] shahrs87 commented on pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
shahrs87 commented on pull request #3222: URL: https://github.com/apache/hbase/pull/3222#issuecomment-833536743 ``` [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ hbase-server --- [INFO] [INFO] --- [INFO] T E

[jira] [Commented] (HBASE-25843) Move master http-related code into o.a.h.h.master.http

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340215#comment-17340215 ] Hudson commented on HBASE-25843: Results for branch master [build #284 on

[jira] [Commented] (HBASE-25847) More DEBUG and TRACE level logging in CatalogJanitor and HbckChore

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340216#comment-17340216 ] Hudson commented on HBASE-25847: Results for branch master [build #284 on

[jira] [Commented] (HBASE-25834) Remove balanceTable method from LoadBalancer interface

2021-05-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340213#comment-17340213 ] Hudson commented on HBASE-25834: Results for branch master [build #284 on

[jira] [Updated] (HBASE-25859) Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread Constantin-Catalin Luca (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Constantin-Catalin Luca updated HBASE-25859: Description: The Reference class incorrectly parses the protobuf magic

[jira] [Comment Edited] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340177#comment-17340177 ] Rushabh Shah edited comment on HBASE-25612 at 5/6/21, 1:06 PM: --- >

[jira] [Resolved] (HBASE-25856) sorry for my mistake, could someone delete it.

2021-05-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah resolved HBASE-25856. -- Resolution: Invalid > sorry for my mistake, could someone delete it. >

[GitHub] [hbase] Apache-HBase commented on pull request #3220: HBASE-25837 TestRollingRestart is flaky

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3220: URL: https://github.com/apache/hbase/pull/3220#issuecomment-833488143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3235: HBASE-25851 Make LoadBalancer not extend Configurable interface (#3233)

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3235: URL: https://github.com/apache/hbase/pull/3235#issuecomment-833486484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on a change in pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
shahrs87 commented on a change in pull request #3222: URL: https://github.com/apache/hbase/pull/3222#discussion_r627366894 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java ## @@ -405,4 +418,77 @@ public RecoverableZooKeeper

[jira] [Comment Edited] (HBASE-25857) HBase bulk import fails with exitCode -100

2021-05-06 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340180#comment-17340180 ] ZFabrik edited comment on HBASE-25857 at 5/6/21, 12:19 PM: --- I think one

[jira] [Comment Edited] (HBASE-25857) HBase bulk import fails with exitCode -100

2021-05-06 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340180#comment-17340180 ] ZFabrik edited comment on HBASE-25857 at 5/6/21, 12:19 PM: --- I think one

[jira] [Commented] (HBASE-25857) HBase bulk import fails with exitCode -100

2021-05-06 Thread ZFabrik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340180#comment-17340180 ] ZFabrik commented on HBASE-25857: - I think one problem is, that `CellSortImporter` emits the whole cell

[jira] [Comment Edited] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340177#comment-17340177 ] Rushabh Shah edited comment on HBASE-25612 at 5/6/21, 12:17 PM: >

[jira] [Commented] (HBASE-25612) HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340177#comment-17340177 ] Rushabh Shah commented on HBASE-25612: -- > Currently aborting master sounds aggressive, when backup

[jira] [Created] (HBASE-25859) Reference class incorrectly parses the protobuf magic marker

2021-05-06 Thread Constantin-Catalin Luca (Jira)
Constantin-Catalin Luca created HBASE-25859: --- Summary: Reference class incorrectly parses the protobuf magic marker Key: HBASE-25859 URL: https://issues.apache.org/jira/browse/HBASE-25859

[GitHub] [hbase] shahrs87 commented on a change in pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
shahrs87 commented on a change in pull request #3222: URL: https://github.com/apache/hbase/pull/3222#discussion_r627357118 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java ## @@ -132,42 +137,57 @@ public void

[jira] [Commented] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340145#comment-17340145 ] Reid Chan commented on HBASE-25858: --- [~andrew.purt...@gmail.com] > [branch-1] hbase-assembly module

[jira] [Updated] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25858: -- Description: {code} [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve

[jira] [Created] (HBASE-25858) [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8

2021-05-06 Thread Reid Chan (Jira)
Reid Chan created HBASE-25858: - Summary: [branch-1] hbase-assembly module includes hbase-thrift only when using jdk8 Key: HBASE-25858 URL: https://issues.apache.org/jira/browse/HBASE-25858 Project: HBase

[jira] [Resolved] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-25831. --- Fix Version/s: 1.7.0 Hadoop Flags: Reviewed Resolution: Fixed > [branch-1] remove

[jira] [Commented] (HBASE-25831) [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check

2021-05-06 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340143#comment-17340143 ] Reid Chan commented on HBASE-25831: --- Checked, hbase-example is clean now. One last module

[GitHub] [hbase] Apache-HBase commented on pull request #3222: HBASE-25612 [branch-1] HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3222: URL: https://github.com/apache/hbase/pull/3222#issuecomment-833426857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3235: HBASE-25851 Make LoadBalancer not extend Configurable interface (#3233)

2021-05-06 Thread GitBox
Apache-HBase commented on pull request #3235: URL: https://github.com/apache/hbase/pull/3235#issuecomment-833420773 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25857) HBase bulk import fails with exitCode -100

2021-05-06 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340132#comment-17340132 ] Wellington Chevreuil commented on HBASE-25857: -- Please use HBase Dev List for such

[GitHub] [hbase] Apache9 opened a new pull request #3235: HBASE-25851 Make LoadBalancer not extend Configurable interface (#3233)

2021-05-06 Thread GitBox
Apache9 opened a new pull request #3235: URL: https://github.com/apache/hbase/pull/3235 Signed-off-by: Yulin Niu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Created] (HBASE-25857) HBase bulk import fails with exitCode -100

2021-05-06 Thread ZFabrik (Jira)
ZFabrik created HBASE-25857: --- Summary: HBase bulk import fails with exitCode -100 Key: HBASE-25857 URL: https://issues.apache.org/jira/browse/HBASE-25857 Project: HBase Issue Type: Bug Affects

[GitHub] [hbase] Apache9 merged pull request #3233: HBASE-25851 Make LoadBalancer not extend Configurable interface

2021-05-06 Thread GitBox
Apache9 merged pull request #3233: URL: https://github.com/apache/hbase/pull/3233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache9 commented on a change in pull request #3233: HBASE-25851 Make LoadBalancer not extend Configurable interface

2021-05-06 Thread GitBox
Apache9 commented on a change in pull request #3233: URL: https://github.com/apache/hbase/pull/3233#discussion_r627141725 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -100,9 +99,11 @@ protected

[GitHub] [hbase] ZhaoBQ commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-06 Thread GitBox
ZhaoBQ commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-833286386 At the beginning, I imitated other deprecated configurations and tried to use Configuration.addDeprecation(), I found that our use of Configuration.addDeprecation() was wrong. The

[GitHub] [hbase] ZhaoBQ edited a comment on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-06 Thread GitBox
ZhaoBQ edited a comment on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-833219457 Here is my test for Configuration.addDeprecation(). Suppose we define the following configuration: hbase-site.xml: deprecate.conf99 hbase-default.xml:

[GitHub] [hbase] ZhaoBQ edited a comment on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-06 Thread GitBox
ZhaoBQ edited a comment on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-833219457 Here is my test for Configuration.addDeprecation(). Suppose we define the following configuration: hbase-site.xml: deprecate.conf99 hbase-default.xml:

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3233: HBASE-25851 Make LoadBalancer not extend Configurable interface

2021-05-06 Thread GitBox
nyl3532016 commented on a change in pull request #3233: URL: https://github.com/apache/hbase/pull/3233#discussion_r627129650 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java ## @@ -100,9 +99,11 @@ protected

[jira] [Updated] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25774: -- Summary: AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

[jira] [Updated] (HBASE-25774) AbstractPeerProcedure.refreshPeer may miss some region servers and cause inconsistency

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25774: -- Priority: Critical (was: Major) > AbstractPeerProcedure.refreshPeer may miss some region servers and

[jira] [Updated] (HBASE-25774) TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is flaky

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25774: -- Issue Type: Bug (was: Improvement) > TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is

[jira] [Commented] (HBASE-25774) TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is flaky

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340016#comment-17340016 ] Duo Zhang commented on HBASE-25774: --- OK, I think I found a possible race here. We will use

[jira] [Updated] (HBASE-25774) TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is flaky

2021-05-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25774: -- Component/s: Replication > TestSyncReplicationStandbyKillRS#testStandbyKillRegionServer is flaky >