[GitHub] [hbase] Apache-HBase commented on pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3202: URL: https://github.com/apache/hbase/pull/3202#issuecomment-837872302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837847210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837831402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837823204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] rahulLiving commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-10 Thread GitBox
rahulLiving commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-837813571 Hi @ndimiduk I need to test out this change once, after addressing some comments. I was out for sometime, hence couldn't do it and thus closed for time being. I'll get it to

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837776421 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3202: URL: https://github.com/apache/hbase/pull/3202#issuecomment-837775180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837773079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3202: URL: https://github.com/apache/hbase/pull/3202#issuecomment-837766619 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3202: URL: https://github.com/apache/hbase/pull/3202#issuecomment-837765986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25858) [branch-1] make hbase-thrift optional in hbase-assembly module

2021-05-10 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342273#comment-17342273 ] Reid Chan commented on HBASE-25858: --- Try merging, FYI [~apurtell] > [branch-1] make hbase-thrift

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837688241 Rolled up the first round of review feedback into d4d707d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629810127 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -241,10 +246,27 @@ public void write(Cell cell)

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-837684227 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-837677173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837666043 I have some changes coming soon. Accepted @bharathv 's argument that unconditionally compressing values if value compression is enabled is fine even if some value cases

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837666043 I have some changes coming soon. Accepted @bharathv 's argument that unconditionally compressing values if value compression is enabled is fine even if some value cases may not

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629802049 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629801863 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -241,10 +246,27 @@ public void write(Cell cell)

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629801332 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -302,14 +343,28 @@ protected Cell parseCell()

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629801332 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -302,14 +343,28 @@ protected Cell parseCell()

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837655575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-837638994 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3246: URL: https://github.com/apache/hbase/pull/3246#issuecomment-837636720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] rda3mon commented on a change in pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
rda3mon commented on a change in pull request #3246: URL: https://github.com/apache/hbase/pull/3246#discussion_r629784728 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java ## @@ -295,6 +295,11 @@ public void

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629779970 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629779580 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629779580 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629779580 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] Apache9 commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache9 commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837580362 > > So we will only compress value? > > This is an enhancement to existing WAL compression. As you know the existing WAL compression already compresses other aspects of WAL

[GitHub] [hbase] Apache-HBase commented on pull request #3251: HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3251: URL: https://github.com/apache/hbase/pull/3251#issuecomment-837580124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
Apache9 commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629777261 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629772178 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -302,14 +343,28 @@ protected Cell parseCell()

[GitHub] [hbase] Apache-HBase commented on pull request #3251: HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3251: URL: https://github.com/apache/hbase/pull/3251#issuecomment-837558899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-05-10 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342205#comment-17342205 ] Bharath Vissapragada commented on HBASE-25032: -- Oops, this patch was committed on 25th

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629763436 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629763212 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -302,14 +343,28 @@ protected Cell parseCell()

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629759791 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +278,26 @@ public void write(Cell cell)

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629761476 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,7 @@ message WALHeader { optional bool

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629760897 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629760196 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -34,21 +36,49 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629759981 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +278,26 @@ public void write(Cell cell)

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629759791 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +278,26 @@ public void write(Cell cell)

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,7 @@ message WALHeader { optional bool

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,7 @@ message WALHeader { optional bool

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629757734 ## File path: hbase-protocol-shaded/src/main/protobuf/server/region/WAL.proto ## @@ -32,6 +32,7 @@ message WALHeader { optional bool

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629757222 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -241,10 +246,27 @@ public void write(Cell cell)

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837518016 > Is it reasonable to always use the same compressor all the time for WALs? It strikes me that operators make an explicit choice about the compression used in their

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837518016 > Is it reasonable to always use the same compressor all the time for WALs? It strikes me that operators make an explicit choice about the compression used in their tables, so

[GitHub] [hbase] Apache-HBase commented on pull request #3242: HBASE-25867 Extra doc around ITBLL

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3242: URL: https://github.com/apache/hbase/pull/3242#issuecomment-837517120 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25855) [hbase-thirdparty] Fix typo in jersey relocation path

2021-05-10 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342201#comment-17342201 ] Sean Busbey commented on HBASE-25855: - ah I see. 3.5.0 was the htrace replacement module. that's

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837512098 > There is a potential performance improvement here. We could create a Deflater/Inflater pair per column family. This idea didn't pan out. It makes compression in

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837512098 bq. There is a potential performance improvement here. We could create a Deflater/Inflater pair per column family. This idea didn't pan out. It makes compression in my

[jira] [Assigned] (HBASE-25855) [hbase-thirdparty] Fix typo in jersey relocation path

2021-05-10 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-25855: --- Assignee: Nick Dimiduk (was: Sean Busbey) > [hbase-thirdparty] Fix typo in jersey

[jira] [Assigned] (HBASE-25855) [hbase-thirdparty] Fix typo in jersey relocation path

2021-05-10 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-25855: --- Assignee: Sean Busbey (was: Nick Dimiduk) > [hbase-thirdparty] Fix typo in jersey

[GitHub] [hbase-thirdparty] busbey commented on a change in pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
busbey commented on a change in pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629751088 ## File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml ## @@ -0,0 +1,110 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] [hbase-thirdparty] ndimiduk commented on a change in pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629746479 ## File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml ## @@ -0,0 +1,110 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] [hbase] ndimiduk commented on pull request #3063: HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name

2021-05-10 Thread GitBox
ndimiduk commented on pull request #3063: URL: https://github.com/apache/hbase/pull/3063#issuecomment-837478253 Hi @rahulLiving , I noticed you closed this PR. Are you planning to take this one in a different direction? -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #3250: HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3250: URL: https://github.com/apache/hbase/pull/3250#issuecomment-837463452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [hbase] saintstack commented on a change in pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-10 Thread GitBox
saintstack commented on a change in pull request #3249: URL: https://github.com/apache/hbase/pull/3249#discussion_r629734904 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1601,6 +1601,89 @@ */ public static final int

[GitHub] [hbase] Apache-HBase commented on pull request #3242: HBASE-25867 Extra doc around ITBLL

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3242: URL: https://github.com/apache/hbase/pull/3242#issuecomment-837454813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #3246: HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…

2021-05-10 Thread GitBox
saintstack commented on a change in pull request #3246: URL: https://github.com/apache/hbase/pull/3246#discussion_r629730178 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java ## @@ -295,6 +295,11 @@ public void

[GitHub] [hbase] saintstack commented on a change in pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-10 Thread GitBox
saintstack commented on a change in pull request #3248: URL: https://github.com/apache/hbase/pull/3248#discussion_r629719036 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java ## @@ -59,10 +59,11 @@ */ @Deprecated String

[GitHub] [hbase] ndimiduk commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
ndimiduk commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-837437980 Oh, one other comment I forgot to mention before hitting submit. Is it reasonable to always use the same compressor all the time for WALs? It strikes me that operators make an

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629712475 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java ## @@ -230,6 +230,11 @@ public static long getKeyDataStructureSize(int

[GitHub] [hbase] shahrs87 commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
shahrs87 commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629711573 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +278,26 @@ public void write(Cell cell)

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-05-10 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342162#comment-17342162 ] Huaxiang Sun commented on HBASE-25032: -- Yeah, no new release is needed for 2.3.*. > Wait for

[GitHub] [hbase] shahrs87 commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-10 Thread GitBox
shahrs87 commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r629708006 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -256,6 +278,26 @@ public void write(Cell cell)

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837377636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Updated] (HBASE-25855) [hbase-thirdparty] Fix typo in jersey relocation path

2021-05-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25855: - Resolution: Fixed Status: Resolved (was: Patch Available) > [hbase-thirdparty] Fix

[GitHub] [hbase] Apache-HBase commented on pull request #3251: HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3251: URL: https://github.com/apache/hbase/pull/3251#issuecomment-837357330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25855) [hbase-thirdparty] Fix typo in jersey relocation path

2021-05-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25855: - Summary: [hbase-thirdparty] Fix typo in jersey relocation path (was: Fix typo in jersey

[jira] [Updated] (HBASE-25855) Fix typo in jersey relocation path

2021-05-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25855: - Fix Version/s: (was: thirdparty-3.5.1) thirdparty-4.0.0 > Fix typo in

[jira] [Commented] (HBASE-25855) Fix typo in jersey relocation path

2021-05-10 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342148#comment-17342148 ] Nick Dimiduk commented on HBASE-25855: -- It appears to me that hbase-core has not moved onto 3.5.x

[GitHub] [hbase] Apache-HBase commented on pull request #3250: HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3250: URL: https://github.com/apache/hbase/pull/3250#issuecomment-837331291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3242: HBASE-25867 Extra doc around ITBLL

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3242: URL: https://github.com/apache/hbase/pull/3242#issuecomment-837320433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342130#comment-17342130 ] Andrew Kyle Purtell commented on HBASE-25032: - Good, so no release is affected and we can

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342127#comment-17342127 ] Michael Stack commented on HBASE-25774: --- Thanks for figuring the race [~zhangduo] (My bad too for

[jira] [Updated] (HBASE-25876) Add retry if we fail to read all bytes of the protobuf magic marker

2021-05-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25876: -- Priority: Trivial (was: Major) > Add retry if we fail to read all bytes of the protobuf

[jira] [Commented] (HBASE-25876) Add retry if we fail to read all bytes of the protobuf magic marker

2021-05-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342125#comment-17342125 ] Michael Stack commented on HBASE-25876: --- Just two places (thought there were more). Trivial.

[GitHub] [hbase] saintstack opened a new pull request #3251: HBASE-25876 Add retry if we fail to read all bytes of the protobuf ma…

2021-05-10 Thread GitBox
saintstack opened a new pull request #3251: URL: https://github.com/apache/hbase/pull/3251 …gic marker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25875: - Fix Version/s: 3.0.0-alpha-1 Status: Patch Available (was: In Progress) >

[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #3243: URL: https://github.com/apache/hbase/pull/3243#discussion_r629644198 ## File path: hbase-rest/pom.xml ## @@ -160,7 +151,6 @@ org.apache.hbase hbase-protocol-shaded - jar Review comment: Yes,

[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #3243: URL: https://github.com/apache/hbase/pull/3243#discussion_r629645829 ## File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/RowResourceBase.java ## @@ -18,22 +18,16 @@ package org.apache.hadoop.hbase.rest;

[GitHub] [hbase-thirdparty] busbey commented on a change in pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
busbey commented on a change in pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629645813 ## File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml ## @@ -0,0 +1,110 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #3243: URL: https://github.com/apache/hbase/pull/3243#discussion_r629645403 ## File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java ## @@ -18,22 +17,19 @@ */ package

[GitHub] [hbase] Apache-HBase commented on pull request #3242: HBASE-25867 Extra doc around ITBLL

2021-05-10 Thread GitBox
Apache-HBase commented on pull request #3242: URL: https://github.com/apache/hbase/pull/3242#issuecomment-837244127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 opened a new pull request #3250: HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread GitBox
pankaj72981 opened a new pull request #3250: URL: https://github.com/apache/hbase/pull/3250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Work started] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25875 started by Pankaj Kumar. > RegionServer failed to start due to IllegalThreadStateException in >

[GitHub] [hbase-thirdparty] busbey commented on pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
busbey commented on pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837242913 > > Since the relocated jaxrs provider is intimately tied to our use of jersey, can we fold this into our packaged relocation of jersey in the `hbase-shaded-jersey` module?

[GitHub] [hbase-thirdparty] ndimiduk commented on pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
ndimiduk commented on pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#issuecomment-837239785 > Since the relocated jaxrs provider is intimately tied to our use of jersey, can we fold this into our packaged relocation of jersey in the `hbase-shaded-jersey` module?

[jira] [Created] (HBASE-25876) Add retry if we fail to read all bytes of the protobuf magic marker

2021-05-10 Thread Michael Stack (Jira)
Michael Stack created HBASE-25876: - Summary: Add retry if we fail to read all bytes of the protobuf magic marker Key: HBASE-25876 URL: https://issues.apache.org/jira/browse/HBASE-25876 Project: HBase

[GitHub] [hbase-thirdparty] ndimiduk commented on a change in pull request #51: HBASE-25863 Shade javax.ws.rs package for use with shaded Jersey

2021-05-10 Thread GitBox
ndimiduk commented on a change in pull request #51: URL: https://github.com/apache/hbase-thirdparty/pull/51#discussion_r629642048 ## File path: hbase-shaded-jackson-jaxrs-json-provider/pom.xml ## @@ -0,0 +1,110 @@ + +http://maven.apache.org/POM/4.0.0;

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342113#comment-17342113 ] Pankaj Kumar commented on HBASE-25875: -- NettyRpcServer should start the secret manager in

[jira] [Resolved] (HBASE-25859) Reference class incorrectly parses the protobuf magic marker

2021-05-10 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25859. --- Fix Version/s: 2.4.4 2.5.0 3.0.0-alpha-1 Hadoop

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-10 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342111#comment-17342111 ] Pankaj Kumar commented on HBASE-25875: -- This is a race condition problem, where LeaderElector is

[GitHub] [hbase] saintstack merged pull request #3236: HBASE-25859 Reference class incorrectly parses the protobuf magic marker

2021-05-10 Thread GitBox
saintstack merged pull request #3236: URL: https://github.com/apache/hbase/pull/3236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

  1   2   >