[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845665536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3289: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3289: URL: https://github.com/apache/hbase/pull/3289#issuecomment-845649532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3288: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3288: URL: https://github.com/apache/hbase/pull/3288#issuecomment-845646683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845643554 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845641118 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845640997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ZhaoBQ commented on pull request #3139: HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.coun…

2021-05-20 Thread GitBox
ZhaoBQ commented on pull request #3139: URL: https://github.com/apache/hbase/pull/3139#issuecomment-845640359 HBASE-25861 is resolved, and I modified this PR. Please review @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] ZhaoBQ commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-20 Thread GitBox
ZhaoBQ commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845635580 The failed tests seem unrelated, rebase the code and retry the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] sandeepvinayak opened a new pull request #3289: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
sandeepvinayak opened a new pull request #3289: URL: https://github.com/apache/hbase/pull/3289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] sandeepvinayak opened a new pull request #3288: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
sandeepvinayak opened a new pull request #3288: URL: https://github.com/apache/hbase/pull/3288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
ZhaoBQ commented on a change in pull request #3106: URL: https://github.com/apache/hbase/pull/3106#discussion_r636612233 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java ## @@ -631,6 +631,10 @@ public void

[GitHub] [hbase] rda3mon commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-20 Thread GitBox
rda3mon commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r636592027 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,7 +240,7 @@ protected void

[GitHub] [hbase] rda3mon commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-20 Thread GitBox
rda3mon commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r636590250 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,7 +240,7 @@ protected void

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845593526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845588830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348922#comment-17348922 ] Hudson commented on HBASE-25841: Results for branch branch-2 [build #255 on

[GitHub] [hbase] Apache9 commented on pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
Apache9 commented on pull request #3287: URL: https://github.com/apache/hbase/pull/3287#issuecomment-845586389 I think the goal for HBASE-23055 is to give us a way to not need to always upgrade region server first when there is a meta schema change, so I think we should try to do this

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845564092 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845560449 Thanks. Unless objection I will merge this tonight or tomorrow morning, to master, and then to branch-2 (for future 2.5.0) -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845559799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348840#comment-17348840 ] Duo Zhang commented on HBASE-25902: --- OK, so the problem is that, for 2.3.0, we will not try to add new

[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845556974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-845554987 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348838#comment-17348838 ] Duo Zhang commented on HBASE-25902: --- Checked our ref guide, we clearly say that you need to upgrade a

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845529048 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Assigned] (HBASE-25150) Metrics recording a time duration should use System.nanoTime()

2021-05-20 Thread Shanmukha Haripriya Kota (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-25150: Assignee: Shanmukha Haripriya Kota > Metrics recording a time

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-845525672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845520890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25841) Add basic jshell support

2021-05-20 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25841: - Release Note: This change adds a new command `hbase jshell` command-line interface. It launches

[GitHub] [hbase] ndimiduk commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
ndimiduk commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845514956 > @ndimiduk > > > That failure looks suspicious. Let me grab the logs before you merge/close the PR. > > How can it be related? That test neither enables WAL

[jira] [Updated] (HBASE-25827) Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25827: - Affects Version/s: 3.0.0-alpha-1 > Per Cell TTL tags get duplicated with increments causing

[GitHub] [hbase] shahrs87 commented on a change in pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
shahrs87 commented on a change in pull request #3210: URL: https://github.com/apache/hbase/pull/3210#discussion_r636480117 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIncrementsFromClientSide.java ## @@ -547,4 +553,51 @@ static void

[GitHub] [hbase] Apache-HBase commented on pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3287: URL: https://github.com/apache/hbase/pull/3287#issuecomment-845482742 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3287: URL: https://github.com/apache/hbase/pull/3287#issuecomment-845477235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] joshelser commented on pull request #3285: Second rebase attempt for HBASE-24749 branch

2021-05-20 Thread GitBox
joshelser commented on pull request #3285: URL: https://github.com/apache/hbase/pull/3285#issuecomment-845465539 ``` [ERROR] TestRegionServerHostname.testRegionServerHostname:111 » IO Shutting down [ERROR] TestRSGroupsWithACL.tearDownAfterClass:213 » IO Waiting for shutdown of

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845463588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845457386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] xcangCRM merged pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
xcangCRM merged pull request #3283: URL: https://github.com/apache/hbase/pull/3283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-845452202 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348784#comment-17348784 ] Hudson commented on HBASE-25032: Results for branch branch-2.4 [build #123 on

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348785#comment-17348785 ] Hudson commented on HBASE-25875: Results for branch branch-2.4 [build #123 on

[jira] [Commented] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348718#comment-17348718 ] Hudson commented on HBASE-25791: Results for branch master [build #297 on

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348719#comment-17348719 ] Hudson commented on HBASE-25841: Results for branch master [build #297 on

[GitHub] [hbase] virajjasani commented on a change in pull request #3215: HBASE-25698 Fixing IllegalReferenceCountException when using TinyLfuBlockCache

2021-05-20 Thread GitBox
virajjasani commented on a change in pull request #3215: URL: https://github.com/apache/hbase/pull/3215#discussion_r636421078 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java ## @@ -890,4 +892,60 @@ public void testDBEShipped() throws

[jira] [Commented] (HBASE-25865) Visualize current state of region assignment

2021-05-20 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348709#comment-17348709 ] Bharath Vissapragada commented on HBASE-25865: -- Patch seems fine to me (and the shading

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845420407 Pushed a fix for whitespace and javadoc issues introduced in last change. No additional changes anticipated from this point. -- This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845417749 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845417490 @ndimiduk > That failure looks suspicious. Let me grab the logs before you merge/close the PR. How can it be related? That test neither enables WAL compression nor

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845417319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3106: URL: https://github.com/apache/hbase/pull/3106#issuecomment-845416257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell commented on a change in pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
apurtell commented on a change in pull request #3287: URL: https://github.com/apache/hbase/pull/3287#discussion_r636405262 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -223,6 +253,21 @@ public TableDescriptor

[GitHub] [hbase] Apache-HBase commented on pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3287: URL: https://github.com/apache/hbase/pull/3287#issuecomment-845407683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3286: Fix concurrent puts to queues.

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-845404078 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348692#comment-17348692 ] Viraj Jasani commented on HBASE-25902: -- FYI [~apurtell] > 1.x to 2.3.x upgrade does not work; you

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-20 Thread GitBox
pankaj72981 commented on a change in pull request #3106: URL: https://github.com/apache/hbase/pull/3106#discussion_r636382334 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java ## @@ -631,6 +631,10 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #3286: Fix concurrent puts to queues.

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-845386496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
ndimiduk commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845378079 I have what's available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] ndimiduk commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
ndimiduk commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845371657 > Unit test failures are not related. It looks like master is recently unstable, related to RS groups. That failure looks suspicious. Let me grab the logs before you

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-20 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-845354766 Unit test failures are not related. It looks like master is recently unstable, related to RS groups. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348663#comment-17348663 ] Pankaj Kumar commented on HBASE-25902: -- [~stack] [~busbey] Have raised 

[GitHub] [hbase] pankaj72981 opened a new pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-20 Thread GitBox
pankaj72981 opened a new pull request #3287: URL: https://github.com/apache/hbase/pull/3287 HMaste should validate the meta table descriptor during startup and rewrite if any mismatch, meanwhile RegionServer should read the default meta table descriptor to avoid inconsistencies. --

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348654#comment-17348654 ] Hudson commented on HBASE-25032: Results for branch branch-2.3 [build #219 on

[GitHub] [hbase] virajjasani commented on a change in pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
virajjasani commented on a change in pull request #3210: URL: https://github.com/apache/hbase/pull/3210#discussion_r636308997 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIncrementsFromClientSide.java ## @@ -547,4 +553,51 @@ static void

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348636#comment-17348636 ] Pankaj Kumar commented on HBASE-25902: -- How about adding one time meta descriptor validation? If

[GitHub] [hbase] Apache-HBase commented on pull request #3286: Fix concurrent puts to queues.

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-845297664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348635#comment-17348635 ] Pankaj Kumar commented on HBASE-25902: -- There are 2 problems here... 1. HMaster will fail to start

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348628#comment-17348628 ] Sean Busbey commented on HBASE-25902: - Would we benefit as a community from establishing an "Upgrade

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-845287478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348624#comment-17348624 ] Michael Stack commented on HBASE-25902: --- bq. our current stable release line is 2.3. that means

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-845284046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348621#comment-17348621 ] Sean Busbey commented on HBASE-25902: - our current stable release line is 2.3. that means folks

[jira] [Updated] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25902: Affects Version/s: 2.4.0 > 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is

[jira] [Updated] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25902: Component/s: Operability meta > 1.x to 2.3.x upgrade does not work; you must

[jira] [Updated] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25902: Affects Version/s: 2.3.0 > 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is

[jira] [Updated] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25902: Priority: Critical (was: Major) > 1.x to 2.3.x upgrade does not work; you must install an hbase2

[jira] [Created] (HBASE-25902) 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first

2021-05-20 Thread Michael Stack (Jira)
Michael Stack created HBASE-25902: - Summary: 1.x to 2.3.x upgrade does not work; you must install an hbase2 that is earlier than hbase-2.3.0 first Key: HBASE-25902 URL:

[GitHub] [hbase] youhailang opened a new pull request #3286: Fix concurrent puts to queues.

2021-05-20 Thread GitBox
youhailang opened a new pull request #3286: URL: https://github.com/apache/hbase/pull/3286 Fix concurrent puts to queues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] Apache9 commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-20 Thread GitBox
Apache9 commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-845261501 Wrote a simple test to verify the performance improvement ``` /** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license

[GitHub] [hbase] joshelser commented on pull request #3285: Second rebase attempt for HBASE-24749 branch

2021-05-20 Thread GitBox
joshelser commented on pull request #3285: URL: https://github.com/apache/hbase/pull/3285#issuecomment-845231959 Blech, i guess trying to get a QA run won't work for a rebase. I'm building/testing the tip of this branch locally and can be a "substitute yetus" :) -- This is an

[GitHub] [hbase] shahrs87 commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-20 Thread GitBox
shahrs87 commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845193884 @apurtell @virajjasani could you please help review this patch ? Thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348573#comment-17348573 ] Duo Zhang commented on HBASE-25901: --- But we do not need double check here... We only need to make sure

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread yuhailang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348570#comment-17348570 ] yuhailang commented on HBASE-25901: --- Since queues's operation is to write less and read more, I think

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-20 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-845178796 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348564#comment-17348564 ] Duo Zhang commented on HBASE-25901: --- OK, on branch-2.3- we use HashMap which could be a problem. So

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread yuhailang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348556#comment-17348556 ] yuhailang commented on HBASE-25901: --- Inside the branch code I'm looking at, the queues are implemented

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348542#comment-17348542 ] Duo Zhang commented on HBASE-25901: --- The queues is a ConcurrentMap, so putting entries into it

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread yuhailang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348540#comment-17348540 ] yuhailang commented on HBASE-25901: --- Yes, I found this problem on a cluster of 40 rs nodes in the

[jira] [Updated] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread yuhailang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhailang updated HBASE-25901: -- Description: When multiwal is used, restarting the region server may result in the loss of

[GitHub] [hbase] Apache9 commented on a change in pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-20 Thread GitBox
Apache9 commented on a change in pull request #3280: URL: https://github.com/apache/hbase/pull/3280#discussion_r636113573 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -91,12 +91,12 @@ private final FileSystem

[GitHub] [hbase] Apache9 commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-20 Thread GitBox
Apache9 commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r636106528 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,7 +240,7 @@ protected void

[jira] [Resolved] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25897. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution:

[jira] [Work started] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25897 started by Duo Zhang. - > TestRetainAssignmentOnRestart is flaky after HBASE-25032 >

[jira] [Assigned] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25897: - Assignee: Duo Zhang > TestRetainAssignmentOnRestart is flaky after HBASE-25032 >

[GitHub] [hbase] Apache9 merged pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-20 Thread GitBox
Apache9 merged pull request #3281: URL: https://github.com/apache/hbase/pull/3281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348506#comment-17348506 ] Duo Zhang commented on HBASE-25901: --- Did you observe a data loss in production? Or you found this by

[GitHub] [hbase] Apache9 commented on a change in pull request #3202: HBASE-25803 Add compaction offload switch

2021-05-20 Thread GitBox
Apache9 commented on a change in pull request #3202: URL: https://github.com/apache/hbase/pull/3202#discussion_r636074862 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SwitchCompactionOffloadProcedure.java ## @@ -0,0 +1,171 @@ +/** + *

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-20 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r636069313 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -152,11 +152,12 @@ public

[jira] [Commented] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348388#comment-17348388 ] Rushabh Shah commented on HBASE-25901: -- [~youhailang] We use pull requests on github as review

[jira] [Updated] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-25901: - Fix Version/s: (was: 2.1.4) > Replication maybe lose data when the regionserver is

[jira] [Updated] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-20 Thread yuhailang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuhailang updated HBASE-25901: -- Attachment: HBASE-25901-v1.patch > Replication maybe lose data when the regionserver is restarted. >

  1   2   >