[GitHub] [hbase] wchevreuil commented on pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-20 Thread GitBox
wchevreuil commented on PR #4945: URL: https://github.com/apache/hbase/pull/4945#issuecomment-1398729482 Thanks for the latest suggestions @Apache9 , I had pushed a new commit addressing those. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] wchevreuil commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-20 Thread GitBox
wchevreuil commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1082877385 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java: ## @@ -188,6 +196,27 @@ protected boolean

[GitHub] [hbase] taklwu opened a new pull request, #4987: Revert "HBASE-27539 Encapsulate and centralise access to ref count th…

2023-01-20 Thread GitBox
taklwu opened a new pull request, #4987: URL: https://github.com/apache/hbase/pull/4987 …rough StoreFileInfo (#4939)" This reverts commit 1e53e1e486119654f68cf4acf025cdf8fe40482a. Revert reason: the change in StoreFileReader breaks the API backward compatibility for the next

[GitHub] [hbase] wchevreuil commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-20 Thread GitBox
wchevreuil commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1082876740 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java: ## @@ -188,6 +196,27 @@ protected boolean

[GitHub] [hbase] wchevreuil commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-20 Thread GitBox
wchevreuil commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1082875860 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java: ## @@ -153,6 +153,25 @@ public class AssignmentManager { private

[GitHub] [hbase] bbeaudreault merged pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-20 Thread GitBox
bbeaudreault merged PR #4986: URL: https://github.com/apache/hbase/pull/4986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4967: URL: https://github.com/apache/hbase/pull/4967#issuecomment-1398701858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1398700220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1398686944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] apurtell merged pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-20 Thread GitBox
apurtell merged PR #4985: URL: https://github.com/apache/hbase/pull/4985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bbeaudreault commented on pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
bbeaudreault commented on PR #4967: URL: https://github.com/apache/hbase/pull/4967#issuecomment-1398657200 Thanks for sticking with me on this @Apache9. Great feedback. I've pushed changes based on your recent comments and provided some extra context on a couple of your comments. For some

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1082802553 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3398,7 +3398,6 @@ private void scan(HBaseRpcController controller,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1082801270 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java: ## @@ -140,4 +140,10 @@ public interface HFileScanner extends Shipper, Closeable {

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1082800609 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java: ## @@ -608,6 +610,11 @@ private boolean nextInternal(List results,

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398592255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398447091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1398437068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s |

[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398400263 There are some javac (checkstyle) warnings. They are all in the net-new code, and I checked them and master has the same issues. Seems like we skipped cleaning up checkstyle in

[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398394580 Nice! I think this looks good. Just waiting on clean pre-commit checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398375408 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] bbeaudreault commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-20 Thread GitBox
bbeaudreault commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1398352078 Thanks all for the review. Having trouble with some flaky tests. I'm going to let it run once more to see if we can get a clean build. So far I've run the failing tests manually

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1082509664 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3616,8 +3620,9 @@ public ScanResponse scan(final RpcController

[GitHub] [hbase] Apache9 commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-20 Thread GitBox
Apache9 commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1082300876 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java: ## @@ -140,4 +140,10 @@ public interface HFileScanner extends Shipper, Closeable {

[GitHub] [hbase] dongjoon-hyun commented on pull request #4953: HBASE-27562 Publish SBOM artifacts

2023-01-20 Thread GitBox
dongjoon-hyun commented on PR #4953: URL: https://github.com/apache/hbase/pull/4953#issuecomment-1398148088 Thank you all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398118750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s |

[GitHub] [hbase] Apache-HBase commented on pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4979: URL: https://github.com/apache/hbase/pull/4979#issuecomment-1398107281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4979: URL: https://github.com/apache/hbase/pull/4979#issuecomment-1398092698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

[GitHub] [hbase] Apache-HBase commented on pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-20 Thread GitBox
Apache-HBase commented on PR #4979: URL: https://github.com/apache/hbase/pull/4979#issuecomment-1398088346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] ndimiduk commented on pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-20 Thread GitBox
ndimiduk commented on PR #4979: URL: https://github.com/apache/hbase/pull/4979#issuecomment-1398068261 Rebased and PR feedback. These changes are untested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] ragarkar commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-20 Thread GitBox
ragarkar commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1398043539 rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] ndimiduk commented on a diff in pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-20 Thread GitBox
ndimiduk commented on code in PR #4979: URL: https://github.com/apache/hbase/pull/4979#discussion_r1082207440 ## hbase-it/src/test/java/org/apache/hadoop/hbase/KubernetesClusterManager.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hbase] Apache9 merged pull request #4951: HBASE-27528 log duplication issues in MasterRpcServices.

2023-01-19 Thread GitBox
Apache9 merged PR #4951: URL: https://github.com/apache/hbase/pull/4951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 merged pull request #4953: HBASE-27562 Publish SBOM artifacts

2023-01-19 Thread GitBox
Apache9 merged PR #4953: URL: https://github.com/apache/hbase/pull/4953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 merged pull request #4968: HBASE-27564 Add default encryption type for MiniKDC to fix failed tests on JDK11+

2023-01-19 Thread GitBox
Apache9 merged PR #4968: URL: https://github.com/apache/hbase/pull/4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-19 Thread GitBox
Apache9 commented on code in PR #4945: URL: https://github.com/apache/hbase/pull/4945#discussion_r1082188117 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java: ## @@ -153,6 +153,25 @@ public class AssignmentManager { private

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1398017223 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] virajjasani commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
virajjasani commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1082136488 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final Pair

[GitHub] [hbase] Reidddddd merged pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Reidd merged PR #4970: URL: https://github.com/apache/hbase/pull/4970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082095480 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397897023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s |

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397893200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397893048 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4970: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4970: URL: https://github.com/apache/hbase/pull/4970#issuecomment-1397892160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082074168 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] Reidddddd merged pull request #4984: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.5

2023-01-19 Thread GitBox
Reidd merged PR #4984: URL: https://github.com/apache/hbase/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Reidddddd merged pull request #4983: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2

2023-01-19 Thread GitBox
Reidd merged PR #4983: URL: https://github.com/apache/hbase/pull/4983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] taklwu merged pull request #4980: HBASE-27575 Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread GitBox
taklwu merged PR #4980: URL: https://github.com/apache/hbase/pull/4980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082035135 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082010622 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job, List

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082005656 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082004856 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003715 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003715 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] rda3mon commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
rda3mon commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1082003004 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] taklwu commented on pull request #4980: Bump future from 0.18.2 to 0.18.3 in /dev-support

2023-01-19 Thread GitBox
taklwu commented on PR #4980: URL: https://github.com/apache/hbase/pull/4980#issuecomment-1397731165 should we edit the title of this PR and add HBASE-27575 as prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397716885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s |

[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397708589 Thanks for doing this @rda3mon -- i made a few small comments, and then I think we should be good. Extra reminder: make sure to run `mvn spotless:apply` after making the

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081946531 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java: ## @@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397705029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081934099 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081932511 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -254,16 +261,21 @@ public void write(ImmutableBytesWritable row, V

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -152,6 +153,10 @@ protected static byte[]

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081929395 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4770: URL: https://github.com/apache/hbase/pull/4770#discussion_r1081926702 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397679103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 52s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397532353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397469665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397433875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
bbeaudreault commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1081645332 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final

[GitHub] [hbase] virajjasani commented on a diff in pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
virajjasani commented on code in PR #4986: URL: https://github.com/apache/hbase/pull/4986#discussion_r1081618087 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java: ## @@ -387,59 +390,45 @@ private static boolean hasNoReferences(final Pair

[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1397354936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[GitHub] [hbase] Apache-HBase commented on pull request #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4986: URL: https://github.com/apache/hbase/pull/4986#issuecomment-1397182983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s |

[GitHub] [hbase] joshelser commented on a diff in pull request #4979: HBASE-27574 Implement ClusterManager interface for Kubernetes

2023-01-19 Thread GitBox
joshelser commented on code in PR #4979: URL: https://github.com/apache/hbase/pull/4979#discussion_r1081422560 ## hbase-it/src/test/java/org/apache/hadoop/hbase/KubernetesClusterManager.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397114998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] bbeaudreault opened a new pull request, #4986: HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion

2023-01-19 Thread GitBox
bbeaudreault opened a new pull request, #4986: URL: https://github.com/apache/hbase/pull/4986 There already existed a robust reference check method for cleaning splits, `checkDaughterInFs`. I cleaned that up a little bit and re-use it in cleanMergeRegion. This way both cleaning use the

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1397095868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1397093394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397063707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 58s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1397048241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[GitHub] [hbase] Apache-HBase commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1396837398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1396777434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] ragarkar commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-19 Thread GitBox
ragarkar commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1396733383 rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache9 closed pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache9 closed pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool URL: https://github.com/apache/hbase/pull/4947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache9 commented on pull request #4947: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-01-19 Thread GitBox
Apache9 commented on PR #4947: URL: https://github.com/apache/hbase/pull/4947#issuecomment-1396705734 Close in favor of #4966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-19 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1396643022 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1396554275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache9 closed pull request #4563: Missing "'s" in README

2023-01-18 Thread GitBox
Apache9 closed pull request #4563: Missing "'s" in README URL: https://github.com/apache/hbase/pull/4563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] ragarkar commented on pull request #4799: HBASE-27389 Add cost function in balancer to consider the cost of bui…

2023-01-18 Thread GitBox
ragarkar commented on PR #4799: URL: https://github.com/apache/hbase/pull/4799#issuecomment-1396540567 recheck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache9 commented on pull request #4953: HBASE-27562 Publish SBOM artifacts

2023-01-18 Thread GitBox
Apache9 commented on PR #4953: URL: https://github.com/apache/hbase/pull/4953#issuecomment-1396535648 Going to merge this later unless objections. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1396392250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #4984: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.5

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4984: URL: https://github.com/apache/hbase/pull/4984#issuecomment-1396367032 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[GitHub] [hbase] Apache-HBase commented on pull request #4984: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.5

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4984: URL: https://github.com/apache/hbase/pull/4984#issuecomment-1396364136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

[GitHub] [hbase] Apache-HBase commented on pull request #4984: Backport "HBASE-27557 [JDK17] Update shade plugin version" to branch-2.5

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4984: URL: https://github.com/apache/hbase/pull/4984#issuecomment-1396363319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] Apache-HBase commented on pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4945: URL: https://github.com/apache/hbase/pull/4945#issuecomment-1396122490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

[GitHub] [hbase] Apache-HBase commented on pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4945: URL: https://github.com/apache/hbase/pull/4945#issuecomment-1396095882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1396066221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

[GitHub] [hbase] Apache-HBase commented on pull request #4985: HBASE-27578 Upgrade hbase-thirdparty to 4.1.4

2023-01-18 Thread GitBox
Apache-HBase commented on PR #4985: URL: https://github.com/apache/hbase/pull/4985#issuecomment-1387540929 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

  1   2   3   4   5   6   7   8   9   10   >