[jira] [Commented] (HBASE-4890) fix possible NPE in HConnectionManager

2012-03-10 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226961#comment-13226961 ] stack commented on HBASE-4890: -- bq. Now we get IOE as the patch is applied. And you used to

[jira] [Commented] (HBASE-4890) fix possible NPE in HConnectionManager

2012-03-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227234#comment-13227234 ] stack commented on HBASE-4890: -- IOE is better than NPE. The IOE says what the error is.

[jira] [Commented] (HBASE-2039) G1 GC issues

2012-03-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227254#comment-13227254 ] stack commented on HBASE-2039: -- A post by Jonathan Payne on G1 not working for him:

[jira] [Commented] (HBASE-2039) G1 GC issues

2012-03-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227253#comment-13227253 ] stack commented on HBASE-2039: -- A post by Jonathan Payne on G1 not working for him:

[jira] [Commented] (HBASE-5560) Avoid RegionServer GC caused by timed-out calls

2012-03-11 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227319#comment-13227319 ] stack commented on HBASE-5560: -- Pardon me lads. Did not mean to confuse. Lars I was telling

[jira] [Commented] (HBASE-5564) Bulkload is discarding duplicate records

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227740#comment-13227740 ] stack commented on HBASE-5564: -- The TreeSet is whats going to be used once the edits make it

[jira] [Commented] (HBASE-5347) GC free memory management in Level-1 Block Cache

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227744#comment-13227744 ] stack commented on HBASE-5347: -- bq. We are not actively pursuing this approach anymore due to

[jira] [Commented] (HBASE-5563) HRegionInfo#compareTo add the comparison of regionId

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227748#comment-13227748 ] stack commented on HBASE-5563: -- Both regions were online? Does this patch make the newest

[jira] [Commented] (HBASE-5563) HRegionInfo#compareTo add the comparison of regionId

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227749#comment-13227749 ] stack commented on HBASE-5563: -- Although, thats a bunch of failures. Want to retry your

[jira] [Commented] (HBASE-5520) Support reseek() at RegionScanner

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227765#comment-13227765 ] stack commented on HBASE-5520: -- We are reseeking to the start of the passed 'row'? Is that

[jira] [Commented] (HBASE-5560) Avoid RegionServer GC caused by timed-out calls

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227803#comment-13227803 ] stack commented on HBASE-5560: -- @Dhruba In trunk: {code}

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227869#comment-13227869 ] stack commented on HBASE-4608: -- Is HLog versioned? If not, perhaps instead of a

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227898#comment-13227898 ] stack commented on HBASE-4608: -- In TestLRUDictionary, we test a single entry in essence. We

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227908#comment-13227908 ] stack commented on HBASE-4608: -- Its the test of a single entry only which is not really

[jira] [Commented] (HBASE-5561) Create HFileSystemFactory

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227920#comment-13227920 ] stack commented on HBASE-5561: -- +1 Create HFileSystemFactory

[jira] [Commented] (HBASE-4542) add filter info to slow query logging

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227921#comment-13227921 ] stack commented on HBASE-4542: -- +1 for 0.94. This is good stuff. add

[jira] [Commented] (HBASE-4542) add filter info to slow query logging

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227923#comment-13227923 ] stack commented on HBASE-4542: -- And Lars, I think it should be safe since its on toStringery

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227929#comment-13227929 ] stack commented on HBASE-4608: -- Its a regular pattern only. Perhaps this does some decent

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227934#comment-13227934 ] stack commented on HBASE-4608: -- The tests do not have variety. I think we should add it here

[jira] [Commented] (HBASE-5548) Add ability to get a table in the shell

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227944#comment-13227944 ] stack commented on HBASE-5548: -- Looks good. Does stuff work as it used to after this patch

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227969#comment-13227969 ] stack commented on HBASE-4608: -- bq. I think WAL_VERSION metadata is orthogonal to compression

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228033#comment-13228033 ] stack commented on HBASE-4608: -- bq. I can add WAL_VERSION as v2 in the metadata. Why not as

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228157#comment-13228157 ] stack commented on HBASE-4608: -- Stop making this more complicated than it need be Ted.

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228158#comment-13228158 ] stack commented on HBASE-4608: -- Stop making this more complicated than it need be Ted.

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228160#comment-13228160 ] stack commented on HBASE-5399: -- @Nicolas What you make of Ted's comment above? You think it

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228161#comment-13228161 ] stack commented on HBASE-5399: -- @Nicolas What you make of Ted's comment above? You think it

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228166#comment-13228166 ] stack commented on HBASE-4608: -- @Ted I think you should resign ownership of this issue. You

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228174#comment-13228174 ] stack commented on HBASE-5270: -- @Chunhui Sorry. I thought I'd provided comments already on

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228175#comment-13228175 ] stack commented on HBASE-4608: -- Let me have a go at it since Li Pi can't finish it just yet.

[jira] [Commented] (HBASE-5128) [uber hbck] Enable hbck to automatically repair table integrity problems as well as region consistency problems while online.

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228180#comment-13228180 ] stack commented on HBASE-5128: -- The only issue that I can see -- the bulk of the patch is

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228185#comment-13228185 ] stack commented on HBASE-4608: -- bq. It is rare that I saw review comments in such tone:

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228202#comment-13228202 ] stack commented on HBASE-4608: -- bq. PREFIX_COMPRESSION_V2, first cited by Stack, is a

[jira] [Commented] (HBASE-5569) TestAtomicOperation.testMultiRowMutationMultiThreads fails occasionally

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228204#comment-13228204 ] stack commented on HBASE-5569: -- This is the failures we saw up on builds.apache.org? There

[jira] [Commented] (HBASE-5569) TestAtomicOperation.testMultiRowMutationMultiThreads fails occasionally

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228205#comment-13228205 ] stack commented on HBASE-5569: -- bq. This debug message comes from StoreScanner to

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228209#comment-13228209 ] stack commented on HBASE-5270: -- bq. It is called by one of test cases. Ok. Its package

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228227#comment-13228227 ] stack commented on HBASE-5270: -- What did you change Chunhui? And rather, could you attach

[jira] [Commented] (HBASE-5569) TestAtomicOperation.testMultiRowMutationMultiThreads fails occasionally

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228236#comment-13228236 ] stack commented on HBASE-5569: -- Ugh. Indexing JIRA lost my comment. Looking at builds, we

[jira] [Commented] (HBASE-5059) Tests for: Support deleted rows in CopyTable

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228241#comment-13228241 ] stack commented on HBASE-5059: -- @Evan If you poke around, you can find the logs of your test

[jira] [Commented] (HBASE-5059) Tests for: Support deleted rows in CopyTable

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228242#comment-13228242 ] stack commented on HBASE-5059: -- @Evan If you poke around, you can find the logs of your test

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228453#comment-13228453 ] stack commented on HBASE-5270: -- I committed to trunk. Can you make a version for 0.92 please

[jira] [Commented] (HBASE-5572) KeeperException.SessionExpiredException management could be improved in Master

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228460#comment-13228460 ] stack commented on HBASE-5572: -- @N Thanks for digging in. So, it looks like your patch

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228464#comment-13228464 ] stack commented on HBASE-5399: -- bq. Yes, this test is flaky... I reproduce the error on the

[jira] [Commented] (HBASE-5564) Bulkload is discarding duplicate records

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228467#comment-13228467 ] stack commented on HBASE-5564: -- Googling it, its either something is already listening on the

[jira] [Commented] (HBASE-5571) Table will be disabling forever

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228484#comment-13228484 ] stack commented on HBASE-5571: -- Oh, any chance of a test? Table will be

[jira] [Commented] (HBASE-5571) Table will be disabling forever

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228482#comment-13228482 ] stack commented on HBASE-5571: -- This patch has much merit. Thanks for digging in on it. I

[jira] [Commented] (HBASE-5572) KeeperException.SessionExpiredException management could be improved in Master

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228487#comment-13228487 ] stack commented on HBASE-5572: -- Above sounds good. Would suggest we retain the test that

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228496#comment-13228496 ] stack commented on HBASE-5270: -- @Lars Yeah. Let me try this trunk patch. Its good for

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228499#comment-13228499 ] stack commented on HBASE-5270: -- The trunk patch went into 0.94. I committed it. So, just

[jira] [Commented] (HBASE-5573) Replace client ZooKeeper watchers by simple ZooKeeper reads

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228501#comment-13228501 ] stack commented on HBASE-5573: -- Hurray! Replace client ZooKeeper watchers

[jira] [Commented] (HBASE-5574) DEFAULT_MAX_FILE_SIZE defaults to a negative value

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228548#comment-13228548 ] stack commented on HBASE-5574: -- +1 Thanks Michael DEFAULT_MAX_FILE_SIZE

[jira] [Commented] (HBASE-5569) TestAtomicOperation.testMultiRowMutationMultiThreads fails occasionally

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228592#comment-13228592 ] stack commented on HBASE-5569: -- hbase-5121 does mess w/ scanners... Seems like pretty issue

[jira] [Commented] (HBASE-5572) KeeperException.SessionExpiredException management could be improved in Master

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228598#comment-13228598 ] stack commented on HBASE-5572: -- +1 on patch. Waiting on hadoopqa...

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228946#comment-13228946 ] stack commented on HBASE-4608: -- Here's my compressing, decompressing, compressing again,

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228947#comment-13228947 ] stack commented on HBASE-4608: -- Here's my compressing, decompressing, compressing again,

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228957#comment-13228957 ] stack commented on HBASE-4608: -- bq. I noticed the size of

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228965#comment-13228965 ] stack commented on HBASE-4608: -- bq. It implies that WAL_VERSION is the same as

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228976#comment-13228976 ] stack commented on HBASE-4608: -- bq. But we don't know if the current dictionary compression

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228979#comment-13228979 ] stack commented on HBASE-4608: -- I took a random set of 40 logs off our front end and did a

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228981#comment-13228981 ] stack commented on HBASE-4608: -- We need facility in wal like we have in hfile for printing

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228985#comment-13228985 ] stack commented on HBASE-4608: -- bq. This would make developing a new compression scheme hard.

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228986#comment-13228986 ] stack commented on HBASE-4608: -- bq. This would make developing a new compression scheme hard.

[jira] [Commented] (HBASE-5128) [uber hbck] Enable hbck to automatically repair table integrity problems as well as region consistency problems while online.

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228994#comment-13228994 ] stack commented on HBASE-5128: -- @Jon Should go into 0.92 soon as ready. On... bq. I'll

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228996#comment-13228996 ] stack commented on HBASE-4608: -- Can I get a +1 from someone else. Its not a big patch.

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229022#comment-13229022 ] stack commented on HBASE-4608: -- @Lars Generalizing the compression done here is out of scope

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229024#comment-13229024 ] stack commented on HBASE-4608: -- Lars, I can't upload a patch to someone else's issue. Made a

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229054#comment-13229054 ] stack commented on HBASE-4608: -- I like your changes Todd. Nice fixup. Lars, let me post v28

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229064#comment-13229064 ] stack commented on HBASE-4608: -- I reran compress, decompress, compress cycle over my 40 odd

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229663#comment-13229663 ] stack commented on HBASE-4608: -- Li asked me lzma some of my logs from the wild. I did. W/

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229771#comment-13229771 ] stack commented on HBASE-4608: -- Here's some WALs to compared compressed w/ patch v29 vs lzma

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-14 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229877#comment-13229877 ] stack commented on HBASE-4608: -- @Ted Would suggest that in future you not piecemeal in your

[jira] [Commented] (HBASE-5399) Cut the link between the client and the zookeeper ensemble

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230050#comment-13230050 ] stack commented on HBASE-5399: -- I should have said, given you've repro'd in an older version

[jira] [Commented] (HBASE-5569) Do not collect deleted KVs when they are still in use by a scanner.

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230428#comment-13230428 ] stack commented on HBASE-5569: -- @Lars Good one. Do not collect deleted KVs

[jira] [Commented] (HBASE-5579) A Delete Version could mask other values

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230445#comment-13230445 ] stack commented on HBASE-5579: -- +1 on patch This was messing up bulk loaded data? How did

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230449#comment-13230449 ] stack commented on HBASE-4608: -- I'll commit v30 then. Thanks all for reviews, etc.

[jira] [Commented] (HBASE-4608) HLog Compression

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230456#comment-13230456 ] stack commented on HBASE-4608: -- Now this is in, does that mean we can cut a 0.94RC0?

[jira] [Commented] (HBASE-5587) Remove dns.interface configuration options

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230642#comment-13230642 ] stack commented on HBASE-5587: -- Thanks Eli for looking out for us. Could do this in 0.96.

[jira] [Commented] (HBASE-5559) --presplit option creates a first split with rowkey-end=0

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230665#comment-13230665 ] stack commented on HBASE-5559: -- Sujee Since you are learning how to contrib., how about your

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230668#comment-13230668 ] stack commented on HBASE-5270: -- Thanks Chunhui. Will apply after 0.92.1 leaves the gate so

[jira] [Commented] (HBASE-5563) HRegionInfo#compareTo add the comparison of regionId

2012-03-15 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230693#comment-13230693 ] stack commented on HBASE-5563: -- +1 on committing everywhere, even into 0.92 (I've tagged RC0;

[jira] [Commented] (HBASE-5549) Master can fail if ZooKeeper session expires

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231491#comment-13231491 ] stack commented on HBASE-5549: -- @N LGTM. Change reconnectAfterExpiry to

[jira] [Commented] (HBASE-5568) Multi concurrent flushcache() for one region could cause data loss

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231507#comment-13231507 ] stack commented on HBASE-5568: -- +1 Good find Chunhui. Multi concurrent

[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231551#comment-13231551 ] stack commented on HBASE-5593: -- @Ted You mean a unit test for the

[jira] [Commented] (HBASE-5588) Deprecate/remove AssignmentManager#clearRegionFromTransition

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231553#comment-13231553 ] stack commented on HBASE-5588: -- +1 on patch set Deprecate/remove

[jira] [Commented] (HBASE-5563) HRegionInfo#compareTo add the comparison of regionId

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231557#comment-13231557 ] stack commented on HBASE-5563: -- +1 on patch for trunk and 0.92 (again). Older regionids

[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231698#comment-13231698 ] stack commented on HBASE-5593: -- That is given directly to

[jira] [Commented] (HBASE-5592) Make it easier to get a table from shell

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231700#comment-13231700 ] stack commented on HBASE-5592: -- I can revert. Would be interested in Bens' opinion first.

[jira] [Commented] (HBASE-5533) Add more metrics to HBase

2012-03-16 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231733#comment-13231733 ] stack commented on HBASE-5533: -- Those metrics look beautiful. NamedThreadFactory overlaps

[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh always fails

2012-03-17 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232109#comment-13232109 ] stack commented on HBASE-5597: -- I'd be fine committing this patch for now and opening another

[jira] [Commented] (HBASE-5341) Push the security 0.92 profile to maven repo

2012-03-18 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232333#comment-13232333 ] stack commented on HBASE-5341: -- I tried doing this but each time, though it built the

[jira] [Commented] (HBASE-5569) Do not collect deleted KVs when they are still in use by a scanner.

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233734#comment-13233734 ] stack commented on HBASE-5569: -- Your 'being extra clear' note needs to become the release

[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233892#comment-13233892 ] stack commented on HBASE-5593: -- Thanks David. Should be fixed now. Reverse

[jira] [Commented] (HBASE-5569) Do not collect deleted KVs when they are still in use by a scanner.

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233896#comment-13233896 ] stack commented on HBASE-5569: -- Ok. Thanks for explaination. +1 on commit.

[jira] [Commented] (HBASE-5548) Add ability to get a table in the shell

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233937#comment-13233937 ] stack commented on HBASE-5548: -- You pass in the shell instance now instead of formatter when

[jira] [Commented] (HBASE-5589) Add of the offline call to the Master Interface

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233952#comment-13233952 ] stack commented on HBASE-5589: -- @Jon OK. Then the order in the Interface is a mythology,

[jira] [Commented] (HBASE-5589) Add of the offline call to the Master Interface

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233990#comment-13233990 ] stack commented on HBASE-5589: -- Good. Thanks. Add of the offline call to

[jira] [Commented] (HBASE-50) Snapshot of table

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233992#comment-13233992 ] stack commented on HBASE-50: Go for it Jesse. My guess is that a lot has changed since but

[jira] [Commented] (HBASE-5594) Unable to stop a master that's waiting on -ROOT- during initialization

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234004#comment-13234004 ] stack commented on HBASE-5594: -- HBASE-5328 has a patch that includes removing the infinite

[jira] [Commented] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234006#comment-13234006 ] stack commented on HBASE-5604: -- I considered that instead of writing sequence files when we

[jira] [Commented] (HBASE-5604) HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234032#comment-13234032 ] stack commented on HBASE-5604: -- Oh, hfile has to be sorted too. At log splitting time, would

[jira] [Commented] (HBASE-5584) Coprocessor hooks can be called in the respective handlers

2012-03-20 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234086#comment-13234086 ] stack commented on HBASE-5584: -- Load up the patch and resubmit the patch Ram. See if it

<    1   2   3   4   5   6   7   8   9   10   >