[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554781113 Please node that I changed a couple of NPE to be IllegalStateException (Guava Preconditions#checkState) as these are more appropriate

[GitHub] [hbase] belugabehr edited a comment on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr edited a comment on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554781113 Please note that I changed a couple of NPE to be IllegalStateException (Guava Preconditions#checkState) as these are more

[GitHub] [hbase] karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-17 Thread GitBox
karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r347149839 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java

[GitHub] [hbase] karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-17 Thread GitBox
karthikhw commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r347149839 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java

[GitHub] [hbase] belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347149074 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@

[GitHub] [hbase] belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554768282 @saintstack Hey, sorry, didn't see that you reviewed this code already so I tried to put in a force-push to keep things cleaner. Ended up

[GitHub] [hbase] belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

2019-11-17 Thread GitBox
belugabehr commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347148986 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java ## @@ -187,10

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

2019-11-17 Thread GitBox
wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347131612 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

2019-11-17 Thread GitBox
wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347130863 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated

2019-11-17 Thread GitBox
wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly update the position of WALs currently being replicated URL: https://github.com/apache/hbase/pull/749#discussion_r347130863 ## File path:

[GitHub] [hbase] wchevreuil merged pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent

2019-11-17 Thread GitBox
wchevreuil merged pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent URL: https://github.com/apache/hbase/pull/828 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] chenxu14 commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

2019-11-17 Thread GitBox
chenxu14 commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#discussion_r347123564 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117642 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117727 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117622 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117764 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117776 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117666 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117686 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r347117677 ## File path:

[GitHub] [hbase] saintstack commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r347117496 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRequestsPerSecondMetric.java

[GitHub] [hbase] saintstack commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-16 Thread GitBox
saintstack commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554702913 Meant to say also, nice to see you around again @belugabehr This is an

[GitHub] [hbase] saintstack commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347117251 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@

[GitHub] [hbase] saintstack commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions

2019-11-16 Thread GitBox
saintstack commented on a change in pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#discussion_r347117195 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java ## @@ -187,10

[GitHub] [hbase] Apache-HBase commented on issue #836: HBASE-23308: Review of NullPointerExceptions

2019-11-16 Thread GitBox
Apache-HBase commented on issue #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836#issuecomment-554691314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…

2019-11-16 Thread GitBox
Apache-HBase commented on issue #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta… URL: https://github.com/apache/hbase/pull/835#issuecomment-554687223 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] belugabehr opened a new pull request #836: HBASE-23308: Review of NullPointerExceptions

2019-11-16 Thread GitBox
belugabehr opened a new pull request #836: HBASE-23308: Review of NullPointerExceptions URL: https://github.com/apache/hbase/pull/836 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack commented on issue #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…

2019-11-16 Thread GitBox
saintstack commented on issue #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta… URL: https://github.com/apache/hbase/pull/835#issuecomment-554686017 Tried this patch on cluster and did right thing. See tail of https://issues.apache.org/jira/browse/HBASE-23294

[GitHub] [hbase] saintstack opened a new pull request #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta…

2019-11-16 Thread GitBox
saintstack opened a new pull request #835: HBASE-23307 Add running of ReplicationBarrierCleaner to hbck2 fixMeta… URL: https://github.com/apache/hbase/pull/835 … invocation This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-16 Thread GitBox
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554684143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #828: HBASE-23102: Improper Usage of Map putIfAbsent

2019-11-16 Thread GitBox
Apache-HBase commented on issue #828: HBASE-23102: Improper Usage of Map putIfAbsent URL: https://github.com/apache/hbase/pull/828#issuecomment-554675895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-16 Thread GitBox
saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-55413 Retry. Failed test passes locally and in previous runs. The single checkstyle complaint I can't figure.

[GitHub] [hbase] ankitsinghal commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs

2019-11-16 Thread GitBox
ankitsinghal commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs URL: https://github.com/apache/hbase/pull/722#issuecomment-554665955 Thank you @brfrn169 for the review, Let me work on the review comments today.

[GitHub] [hbase] belugabehr commented on issue #828: HBASE-23102: Improper Usage of Map putIfAbsent

2019-11-16 Thread GitBox
belugabehr commented on issue #828: HBASE-23102: Improper Usage of Map putIfAbsent URL: https://github.com/apache/hbase/pull/828#issuecomment-554656882 @wchevreuil Thank you for your interest and review! I have backed out the style changes. Please review once more. Thanks!

[GitHub] [hbase] Apache-HBase commented on issue #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-16 Thread GitBox
Apache-HBase commented on issue #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#issuecomment-554646385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

2019-11-16 Thread GitBox
wchevreuil commented on issue #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#issuecomment-554635904 > Chatted with wellington a little bit to give some more context (I was worried I would be too vague, but here

[GitHub] [hbase] wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

2019-11-16 Thread GitBox
wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#discussion_r347089315 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

2019-11-16 Thread GitBox
wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#discussion_r347090421 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

2019-11-16 Thread GitBox
wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#discussion_r347089315 ## File path:

[GitHub] [hbase] wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when…

2019-11-16 Thread GitBox
wchevreuil commented on a change in pull request #740: HBASE-23197 'IllegalArgumentException: Wrong FS' on edits replay when… URL: https://github.com/apache/hbase/pull/740#discussion_r347089120 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-16 Thread GitBox
Apache-HBase commented on issue #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#issuecomment-554629099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] wchevreuil commented on a change in pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent

2019-11-16 Thread GitBox
wchevreuil commented on a change in pull request #828: HBASE-23102: Improper Usage of Map putIfAbsent URL: https://github.com/apache/hbase/pull/828#discussion_r347087338 ## File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java ##

[GitHub] [hbase] karthikhw opened a new pull request #834: HBASE-23237 Negative sign in requestsPerSecond

2019-11-15 Thread GitBox
karthikhw opened a new pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834 We see negative sign in requestPerSecond metric, occurs during region transition to another regionserver.

[GitHub] [hbase] Apache9 merged pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…

2019-11-15 Thread GitBox
Apache9 merged pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-15 Thread GitBox
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554606932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports

2019-11-15 Thread GitBox
bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347070236 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java

[GitHub] [hbase] bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports

2019-11-15 Thread GitBox
bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347070047 ## File path:

[GitHub] [hbase] apurtell closed pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition

2019-11-15 Thread GitBox
apurtell closed pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-15 Thread GitBox
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554591739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-15 Thread GitBox
saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554585413 Second-to-last push had a bug. This last push is good. Tested on live cluster and did nice cleanup of 'Unknown

[GitHub] [hbase] apurtell commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition

2019-11-15 Thread GitBox
apurtell commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-554583769 Doing some local tests... This is an automated

[GitHub] [hbase] apurtell commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition

2019-11-15 Thread GitBox
apurtell commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r347062457 ## File path:

[GitHub] [hbase] apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports

2019-11-15 Thread GitBox
apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347061636 ## File path:

[GitHub] [hbase] apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports

2019-11-15 Thread GitBox
apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347061440 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java

[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-15 Thread GitBox
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554544769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-15 Thread GitBox
Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#issuecomment-554519806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters

2019-11-15 Thread GitBox
bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554499618 I'm fairly certain that the test failures are not related to the patch. There is a long discussion between @busbey and me in the Slack

[GitHub] [hbase] Apache-HBase commented on issue #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…

2019-11-15 Thread GitBox
Apache-HBase commented on issue #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833#issuecomment-554493379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] udaikashyap commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-11-15 Thread GitBox
udaikashyap commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554425313 The unit test failure seems due to bad xml file

[GitHub] [hbase] Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-15 Thread GitBox
Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#issuecomment-554395100 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-15 Thread GitBox
joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346864273 ## File path:

[GitHub] [hbase] joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-15 Thread GitBox
joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346857842 ## File path:

[GitHub] [hbase] guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

2019-11-15 Thread GitBox
guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#discussion_r346850295 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-11-15 Thread GitBox
Apache-HBase commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554373636 :broken_heart: **-1 overall**

[GitHub] [hbase] virajjasani commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition

2019-11-15 Thread GitBox
virajjasani commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-554363978 > > Any chance for a unit test? > > @apurtell I tried writing at least one test but for this specific edge

[GitHub] [hbase] virajjasani edited a comment on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition

2019-11-15 Thread GitBox
virajjasani edited a comment on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-553338857 > Any chance for a unit test? @apurtell I tried writing at least one test but for this specific

[GitHub] [hbase] Apache9 opened a new pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…

2019-11-15 Thread GitBox
Apache9 opened a new pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833 …f 2.1.8 This is an automated message from the Apache Git Service.

[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters

2019-11-15 Thread GitBox
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554339869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

2019-11-15 Thread GitBox
Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#issuecomment-554332398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache9 merged pull request #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers …

2019-11-15 Thread GitBox
Apache9 merged pull request #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers … URL: https://github.com/apache/hbase/pull/827 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache9 merged pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc…

2019-11-15 Thread GitBox
Apache9 merged pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc… URL: https://github.com/apache/hbase/pull/813 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] meszibalu commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position

2019-11-15 Thread GitBox
meszibalu commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554271455 (Triggered jenkins manually.)

[GitHub] [hbase] infraio opened a new pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…

2019-11-15 Thread GitBox
infraio opened a new pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832 …CreationOutputSink This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on issue #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc…

2019-11-14 Thread GitBox
Apache-HBase commented on issue #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc… URL: https://github.com/apache/hbase/pull/813#issuecomment-554238400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] ZhaoBQ commented on issue #816: HBASE-23278 Add a table-level compaction progress display on the UI

2019-11-14 Thread GitBox
ZhaoBQ commented on issue #816: HBASE-23278 Add a table-level compaction progress display on the UI URL: https://github.com/apache/hbase/pull/816#issuecomment-554235919 Thanks for giving a review @guangxuCheng ! This is an

[GitHub] [hbase] Apache-HBase commented on issue #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
Apache-HBase commented on issue #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#issuecomment-554235660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554233202 Test failure doesn't seem related to the patch. Fixed some more checkstyle nits (hopefully last).

[GitHub] [hbase] Apache-HBase commented on issue #816: HBASE-23278 Add a table-level compaction progress display on the UI

2019-11-14 Thread GitBox
Apache-HBase commented on issue #816: HBASE-23278 Add a table-level compaction progress display on the UI URL: https://github.com/apache/hbase/pull/816#issuecomment-554226671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554226541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

2019-11-14 Thread GitBox
Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#issuecomment-554218927 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] chenxu14 opened a new pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table

2019-11-14 Thread GitBox
chenxu14 opened a new pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831 RSGroupAdminServer#balanceRSGroup will take too long time, if the target group has thousands of tables, because we will build RegionPlan

[GitHub] [hbase] Apache-HBase commented on issue #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers …

2019-11-14 Thread GitBox
Apache-HBase commented on issue #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers … URL: https://github.com/apache/hbase/pull/827#issuecomment-554203348 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #822: HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names…

2019-11-14 Thread GitBox
Apache-HBase commented on issue #822: HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names… URL: https://github.com/apache/hbase/pull/822#issuecomment-554203136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'

2019-11-14 Thread GitBox
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554202551 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346644880 ## File path:

[GitHub] [hbase] chenxu14 commented on issue #825: HBASE-23293 [REPLICATION] make ship edits timeout configurable

2019-11-14 Thread GitBox
chenxu14 commented on issue #825: HBASE-23293 [REPLICATION] make ship edits timeout configurable URL: https://github.com/apache/hbase/pull/825#issuecomment-554190286 failed UT can pass locally This is an automated message

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346644880 ## File path:

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346644880 ## File path:

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346644880 ## File path:

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346638899 ## File path:

[GitHub] [hbase] zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…

2019-11-14 Thread GitBox
zhaoyim commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346638899 ## File path:

[GitHub] [hbase] infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile

2019-11-14 Thread GitBox
infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile URL: https://github.com/apache/hbase/pull/820#discussion_r346630109 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedWriterCreationOutputSink.java

[GitHub] [hbase] infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile

2019-11-14 Thread GitBox
infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile URL: https://github.com/apache/hbase/pull/820#discussion_r346630056 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java ## @@

[GitHub] [hbase] gjacoby126 commented on a change in pull request #822: HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names…

2019-11-14 Thread GitBox
gjacoby126 commented on a change in pull request #822: HBASE-23288 - Backport HBASE-23251 (Add Column Family and Table Names… URL: https://github.com/apache/hbase/pull/822#discussion_r346616832 ## File path:

[GitHub] [hbase] bharathv commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
bharathv commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#discussion_r346608400 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaRegionLocationCache.java

[GitHub] [hbase] bharathv commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
bharathv commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#discussion_r346608529 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaRegionLocationCache.java

[GitHub] [hbase] saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#discussion_r346600718 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaRegionLocationCache.java

[GitHub] [hbase] saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#discussion_r346606717 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaRegionLocationCache.java

[GitHub] [hbase] saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
saintstack commented on a change in pull request #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#discussion_r346596001 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java

[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters

2019-11-14 Thread GitBox
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554123030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

  1   2   3   4   5   6   7   8   9   10   >