[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570791#comment-15570791
]
Hudson commented on HBASE-15638:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1776 (See
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547963#comment-15547963
]
Anoop Sam John commented on HBASE-15638:
HBASE-16769
> Shade protobuf
> --
>
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547841#comment-15547841
]
stack commented on HBASE-15638:
---
Open a blocker against 2.0 [~anoop.hbase]? Then it'll get attention?
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547800#comment-15547800
]
Anoop Sam John commented on HBASE-15638:
Yes. For Admin public APIs what we did is we deprecated
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547779#comment-15547779
]
stack commented on HBASE-15638:
---
But we need to do master cp still?
> Shade protobuf
> --
>
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547772#comment-15547772
]
ramkrishna.s.vasudevan commented on HBASE-15638:
[~saint@gmail.com]
Able to fix the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546084#comment-15546084
]
Anoop Sam John commented on HBASE-15638:
I mean the Backward compatibility break as we change the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545593#comment-15545593
]
stack commented on HBASE-15638:
---
Just MasterObserver has this issue? If just MasterObserver, I could move
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545589#comment-15545589
]
stack commented on HBASE-15638:
---
How are they broken? [~anoop.hbase]
You mean, this kind of change in
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544862#comment-15544862
]
Anoop Sam John commented on HBASE-15638:
We can fix raising a new jira. I can do that based on
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544854#comment-15544854
]
Anoop Sam John commented on HBASE-15638:
[~saint@gmail.com]
Some of the CP method signatures
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544765#comment-15544765
]
Hudson commented on HBASE-15638:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1723 (See
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544418#comment-15544418
]
stack commented on HBASE-15638:
---
The above set of patches passed the jenkins build I'd made for them:
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537173#comment-15537173
]
stack commented on HBASE-15638:
---
HBASE-16741 subtask is about enhancing the build step to add shading and
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535165#comment-15535165
]
stack commented on HBASE-15638:
---
Update:
* HBASE-16264 subtask is good to go; does shading of protobuf
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508044#comment-15508044
]
stack commented on HBASE-15638:
---
Ok. Have a plan and patch for Endpoints in sub-task. Has downside of
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431858#comment-15431858
]
stack commented on HBASE-15638:
---
Oh, [~mbertozzi] has been helping me w/ this stuff.
> Shade protobuf
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431838#comment-15431838
]
stack commented on HBASE-15638:
---
Let me update the discussion on dev list.
> Shade protobuf
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431832#comment-15431832
]
stack commented on HBASE-15638:
---
I now move to the subtask on CPEPs. It will have the work that is attached
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431815#comment-15431815
]
stack commented on HBASE-15638:
---
tl;dr Shading is in hbase-protocol only, not global. Makes it so we can
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398663#comment-15398663
]
stack commented on HBASE-15638:
---
Ok. Putting this aside for the moment. Let me upload latest. Am going to
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398483#comment-15398483
]
stack commented on HBASE-15638:
---
The TestInterfaceAudienceAnnotations is interesting. It is shaded pb not
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397500#comment-15397500
]
Hadoop QA commented on HBASE-15638:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397038#comment-15397038
]
stack commented on HBASE-15638:
---
Few of the test failures are interesting class loading problems Fixed
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396937#comment-15396937
]
stack commented on HBASE-15638:
---
Thank you [~ram_krish] for the review.
bq. The change from
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396908#comment-15396908
]
ramkrishna.s.vasudevan commented on HBASE-15638:
Went thro the review board. Last 2 pages
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394727#comment-15394727
]
Hadoop QA commented on HBASE-15638:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394466#comment-15394466
]
Hadoop QA commented on HBASE-15638:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394133#comment-15394133
]
stack commented on HBASE-15638:
---
Ok. v6 should be better. Includes a commit message describing content too.
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393542#comment-15393542
]
Hadoop QA commented on HBASE-15638:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390894#comment-15390894
]
Hadoop QA commented on HBASE-15638:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390879#comment-15390879
]
stack commented on HBASE-15638:
---
My fault. I had not set 'submit patch'
> Shade protobuf
> --
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389898#comment-15389898
]
Vivek Koppuru commented on HBASE-15638:
---
Sorry about the comments, I accidentally put my work into
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388192#comment-15388192
]
stack commented on HBASE-15638:
---
Jenkins is struggling. Let me redo the last patch now HBASE-16263 has been
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387466#comment-15387466
]
ramkrishna.s.vasudevan commented on HBASE-15638:
Thanks [~saint@gmail.com]
> Shade
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387464#comment-15387464
]
ramkrishna.s.vasudevan commented on HBASE-15638:
It applies to the new patch also.
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387226#comment-15387226
]
stack commented on HBASE-15638:
---
Is the +1 for the included subtask HBASE-16263 too? Does it apply to the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387225#comment-15387225
]
stack commented on HBASE-15638:
---
Yessir [~ram_krish].
I just uploaded a new version of the patch. It
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387187#comment-15387187
]
ramkrishna.s.vasudevan commented on HBASE-15638:
+1. Thanks Stack. So the only thing
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387143#comment-15387143
]
stack commented on HBASE-15638:
---
Uploaded patch that changes all pb references from com.google.protobuf to
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386857#comment-15386857
]
stack commented on HBASE-15638:
---
Thank you [~ghelmling] That helps. I think best thing for me to do is try
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386820#comment-15386820
]
Gary Helmling commented on HBASE-15638:
---
[~saint@gmail.com], I'm not sure how to make this work
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386794#comment-15386794
]
stack commented on HBASE-15638:
---
Made a subtask out of moving all protos under hbase-protocol.
Chatted w/
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385343#comment-15385343
]
stack commented on HBASE-15638:
---
Stuff to move out of hbase-server and back into hbase-protocol if we go
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385114#comment-15385114
]
stack commented on HBASE-15638:
---
Reassessing your suggestion @busbey:
bq. if all references to our
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369213#comment-15369213
]
Andrew Purtell commented on HBASE-15638:
We should look at this again in light of HADOOP-13363
>
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242485#comment-15242485
]
stack commented on HBASE-15638:
---
Grand
> Shade protobuf
> --
>
> Key:
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242463#comment-15242463
]
Duo Zhang commented on HBASE-15638:
---
OK, I got your point. There would be some maven tricks. We need to
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242459#comment-15242459
]
stack commented on HBASE-15638:
---
Thanks [~busbey] Let me look at where we are making direct reference to
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242452#comment-15242452
]
stack commented on HBASE-15638:
---
shade happens at the package stage... which is before unit test and the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242447#comment-15242447
]
Duo Zhang commented on HBASE-15638:
---
Yes, let's only reference the classes in com.google.protobuf in
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242448#comment-15242448
]
Sean Busbey commented on HBASE-15638:
-
{quote}
bq. ... then turning that into a shaded module with
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242440#comment-15242440
]
Sean Busbey commented on HBASE-15638:
-
sorry, I wasn't careful with my language in the prior message.
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242439#comment-15242439
]
Sean Busbey commented on HBASE-15638:
-
I thought we were stuck with a reference to the HDFS protobuf
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242437#comment-15242437
]
stack commented on HBASE-15638:
---
bq. ... then turning that into a shaded module with relocated protobufs in
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242433#comment-15242433
]
Sean Busbey commented on HBASE-15638:
-
it'll be awkward but makes it clear in the source when we mean
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242422#comment-15242422
]
stack commented on HBASE-15638:
---
Thanks [~busbey]
That mean, you think this patche's approach where all
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242420#comment-15242420
]
stack commented on HBASE-15638:
---
I don't think I can do this [~sergey.soldatov] For sure the later PB
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242278#comment-15242278
]
Duo Zhang commented on HBASE-15638:
---
I mean we can use the shade plugin when building artifacts without
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241822#comment-15241822
]
Sean Busbey commented on HBASE-15638:
-
we can't rely on shading doing relocation within the hadoop
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241687#comment-15241687
]
Sergey Soldatov commented on HBASE-15638:
-
The simple way is just to exclude ByteString from the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241606#comment-15241606
]
stack commented on HBASE-15638:
---
I see. Let me try your suggestion [~sergey.soldatov] How do I deal with
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241576#comment-15241576
]
Sergey Soldatov commented on HBASE-15638:
-
Well, for me the approach to change sources to use
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241419#comment-15241419
]
stack commented on HBASE-15638:
---
[~Apache9]
I don't follow. I am using the maven shade plugin in
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241414#comment-15241414
]
stack commented on HBASE-15638:
---
I think we can work on this in a different issue. asyncwal no longer
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240483#comment-15240483
]
Duo Zhang commented on HBASE-15638:
---
And I suppose the patch here is only used for testing? The shading
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240437#comment-15240437
]
Duo Zhang commented on HBASE-15638:
---
Oh I mean a sub-module... Just like 'hbase-common', maybe
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239820#comment-15239820
]
stack commented on HBASE-15638:
---
The substitutions I'm running:
{code}
802 find . -name *.java -exec
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239664#comment-15239664
]
stack commented on HBASE-15638:
---
bq. Well, that depends on whether HDFS dependency it are included in the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239659#comment-15239659
]
stack commented on HBASE-15638:
---
bq. we could make a module that creates a shaded/relocated version of the
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239497#comment-15239497
]
Sergey Soldatov commented on HBASE-15638:
-
{qoute}
So, shade in the top-level pom?
{quote}
Yep.
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239441#comment-15239441
]
Sean Busbey commented on HBASE-15638:
-
we could make a module that creates a shaded/relocated version
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239421#comment-15239421
]
stack commented on HBASE-15638:
---
Thank you for taking a look [~sergey.soldatov]
bq. What is the reason to
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239404#comment-15239404
]
stack commented on HBASE-15638:
---
When you say 'new project', you mean a new standalone project up on github
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238637#comment-15238637
]
Duo Zhang commented on HBASE-15638:
---
Let's move FanOutOneBlockAsyncDFSOutputSaslHelper and related
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238343#comment-15238343
]
Sergey Soldatov commented on HBASE-15638:
-
[~stack] What is the reason to do it in this way? IMHO
[
https://issues.apache.org/jira/browse/HBASE-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238283#comment-15238283
]
stack commented on HBASE-15638:
---
This depends on HBASE-15174
> Shade protobuf
> --
>
>
77 matches
Mail list logo
