[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543182#comment-16543182 ] Hudson commented on HBASE-19572: Results for branch master [build #395 on

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542889#comment-16542889 ] Hudson commented on HBASE-19572: Results for branch branch-2.1 [build #55 on

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542868#comment-16542868 ] Hudson commented on HBASE-19572: Results for branch branch-2 [build #977 on

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542808#comment-16542808 ] Hudson commented on HBASE-19572: Results for branch branch-2.0 [build #543 on

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542442#comment-16542442 ] Toshihiro Suzuki commented on HBASE-19572: -- Thank you for reviewing and committing the patch

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542439#comment-16542439 ] Reid Chan commented on HBASE-19572: --- Pushed to master, branch-2, branch-2.0, branch-2.1. Thanks for

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541731#comment-16541731 ] Toshihiro Suzuki commented on HBASE-19572: -- [~reidchan] It seems like we can apply the last

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541439#comment-16541439 ] Reid Chan commented on HBASE-19572: --- Could you provide a patch for branch-2 as well? ping [~brfrn169]

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541376#comment-16541376 ] Hadoop QA commented on HBASE-19572: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541280#comment-16541280 ] Reid Chan commented on HBASE-19572: --- I will commit it tomorrow if there's no other objection >

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541276#comment-16541276 ] Reid Chan commented on HBASE-19572: --- +1 But it's still good to go, we can do some refactor in another

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541259#comment-16541259 ] Reid Chan commented on HBASE-19572: --- I just think your patch can do much better if you get to know

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541225#comment-16541225 ] Toshihiro Suzuki commented on HBASE-19572: -- Thank you [~reidchan]. I just attached a new patch.

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541214#comment-16541214 ] Reid Chan commented on HBASE-19572: --- Got your mind, ok. > RegionMover should use the configured

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-12 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541207#comment-16541207 ] Toshihiro Suzuki commented on HBASE-19572: -- [~reidchan] I think we need the "conf" as a member

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-11 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541150#comment-16541150 ] Reid Chan commented on HBASE-19572: --- Oh ye, it's {{RegionMoverBuilder}}. {code} +private static

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-11 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541128#comment-16541128 ] Toshihiro Suzuki commented on HBASE-19572: -- Thank you for reviewing [~reidchan]. Regarding 1,

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-11 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541081#comment-16541081 ] Reid Chan commented on HBASE-19572: --- LGTM overall. Two questions, 1. Any particular reason why

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-10 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538105#comment-16538105 ] Toshihiro Suzuki commented on HBASE-19572: -- It looks like the patch is still valid. Could you

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538100#comment-16538100 ] Hadoop QA commented on HBASE-19572: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-07-09 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537948#comment-16537948 ] Toshihiro Suzuki commented on HBASE-19572: -- I just uploaded the latest patch to make sure it

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Esteban Gutierrez (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489162#comment-16489162 ] Esteban Gutierrez commented on HBASE-19572: --- Thanks [~brfrn169]! I will go ahead and commit

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489080#comment-16489080 ] Toshihiro Suzuki commented on HBASE-19572: -- It looks good. Could you please take a look at this?

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488914#comment-16488914 ] Hadoop QA commented on HBASE-19572: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488690#comment-16488690 ] Toshihiro Suzuki commented on HBASE-19572: -- I just attached the rebased patch. > RegionMover

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488666#comment-16488666 ] Hadoop QA commented on HBASE-19572: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-24 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488663#comment-16488663 ] Toshihiro Suzuki commented on HBASE-19572: -- I just reattached the latest patch to rerun a QA. >

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474839#comment-16474839 ] Hadoop QA commented on HBASE-19572: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-05-14 Thread Esteban Gutierrez (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474644#comment-16474644 ] Esteban Gutierrez commented on HBASE-19572: --- lgtm [~brfrn169]. Will upload again, just to make

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-17 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440494#comment-16440494 ] Toshihiro Suzuki commented on HBASE-19572: -- The last build looks good. Could you please take a

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440472#comment-16440472 ] Hadoop QA commented on HBASE-19572: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-16 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440344#comment-16440344 ] Toshihiro Suzuki commented on HBASE-19572: -- I attached the latest patch again to re-run a build.

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-04 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426423#comment-16426423 ] Toshihiro Suzuki commented on HBASE-19572: -- I'm not familiar with shadedjars but it seems like

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424959#comment-16424959 ] Hadoop QA commented on HBASE-19572: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2018-04-03 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424840#comment-16424840 ] Toshihiro Suzuki commented on HBASE-19572: -- I just attached a rebased patch. Could you please

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2017-12-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307239#comment-16307239 ] Hadoop QA commented on HBASE-19572: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

2017-12-31 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307216#comment-16307216 ] Toshihiro Suzuki commented on HBASE-19572: -- I just attached a patch. [~esteban] if you have