[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767357#comment-13767357
]
stack commented on HBASE-8884:
--
Continuation over in HBASE-9461. Changes CallRunner so not
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762774#comment-13762774
]
Chao Shi commented on HBASE-8884:
-
stack, could you please explain a little bit more on
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762979#comment-13762979
]
stack commented on HBASE-8884:
--
[~stepinto] I was reading rpc code so I could better review
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763140#comment-13763140
]
Chao Shi commented on HBASE-8884:
-
I haven't thought on the interface clearly. You idea
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762706#comment-13762706
]
Chao Shi commented on HBASE-8884:
-
Hi stack,
Thanks for your review comments.
bq.
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762717#comment-13762717
]
stack commented on HBASE-8884:
--
As is, it is hard to follow what is going on.
+ Do we have
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761070#comment-13761070
]
stack commented on HBASE-8884:
--
Looking more at this patch, we effectively double the number
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761073#comment-13761073
]
stack commented on HBASE-8884:
--
I took a looksee and my claim above this patch doubling the
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761074#comment-13761074
]
stack commented on HBASE-8884:
--
Yeah, so why is CallRunner a Runnable at all?
As you can
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761078#comment-13761078
]
stack commented on HBASE-8884:
--
Shouldn't MONITORED_RPC be in Handler rather than kept as a
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752828#comment-13752828
]
stack commented on HBASE-8884:
--
I commented over in hbase-9101 [~stepinto]
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725073#comment-13725073
]
Chao Shi commented on HBASE-8884:
-
Hi stack,
I opened another issue (HBASE-9101) and
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721833#comment-13721833
]
stack commented on HBASE-8884:
--
The commit needs a release note.
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721839#comment-13721839
]
stack commented on HBASE-8884:
--
I added a few comments up on rb.
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712606#comment-13712606
]
Ted Yu commented on HBASE-8884:
---
Integrated to trunk.
Thanks for the patch, Chao.
Thanks
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712867#comment-13712867
]
Hudson commented on HBASE-8884:
---
FAILURE: Integrated in HBase-TRUNK #4269 (See
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713201#comment-13713201
]
Hudson commented on HBASE-8884:
---
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #623
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713257#comment-13713257
]
Chao Shi commented on HBASE-8884:
-
Good! Thanks all reviewers.
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710907#comment-13710907
]
Hadoop QA commented on HBASE-8884:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711210#comment-13711210
]
Jesse Yates commented on HBASE-8884:
+1 LGTM
Pluggable RpcScheduler
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711266#comment-13711266
]
Ted Yu commented on HBASE-8884:
---
Will wait for one more day for additional comments before
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708814#comment-13708814
]
Jesse Yates commented on HBASE-8884:
this is kind of a big patch... mind putting it up
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709371#comment-13709371
]
Chao Shi commented on HBASE-8884:
-
bq. this is kind of a big patch... mind putting it up
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707871#comment-13707871
]
Ted Yu commented on HBASE-8884:
---
Patch v6 looks good. Minor comments below.
For
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707951#comment-13707951
]
Hadoop QA commented on HBASE-8884:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707954#comment-13707954
]
Ted Yu commented on HBASE-8884:
---
I don't have other comments.
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13706603#comment-13706603
]
Chao Shi commented on HBASE-8884:
-
Hi [~stack] and [~yuzhih...@gmail.com], any comments on
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702975#comment-13702975
]
Hadoop QA commented on HBASE-8884:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703119#comment-13703119
]
Hadoop QA commented on HBASE-8884:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703413#comment-13703413
]
Hadoop QA commented on HBASE-8884:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13704011#comment-13704011
]
Ted Yu commented on HBASE-8884:
---
{code}
+public class SimpleRpcScheduler implements
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13704203#comment-13704203
]
Hadoop QA commented on HBASE-8884:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701381#comment-13701381
]
Ted Yu commented on HBASE-8884:
---
Why is SimpleRpcScheduler embedded in RpcServer ?
I would
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701433#comment-13701433
]
stack commented on HBASE-8884:
--
Thank you for digging in on this issue.
Related, our Elliott
[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701488#comment-13701488
]
Chao Shi commented on HBASE-8884:
-
Thanks for reviewing this patch so quickly.
{quote}
35 matches
Mail list logo
