[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359178#comment-16359178 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358907#comment-16358907 ] Prasanth Jayachandran commented on HIVE-18359: -- Minor golden file updates for 3 test

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358234#comment-16358234 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358170#comment-16358170 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357507#comment-16357507 ] Prasanth Jayachandran commented on HIVE-18359: -- Rebased patch > Extend grouping set limits

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357384#comment-16357384 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356856#comment-16356856 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356435#comment-16356435 ] Jesus Camacho Rodriguez commented on HIVE-18359: +1 pending tests > Extend grouping set

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356007#comment-16356007 ] Prasanth Jayachandran commented on HIVE-18359: -- Added negative test. > Extend grouping set

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355909#comment-16355909 ] Prasanth Jayachandran commented on HIVE-18359: -- minor change suggested by [~kgyrtkirk] >

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355323#comment-16355323 ] Prasanth Jayachandran commented on HIVE-18359: -- rebased patch > Extend grouping set limits

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345194#comment-16345194 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345092#comment-16345092 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344781#comment-16344781 ] Zoltan Haindrich commented on HIVE-18359: - I was taking a quick look; and something have caught my

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344683#comment-16344683 ] Prasanth Jayachandran commented on HIVE-18359: -- Added fix for HIVE-18523 along with this

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337714#comment-16337714 ] Zoltan Haindrich commented on HIVE-18359: - I've opened HIVE-18513 to fix that issue > Extend

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337626#comment-16337626 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337564#comment-16337564 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336285#comment-16336285 ] Prasanth Jayachandran commented on HIVE-18359: -- Rebased the patch. To handle mapperIsAbsent,

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322261#comment-16322261 ] Zoltan Haindrich commented on HIVE-18359: - I was unable to create a test for this - (

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321959#comment-16321959 ] Zoltan Haindrich commented on HIVE-18359: - I was thinking about a similar situation when I was

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321842#comment-16321842 ] Prasanth Jayachandran commented on HIVE-18359: -- [~kgyrtkirk] The assumption around handling

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319894#comment-16319894 ] Zoltan Haindrich commented on HIVE-18359: -

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319776#comment-16319776 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319727#comment-16319727 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319304#comment-16319304 ] Prasanth Jayachandran commented on HIVE-18359: -- bq. I'm not sure how, but it seems to me that

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319074#comment-16319074 ] Zoltan Haindrich commented on HIVE-18359: - HIVE-18413 fixes a probable npe - and a slight chance

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319048#comment-16319048 ] Prasanth Jayachandran commented on HIVE-18359: -- [~kgyrtkirk] Thanks for looking at this.

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318297#comment-16318297 ] Zoltan Haindrich commented on HIVE-18359: - I've applied HIVE-18413 ; and now it's possible to run

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318209#comment-16318209 ] Zoltan Haindrich commented on HIVE-18359: - [~prasanth_j] that NPE seems to be a leftover bug after

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317719#comment-16317719 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317672#comment-16317672 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313927#comment-16313927 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313830#comment-16313830 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313802#comment-16313802 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313701#comment-16313701 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312461#comment-16312461 ] Pengcheng Xiong commented on HIVE-18359: LGTM +1 pending tests. :) > Extend grouping set limits

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309835#comment-16309835 ] Hive QA commented on HIVE-18359: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-18359) Extend grouping set limits from int to long

[ https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309774#comment-16309774 ] Hive QA commented on HIVE-18359: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||