GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/175
[WIP][HIVEMALL-230] Revise Optimizer Implementation
## What changes were proposed in this pull request?
Revise Optimizer implementation.
1. Revise default hyperparameters
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/173
[HIVEMALL-227][DOC] Removed md5 and replace sha1 with sha512 following new
ASF policy
## What changes were proposed in this pull request?
Removed md5 and replace sha1 with sha512
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/171
Merged. Thanks!
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/172
Merged, thanks!
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/171#discussion_r233324312
--- Diff:
spark/spark-2.3/src/test/scala/org/apache/spark/sql/hive/XGBoostSuite.scala ---
@@ -77,6 +77,7 @@ final class XGBoostSuite extends
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/171#discussion_r233288186
--- Diff: spark/pom.xml ---
@@ -52,6 +52,12 @@
hivemall-core
${project.version
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/171#discussion_r233287740
--- Diff:
spark/spark-2.3/src/main/scala/org/apache/spark/sql/hive/HivemallOps.scala ---
@@ -1935,18 +1935,6 @@ object HivemallOps
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/171#discussion_r233287092
--- Diff:
spark/spark-2.3/src/test/scala/org/apache/spark/sql/hive/XGBoostSuite.scala ---
@@ -77,6 +77,7 @@ final class XGBoostSuite extends
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/170
[WIP][HIVEMALL-223] Add -kv_map and -vk_map option to to_ordered_list UDAF
## What changes were proposed in this pull request?
Add `-kv_map` and `-vk_map` option
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/163
@jaxony Merged with some modification. Thank you for your first
contribution to Apache Hivemall!
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/168
We might need to set asf mirror to avoid timeout by the default ASF
repository.
https://maven.apache.org/guides/mini/guide-mirror-settings.html
https://code.i-harness.com/ja/q
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/168
```
[WARNING] Could not transfer metadata
org.apache.hivemall:hivemall-spark2.1:0.5.1-incubating-SNAPSHOT/maven-metadata.xml
from/to apache.snapshots (https://repository.apache.org
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/168
See what happens.
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/168#discussion_r227797186
--- Diff: .travis.yml ---
@@ -35,7 +40,7 @@ notifications:
email: false
script:
- - ./bin/run_travis_tests.sh
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/168#discussion_r227796760
--- Diff: .travis.yml ---
@@ -1,5 +1,10 @@
sudo: false
+cache:
+ timeout: 1500
+ directories:
+ - $HOME/.m2
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/168
@maropu
Is this `clean` required?
https://github.com/apache/incubator-hivemall/blob/master/bin/run_travis_tests.sh#L42
---
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/169
[HIVEMALL-222] Introduce Gradient Clipping to avoid exploding gradient to
General Classifier/Regressor
## What changes were proposed in this pull request?
Avoid [exploding
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/168
Seems not working..
`timeout: 1000` helps (?)
https://docs.travis-ci.com/user/caching/#setting-the-timeout
Please add `[HIVEMALL-221]` to the PR title.
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226845079
--- Diff: core/src/main/java/hivemall/fm/Feature.java ---
@@ -383,4 +383,10 @@ public static void l2normalize(@Nonnull final
Feature[] features
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226579427
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578559
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578817
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578495
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226579051
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578854
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578153
--- Diff: core/src/main/java/hivemall/fm/Feature.java ---
@@ -383,4 +383,10 @@ public static void l2normalize(@Nonnull final
Feature[] features
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226525857
--- Diff: core/src/main/java/hivemall/mf/CofactorizationUDTF.java ---
@@ -0,0 +1,574 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226243032
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,638 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226241124
--- Diff: core/src/main/java/hivemall/mf/CofactorizationUDTF.java ---
@@ -0,0 +1,574 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226237654
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226239653
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226239017
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226204201
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226202891
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226198983
--- Diff: core/src/main/java/hivemall/mf/FactorizedModel.java ---
@@ -30,25 +30,25 @@
import javax.annotation.concurrent.NotThreadSafe
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226199747
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/167#discussion_r226199666
--- Diff: core/src/main/java/hivemall/mf/CofactorModel.java ---
@@ -0,0 +1,629 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/166
[HIVEMALL-219] Fixed LDA bug for single update and added unit tests
## What changes were proposed in this pull request?
Fixed LDA bug for single update and added unit tests
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/165
[HIVEMALL-219][BUGFIX] Fixed NPE in finalizeTraining()
## What changes were proposed in this pull request?
Fixed NPE in finalizeTraining() where there are no training example
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/164
[HIVEMALL-218] Fixed train_lda NPE where input row is null
## What changes were proposed in this pull request?
Fixed NegativeArraySizeException where input is NULL of `train_lda
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/163
Please add a unit test and evaluate this function on Hive environment.
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/163#discussion_r215564184
--- Diff: core/src/main/java/hivemall/ftvec/text/OkapiBM25UDF.java ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/162#discussion_r215535078
--- Diff: docs/gitbook/tips/emr.md ---
@@ -21,15 +21,15 @@
## Prerequisite
Learn how to use Hive with Elastic MapReduce (EMR
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/162#discussion_r214870585
--- Diff: docs/gitbook/tips/hadoop_tuning.md ---
@@ -75,13 +75,13 @@ feature_dimensions (2^24 by the default) * 4 bytes
(float) * 2 (iff covariance
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/160#discussion_r214800712
--- Diff: core/src/main/java/hivemall/tools/math/IsInfiniteUDF.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/159
[HIVEMALL-214][DOC] Update userguide for General Classifier/Regressor
example
## What changes were proposed in this pull request?
Refine user guide for generic classifier
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/158
@chezou Merged. Thank you for your first contribution!
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r214236762
--- Diff: docs/gitbook/supervised_learning/tutorial.md ---
@@ -0,0 +1,457 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r214222772
--- Diff: docs/gitbook/supervised_learning/tutorial.md ---
@@ -0,0 +1,461 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r214226384
--- Diff: docs/gitbook/supervised_learning/tutorial.md ---
@@ -0,0 +1,461 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r214223029
--- Diff: docs/gitbook/supervised_learning/tutorial.md ---
@@ -0,0 +1,461 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r214223937
--- Diff: docs/gitbook/supervised_learning/tutorial.md ---
@@ -0,0 +1,461 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r213890176
--- Diff: docs/gitbook/getting_started/tutorial.md ---
@@ -0,0 +1,493 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning with Apache
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r213890053
--- Diff: docs/gitbook/getting_started/tutorial.md ---
@@ -0,0 +1,493 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning with Apache
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r213890384
--- Diff: docs/gitbook/SUMMARY.md ---
@@ -25,6 +25,7 @@
* [Installation](getting_started/installation.md)
* [Install as permanent
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/158#discussion_r213890012
--- Diff: docs/gitbook/getting_started/tutorial.md ---
@@ -0,0 +1,493 @@
+
+
+# Step-by-Step Tutorial on Supervised Learning with Apache
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/157
[HIVEMALL-212] Fix Classifier/Regressor not to forward zero weighted values
## What changes were proposed in this pull request?
Feature with weight = 0.0 need not to be saved
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/156
confirmed optimizer is working fine using a9a classification.
https://gist.github.com/myui/a33a06ff3cf7db0e63ba46ec29703e43
---
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/156
[HIVEMALL-211][BUGFIX] Fixed Optimizer for regularization updates
## What changes were proposed in this pull request?
This PR fixes a bug of regularization scheme of Optimizer
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/155
@takuti will merge after EMR tests. FYI
---
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/155
[HIVEMALL-201-2] Evaluate, fix and document FFM
## What changes were proposed in this pull request?
Applied some refactoring to #149
This PR closes #149
## What type
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r211470802
--- Diff:
core/src/main/java/hivemall/fm/FieldAwareFactorizationMachineModel.java ---
@@ -123,17 +117,18 @@ void updateWi(final double dloss
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/139
@maropu is this PR still WIP?
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/154
@takuti thank you for the comments. Reflected your reviews.
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/154
@takuti could you review this PR?
---
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/154
[HIVEMALL-210][BUGFIX] Fix a bug in lda_predict/plsa_predict
## What changes were proposed in this pull request?
Fixed a bug in lda_predict/plsa_predict that duplicated term
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r205390805
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineModel.java ---
@@ -399,9 +399,8 @@ public void initRandom(int factor, long seed
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r200611442
--- Diff:
core/src/main/java/hivemall/fm/FieldAwareFactorizationMachineModel.java ---
@@ -51,11 +50,6 @@
public
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r200605210
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -351,19 +370,29 @@ private static void writeBuffer(@Nonnull ByteBuffer
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r200604967
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -351,19 +370,29 @@ private static void writeBuffer(@Nonnull ByteBuffer
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r200590772
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -283,9 +293,16 @@ public void process(Object[] args) throws
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/153
@iijima-satoshi LGTM. Merged. Thank you for your contribution!
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r200093417
--- Diff:
core/src/main/java/hivemall/fm/FieldAwareFactorizationMachineModel.java ---
@@ -259,9 +255,9 @@ protected final float eta(@Nonnull final
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/153
@iijima-satoshi
Thank you for the contribution. Will merge testing.
@takuti
You need to update Lucene version to `5.5.5` in `tokenize_ja_kuromoji`.
https
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
> -lambda 0.0001 (default), -init_v adjusted_random
0.6756640217829124 0.8644404496920104
> -lambda 0.001, -init_v adjusted_random
0.6749224090
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
revising in
https://github.com/myui/incubator-hivemall/commits/HIVEMALL-201-2
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
@takuti with the modified default hyperparameter of FM, the performance of
FM is getting worse.
Before
> 0.6736798239047873 (mae) 0.858938110314545 (rmse)
Af
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/135
I'm going to merge this PR to master. If you find any problem, please
comment here.
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/135
For K-minimum Values (KMV) and Sketch related codes, I'll create an another
JIRA ticket.
For other UDFs, we accept incoming PRs.
https://docs.google.com/spreadsheets/d
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/135
@jeromebanks I'm considering to merge this PR. Could you review if possible?
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
We need to remain the default hyperparameter of FM as it is for backward
compatibility. I'll take care of it on merging.
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
@takuti Sure.
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r191645232
--- Diff:
core/src/test/java/hivemall/fm/FieldAwareFactorizationMachineUDTFTest.java ---
@@ -256,6 +256,19 @@ public void testEarlyStopping
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r191309443
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineModel.java ---
@@ -92,6 +92,14 @@ protected float getW(int i
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r191308798
--- Diff: core/src/main/java/hivemall/fm/FMArrayModel.java ---
@@ -80,6 +80,11 @@ public float getW(@Nonnull final Feature x) {
@Override
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r191309836
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineModel.java ---
@@ -92,6 +92,14 @@ protected float getW(int i
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r191298514
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -379,23 +379,28 @@ protected void checkInputVector(@Nonnull final
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
This kind of behavior could often be happen and Libffm's early stopping
strategy is too aggressive.
```
7 0.43239 0.46952
8 0.42362 0.46999
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
```
iter tr_logloss va_logloss
1 0.49738 0.48776
2 0.47383 0.47995
3 0.46366 0.47480
4 0.45561
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r190843344
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -352,9 +352,13 @@ private static void writeBuffer(@Nonnull ByteBuffer
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r190842171
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -563,6 +580,10 @@ protected void runTrainingIteration(int iterations
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/150
Merged Thanks.
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
It might be better to reconsider `eta0` when enabling `l2norm` by the
default and by enlarging`max_init_size`. In my experience for FM, init random
size should be small when the avg feature
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
@takuti so then, better to enable l2_norm by the default and
`-disable_l2norm` to disable l2 normalization. My concern is that L2
normalization performed worse for small datasets
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
Also, it's better to revise default `-iters` from 1 to 10 (at least 10
iterations with early stopping).
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
BTW, it might be better to implement `early stopping` using validation data.
https://github.com/guestwalk/libffm
We can use a similar approaches to `_validationRatio` used
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
@takuti Thank you for detailed verification. Let's disable linear term by
the default.
Remove `-disable_wi` and `-enable_wi` (alias `-linear_term` ) to enable
linear term
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/149
@takuti I advice to check 2-3 updates to investigate how gradient updates
differ.
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/145#discussion_r184281067
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -69,13 +69,10 @@
private static final int READ_TIMEOUT_MS
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/145#discussion_r184277838
--- Diff:
core/src/main/java/hivemall/ftvec/trans/QuantifiedFeaturesUDTF.java ---
@@ -87,32 +87,37 @@ public StructObjectInspector
initialize
1 - 100 of 549 matches
Mail list logo
