[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-30 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r214240248 --- Diff: docs/gitbook/supervised_learning/tutorial.md --- @@ -0,0 +1,457 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-30 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213941931 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213892214 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213896045 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213897864 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213898251 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213898101 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213892353 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213898139 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213891358 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213895853 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213892034 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213891598 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #158: [HIVEMALL-215] Add step-by-step tutori...

2018-08-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/158#discussion_r213891146 --- Diff: docs/gitbook/getting_started/tutorial.md --- @@ -0,0 +1,493 @@ + + +# Step-by-Step Tutorial on Supervised Learning

[GitHub] incubator-hivemall pull request #154: [HIVEMALL-210][BUGFIX] Fix a bug in ld...

2018-08-05 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/154#discussion_r207773897 --- Diff: core/src/test/java/hivemall/utils/struct/SortableKeyValueTest.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-hivemall pull request #154: [HIVEMALL-210][BUGFIX] Fix a bug in ld...

2018-08-05 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/154#discussion_r207774408 --- Diff: core/src/main/java/hivemall/utils/struct/KeySortableValue.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-hivemall issue #154: [HIVEMALL-210][BUGFIX] Fix a bug in lda_predi...

2018-08-05 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/154 👀 Let me check...get back to you in a day. ---

[GitHub] incubator-hivemall pull request #152: [HIVEMALL-207] Remove ddl/*.td.hql fil...

2018-06-21 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/152 [HIVEMALL-207] Remove ddl/*.td.hql files maintained for a specific company's use ## What changes were proposed in this pull request? Remove `resources/ddl/*.td.hql` files

[GitHub] incubator-hivemall pull request #135: [WIP][HIVEMALL-145] Merge Brickhouse f...

2018-05-31 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/135#discussion_r192006959 --- Diff: core/src/main/java/hivemall/tools/sanity/AssertUDF.java --- @@ -25,8 +25,10 @@ @Description(name = "a

[GitHub] incubator-hivemall issue #149: [HIVEMALL-201] Evaluate, fix and document FFM

2018-05-30 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 @myui Documentation and system tests on my laptop/EMR have been conducted, and I'm now ready for review. Could you look more deeply into the updates for merge? ---

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-30 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191694422 --- Diff: core/src/test/java/hivemall/fm/FieldAwareFactorizationMachineUDTFTest.java --- @@ -256,6 +256,19 @@ public void testEarlyStopping

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191317118 --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineModel.java --- @@ -92,6 +92,14 @@ protected float getW(int i

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-29 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191315508 --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java --- @@ -379,23 +379,28 @@ protected void checkInputVector(@Nonnull final

[GitHub] incubator-hivemall issue #149: [WIP][HIVEMALL-201] Evaluate, fix and documen...

2018-05-28 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 Make sense as a compromise in terms of memory consumption. I'll note on documentation to clarify the fact that our `-early_stopping` option does not return the best of the best

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191149655 --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java --- @@ -352,9 +352,13 @@ private static void writeBuffer(@Nonnull

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191145436 --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java --- @@ -563,6 +580,10 @@ protected void runTrainingIteration(int iterations

[GitHub] incubator-hivemall issue #149: [WIP][HIVEMALL-201] Evaluate, fix and documen...

2018-05-22 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 I'll change default options and consider to implement early stopping option as you suggested. > What happens without `-l2norm` ? Once we drop instance-wise

[GitHub] incubator-hivemall issue #149: [WIP][HIVEMALL-201] Evaluate, fix and documen...

2018-05-22 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 ### With linear terms Hivemall ```sql INSERT OVERWRITE TABLE criteo.ffm_model SELECT train_ffm(features, label, '-init_v random -max_init_value 0.5

[GitHub] incubator-hivemall issue #149: [WIP][HIVEMALL-201] Evaluate, fix and documen...

2018-05-17 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 Note: I've extended LIBFFM code so it uses linear terms: https://github.com/takuti/criteo-ffm/commit/9aca61d93ed8f583025729206ed0dbfd54806a44 However, I cannot observe significant

[GitHub] incubator-hivemall issue #149: [WIP][HIVEMALL-201] Evaluate, fix and documen...

2018-05-17 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 Evaluation has been conducted at: [takuti/criteo-ffm](https://github.com/takuti/criteo-ffm). See the repository for detail. As an example, I have used tiny data provided

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-16 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/149 [WIP][HIVEMALL-201] Evaluate, fix and document FFM ## What changes were proposed in this pull request? - Evaluate FFM so Hivemall replicates comparable accuracy to [LIBFFM

[GitHub] incubator-hivemall issue #148: [HIVEMALL-193] Implement a tool for generatin...

2018-04-24 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/148 Now `mvn org.apache.hivemall:hivemall-docs:generate-funcs-list` automatically updates `docs/gitbook/*` ---

[GitHub] incubator-hivemall pull request #148: [HIVEMALL-193] Implement a tool for ge...

2018-04-24 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/148#discussion_r183652781 --- Diff: tools/hivemall-docs/pom.xml --- @@ -0,0 +1,173 @@ + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org

[GitHub] incubator-hivemall pull request #148: [HIVEMALL-193] Implement a tool for ge...

2018-04-24 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/148#discussion_r183640278 --- Diff: tools/hivemall-docs/pom.xml --- @@ -0,0 +1,173 @@ + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org

[GitHub] incubator-hivemall pull request #148: [HIVEMALL-193] Implement a tool for ge...

2018-04-22 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/148 [HIVEMALL-193] Implement a tool for generating a list of Hivemall UDFs ## What changes were proposed in this pull request? Automatically generate a list of UDFs

[GitHub] incubator-hivemall pull request #147: [HIVEMALL-197] Update Apache incubator...

2018-04-19 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/147 [HIVEMALL-197] Update Apache incubator logo ## What changes were proposed in this pull request? * Avoid direct link to ASF's file * Update Apache incubator logo

[GitHub] incubator-hivemall pull request #145: [HIVEMALL-191] Add Kryo serialization ...

2018-04-18 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/145#discussion_r182618689 --- Diff: core/src/main/java/hivemall/ftvec/trans/QuantifiedFeaturesUDTF.java --- @@ -87,30 +80,27 @@ public StructObjectInspector initialize

[GitHub] incubator-hivemall pull request #145: [HIVEMALL-191] Add Kryo serialization ...

2018-04-18 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/145#discussion_r182611062 --- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java --- @@ -69,13 +69,10 @@ private static final int READ_TIMEOUT_MS

[GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...

2018-04-18 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/146#discussion_r182323012 --- Diff: core/src/main/java/hivemall/smile/tools/TreeExportUDF.java --- @@ -141,17 +141,17 @@ public String getDisplayString(String[] children

[GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...

2018-04-17 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/146 [HIVEMALL-192] Fix typos: graphvis -> graphviz ## What changes were proposed in this pull request? Fix crucial typos. ## What type of PR is it? Improvem

[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-17 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/145 Added serialization test case to all existing GenericUDF/UDTF tests. Vanilla UDF and UDAF tests are not changed. @myui Could you review? ---

[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-16 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/145 // Fixing scala test failure ---

[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-15 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/145 I just `grep KryoException` to find target UDFs. @myui Please let me know if there are other UDFs we have to test/fix. Maybe, should we add `testSerialization` to all existing UDF tests? ---

[GitHub] incubator-hivemall pull request #145: [HIVEMALL-191] Add Kryo serialization ...

2018-04-15 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/145 [HIVEMALL-191] Add Kryo serialization test to existing workaround code ## What changes were proposed in this pull request? Add Kryo serialization test to existing workaround code

[GitHub] incubator-hivemall pull request #143: [HIVEMALL-189] Create a list of all fu...

2018-04-12 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/143 [HIVEMALL-189] Create a list of all functions ## What changes were proposed in this pull request? Create a list of all functions in the documentation. In order to make

[GitHub] incubator-hivemall pull request #142: [HIVEMALL-188] Avoid KryoException: ja...

2018-04-09 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/142 [HIVEMALL-188] Avoid KryoException: java.lang.NullPointerException ## What changes were proposed in this pull request? Fix a bug in `tokenize_ja` that occasionally raises

[GitHub] incubator-hivemall pull request #134: CI sets enforced env variable JAVA8_HO...

2018-02-20 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/134 CI sets enforced env variable JAVA8_HOME ## What changes were proposed in this pull request? The variable is enforced for building Spark 2.2; See: http

[GitHub] incubator-hivemall issue #126: [HIVEMALL-162] Support L1 normalization

2017-12-18 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/126 Oh, thanks! Fixed and directly pushed to master. ---

[GitHub] incubator-hivemall issue #126: [HIVEMALL-162] Support L1 normalization

2017-12-14 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/126 Ah, good point. I've updated the document. ---

[GitHub] incubator-hivemall issue #126: [HIVEMALL-162] Support L1 normalization

2017-12-13 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/126 Another option is to provide generic `normalize` interface like [sklearn](http://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.normalize.html) ---

[GitHub] incubator-hivemall pull request #125: [HIVEMALL-18] approx_distinct_count UD...

2017-11-23 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/125#discussion_r152906912 --- Diff: core/src/main/java/hivemall/sketch/hll/ApproxCountDistinctUDAF.java --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache

[GitHub] incubator-hivemall pull request #124: [HIVEMALL-157] Return empty list for u...

2017-10-30 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/124 [HIVEMALL-157] Return empty list for uninitialized query handler ## What changes were proposed in this pull request? Even though `to_ordered_list` allows (and ignores) NULL

[GitHub] incubator-hivemall pull request #121: [HIVEMALL-151] Support Matrix conversi...

2017-10-12 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/121#discussion_r144199528 --- Diff: core/src/main/java/hivemall/math/matrix/MatrixUtils.java --- @@ -70,4 +77,259 @@ public void apply(int i, int value

[GitHub] incubator-hivemall pull request #121: [HIVEMALL-151] Support Matrix conversi...

2017-10-12 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/121#discussion_r144195570 --- Diff: core/src/main/java/hivemall/math/matrix/MatrixUtils.java --- @@ -70,4 +77,259 @@ public void apply(int i, int value

[GitHub] incubator-hivemall pull request #121: [HIVEMALL-151] Support Matrix conversi...

2017-10-12 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/121#discussion_r144200688 --- Diff: core/src/main/java/hivemall/math/matrix/MatrixUtils.java --- @@ -70,4 +77,259 @@ public void apply(int i, int value

[GitHub] incubator-hivemall issue #120: [HIVEMALL-149] Add tiny script for updating r...

2017-10-04 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/120 @myui updated with README ---

[GitHub] incubator-hivemall pull request #120: [HIVEMALL-149] Add tiny script for upd...

2017-10-03 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/120 [HIVEMALL-149] Add tiny script for updating resources/ddl/define-* ## What changes were proposed in this pull request? Add a script for updating resources/ddl/define

[GitHub] incubator-hivemall issue #119: [WIP][HIVEMALL-148] Add a script for merging ...

2017-10-03 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/119 This script is experimental; since the original Python script is a little bit confusing to maintain, I will simplify it more from here. If JIRA updates is unnecessary, the script might

[GitHub] incubator-hivemall pull request #119: [WIP][HIVEMALL-148] Add a script for m...

2017-10-03 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/119 [WIP][HIVEMALL-148] Add a script for merging GitHub PR ## What changes were proposed in this pull request? Add a script which helps merging GitHub PR lie: - https

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-03 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/118#discussion_r142328137 --- Diff: core/src/main/java/hivemall/tools/text/WordNgramsUDF.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-02 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/118#discussion_r142312467 --- Diff: core/src/main/java/hivemall/tools/text/NgramsUDF.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-02 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/118#discussion_r142300766 --- Diff: core/src/main/java/hivemall/tools/text/NgramsUDF.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-02 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/118#discussion_r142298457 --- Diff: core/src/main/java/hivemall/tools/text/NgramsUDF.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-02 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/118#discussion_r142296940 --- Diff: core/src/main/java/hivemall/tools/text/NgramsUDF.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #118: [HIVEMALL-146] Yet another UDF to gene...

2017-10-01 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/118 [HIVEMALL-146] Yet another UDF to generate n-grams ## What changes were proposed in this pull request? Add a new UDF `to_ngrams(array words, int minSize, int maxSize)` which

[GitHub] incubator-hivemall pull request #115: [WIP][HIVEMALL-124][BUGFIX] Fixed bugs...

2017-09-15 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/115#discussion_r139072140 --- Diff: core/src/main/java/hivemall/evaluation/BinaryResponsesMeasures.java --- @@ -79,8 +91,15 @@ public static double IDCG(final int n

[GitHub] incubator-hivemall pull request #115: [WIP][HIVEMALL-124][BUGFIX] Fixed bugs...

2017-09-15 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/115#discussion_r139082280 --- Diff: core/src/main/java/hivemall/evaluation/BinaryResponsesMeasures.java --- @@ -120,48 +148,65 @@ public static int countTruePositive(final

[GitHub] incubator-hivemall issue #107: [HIVEMALL-132] Generalize f1score UDAF to sup...

2017-09-01 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/107 @myui Would you double-check this? I can merge whenever you are ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hivemall issue #107: [HIVEMALL-132] Generalize f1score UDAF to sup...

2017-08-28 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/107 Importantly, in case that the number of mappers is 1, fixing the bug in `merge()` does not change the output value; you might see the same result `0.42483920860540153` even if the bug

[GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/110#discussion_r135462565 --- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java --- @@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder

[GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/110#discussion_r135459734 --- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java --- @@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135453504 --- Diff: core/src/main/java/hivemall/evaluation/F1ScoreUDAF.java --- @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135447663 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135450159 --- Diff: core/src/test/java/hivemall/evaluation/FMeasureUDAFTest.java --- @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135450892 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,261 @@ + + + + +# Binary problems

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135454567 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,261 @@ + + + + +# Binary problems

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-28 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r135449941 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...

2017-08-27 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/110#discussion_r135446415 --- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java --- @@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder

[GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...

2017-08-27 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/110 [HIVEMALL-142] Implement SingularizeUDF ## What changes were proposed in this pull request? Implement `singularize(string word)` to obtain singular form of `word

[GitHub] incubator-hivemall pull request #109: [HIVEMALL-140] Rename function name of...

2017-08-23 Thread takuti
GitHub user takuti opened a pull request: https://github.com/apache/incubator-hivemall/pull/109 [HIVEMALL-140] Rename function name of PrecisionUDAF and RecallUDAF ## What changes were proposed in this pull request? Since `precision` is a reserved keyword from Hive 2.2.0

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-22 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134491966 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134138339 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,232 @@ + + + + +# Binary problems

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134156437 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134145129 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134141170 --- Diff: docs/gitbook/eval/multilabel_classification_measures.md --- @@ -0,0 +1,144 @@ + + + + +# Multi-label classification

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134145190 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134142978 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134135290 --- Diff: core/src/main/java/hivemall/UDAFEvaluatorWithOptions.java --- @@ -0,0 +1,97 @@ +package hivemall; + +import

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134146143 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,232 @@ + + + + +# Binary problems

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134151609 --- Diff: core/src/test/java/hivemall/evaluation/FMeasureUDAFTest.java --- @@ -0,0 +1,355 @@ +package hivemall.evaluation; + +import

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134146276 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134157657 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134141649 --- Diff: docs/gitbook/eval/multilabel_classification_measures.md --- @@ -0,0 +1,144 @@ + + + + +# Multi-label classification

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134154140 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134149484 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134145321 --- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java --- @@ -18,118 +18,387 @@ */ package hivemall.evaluation

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134141399 --- Diff: docs/gitbook/eval/multilabel_classification_measures.md --- @@ -0,0 +1,144 @@ + + + + +# Multi-label classification

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134140877 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,232 @@ + + + + +# Binary problems

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134136143 --- Diff: core/src/test/java/hivemall/evaluation/FMeasureUDAFTest.java --- @@ -0,0 +1,355 @@ +package hivemall.evaluation; + +import

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-08-21 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r134137472 --- Diff: docs/gitbook/eval/binary_classification_measures.md --- @@ -0,0 +1,232 @@ + + + + +# Binary problems

  1   2   >