[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #421: Add friendly names to catalog tables

2019-08-28 Thread GitBox
rdsr commented on a change in pull request #421: Add friendly names to catalog tables URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r318886702 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ## @@ -43,6 +43,11 @@ public

[GitHub] [incubator-iceberg] shardulm94 commented on issue #417: Adding support for time-based partitioning on long column type

2019-08-28 Thread GitBox
shardulm94 commented on issue #417: Adding support for time-based partitioning on long column type URL: https://github.com/apache/incubator-iceberg/issues/417#issuecomment-526015243 @rdblue Any thoughts here? I think the issue is that for long types, we cannot assume the granularity of

[GitHub] [incubator-iceberg] jun-he commented on issue #357: Add in and not in predicates

2019-08-28 Thread GitBox
jun-he commented on issue #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#issuecomment-525996826 @rdblue Addressed all the comments. Thanks. This is an automated message from the

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

2019-08-28 Thread GitBox
jerryshao commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r318864226 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveClientPool.java

[GitHub] [incubator-iceberg] rdblue commented on issue #424: Dates.day and Timestamp.day's return type should return DateType

2019-08-28 Thread GitBox
rdblue commented on issue #424: Dates.day and Timestamp.day's return type should return DateType URL: https://github.com/apache/incubator-iceberg/pull/424#issuecomment-525924624 +1 Thanks for working on this, @manishmalhotrawork!

[GitHub] [incubator-iceberg] manishmalhotrawork opened a new pull request #424: Dates.day and Timestamp.day's return type should return DateType

2019-08-28 Thread GitBox
manishmalhotrawork opened a new pull request #424: Dates.day and Timestamp.day's return type should return DateType URL: https://github.com/apache/incubator-iceberg/pull/424 this PR is for #279 thanks @rdblue for explaining with patience ! cc @aokolnychyi

[GitHub] [incubator-iceberg] xabriel commented on issue #404: Provide a way to show metadata for a Hadoop table

2019-08-28 Thread GitBox
xabriel commented on issue #404: Provide a way to show metadata for a Hadoop table URL: https://github.com/apache/incubator-iceberg/issues/404#issuecomment-525866590 @waterlx are you currently working on this? This is an

[GitHub] [incubator-iceberg] xabriel commented on issue #404: Provide a way to show metadata for a Hadoop table

2019-08-28 Thread GitBox
xabriel commented on issue #404: Provide a way to show metadata for a Hadoop table URL: https://github.com/apache/incubator-iceberg/issues/404#issuecomment-525866344 Adding link to PR that implemented the functionality for HiveMetaStore:

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318684701 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -131,18 +136,22

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318680962 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5 +306,110

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318677280 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -131,18

[GitHub] [incubator-iceberg] rdblue commented on issue #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
rdblue commented on issue #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#issuecomment-525821869 @chenjunjiedada, looks like there is a test failure. Can you take a look?

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318677245 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -131,18 +136,22

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318675192 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -131,18

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318675192 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -131,18

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318669321 ## File path: spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTableUtil.java ## @@ -116,4

[GitHub] [incubator-iceberg] rdblue commented on issue #91: Ignore unsupported partition fields

2019-08-28 Thread GitBox
rdblue commented on issue #91: Ignore unsupported partition fields URL: https://github.com/apache/incubator-iceberg/pull/91#issuecomment-525813946 @fbocse, sorry for the delay getting back to you on this one. I merged your changes with a few updates in #411. Thank you for fixing this!

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-08-28 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525813417 Credit for this one should go to @fbocse, who authored the original PR. Looks like that was lost when GitHub

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table

2019-08-28 Thread GitBox
chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r318666900 ## File path: spark/src/test/java/org/apache/iceberg/spark/source/TestSparkTableUtil.java ## @@

[GitHub] [incubator-iceberg] rdblue merged pull request #411: Ignore unsupported partition transforms for forward compatibility

2019-08-28 Thread GitBox
rdblue merged pull request #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iceberg] rdblue closed issue #32: Ignore unsupported partition fields

2019-08-28 Thread GitBox
rdblue closed issue #32: Ignore unsupported partition fields URL: https://github.com/apache/incubator-iceberg/issues/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iceberg] rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility

2019-08-28 Thread GitBox
rdblue commented on issue #411: Ignore unsupported partition transforms for forward compatibility URL: https://github.com/apache/incubator-iceberg/pull/411#issuecomment-525812283 Thanks for reviewing, @aokolnychyi! I'll merge this.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #421: Add friendly names to catalog tables

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #421: Add friendly names to catalog tables URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r318662709 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java ## @@ -43,6 +43,11 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

2019-08-28 Thread GitBox
rdblue commented on a change in pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406#discussion_r318661845 ## File path: hive/src/main/java/org/apache/iceberg/hive/HiveClientPool.java

[GitHub] [incubator-iceberg] jerryshao opened a new pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

2019-08-28 Thread GitBox
jerryshao opened a new pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406 Iceberg's hive catalog has two issues work with Spark embedded metastore: 1. Iceberg requires HIVE_LOCKS which

[GitHub] [incubator-iceberg] jerryshao closed pull request #406: Throw an exception when using Iceberg with Spark embedded metastore

2019-08-28 Thread GitBox
jerryshao closed pull request #406: Throw an exception when using Iceberg with Spark embedded metastore URL: https://github.com/apache/incubator-iceberg/pull/406 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iceberg] aokolnychyi opened a new issue #423: Optimize ParquetMetricsRowGroupFilter by using ByteBuffer

2019-08-28 Thread GitBox
aokolnychyi opened a new issue #423: Optimize ParquetMetricsRowGroupFilter by using ByteBuffer URL: https://github.com/apache/incubator-iceberg/issues/423 See [this link](https://github.com/apache/incubator-iceberg/pull/398#discussion_r318196009) for details.

[GitHub] [incubator-iceberg] aokolnychyi opened a new issue #422: Consider building a HadoopCatalog

2019-08-28 Thread GitBox
aokolnychyi opened a new issue #422: Consider building a HadoopCatalog URL: https://github.com/apache/incubator-iceberg/issues/422 I think we should consider building a `Catalog` implementation that relies on renames for committing metadata. That way, users will be able to avoid using HMS