yujiantao commented on issue #743: [spark-3] Bump Apache spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#issuecomment-581109895
@rdblue Sorry for late reply as I was on a long vocation. I have refreshed
the commit.
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373827428
##
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchWrite.java
##
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373827417
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java
jerryshao commented on issue #743: [spark-3] Bump Apache spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#issuecomment-581282605
LGTM.
This is an automated message from the Apache Git Service.
jun-he commented on issue #760: Operators In / Not In are not implemented for
Residuals
URL:
https://github.com/apache/incubator-iceberg/issues/760#issuecomment-581180942
@arina-ielchiieva I have submitted a PR to address this issue. Thanks.
rdblue commented on a change in pull request #315: Incremental processing
implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373878272
##
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##
@@ -103,7 +122,35 @@
rdblue commented on a change in pull request #315: Incremental processing
implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373878737
##
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##
@@ -42,6 +42,16 @@
rdblue merged pull request #315: Incremental processing implementation
URL: https://github.com/apache/incubator-iceberg/pull/315
This is an automated message from the Apache Git Service.
To respond to the message, please log
rdblue commented on a change in pull request #766: Support in and notIn in
ResidualVisitor
URL: https://github.com/apache/incubator-iceberg/pull/766#discussion_r373879036
##
File path:
api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
##
@@ -195,6
rdblue commented on a change in pull request #766: Support in and notIn in
ResidualVisitor
URL: https://github.com/apache/incubator-iceberg/pull/766#discussion_r373879733
##
File path: api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java
##
@@ -156,4 +158,46
rdsr commented on a change in pull request #315: Incremental processing
implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373885093
##
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##
@@ -42,6 +42,16 @@ private
rdblue commented on a change in pull request #766: Support in and notIn in
ResidualVisitor
URL: https://github.com/apache/incubator-iceberg/pull/766#discussion_r373879282
##
File path: api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java
##
@@ -156,4 +158,46
rdblue commented on issue #764: make org.apache.iceberg. PartitionData public
URL:
https://github.com/apache/incubator-iceberg/issues/764#issuecomment-581183953
I don't think that this necessarily needs to be public. It's an internal
implementation that is not part of the public API. What
rdblue commented on a change in pull request #743: [spark-3] Bump Apache spark
to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373880002
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestForwardCompatibility.java
rdblue commented on issue #743: [spark-3] Bump Apache spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#issuecomment-581183783
Thanks @yujiantao! I caught a couple more minor things. Once those are done,
we should be good to merge.
rdblue commented on a change in pull request #743: [spark-3] Bump Apache spark
to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373879959
##
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestTables.java
##
@@ -37,7
rdblue commented on issue #761: Suggestion for newbie getting started guide
URL:
https://github.com/apache/incubator-iceberg/issues/761#issuecomment-581184156
Hadoop tables cannot be used with a file system that doesn't support atomic
rename. They should only be used with HDFS or a local
jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373880462
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##
rdblue commented on issue #751: Add an option to decide whether to delete data
files in Catalog.dropTable()
URL:
https://github.com/apache/incubator-iceberg/issues/751#issuecomment-581184344
I think you're saying you want a purge option that deletes metadata, but not
data?
I'm
rdblue commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373880794
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##
rdblue commented on issue #315: Incremental processing implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#issuecomment-581182311
@rdsr, I'm merging this. Thanks for all your work on it!
I think we do need to follow up pretty quickly with better validations for
rdblue edited a comment on issue #764: make org.apache.iceberg. PartitionData
public
URL:
https://github.com/apache/incubator-iceberg/issues/764#issuecomment-581183953
I don't think that this necessarily needs to be public. It's an internal
implementation that is not part of the public
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897760
##
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestTables.java
##
@@
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897701
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestForwardCompatibility.java
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897701
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestForwardCompatibility.java
edgarRd commented on issue #213: Incomplete Iceberg to ORC column mapping
URL:
https://github.com/apache/incubator-iceberg/issues/213#issuecomment-581215477
Closing this issue since it was fixed in #227
This is an automated
edgarRd closed issue #213: Incomplete Iceberg to ORC column mapping
URL: https://github.com/apache/incubator-iceberg/issues/213
This is an automated message from the Apache Git Service.
To respond to the message, please log
edgarRd commented on issue #768: Metrics javadoc fixes #767
URL: https://github.com/apache/incubator-iceberg/pull/768#issuecomment-581219056
PTAL @rdsr @rdblue - Thanks!
This is an automated message from the Apache Git
edgarRd commented on a change in pull request #768: Metrics javadoc fixes #767
URL: https://github.com/apache/incubator-iceberg/pull/768#discussion_r373907688
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -114,6 +114,56 @@ public abstract File
edgarRd opened a new pull request #768: Metrics javadoc fixes #767
URL: https://github.com/apache/incubator-iceberg/pull/768
Adding javadoc to `Metrics` following `Parquet` metrics implementation as
proposal.
This is an
jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373900954
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##
jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373900954
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##
jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373900954
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##
edgarRd opened a new issue #767: Clarify / Document metrics contract
URL: https://github.com/apache/incubator-iceberg/issues/767
The metrics contract is a bit unclear, from the implementation. Since it's
not defined in the spec, having the only fully implemented metrics for Parquet,
and
34 matches
Mail list logo
