[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506977#comment-16506977
]
Vyacheslav Daradur commented on IGNITE-5097:
Moved status to "Open", because we are waiting
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433800#comment-16433800
]
Vyacheslav Daradur commented on IGNITE-5097:
Moving to 2.6 because CPP part is not finished.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343237#comment-16343237
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], as environment variable backward-compatibility
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343056#comment-16343056
]
Vyacheslav Daradur commented on IGNITE-5097:
Hi, [~vozerov], [~isapego], could you please
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196825#comment-16196825
]
Vyacheslav Daradur commented on IGNITE-5097:
Hi, [~vozerov], [~isapego], could you please
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185819#comment-16185819
]
Vladimir Ozerov commented on IGNITE-5097:
-
Moving to 2.4 due to huge impact and additional
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166495#comment-16166495
]
Pavel Tupitsyn commented on IGNITE-5097:
[~daradurvs] looks good to me.
> BinaryMarshaller
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166373#comment-16166373
]
Vyacheslav Daradur commented on IGNITE-5097:
[~ptupitsyn], thank you for the notes!
I've
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166170#comment-16166170
]
Pavel Tupitsyn commented on IGNITE-5097:
[~daradurvs]:
1) Make sure code lines fit within 120
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166042#comment-16166042
]
Vyacheslav Daradur commented on IGNITE-5097:
[~ptupitsyn], could you please review the new
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165876#comment-16165876
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego], could you please port the new
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165858#comment-16165858
]
Vyacheslav Daradur commented on IGNITE-5097:
[~vozerov],
bq. It should be set to false by
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148761#comment-16148761
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], TC showed one more minor issue. Please, merge
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148755#comment-16148755
]
Vladimir Ozerov commented on IGNITE-5097:
-
[~daradurvs],
Legacy features is part of normal
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147583#comment-16147583
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego], thanks a lot!
Rerun
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147544#comment-16147544
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], I've fixed issues. Please, re-merge changes from
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147462#comment-16147462
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], TC shows compilation errors. I'll take a look.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147386#comment-16147386
]
Vyacheslav Daradur commented on IGNITE-5097:
Hi, [~isapego], I've merged your changes to the
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147239#comment-16147239
]
ASF GitHub Bot commented on IGNITE-5097:
GitHub user daradurvs opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147240#comment-16147240
]
ASF GitHub Bot commented on IGNITE-5097:
Github user daradurvs closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120600#comment-16120600
]
ASF GitHub Bot commented on IGNITE-5097:
Github user daradurvs closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120271#comment-16120271
]
ASF GitHub Bot commented on IGNITE-5097:
GitHub user daradurvs opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089914#comment-16089914
]
Anton Vinogradov commented on IGNITE-5097:
--
[~vozerov],
I don't think we should extend
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089542#comment-16089542
]
Vyacheslav Daradur commented on IGNITE-5097:
[~vozerov], why do you think that?
As I
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087710#comment-16087710
]
Vladimir Ozerov commented on IGNITE-5097:
-
[~daradurvs], [~avinogradov],
Folks, I think it makes
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081832#comment-16081832
]
Vyacheslav Daradur commented on IGNITE-5097:
Latest
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080066#comment-16080066
]
Pavel Tupitsyn commented on IGNITE-5097:
.NET part looks good to me.
> BinaryMarshaller should
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080019#comment-16080019
]
Vyacheslav Daradur commented on IGNITE-5097:
I've added compatibility mode, as it had been
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072717#comment-16072717
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego],
I've rebased the branch.
>
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072701#comment-16072701
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs],
Also, please merge changes from master, cause
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072682#comment-16072682
]
Vyacheslav Daradur commented on IGNITE-5097:
[~avinogradov],
Makes sense. Thank you for the
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072676#comment-16072676
]
Anton Vinogradov commented on IGNITE-5097:
--
[~daradurvs],
seems you changing storage format, so
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036800#comment-16036800
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], yeah, I'm going to do it in the nearest time.
>
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036753#comment-16036753
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego], as far as I know, you've already
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036721#comment-16036721
]
Pavel Tupitsyn commented on IGNITE-5097:
Got it. Sounds good to me then.
> BinaryMarshaller
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036716#comment-16036716
]
Vyacheslav Daradur commented on IGNITE-5097:
bq. Not sure though about int<->uint casts.
It
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036696#comment-16036696
]
Pavel Tupitsyn commented on IGNITE-5097:
[~daradurvs], .NET changes look good to me in general,
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036396#comment-16036396
]
Vyacheslav Daradur commented on IGNITE-5097:
I've ported the code to .NET platform.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033515#comment-16033515
]
Vyacheslav Daradur commented on IGNITE-5097:
[~vozerov], thanks for your notes.
bq.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033134#comment-16033134
]
Vladimir Ozerov commented on IGNITE-5097:
-
[~daradurvs], in general fix looks good. Several
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030867#comment-16030867
]
Vyacheslav Daradur commented on IGNITE-5097:
I've prepared separate PR where only arrays
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030851#comment-16030851
]
ASF GitHub Bot commented on IGNITE-5097:
GitHub user daradurvs opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029510#comment-16029510
]
Vyacheslav Daradur commented on IGNITE-5097:
[~vozerov], what about Decimal's bytes array?
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028566#comment-16028566
]
Vyacheslav Daradur commented on IGNITE-5097:
Ok, I'll rollback incompatible changes shortly.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028478#comment-16028478
]
Igor Sapego commented on IGNITE-5097:
-
Well, OK, it's all ready for C++ already then. Waiting for
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028455#comment-16028455
]
Vladimir Ozerov commented on IGNITE-5097:
-
[~isapego], yes, it makes sense for strings as well.
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028239#comment-16028239
]
Igor Sapego commented on IGNITE-5097:
-
[~vozerov], what about strings?
> BinaryMarshaller should
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028235#comment-16028235
]
Vladimir Ozerov commented on IGNITE-5097:
-
I would only do that for arrays. Applying varlens to
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028233#comment-16028233
]
Pavel Tupitsyn commented on IGNITE-5097:
I agree.
> BinaryMarshaller should write ints in
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028232#comment-16028232
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego], [~ptupitsyn], [~vozerov]
Let's
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026571#comment-16026571
]
Igor Sapego commented on IGNITE-5097:
-
I mean only sizes of course.
> BinaryMarshaller should write
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026565#comment-16026565
]
Pavel Tupitsyn commented on IGNITE-5097:
[~isapego] I agree.
> primitive arrays
You mean array
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026554#comment-16026554
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], [~ptupitsyn], so what is the decision, guys? I
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019533#comment-16019533
]
Pavel Tupitsyn commented on IGNITE-5097:
Shifting entire stream is not an option, I think. Too
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019517#comment-16019517
]
Vyacheslav Daradur commented on IGNITE-5097:
bq. I pretty much sure, it's expensive in Java
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019512#comment-16019512
]
Vyacheslav Daradur commented on IGNITE-5097:
bq. I pretty much sure, it's expensive in Java
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019507#comment-16019507
]
Igor Sapego commented on IGNITE-5097:
-
{quote}
Is resize-array or shift operations "expensive" in
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019501#comment-16019501
]
Vyacheslav Daradur commented on IGNITE-5097:
bq. the max size is going to take 5 bytes then
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012416#comment-16012416
]
Pavel Tupitsyn commented on IGNITE-5097:
[~isapego]
> write length in varint, always using 4
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012325#comment-16012325
]
Igor Sapego commented on IGNITE-5097:
-
Of course, we can still write length in varint, always using 4
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012281#comment-16012281
]
Igor Sapego commented on IGNITE-5097:
-
In Java collection are being written in *one* call, not in
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010578#comment-16010578
]
Igor Sapego commented on IGNITE-5097:
-
Hi, guys,
There is an issue with implementation for
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006158#comment-16006158
]
Igor Sapego commented on IGNITE-5097:
-
Well, on the second thought, there will be always about 6
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006153#comment-16006153
]
Pavel Tupitsyn commented on IGNITE-5097:
For {{UUID}} it does not make sense, since it is a pair
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006066#comment-16006066
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego],
I didn't implement it, because it
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005097#comment-16005097
]
Igor Sapego commented on IGNITE-5097:
-
[~daradurvs], what about {{Date}} and {{Timestamp}} types? It
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995157#comment-15995157
]
Vyacheslav Daradur commented on IGNITE-5097:
[Varint encoding
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995144#comment-15995144
]
ASF GitHub Bot commented on IGNITE-5097:
GitHub user daradurvs opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986291#comment-15986291
]
Vyacheslav Daradur commented on IGNITE-5097:
[~isapego] I'll create them after implementation
[
https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986266#comment-15986266
]
Igor Sapego commented on IGNITE-5097:
-
This will affect platforms, so we need subtickets for C++ and
70 matches
Mail list logo