[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178158#comment-17178158 ] Mark Robert Miller edited comment on SOLR-14636 at 8/15/20, 5:16 AM: -

[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178158#comment-17178158 ] Mark Robert Miller edited comment on SOLR-14636 at 8/15/20, 5:15 AM: -

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178158#comment-17178158 ] Mark Robert Miller commented on SOLR-14636: --- I think Noble pretty much has it. Nothing I’m

[jira] [Commented] (SOLR-14722) timeAllowed should track from the very start of the request

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178154#comment-17178154 ] ASF subversion and git services commented on SOLR-14722: Commit

[GitHub] [lucene-solr] dsmiley merged pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-14 Thread GitBox
dsmiley merged pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14596) Add equals()/hashCode() impls to SolrJ Request objects

2020-08-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178149#comment-17178149 ] David Smiley commented on SOLR-14596: - I didn't consider someone would want to put a request into a

[GitHub] [lucene-solr] chatman commented on pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-14 Thread GitBox
chatman commented on pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#issuecomment-674337102 @atris I've brought your changes and updated this PR. There are test failures now, seems like something may have changed in master to have caused these since the time David

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178137#comment-17178137 ] Noble Paul commented on SOLR-14636: --- {quote}but lets celebrate a tremendous milestone and have it

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
MarcusSorealheis commented on a change in pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r470914648 ## File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java ## @@ -29,6 +29,6 @@ @Documented

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
MarcusSorealheis commented on a change in pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r470914648 ## File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java ## @@ -29,6 +29,6 @@ @Documented

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
MarcusSorealheis commented on a change in pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r470914210 ## File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java ## @@ -29,6 +29,6 @@ @Documented

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
MarcusSorealheis commented on a change in pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r470914277 ## File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java ## @@ -29,6 +29,6 @@ @Documented

[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178114#comment-17178114 ] Mark Robert Miller edited comment on SOLR-14636 at 8/15/20, 12:19 AM:

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178114#comment-17178114 ] Mark Robert Miller commented on SOLR-14636: --- My wife is actually a bigger stopping pressure

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178112#comment-17178112 ] Mark Robert Miller commented on SOLR-14636: --- To clear up some confusion on that: why do I do

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178110#comment-17178110 ] Mark Robert Miller commented on SOLR-14636: --- I don’t really choose where to stop, sometimes I

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178107#comment-17178107 ] ASF subversion and git services commented on SOLR-14680: Commit

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178106#comment-17178106 ] Noble Paul commented on SOLR-14680: --- Thanks [~gerlowskija] I just pulled that file into master as

[jira] [Comment Edited] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178103#comment-17178103 ] Noble Paul edited comment on SOLR-14680 at 8/14/20, 11:52 PM: -- {quote}The

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
anshumg commented on a change in pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#discussion_r470907966 ## File path: solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java ## @@ -29,6 +29,6 @@ @Documented @Retention(SOURCE)

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178104#comment-17178104 ] Ishan Chattopadhyaya commented on SOLR-14636: - David: I think we first need to make sure all

[jira] [Comment Edited] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178103#comment-17178103 ] Noble Paul edited comment on SOLR-14680 at 8/14/20, 11:44 PM: -- {quote}The

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178103#comment-17178103 ] Noble Paul commented on SOLR-14680: --- {quote}The main reason is that there's nothing in Solr that uses

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178098#comment-17178098 ] Mark Robert Miller commented on SOLR-14636: --- Oh man, I think I may have finally gotten fast

[jira] [Commented] (SOLR-14753) More Consistent Thread Safety Annotations.

2020-08-14 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178093#comment-17178093 ] Marcus Eagan commented on SOLR-14753: - [~anshum] Can you take a look and merge this PR. It's very

[jira] [Commented] (SOLR-14731) Make use of @SolrSingleThreaded Implementation

2020-08-14 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178092#comment-17178092 ] Marcus Eagan commented on SOLR-14731: - This PR makes use of an improved name, but will cause

[jira] [Updated] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2020-08-14 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Worah updated LUCENE-9450: - Status: Patch Available (was: Open) > Taxonomy index should use DocValues not StoredFields >

[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-14 Thread GitBox
MarcusSorealheis opened a new pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755 # Description The thread safety annotation names are misleading/confusing for readers, yet the purpose is to clarify things for readers. Here is a fix proposed by

[jira] [Commented] (SOLR-14596) Add equals()/hashCode() impls to SolrJ Request objects

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178086#comment-17178086 ] Jason Gerlowski commented on SOLR-14596: My immediate objective here is tests, which are

[GitHub] [lucene-solr] janhoy closed pull request #1255: SOLR-14216 Exclude Healthcheck from auth (do not merge)

2020-08-14 Thread GitBox
janhoy closed pull request #1255: URL: https://github.com/apache/lucene-solr/pull/1255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (SOLR-14753) More Consistent Thread Safety Annotations.

2020-08-14 Thread Marcus Eagan (Jira)
Marcus Eagan created SOLR-14753: --- Summary: More Consistent Thread Safety Annotations. Key: SOLR-14753 URL: https://issues.apache.org/jira/browse/SOLR-14753 Project: Solr Issue Type:

[jira] [Resolved] (SOLR-14703) Edismax parser replaces whitespace characters with spaces

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14703. Fix Version/s: 8.7 master (9.0) Resolution: Fixed > Edismax

[jira] [Assigned] (SOLR-14703) Edismax parser replaces whitespace characters with spaces

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-14703: -- Assignee: Jason Gerlowski > Edismax parser replaces whitespace characters with spaces

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2020-08-14 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178079#comment-17178079 ] Marcus Eagan commented on SOLR-13998: - Great. Thanks [~cpoerschke] and [~dsmiley]. > Add thread

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-14 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674270585 256 iterations and no failures yet! This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178058#comment-17178058 ] Michael McCandless commented on LUCENE-8776: [~dsmiley] I am pretty sure your example would

[jira] [Commented] (SOLR-14596) Add equals()/hashCode() impls to SolrJ Request objects

2020-08-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178055#comment-17178055 ] David Smiley commented on SOLR-14596: - Assuming this is just for tests, I suspect we don't need to

[jira] [Commented] (SOLR-14703) Edismax parser replaces whitespace characters with spaces

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178050#comment-17178050 ] ASF subversion and git services commented on SOLR-14703: Commit

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178049#comment-17178049 ] David Smiley commented on SOLR-14636: - I'm concerned of scope-creep in this reference_impl to tackle

[jira] [Commented] (SOLR-14677) DIH doesnt close DataSource when import encounters errors

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178047#comment-17178047 ] ASF subversion and git services commented on SOLR-14677: Commit

[jira] [Commented] (LUCENE-9443) "IndexReader is closed" regression in highlighter

2020-08-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178044#comment-17178044 ] David Smiley commented on LUCENE-9443: -- FYI I had forgotten to push this commit to branch_8x until

[jira] [Comment Edited] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178030#comment-17178030 ] Roman edited comment on LUCENE-8776 at 8/14/20, 8:11 PM: - [~mgibney]  I'll dig

[jira] [Commented] (LUCENE-9443) "IndexReader is closed" regression in highlighter

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178041#comment-17178041 ] ASF subversion and git services commented on LUCENE-9443: - Commit

[GitHub] [lucene-solr] dsmiley merged pull request #1723: SOLR prometheus: simplify concurrent collection

2020-08-14 Thread GitBox
dsmiley merged pull request #1723: URL: https://github.com/apache/lucene-solr/pull/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178036#comment-17178036 ] David Smiley commented on LUCENE-8776: -- (from my message to the dev list last week): Where I work,

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178030#comment-17178030 ] Roman commented on LUCENE-8776: --- I'll dig for more concrete examples but when you pointed out 

[jira] [Comment Edited] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Ram Venkat (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178027#comment-17178027 ] Ram Venkat edited comment on LUCENE-8776 at 8/14/20, 7:22 PM: --  

[jira] [Comment Edited] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Ram Venkat (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178027#comment-17178027 ] Ram Venkat edited comment on LUCENE-8776 at 8/14/20, 7:22 PM: --  

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Ram Venkat (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178027#comment-17178027 ] Ram Venkat commented on LUCENE-8776:   [~mikemccand] The solution we had worked and satisfied

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178026#comment-17178026 ] Jason Gerlowski commented on SOLR-14680: I added the missing package-info to fix precommit.

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178020#comment-17178020 ] ASF subversion and git services commented on SOLR-14680: Commit

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177991#comment-17177991 ] Dawid Weiss commented on LUCENE-8776: - bq. The light-emitting-diode token is repeated a 2nd time (at

[jira] [Commented] (SOLR-14703) Edismax parser replaces whitespace characters with spaces

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177981#comment-17177981 ] ASF subversion and git services commented on SOLR-14703: Commit

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2020-08-14 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177980#comment-17177980 ] Anshum Gupta commented on SOLR-13998: - +1 on fixing this annotation. 

[GitHub] [lucene-solr] gerlowskija merged pull request #1713: SOLR-14703 Edismax parser replaces whitespace characters with spaces

2020-08-14 Thread GitBox
gerlowskija merged pull request #1713: URL: https://github.com/apache/lucene-solr/pull/1713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177977#comment-17177977 ] Michael Gibney commented on LUCENE-8776: {quote}I see this solution as working around the fact

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2020-08-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177969#comment-17177969 ] Christine Poerschke commented on SOLR-13998: +1 to consider replacing the

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class

2020-08-14 Thread GitBox
MarcusSorealheis commented on pull request #1744: URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-674179100 I'm not sure what the end result is of adding all these annotations in the short term, but if it is very challenging to get them reviewed for something as simple

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class

2020-08-14 Thread GitBox
MarcusSorealheis commented on pull request #1744: URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-674178586 @anshumg > The annotation usage is correct, however I haven't taken a look at the code itself to validate if it's meant to be single threaded or not.

[jira] [Commented] (SOLR-14700) CloudSolrClient cannot be used without setting an explicit streamContext

2020-08-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177868#comment-17177868 ] Christine Poerschke commented on SOLR-14700: Thanks [~mabd] for reporting and diagnosing this

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1754: SOLR-14700: add StreamingTest.testCloudSolrStreamWithoutStreamContext() test

2020-08-14 Thread GitBox
cpoerschke opened a new pull request #1754: URL: https://github.com/apache/lucene-solr/pull/1754 https://issues.apache.org/jira/browse/SOLR-14700 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177858#comment-17177858 ] Andrzej Bialecki commented on SOLR-14680: - In my opinion all of these commits should be reverted.

[jira] [Comment Edited] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177852#comment-17177852 ] Roman edited comment on LUCENE-8776 at 8/14/20, 4:14 PM: - {{Sorry for

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177852#comment-17177852 ] Roman commented on LUCENE-8776: --- {{Sorry for crossposting (into the forum and here); I will try to study

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2020-08-14 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177840#comment-17177840 ] Gautam Worah commented on LUCENE-9450: -- I've added a new PR revision with the style modifications

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177838#comment-17177838 ] Michael McCandless commented on LUCENE-8776: OK I think I understand the original example in

[jira] [Commented] (LUCENE-9412) Repro Jenkins jobs failing to fetch build output

2020-08-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177827#comment-17177827 ] Mike Drob commented on LUCENE-9412: --- Comment from infra: {quote}It looks like lucene1 is in our Puppet

[jira] [Commented] (SOLR-14639) Improve concurrency of SlowCompositeReaderWrapper.terms

2020-08-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177826#comment-17177826 ] Erick Erickson commented on SOLR-14639: --- I'll add my thanks, this is one of those thankless

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-14 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674118327 > @mikemccand nevermind I think I found the issue. I think it's ready now. Yay! I will kick off new beasting (of all Lucene core + module tests) on my 128 core

[jira] [Commented] (LUCENE-9447) Make BEST_COMPRESSION compress more aggressively?

2020-08-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177806#comment-17177806 ] Robert Muir commented on LUCENE-9447: - {quote} but I still worry that preset dictionaries would be

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-14 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674108890 > I'm not familiar with the pooled reader stuff, but it seems reasonable to me. I trust the tests (especially w/ added test coverage) far more than I trust my knowledge of

[GitHub] [lucene-solr] joel-bernstein opened a new pull request #1753: Block collapse

2020-08-14 Thread GitBox
joel-bernstein opened a new pull request #1753: URL: https://github.com/apache/lucene-solr/pull/1753 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the

[jira] [Updated] (LUCENE-9461) Query hit highlighting components on top of matches API

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9461: Description: Highlighters. Eventually, you'll have to face them. When a Lucene Query is ran

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177790#comment-17177790 ] Dawid Weiss commented on LUCENE-8776: - [^LUCENE-8776-proof-of-concept.patch] is a proof-of-concept

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-14 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674091972 @mikemccand nevermind I think I found the issue. I think it's ready now. This is an automated message from

[GitHub] [lucene-solr] s1monw merged pull request #1751: Ensure DWPTPool never release any new DWPT after it's closed

2020-08-14 Thread GitBox
s1monw merged pull request #1751: URL: https://github.com/apache/lucene-solr/pull/1751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-8776: Attachment: LUCENE-8776-proof-of-concept.patch > Start offset going backwards has a legitimate

[jira] [Commented] (LUCENE-9462) Fields without positions should still return MatchIterator

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177784#comment-17177784 ] Dawid Weiss commented on LUCENE-9462: - I'd love to. I think I'll finish the entire issue first and

[GitHub] [lucene-solr] madrob commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-14 Thread GitBox
madrob commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468773336 ## File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java ## @@ -240,4 +303,15 @@ protected long calculateLiveMemoryUsage() {

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1714#comment-1714 ] Jason Gerlowski commented on SOLR-14680: The build error Uwe mentioned is fixed, but there's a

[jira] [Comment Edited] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1714#comment-1714 ] Jason Gerlowski edited comment on SOLR-14680 at 8/14/20, 1:37 PM: -- The

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-14 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1711#comment-1711 ] Mark Robert Miller commented on SOLR-14636: --- I’d expect some test instability for a bit. I’ve

[jira] [Commented] (LUCENE-9462) Fields without positions should still return MatchIterator

2020-08-14 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177756#comment-17177756 ] Alan Woodward commented on LUCENE-9462: --- Thanks [~dweiss]! Should we backport this to 8.7 as well?

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-08-14 Thread GitBox
mikemccand commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r470604022 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177740#comment-17177740 ] Dawid Weiss commented on LUCENE-8776: - I don't think it can be rearranged for both positions and

[jira] [Resolved] (LUCENE-9463) Query match region retrieval component, passage scoring and formatting

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9463. - Fix Version/s: master (9.0) Resolution: Fixed > Query match region retrieval component,

[jira] [Commented] (SOLR-14749) Provide a clean API for cluster-level event processing

2020-08-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177739#comment-17177739 ] Andrzej Bialecki commented on SOLR-14749: - {quote}If a plugin wishes to listen to a ZK node

[jira] [Commented] (LUCENE-9463) Query match region retrieval component, passage scoring and formatting

2020-08-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177738#comment-17177738 ] ASF subversion and git services commented on LUCENE-9463: - Commit

[GitHub] [lucene-solr] dweiss merged pull request #1750: LUCENE-9463: Query match region retrieval component, passage scoring and formatting

2020-08-14 Thread GitBox
dweiss merged pull request #1750: URL: https://github.com/apache/lucene-solr/pull/1750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14596) Add equals()/hashCode() impls to SolrJ Request objects

2020-08-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177734#comment-17177734 ] Jason Gerlowski commented on SOLR-14596: For CollectionAdminRequest at least, I think you're

[jira] [Updated] (LUCENE-9461) Query hit highlighting components on top of matches API

2020-08-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9461: Description: Highlighters. Eventually, you'll have to face them. When a Lucene Query is ran

[jira] [Commented] (SOLR-14662) Elevation with distributed search causes NPE

2020-08-14 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177728#comment-17177728 ] Thomas Schmiereck commented on SOLR-14662: -- I simulated that on my local system and found out

[jira] [Commented] (SOLR-14752) Zookeeper status fails on zk 3.6.1 with prometheus enabled

2020-08-14 Thread Philipp Trulson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177721#comment-17177721 ] Philipp Trulson commented on SOLR-14752: I can try, but I haven't developed in Java yet, so I'm

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-14 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-674031356 I pushed a new commit and fixed `ant test -Dtestcase=TestIndexWriter -Dtests.method=testRandomOperations -Dtests.seed=432EB011B0898067 -Dtests.slow=true

[GitHub] [lucene-solr] s1monw commented on pull request #1743: Gradual naming convention enforcement.

2020-08-14 Thread GitBox
s1monw commented on pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#issuecomment-674029698 @mikemccand I opened https://github.com/apache/lucene-solr/pull/1751 for one of the failures and fixed the cloning issue in main line. I can't reproduce any of the other

[GitHub] [lucene-solr] jpountz opened a new pull request #1752: LUCENE-9456: Move metadata about stored fields to the meta file.

2020-08-14 Thread GitBox
jpountz opened a new pull request #1752: URL: https://github.com/apache/lucene-solr/pull/1752 Stored fields have a metadata file, but it currently only records metadata about the index, not the actual data. This commit moves all metadata to the metadata file. Given similarities

[GitHub] [lucene-solr] s1monw commented on pull request #1751: Ensure DWPTPool never release any new DWPT after it's closed

2020-08-14 Thread GitBox
s1monw commented on pull request #1751: URL: https://github.com/apache/lucene-solr/pull/1751#issuecomment-674029292 here is a corresponding test failure: ```org.apache.lucene.index.TestIndexWriterWithThreads > test suite's output saved to

[GitHub] [lucene-solr] s1monw opened a new pull request #1751: Ensure DWPTPool never release any new DWPT after it's closed

2020-08-14 Thread GitBox
s1monw opened a new pull request #1751: URL: https://github.com/apache/lucene-solr/pull/1751 The DWPTPool should not release new DPWTs after it's closed. Yet, if the pool is in a state where it's preventing new writers from being created in order to swap the delete queue it might get

[jira] [Assigned] (SOLR-14752) Zookeeper status fails on zk 3.6.1 with prometheus enabled

2020-08-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14752: -- Assignee: Jan Høydahl > Zookeeper status fails on zk 3.6.1 with prometheus enabled >

[GitHub] [lucene-solr] dweiss opened a new pull request #1750: LUCENE-9463: Query match region retrieval component, passage scoring and formatting

2020-08-14 Thread GitBox
dweiss opened a new pull request #1750: URL: https://github.com/apache/lucene-solr/pull/1750 Separated components from previous PR. Already reviewed by @romseygeek This is an automated message from the Apache Git Service.

  1   2   >