linwenyao commented on pull request #1784:
URL: https://github.com/apache/lucene-solr/pull/1784#issuecomment-681296475
[#1783](https://github.com/apache/lucene-solr/pull/1783) closed.
This is an automated message from the
linwenyao commented on pull request #1784:
URL: https://github.com/apache/lucene-solr/pull/1784#issuecomment-681294701
The master pull request has been committed.
This is an automated message from the Apache Git Service.
To
linwenyao opened a new pull request #1791:
URL: https://github.com/apache/lucene-solr/pull/1791
`throw new CorruptIndexException("invalid deletion count: " + softDelCount +
delCount + " vs maxDoc=" + info.maxDoc(), input);`
It needs to be changed to:
`throw new
linwenyao closed pull request #1783:
URL: https://github.com/apache/lucene-solr/pull/1783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tflobbe commented on a change in pull request #1774:
URL: https://github.com/apache/lucene-solr/pull/1774#discussion_r477616371
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -719,6 +719,7 @@ public void load() {
createHandler(ZK_PATH,
MarcusSorealheis closed pull request #1781:
URL: https://github.com/apache/lucene-solr/pull/1781
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MarcusSorealheis commented on pull request #1781:
URL: https://github.com/apache/lucene-solr/pull/1781#issuecomment-681146332
@thelabdude That's right. We need to compare the hostname. If the test is no
longer broken, then this is fine to close.
ctargett edited a comment on pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#issuecomment-681096031
The MBean Request Handler page is under Monitoring Solr. That makes sense -
you look at MBeans as a way of monitoring stats. I quickly searched the source
files and
ctargett commented on a change in pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#discussion_r477558467
##
File path: solr/solr-ref-guide/src/luke-request-handler.adoc
##
@@ -0,0 +1,77 @@
+= Luke Request Handler
+// Licensed to the Apache Software
ctargett commented on pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#issuecomment-681096031
The MBean Request Handler page is under Monitoring Solr. That makes sense -
you look at MBeans as a way of monitoring stats. I quickly searched the source
files and don't
[
https://issues.apache.org/jira/browse/SOLR-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185445#comment-17185445
]
Neal Sidhwaney commented on SOLR-13645:
---
Hello,
I was wondering if this could be committed. It
[
https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185424#comment-17185424
]
David Smiley edited comment on SOLR-14781 at 8/26/20, 7:48 PM:
---
I used
[
https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185442#comment-17185442
]
Erick Erickson commented on SOLR-14781:
---
Eww. It's going to be "interesting" to remove them
epugh commented on pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#issuecomment-681081838
Thanks for looking at this @ctargett (and I hope your vacation was good).
I modeled the `luke-request-handler.adoc` page on the
`mbean-request-handler.adoc` page,
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185432#comment-17185432
]
Mark Robert Miller commented on SOLR-14636:
---
So as this issue comes to a close and and this
[
https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185424#comment-17185424
]
David Smiley commented on SOLR-14781:
-
I used IntelliJ's "Unused declaration" inspection configured
[
https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-14781:
Attachment: unused.xml
> Remove unused classes
> -
>
> Key:
David Smiley created SOLR-14781:
---
Summary: Remove unused classes
Key: SOLR-14781
URL: https://issues.apache.org/jira/browse/SOLR-14781
Project: Solr
Issue Type: Improvement
Security
mayya-sharipova commented on pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#issuecomment-681055927
@jimczi I have tried to address your comments in 746c8fa. Can you please
continue to review when you have time.
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477509287
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the
ctargett edited a comment on pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#issuecomment-681050148
Eric, the content is good for the new page (I've long wanted to make a page
for each request handler), but can you discuss your idea to put the new page
under the
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504436
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##
@@ -150,11 +150,15 @@ public void setScorer(Scorable
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504337
##
File path:
lucene/core/src/java/org/apache/lucene/search/FilteringLeafFieldComparator.java
##
@@ -32,8 +33,22 @@
DocIdSetIterator
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504147
##
File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java
##
@@ -136,6 +136,13 @@ public int compareValues(T first, T
ctargett commented on pull request #1773:
URL: https://github.com/apache/lucene-solr/pull/1773#issuecomment-681050148
Eric, the content is good for the new page (I've long wanted to make a page
for each request handler), but can you discuss your idea to put the new page
under the UI
[
https://issues.apache.org/jira/browse/SOLR-14778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Megan Carey updated SOLR-14778:
---
Description:
Solr currently "supports" disabling the UpdateLog, though it is "required" for
NRT
cpoerschke opened a new pull request #1790:
URL: https://github.com/apache/lucene-solr/pull/1790
As part of https://issues.apache.org/jira/browse/LUCENE-8626 I noticed that
we have both
*
ravowlga123 commented on pull request #1362:
URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-680999365
@janhoy I have updated the branch but @erikhatcher has concerns regarding
the change it seems. Please do let me know your thoughts on above.
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185324#comment-17185324
]
Nico Tonozzi commented on LUCENE-9378:
--
Oh, and to clarify, we are not sorting by this field, but
cpoerschke commented on a change in pull request #1774:
URL: https://github.com/apache/lucene-solr/pull/1774#discussion_r477438969
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -719,6 +719,7 @@ public void load() {
createHandler(ZK_PATH,
madrob commented on a change in pull request #1785:
URL: https://github.com/apache/lucene-solr/pull/1785#discussion_r477426920
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -121,19 +135,41 @@ public static String
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185304#comment-17185304
]
Mark Robert Miller commented on SOLR-14636:
---
It looks like we will be going into a bit more
[
https://issues.apache.org/jira/browse/SOLR-11245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185294#comment-17185294
]
Houston Putman commented on SOLR-11245:
---
I agree with David that it's better to have something
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185273#comment-17185273
]
Erick Erickson commented on LUCENE-9313:
Feel free to put up what you have now if it's failing
[
https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185257#comment-17185257
]
Ishan Chattopadhyaya commented on SOLR-14726:
-
+1 to SIP. Please feel free to open jira
erikhatcher commented on pull request #1362:
URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-680930577
We need to re-think this change. I believe we need to use `principalClaim`
and bring back, in effect, requiring or not requiring `sub`.
[
https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185244#comment-17185244
]
Alexandre Rafalovitch commented on SOLR-14726:
--
I did some preliminary research and I keep
thelabdude commented on pull request #1781:
URL: https://github.com/apache/lucene-solr/pull/1781#issuecomment-680928789
@MarcusSorealheis thanks for helping out with this branch. The
`SolrPingTest` passes for me locally w/o your fixes, which is not surprising
for ignored tests as a
[
https://issues.apache.org/jira/browse/SOLR-11245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman reassigned SOLR-11245:
-
Assignee: Houston Putman (was: Jan Høydahl)
> Cloud native Dockerfile
>
[
https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185226#comment-17185226
]
Alexandre Rafalovitch commented on SOLR-14597:
--
Posted this on SIP, but it belongs here
janhoy commented on pull request #1362:
URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-680903685
Sorry for not following up on this earlier. @ravowlga123 would you mind to
bring your branch up to date with master, and then I'll merge it.
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185188#comment-17185188
]
Bram Van Dam commented on SOLR-14413:
-
[~slackhappy] Thanks for adding that test. On master, it seems
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185167#comment-17185167
]
Dragan Ivanovic commented on LUCENE-9313:
-
Ok, thank you both [~rcmuir] [~erickerickson]. I will
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185161#comment-17185161
]
Erick Erickson commented on LUCENE-9313:
[~dragan.ivanovic] Currently things are a bit
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185155#comment-17185155
]
Robert Muir commented on LUCENE-9313:
-
[~dragan.ivanovic] As you mentioned, yes there is a
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185149#comment-17185149
]
Dragan Ivanovic commented on LUCENE-9313:
-
Thank you [~rcmuir]. I would like that
[
https://issues.apache.org/jira/browse/SOLR-14779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14779.
---
Resolution: Information Provided
Please raise questions like this on the user's list, we try
[
https://issues.apache.org/jira/browse/SOLR-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14780.
---
Resolution: Invalid
Please raise questions like this on the user's list, we try to reserve
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-9313:
Fix Version/s: master (9.0)
Resolution: Fixed
Status: Resolved (was: Patch
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185125#comment-17185125
]
ASF subversion and git services commented on LUCENE-9313:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185124#comment-17185124
]
ASF subversion and git services commented on LUCENE-9313:
-
Commit
s1monw opened a new pull request #1789:
URL: https://github.com/apache/lucene-solr/pull/1789
Today we need to decide on an index sorting before we create the index.
In some situations it might make a lot of sense to sort an index afterwards
when the index doesn't change anymore or to
Simon Willnauer created LUCENE-9484:
---
Summary: Allow index sorting to happen after the fact
Key: LUCENE-9484
URL: https://issues.apache.org/jira/browse/LUCENE-9484
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9483.
--
Fix Version/s: 8.7
Resolution: Fixed
> Disable per-thread caching of buffers for
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9447.
--
Fix Version/s: 8.7
Resolution: Fixed
> Make BEST_COMPRESSION compress more
[
https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand reopened LUCENE-9483:
--
> Disable per-thread caching of buffers for stored fields
>
Victor Bonchevski created SOLR-14780:
Summary: Solr Server Context Filtering in Auto Suggester not
working
Key: SOLR-14780
URL: https://issues.apache.org/jira/browse/SOLR-14780
Project: Solr
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9456.
--
Fix Version/s: 8.7
Resolution: Fixed
> Stored fields should store the number of chunks
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185099#comment-17185099
]
ASF subversion and git services commented on LUCENE-9447:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185097#comment-17185097
]
ASF subversion and git services commented on LUCENE-9456:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185098#comment-17185098
]
ASF subversion and git services commented on LUCENE-9447:
-
Commit
s1monw merged pull request #1788:
URL: https://github.com/apache/lucene-solr/pull/1788
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
s1monw opened a new pull request #1788:
URL: https://github.com/apache/lucene-solr/pull/1788
This would have saved me many hours of waiting for tests to finish in order
to realize that my java-version is not working with jlint as well as an
existing RAT issue on the release branch. I
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185070#comment-17185070
]
Joe Doupnik edited comment on SOLR-14768 at 8/26/20, 10:09 AM:
---
After some
[
https://issues.apache.org/jira/browse/SOLR-14664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185071#comment-17185071
]
Jan Høydahl commented on SOLR-14664:
Any idea of what that would look like? I mean, other than the
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185070#comment-17185070
]
Joe Doupnik commented on SOLR-14768:
After some review of the source code of Solr 8.6.1, file
janhoy commented on pull request #1393:
URL: https://github.com/apache/lucene-solr/pull/1393#issuecomment-680778630
Abandoned in favor of #1769
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-11245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185068#comment-17185068
]
Jan Høydahl commented on SOLR-11245:
Houston, feel free to assign yourself to this Jira and drive it
janhoy closed pull request #1393:
URL: https://github.com/apache/lucene-solr/pull/1393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-14752.
Resolution: Fixed
Resolving for 8.7. Let's re-open if there will be a backport to 8.6.x
>
jpountz opened a new pull request #1787:
URL: https://github.com/apache/lucene-solr/pull/1787
These buffers can use lots of memory when the number of segments,
threads or both is high.
This is an automated message
Adrien Grand created LUCENE-9483:
Summary: Disable per-thread caching of buffers for stored fields
Key: LUCENE-9483
URL: https://issues.apache.org/jira/browse/LUCENE-9483
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185045#comment-17185045
]
ASF subversion and git services commented on LUCENE-9447:
-
Commit
jpountz merged pull request #1762:
URL: https://github.com/apache/lucene-solr/pull/1762
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185039#comment-17185039
]
Philipp Trulson commented on SOLR-14752:
Thanks for helping and cleaning up, I wasn't sure what's
noblepaul commented on a change in pull request #1785:
URL: https://github.com/apache/lucene-solr/pull/1785#discussion_r477128165
##
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##
@@ -1174,7 +1174,8 @@ private SolrCoreMetricManager
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185022#comment-17185022
]
ASF subversion and git services commented on SOLR-14752:
Commit
jpountz merged pull request #1752:
URL: https://github.com/apache/lucene-solr/pull/1752
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185021#comment-17185021
]
ASF subversion and git services commented on LUCENE-9456:
-
Commit
janhoy closed pull request #1786:
URL: https://github.com/apache/lucene-solr/pull/1786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
janhoy closed pull request #1771:
URL: https://github.com/apache/lucene-solr/pull/1771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-14705.
Resolution: Not A Problem
> Release Smoke Test Script Shows Unusable JDK Version
>
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185020#comment-17185020
]
ASF subversion and git services commented on SOLR-14752:
Commit
jpountz closed pull request #1748:
URL: https://github.com/apache/lucene-solr/pull/1748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jpountz commented on pull request #1748:
URL: https://github.com/apache/lucene-solr/pull/1748#issuecomment-680733827
I'm closing in favor of #1762 and I'll open a separate PR to disable the
per-thread caching of buffers.
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14752:
---
Fix Version/s: 8.7
> Zookeeper status fails on zk 3.6.1 with prometheus enabled
>
[
https://issues.apache.org/jira/browse/SOLR-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185006#comment-17185006
]
Jan Høydahl commented on SOLR-14752:
I cleaned up the test in
janhoy opened a new pull request #1786:
URL: https://github.com/apache/lucene-solr/pull/1786
Followup to #1771
Just cleaned up the test
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184987#comment-17184987
]
Jan Høydahl commented on SOLR-14751:
Thanks, you beat me to it :)
> Zookeeper Admin screen not
janhoy commented on a change in pull request #1771:
URL: https://github.com/apache/lucene-solr/pull/1771#discussion_r477091492
##
File path:
solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java
##
@@ -211,4 +211,39 @@ public void
Antonio Dinis created SOLR-14779:
Summary: Solr collections gets wiped on restart
Key: SOLR-14779
URL: https://issues.apache.org/jira/browse/SOLR-14779
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LUCENE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184969#comment-17184969
]
Tobias Graf commented on LUCENE-6336:
-
We hit the same issue. Would love to see this fixed.
>
92 matches
Mail list logo
