[jira] [Comment Edited] (LUCENE-10070) "count all" faceting functionality counts deleted docs for multiple implementations

2021-09-10 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413450#comment-17413450 ] Ankur edited comment on LUCENE-10070 at 9/11/21, 1:12 AM: -- [~gsmiller] Thanks

[jira] [Comment Edited] (LUCENE-10070) "count all" faceting functionality counts deleted docs for multiple implementations

2021-09-10 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413450#comment-17413450 ] Ankur edited comment on LUCENE-10070 at 9/11/21, 1:11 AM: -- [~gsmiller] Thanks

[jira] [Commented] (LUCENE-10070) "count all" faceting functionality counts deleted docs for multiple implementations

2021-09-10 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413450#comment-17413450 ] Ankur commented on LUCENE-10070: [~gsmiller] Thanks for taking a look the the above PR.  I

[GitHub] [lucene] goankur commented on a change in pull request #282: Lucene-10070

2021-09-10 Thread GitBox
goankur commented on a change in pull request #282: URL: https://github.com/apache/lucene/pull/282#discussion_r706535368 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -272,7 +273,8 @@ private void count(FacetsCollector

[GitHub] [lucene] goankur commented on a change in pull request #282: Lucene-10070

2021-09-10 Thread GitBox
goankur commented on a change in pull request #282: URL: https://github.com/apache/lucene/pull/282#discussion_r706535312 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -152,7 +153,8 @@ private FacetResult

[GitHub] [lucene] goankur commented on a change in pull request #282: Lucene-10070

2021-09-10 Thread GitBox
goankur commented on a change in pull request #282: URL: https://github.com/apache/lucene/pull/282#discussion_r706535145 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java ## @@ -207,11 +210,17 @@ public Void

[jira] [Resolved] (LUCENE-10096) Tamil Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10096. -- Fix Version/s: main (9.0) Resolution: Fixed > Tamil Analyzer > -- > >

[jira] [Commented] (LUCENE-10096) Tamil Analyzer

2021-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413449#comment-17413449 ] ASF subversion and git services commented on LUCENE-10096: -- Commit

[GitHub] [lucene] rmuir merged pull request #292: LUCENE-10096: Tamil Analyzer

2021-09-10 Thread GitBox
rmuir merged pull request #292: URL: https://github.com/apache/lucene/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] goankur commented on a change in pull request #282: Lucene-10070

2021-09-10 Thread GitBox
goankur commented on a change in pull request #282: URL: https://github.com/apache/lucene/pull/282#discussion_r706532667 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java ## @@ -159,13 +160,15 @@ private

[GitHub] [lucene] goankur commented on a change in pull request #282: Lucene-10070

2021-09-10 Thread GitBox
goankur commented on a change in pull request #282: URL: https://github.com/apache/lucene/pull/282#discussion_r706532667 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java ## @@ -159,13 +160,15 @@ private

[jira] [Resolved] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10095. -- Resolution: Fixed > Nepali Analyzer > --- > > Key: LUCENE-10095

[jira] [Commented] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413447#comment-17413447 ] ASF subversion and git services commented on LUCENE-10095: -- Commit

[GitHub] [lucene] rmuir merged pull request #290: LUCENE-10095: Nepali Analyzer

2021-09-10 Thread GitBox
rmuir merged pull request #290: URL: https://github.com/apache/lucene/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] goankur opened a new pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

2021-09-10 Thread GitBox
goankur opened a new pull request #293: URL: https://github.com/apache/lucene/pull/293 # Description Following `Facets` implementations are changed to ignore deleted documents for `count all` queries that don't use `FacetsCollector` instance. -

[GitHub] [lucene] mdmarshmallow commented on a change in pull request #288: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

2021-09-10 Thread GitBox
mdmarshmallow commented on a change in pull request #288: URL: https://github.com/apache/lucene/pull/288#discussion_r706366414 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -253,4 +257,78 @@ public FacetResult

[GitHub] [lucene] mikemccand commented on a change in pull request #288: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

2021-09-10 Thread GitBox
mikemccand commented on a change in pull request #288: URL: https://github.com/apache/lucene/pull/288#discussion_r706319030 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -253,4 +257,78 @@ public FacetResult

[GitHub] [lucene-solr] mikemccand commented on pull request #2567: LUCENE-9662: CheckIndex should be concurrent (backporting)

2021-09-10 Thread GitBox
mikemccand commented on pull request #2567: URL: https://github.com/apache/lucene-solr/pull/2567#issuecomment-917040356 > Hi @mikemccand, I've added the usage instruction commit to this PR and merged. Thanks again for your review and approval! Woot! Thank you @zacharymorn! What an

[jira] [Commented] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413275#comment-17413275 ] Robert Muir commented on LUCENE-10097: -- Note: apart from ordering, in some cases this is done

[GitHub] [lucene] rmuir commented on pull request #292: LUCENE-10096: Tamil Analyzer

2021-09-10 Thread GitBox
rmuir commented on pull request #292: URL: https://github.com/apache/lucene/pull/292#issuecomment-917034582 > Thanks @rmuir! The change looks great to me, but I do not speak nor read Tamil :) > > The TamilNLP stop words were reasonably licensed? yes apache 2. see

[GitHub] [lucene] rmuir opened a new pull request #292: LUCENE-10096: Tamil Analyzer

2021-09-10 Thread GitBox
rmuir opened a new pull request #292: URL: https://github.com/apache/lucene/pull/292 Add Tamil analyzer based on snowball stemmer and TamilNLP stopwords -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-09-10 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-10097: --- Summary: Replace TreeMap use by HashMap when unnecessary Key: LUCENE-10097 URL: https://issues.apache.org/jira/browse/LUCENE-10097 Project: Lucene - Core

[jira] [Created] (LUCENE-10096) Tamil Analyzer

2021-09-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10096: Summary: Tamil Analyzer Key: LUCENE-10096 URL: https://issues.apache.org/jira/browse/LUCENE-10096 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene] jimczi opened a new pull request #291: LUCENE-10089: Disable numeric sort optimization early

2021-09-10 Thread GitBox
jimczi opened a new pull request #291: URL: https://github.com/apache/lucene/pull/291 This commit moves the responsibility to disable the numeric sort optimization on comparators to the SortField. This way we don't need to apply the logic on every top field collectors. -- This is

[jira] [Commented] (LUCENE-10094) QueryCache wrapper Weight doesn't delegate its count() method

2021-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413254#comment-17413254 ] ASF subversion and git services commented on LUCENE-10094: -- Commit

[GitHub] [lucene] rmuir opened a new pull request #290: LUCENE-10095: Nepali Analyzer

2021-09-10 Thread GitBox
rmuir opened a new pull request #290: URL: https://github.com/apache/lucene/pull/290 Add Nepali analyzer based on snowball stemmer and NLTK stopwords. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10095: - Fix Version/s: main (9.0) > Nepali Analyzer > --- > > Key:

[jira] [Created] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10095: Summary: Nepali Analyzer Key: LUCENE-10095 URL: https://issues.apache.org/jira/browse/LUCENE-10095 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene-solr] thelabdude merged pull request #2571: SOLR-15621: index.html for Admin UI should send Solr version in the request for JavaScript files

2021-09-10 Thread GitBox
thelabdude merged pull request #2571: URL: https://github.com/apache/lucene-solr/pull/2571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-solr] thelabdude opened a new pull request #2571: SOLR-15621: index.html for Admin UI should send Solr version in the request for JavaScript files

2021-09-10 Thread GitBox
thelabdude opened a new pull request #2571: URL: https://github.com/apache/lucene-solr/pull/2571 backport of #2570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene-solr] thelabdude merged pull request #2570: SOLR-15621: index.html for Admin UI should send Solr version in the request for JavaScript files

2021-09-10 Thread GitBox
thelabdude merged pull request #2570: URL: https://github.com/apache/lucene-solr/pull/2570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10088) Too many open files in TestIndexWriterMergePolicy.testStressUpdateSameDocumentWithMergeOnGetReader

2021-09-10 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413103#comment-17413103 ] Simon Willnauer commented on LUCENE-10088: -- Oh don’t get me wrong Adrien, we do that. We have

[jira] [Resolved] (LUCENE-10094) QueryCache wrapper Weight doesn't delegate its count() method

2021-09-10 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10094. Resolution: Fixed > QueryCache wrapper Weight doesn't delegate its count() method >

[jira] [Commented] (LUCENE-10094) QueryCache wrapper Weight doesn't delegate its count() method

2021-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413075#comment-17413075 ] ASF subversion and git services commented on LUCENE-10094: -- Commit

[GitHub] [lucene] romseygeek merged pull request #289: LUCENE-10094: Delegate count() from CachingWrapperWeight

2021-09-10 Thread GitBox
romseygeek merged pull request #289: URL: https://github.com/apache/lucene/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] romseygeek opened a new pull request #289: LUCENE-10094: Delegate count() from CachingWrapperWeight

2021-09-10 Thread GitBox
romseygeek opened a new pull request #289: URL: https://github.com/apache/lucene/pull/289 CachingWrapperWeight always returns -1 from its `count()` method, which disables the fast path for TermQuery, MatchAllDocQuery, etc, when running `IndexSearcher.count(Query)`. This commit makes

[jira] [Created] (LUCENE-10094) QueryCache wrapper Weight doesn't delegate its count() method

2021-09-10 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-10094: -- Summary: QueryCache wrapper Weight doesn't delegate its count() method Key: LUCENE-10094 URL: https://issues.apache.org/jira/browse/LUCENE-10094 Project: Lucene

[GitHub] [lucene] zacharymorn commented on pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-09-10 Thread GitBox
zacharymorn commented on pull request #240: URL: https://github.com/apache/lucene/pull/240#issuecomment-916729951 Hi @jpountz @gsmiller , just want to check back on this PR to see if you have any further feedback? -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (LUCENE-10093) TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges test failure

2021-09-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413003#comment-17413003 ] Adrien Grand commented on LUCENE-10093: --- There is disagreement between the code and the tests

[GitHub] [lucene-solr] zacharymorn commented on pull request #2567: LUCENE-9662: CheckIndex should be concurrent (backporting)

2021-09-10 Thread GitBox
zacharymorn commented on pull request #2567: URL: https://github.com/apache/lucene-solr/pull/2567#issuecomment-916674521 Hi @mikemccand, I've added the usage instruction commit to this PR and merged. Thanks again for your review and approval! -- This is an automated message from the

[jira] [Commented] (LUCENE-9662) CheckIndex should be concurrent

2021-09-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412997#comment-17412997 ] ASF subversion and git services commented on LUCENE-9662: - Commit

[GitHub] [lucene-solr] zacharymorn merged pull request #2567: LUCENE-9662: CheckIndex should be concurrent (backporting)

2021-09-10 Thread GitBox
zacharymorn merged pull request #2567: URL: https://github.com/apache/lucene-solr/pull/2567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-09-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412974#comment-17412974 ] Adrien Grand commented on LUCENE-10004: --- This is already what is happening: {code} if

[jira] [Commented] (LUCENE-10088) Too many open files in TestIndexWriterMergePolicy.testStressUpdateSameDocumentWithMergeOnGetReader

2021-09-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412971#comment-17412971 ] Adrien Grand commented on LUCENE-10088: --- +1 to this one-line fix to avoid worst-case scenarios