[
https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142675#comment-17142675
]
Bram Van Dam commented on SOLR-14581:
-
I originally asked about how the commit mechanism works in
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444182510
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444201265
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
murblanc merged pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dsmiley commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648157149
> Why clutter up CoreContainer with path logic when we have classes
specifically meant to hold that?
`CoreContainer.getSolrHome()` and
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142973#comment-17142973
]
ASF subversion and git services commented on SOLR-14546:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142974#comment-17142974
]
ASF subversion and git services commented on SOLR-14546:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14586:
--
Description:
continuing discussion from SOLR-14579
consider the following
{code:java}
jimczi commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444163411
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map
gerlowskija commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648114057
I don't mind this PR at all, I just have some questions. I don't really
understand the aversion to `SolrPaths` and `File`. More detailed questions
below. Treat this
gerlowskija edited a comment on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648114057
I don't mind this PR at all, I just have some questions. I don't really
understand the aversion to `SolrPaths` and `File`. More detailed questions
below.
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136783#comment-17136783
]
Bruno Roustant edited comment on LUCENE-9379 at 6/23/20, 12:51 PM:
---
So
[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142864#comment-17142864
]
Erick Erickson commented on SOLR-13268:
---
I'm thinking of reverting _testing_ to use synchronous
mikemccand commented on a change in pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#discussion_r444216252
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene86/Lucene86PointsWriter.java
##
@@ -68,11 +71,9 @@ public
DEVILCODER-SB99 opened a new pull request #1605:
URL: https://github.com/apache/lucene-solr/pull/1605
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142718#comment-17142718
]
Noble Paul commented on SOLR-14586:
---
[~megancarey] {{putIfAbsent() }} is particularly bad. The value is
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444134039
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-8962:
Attachment: test.diff
Status: Reopened (was: Reopened)
here is a test that shows
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142831#comment-17142831
]
Noble Paul commented on SOLR-14586:
---
{quote}I'm finding your tone quite aggressive,
{quote}
Not at all.
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142836#comment-17142836
]
Erick Erickson commented on LUCENE-9411:
Thanks, I'll check it out and then push.
My hack was
Atri Sharma created SOLR-14588:
--
Summary: Circuit Breakers Infrastructure and Real JVM Based
Circuit Breaker
Key: SOLR-14588
URL: https://issues.apache.org/jira/browse/SOLR-14588
Project: Solr
noblepaul commented on pull request #1598:
URL: https://github.com/apache/lucene-solr/pull/1598#issuecomment-647991595
@sigram
shall I go ahead and merge this?
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142718#comment-17142718
]
Noble Paul edited comment on SOLR-14586 at 6/23/20, 8:25 AM:
-
[~megancarey]
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142802#comment-17142802
]
Nitsan Wakart commented on SOLR-14586:
--
"do you expect a developer to run a perf benchmark every
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142802#comment-17142802
]
Nitsan Wakart edited comment on SOLR-14586 at 6/23/20, 9:45 AM:
"do you
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142809#comment-17142809
]
Dawid Weiss commented on LUCENE-9411:
-
For gradle-only I don't think we need to care about the
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9411:
Attachment: LUCENE-9411.patch
> Fail complation on warnings
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142708#comment-17142708
]
Nitsan Wakart commented on SOLR-14586:
--
Lambdas can sometimes be slow, and induce allocation. This
atris commented on pull request #1605:
URL: https://github.com/apache/lucene-solr/pull/1605#issuecomment-647988672
How is this different from #1605 ?
I have not looked at the PRs yet, but they seem scattered and incomplete.
Most of the code is not licensed to ASF, there are no tests
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142751#comment-17142751
]
Florin Babes commented on SOLR-14571:
-
kind reminder
> Index download speed while replicating is
[
https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143053#comment-17143053
]
ASF subversion and git services commented on SOLR-14502:
Commit
madrob commented on a change in pull request #1598:
URL: https://github.com/apache/lucene-solr/pull/1598#discussion_r444323329
##
File path:
solr/solrj/src/test/org/apache/solr/client/solrj/cloud/autoscaling/TestPolicy2.java
##
@@ -516,6 +517,16 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143073#comment-17143073
]
Ilan Ginzburg commented on SOLR-14546:
--
Sure [~ichattopadhyaya], thank for spotting this that
[
https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143078#comment-17143078
]
Christine Poerschke commented on SOLR-14560:
Haven't yet had a chance to learn about
murblanc commented on pull request #1504:
URL: https://github.com/apache/lucene-solr/pull/1504#issuecomment-648188037
@noblepaul if no objections, I'll merge that soon (after rebasing,
precommitting and checking all is ok).
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142989#comment-17142989
]
Dawid Weiss commented on LUCENE-9411:
-
It's not your fault, Erick, so no blame!
{quote}Stupid of me
gerlowskija commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648235882
> My only concern, which seems to be shared by you, is that CoreContainer is
pretty big as it is. But I think this path and it's initialization is in scope
of its
[
https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-14502:
---
Fix Version/s: 8.6
master (9.0)
> increase bin/solr's post kill
madrob commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r444325409
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -191,7 +190,7 @@ public DocCollection
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143064#comment-17143064
]
Mike Drob commented on SOLR-14588:
--
See also SOLR-6930
> Circuit Breakers Infrastructure and Real JVM
[
https://issues.apache.org/jira/browse/SOLR-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143069#comment-17143069
]
Christine Poerschke commented on SOLR-12698:
Returning to this. Looks like [~dsmiley]'s
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143085#comment-17143085
]
Ilan Ginzburg commented on SOLR-14546:
--
[https://github.com/apache/lucene-solr/pull/1607]
>
murblanc opened a new pull request #1607:
URL: https://github.com/apache/lucene-solr/pull/1607
# Description
Add a "Bug Fixes" section in the Solr 9.0.0 section in CHANGES.txt and move
the fix to SOLR-14546 into it.
# Solution
Text edit.
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143091#comment-17143091
]
ASF subversion and git services commented on SOLR-14546:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143093#comment-17143093
]
Mike Drob commented on SOLR-14582:
--
Should we have a warning if somebody tries to use this with the
murblanc merged pull request #1607:
URL: https://github.com/apache/lucene-solr/pull/1607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143059#comment-17143059
]
Ishan Chattopadhyaya commented on SOLR-14546:
-
[~ilan], Shouldn't we place this changelog in
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-9411:
---
Summary: Fail complation on warnings, 9x gradle-only (was: Fail complation
on warnings)
>
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143043#comment-17143043
]
ASF subversion and git services commented on SOLR-14584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143045#comment-17143045
]
ASF subversion and git services commented on SOLR-14584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143044#comment-17143044
]
ASF subversion and git services commented on SOLR-14584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-14584.
Fix Version/s: 8.6
master (9.0)
Assignee: Christine
atris opened a new pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606
This commit consists of two parts: initial circuit breakers infrastructure
and real JVM memory based circuit breaker which monitors incoming search
requests and rejects them with SERVICE_TOO_BUSY
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143061#comment-17143061
]
Ishan Chattopadhyaya commented on SOLR-12823:
-
I think we should add an upgrade note for this
[
https://issues.apache.org/jira/browse/SOLR-14376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143071#comment-17143071
]
Christine Poerschke commented on SOLR-14376:
quick question: just spotted a
{code:java}
//
madrob commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648271244
This has been something that I've wanted for a long time, so I'm really
excited to see somebody picking up the work! Thank you @atris !
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg resolved SOLR-14546.
--
Resolution: Fixed
> OverseerTaskProcessor can process messages out of order
>
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444284423
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
gerlowskija edited a comment on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648235882
> My only concern, which seems to be shared by you, is that CoreContainer is
pretty big as it is. But I think this path and it's initialization is in scope
of
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143039#comment-17143039
]
ASF subversion and git services commented on SOLR-14584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143040#comment-17143040
]
ASF subversion and git services commented on SOLR-14584:
Commit
asfgit closed pull request #1597:
URL: https://github.com/apache/lucene-solr/pull/1597
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143041#comment-17143041
]
ASF subversion and git services commented on SOLR-14584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143049#comment-17143049
]
ASF subversion and git services commented on SOLR-14502:
Commit
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444334278
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143089#comment-17143089
]
Ilan Ginzburg commented on SOLR-12823:
--
[~ichattopadhyaya] I'll put out a PR with this.
> remove
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444375970
##
File path:
solr/core/src/test-files/solr/collection1/conf/solrconfig-cache-enable-disable.xml
##
@@ -70,6 +70,10 @@
10
+false
+
+
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444392412
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r17940
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo8.pdf
> Lucene Logo Contest
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143205#comment-17143205
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 8 [^lucene_logo8.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143202#comment-17143202
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 6 [^lucene_logo6.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143203#comment-17143203
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 7 [^lucene_logo7.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo7.pdf
> Lucene Logo Contest
> ---
>
> Key:
ErickErickson commented on pull request #1607:
URL: https://github.com/apache/lucene-solr/pull/1607#issuecomment-648285224
Ilan:
There’s no need to burden yourself with much process for something this
simple/uncontroversial,
ditto with spelling corrections and the like.
Up
murblanc commented on pull request #1607:
URL: https://github.com/apache/lucene-solr/pull/1607#issuecomment-648287499
Thanks @ErickErickson. I do understand that and likely will get to it
eventually but I prefer to do it that way for now, I likely understand
SolrCloud better than I
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143119#comment-17143119
]
Ilan Ginzburg commented on SOLR-12823:
--
[~ichattopadhyaya] actually the original PR already updated
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444382798
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -224,6 +224,9 @@ private SolrConfig(SolrResourceLoader loader, String name,
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444383850
##
File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143179#comment-17143179
]
Cassandra Targett edited comment on SOLR-12823 at 6/23/20, 6:20 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo3.pdf
> Lucene Logo Contest
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143195#comment-17143195
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 3 [^lucene_logo3.pdf]
> Lucene Logo Contest
>
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r24345
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143200#comment-17143200
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 5 [^lucene_logo5.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143199#comment-17143199
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 4 [^lucene_logo4.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo6.pdf
> Lucene Logo Contest
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo5.pdf
> Lucene Logo Contest
> ---
>
> Key:
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r44004
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143124#comment-17143124
]
Ishan Chattopadhyaya commented on SOLR-12823:
-
Oh, I see. I was confused due to the empty 9x
atris commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648326325
To provide some context, I ran this against large facets with the memory
circuit breaker tripping in the right place.
@madrob Thanks for reviewing, I have raised
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atri Sharma reassigned SOLR-14588:
--
Assignee: Atri Sharma
> Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker
>
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r17129
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -224,6 +224,13 @@ private SolrConfig(SolrResourceLoader loader, String
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143189#comment-17143189
]
BARIS KAZAR commented on LUCENE-9221:
-
Lucene Logo 1[^lucene_logo1.pdf]
> Lucene Logo Contest
>
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo2.pdf
> Lucene Logo Contest
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BARIS KAZAR updated LUCENE-9221:
Attachment: lucene_logo1.pdf
> Lucene Logo Contest
> ---
>
> Key:
atris commented on pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#issuecomment-648362568
@madrob Updated, please see and share your thoughts.
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143089#comment-17143089
]
Ilan Ginzburg edited comment on SOLR-12823 at 6/23/20, 5:06 PM:
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444384399
##
File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444394541
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
madrob commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r16519
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
1 - 100 of 138 matches
Mail list logo
