dxl360 commented on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729475817
Original implementation accumulates `int invertState.length` (number of
tokens) by term frequency and will overflow if the term frequency is too large.
Can we increment
anshumg commented on a change in pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r525809933
##
File path: solr/core/src/test/org/apache/solr/cloud/LeaderElectionTest.java
##
@@ -414,6 +425,11 @@ private void waitForLeader(List threads, int
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729393685
I've been following the comment thread on `WindowsDirectory`, but not sure
if there's a consensus to remove it in this PR? For the time being, I've pushed
a standalone
zacharymorn edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857
> > I think we just need to resolve the "replace now or not" question?
>
> I'd like to improve the testcase and use a real index on top of a
combination
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857
> > I think we just need to resolve the "replace now or not" question?
>
> I'd like to improve the testcase and use a real index on top of a
combination with
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525759421
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729387261
> > Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse usage, to
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525747419
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java
##
@@ -18,29 +18,37 @@
import
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525747082
##
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##
@@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525746628
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
dxl360 removed a comment on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729332268
> I'm concerned about this change: other things will overflow if you have
too many term frequencies in a field. Currently frequency is bounded by 2^32-1
within a
dxl360 closed pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dxl360 commented on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-729332268
> I'm concerned about this change: other things will overflow if you have
too many term frequencies in a field. Currently frequency is bounded by 2^32-1
within a doc, and
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233826#comment-17233826
]
Gautam Worah edited comment on LUCENE-9378 at 11/18/20, 12:11 AM:
--
rustamhsmv closed pull request #126:
URL: https://github.com/apache/lucene-solr/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rustamhsmv closed pull request #125:
URL: https://github.com/apache/lucene-solr/pull/125
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Julie Tibshirani created LUCENE-9616:
Summary: Improve test coverage for internal format versions
Key: LUCENE-9616
URL: https://issues.apache.org/jira/browse/LUCENE-9616
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-9616:
-
Description:
Some formats use an internal versioning system -- for example
[
https://issues.apache.org/jira/browse/SOLR-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234003#comment-17234003
]
Michael Gibney commented on SOLR-14921:
---
Thanks for taking a look, [~gerlowskija]! You're right
[
https://issues.apache.org/jira/browse/SOLR-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233976#comment-17233976
]
ASF subversion and git services commented on SOLR-14792:
Commit
dsmiley commented on pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729210262
Wouldn't it be simpler for the release manager to build the docker image,
examine the sha256 hash of the image, and publish that to the download
location, making it
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233906#comment-17233906
]
Michael Sokolov commented on LUCENE-9004:
-
Oh excellent, I stand corrected, thanks for the
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233885#comment-17233885
]
Michael McCandless commented on LUCENE-9378:
{quote}Meanwhile, I'll open an issue to disable
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233865#comment-17233865
]
Uwe Schindler edited comment on LUCENE-9004 at 11/17/20, 7:18 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233865#comment-17233865
]
Uwe Schindler commented on LUCENE-9004:
---
{quote}I changed it to . Based on
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233826#comment-17233826
]
Gautam Worah edited comment on LUCENE-9378 at 11/17/20, 6:49 PM:
-
Thanks
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233826#comment-17233826
]
Gautam Worah commented on LUCENE-9378:
--
Thanks for catching that regression so quickly Adrien!
I
[
https://issues.apache.org/jira/browse/SOLR-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233806#comment-17233806
]
Jason Gerlowski commented on SOLR-14921:
I'll qualify my comments below by admitting upfront that
jtibshirani commented on a change in pull request #2047:
URL: https://github.com/apache/lucene-solr/pull/2047#discussion_r524835397
##
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##
@@ -25,47 +25,22 @@
private VectorUtil() {
}
- public
jtibshirani closed pull request #2047:
URL: https://github.com/apache/lucene-solr/pull/2047
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jtibshirani commented on pull request #2084:
URL: https://github.com/apache/lucene-solr/pull/2084#issuecomment-729105823
> Are you able to push the commit yet?
Not yet, I'm still waiting on account credentials.
This
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233793#comment-17233793
]
ASF subversion and git services commented on SOLR-14683:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233792#comment-17233792
]
ASF subversion and git services commented on SOLR-14683:
Commit
cpoerschke commented on pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729102552
> ... is there any automatic tool that will remove them ... If not I suspect
we may risk forgetting ...
I'm not aware of any automatic tool we currently use that
[
https://issues.apache.org/jira/browse/SOLR-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233760#comment-17233760
]
David Smiley commented on SOLR-15007:
-
I am thinking of a rough idea of an implementation approach.
Mathieu Marie created SOLR-15007:
Summary: Aggregate core handler=/select and /update metrics at the
node level metric too
Key: SOLR-15007
URL: https://issues.apache.org/jira/browse/SOLR-15007
thelabdude commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r525335246
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##
@@ -334,11 +334,6 @@ private StreamComparator
HoustonPutman commented on pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-729061623
I completely agree with everything you've said @janhoy, and really like that
solution! I am by no means an expert on this verification stuff, so what do you
imagine
alessandrobenedetti commented on pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-729051840
I am not against the back-compat niceties, but is there any automatic tool
that will remove them when a release candidate happen for 9.0 ?
If not I suspect we
uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496
Another thing to keep in mind: The old/new direct i/o dircetory has one
problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage
collector needs
uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496
Another thing to keep in mind: The old/new direct i/o dircetory has one
problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage
collector needs
[
https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov updated LUCENE-9615:
Description: HnswGraphBuilder has a few tunables: maxConnections,
beamWidth, and we may
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729050496
Another thing to keep in mind: The old/new direct i/o dircetory has one
problem: It uses ByteBuffer.allocateDirect on every clone. As the garbage
collector needs to
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525305942
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
[
https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Sokolov updated LUCENE-9615:
Description: HnswGraphBuilder has a few tunables: fanout, beamWidth,
potentially whether
Michael Sokolov created LUCENE-9615:
---
Summary: Expose HnswGraphBuilder index-time hyperparameters
Key: LUCENE-9615
URL: https://issues.apache.org/jira/browse/LUCENE-9615
Project: Lucene - Core
Michael Sokolov created LUCENE-9614:
---
Summary: Implement KNN Query
Key: LUCENE-9614
URL: https://issues.apache.org/jira/browse/LUCENE-9614
Project: Lucene - Core
Issue Type: New Feature
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729039812
> I think we just need to resolve the "replace now or not" question?
I'd like to improve the testcase and use a real index on top of a
combination with
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525294149
##
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##
@@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL
uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729037126
> Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729037126
> Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse usage, to
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729034044
> Hmm, maybe this is a good reason to make this change in two steps (add
pure java version, then, later, remove native one)? Which platforms will now
throw
[
https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233697#comment-17233697
]
Tim Allison commented on SOLR-14973:
Y. I believe that it is fixed in 8.7.0, too. It looks like the
[
https://issues.apache.org/jira/browse/SOLR-14973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233680#comment-17233680
]
Markus Schuch commented on SOLR-14973:
--
I think this is fixed in Solr 8.7.0 by SOLR-14439
> Solr
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r525257315
##
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##
@@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729007347
> > Thank you @zacharymorn! It's so nice we can move this to pure java now
-- this makes it much easier and lower risk for Lucene users to test.
> > I suspect for
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729002846
> IMHO, we should add more Javadocs, that this directory may throw
UnsupportedOperationException if the underlying platform does not allow direct
IO.
Hmm, maybe
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233638#comment-17233638
]
Joel Bernstein edited comment on SOLR-14608 at 11/17/20, 2:48 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233638#comment-17233638
]
Joel Bernstein edited comment on SOLR-14608 at 11/17/20, 2:49 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233638#comment-17233638
]
Joel Bernstein commented on SOLR-14608:
---
Coming back to this ticket to get it wrapped up. The
[
https://issues.apache.org/jira/browse/LUCENE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Ferenczi resolved LUCENE-9023.
--
Fix Version/s: 8.8
Resolution: Fixed
> GlobalOrdinalsWithScore should not compute
Adrien Grand created LUCENE-9613:
Summary: Create blocks for ords when it helps in
Lucene80DocValuesFormat
Key: LUCENE-9613
URL: https://issues.apache.org/jira/browse/LUCENE-9613
Project: Lucene -
[
https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233633#comment-17233633
]
Michael Sokolov commented on LUCENE-9004:
-
I changed it to . Based on
[
https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233574#comment-17233574
]
ASF subversion and git services commented on LUCENE-8626:
-
Commit
msokolov merged pull request #2053:
URL: https://github.com/apache/lucene-solr/pull/2053
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9413:
--
Fix Version/s: master (9.0)
> Add a char filter corresponding to CJKWidthFilter
>
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-9413.
---
Fix Version/s: 8.8
Assignee: Tomoko Uchida
Resolution: Fixed
> Add a char
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233486#comment-17233486
]
ASF subversion and git services commented on LUCENE-9413:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233487#comment-17233487
]
ASF subversion and git services commented on LUCENE-9413:
-
Commit
janhoy commented on pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-728787567
+1 to lighter weight. However, our users should somehow be able to verify
that a Docker image pulled from Docker Hub (or downloaded from elsewhere) is
indeed the officially
[
https://issues.apache.org/jira/browse/LUCENE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233452#comment-17233452
]
Dawid Weiss commented on LUCENE-9612:
-
Ah, thanks for looking into it, Adrien!
>
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233445#comment-17233445
]
ASF subversion and git services commented on LUCENE-9378:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9612.
--
Resolution: Fixed
Woops, I thought I had fixed it over the weekend but my push only worked on
uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-728774023
Hi,
We can also remove WindowsDirectory. This one was not done for direct IO,
but in my opinion, it's obsolete, too:
dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524972056
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-728774023
Hi,
We can also remove WindowsDirectory. This one was not done for direct IO, bt
it's obsolete, too: https://issues.apache.org/jira/browse/LUCENE-2791
It was
[
https://issues.apache.org/jira/browse/LUCENE-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233441#comment-17233441
]
ASF subversion and git services commented on LUCENE-9413:
-
Commit
mocobeta merged pull request #2081:
URL: https://github.com/apache/lucene-solr/pull/2081
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mocobeta commented on pull request #2081:
URL: https://github.com/apache/lucene-solr/pull/2081#issuecomment-728773010
Merged. Thank you @rmuir for review!
This is an automated message from the Apache Git Service.
To respond
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524967715
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524965464
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java
##
@@ -18,29 +18,37 @@
import
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524963604
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524962771
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961831
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961331
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java
##
@@ -18,29 +18,37 @@
import
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524954118
##
File path: lucene/misc/src/java/overview.html
##
@@ -35,7 +35,7 @@ NativeUnixDirectory
have to compile on your platform.
-{@link
dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524958131
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
Dawid Weiss created LUCENE-9612:
---
Summary: TestBestCompressionLucene80DocValuesFormat fails reliably
with java.io.FileNotFoundException: _0_Lucene80_0.dvm
Key: LUCENE-9612
URL:
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524950844
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -74,12 +65,12 @@
*
* @lucene.experimental
*/
89 matches
Mail list logo
