[GitHub] [metron] justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-555801059 Merged master, primarily to pull in #1561. I'm letting Travis build and run the tests, but at this point we shouldn't have any JUnit 4 at all.

[GitHub] [metron] sardell opened a new pull request #1567: METRON-2323: Increase unit test coverage for Alerts List

2019-11-19 Thread GitBox
sardell opened a new pull request #1567: METRON-2323: Increase unit test coverage for Alerts List URL: https://github.com/apache/metron/pull/1567 ## Contributor Comments The alerts list component is one of the largest components in the Alerts UI. It is also really tightly coupled with

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-555801059 Merged master, primarily to pull in #1561. I'm letting Travis build and run the tests, but at this point we shouldn't have any JUnit 4 carrying

[GitHub] [metron] asfgit closed pull request #1561: METRON-2311: Remove JUnit from all our uber jars

2019-11-19 Thread GitBox
asfgit closed pull request #1561: METRON-2311: Remove JUnit from all our uber jars URL: https://github.com/apache/metron/pull/1561 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [metron] justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348256304 ## File path:

[GitHub] [metron] justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348256138 ## File path:

[jira] [Created] (METRON-2323) Increase unit test coverage for Alerts List

2019-11-19 Thread Shane Ardell (Jira)
Shane Ardell created METRON-2323: Summary: Increase unit test coverage for Alerts List Key: METRON-2323 URL: https://issues.apache.org/jira/browse/METRON-2323 Project: Metron Issue Type:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348189357 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348189222 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348189008 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348189052 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348188806 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348122344 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-19 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348187588 ## File path:

[GitHub] [metron] nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-555691171 +1 Thanks for taking care of this @sardell . Works like a charm.

[GitHub] [metron] mmiklavc commented on issue #1563: METRON-2318: Merge master into feature branch

2019-11-19 Thread GitBox
mmiklavc commented on issue #1563: METRON-2318: Merge master into feature branch URL: https://github.com/apache/metron/pull/1563#issuecomment-555669156 +1 by inspection pending your manual smoke test checks out. Considering the squashing in the past couple merge commits, we'll want to do a

[GitHub] [metron] mmiklavc commented on issue #1566: METRON-2322 Add Ambari connection check to upgrade_helper script

2019-11-19 Thread GitBox
mmiklavc commented on issue #1566: METRON-2322 Add Ambari connection check to upgrade_helper script URL: https://github.com/apache/metron/pull/1566#issuecomment-555633562 ###Test Plan I verified this in full dev and also ran shellcheck. * Follow the readme steps for

[GitHub] [metron] mmiklavc edited a comment on issue #1566: METRON-2322 Add Ambari connection check to upgrade_helper script

2019-11-19 Thread GitBox
mmiklavc edited a comment on issue #1566: METRON-2322 Add Ambari connection check to upgrade_helper script URL: https://github.com/apache/metron/pull/1566#issuecomment-555633562 ### Test Plan I verified this in full dev and also ran shellcheck. * Follow the readme steps for

[GitHub] [metron] mmiklavc opened a new pull request #1566: METRON-2322 Add Ambari connection check to upgrade_helper script

2019-11-19 Thread GitBox
mmiklavc opened a new pull request #1566: METRON-2322 Add Ambari connection check to upgrade_helper script URL: https://github.com/apache/metron/pull/1566 ## Contributor Comments https://issues.apache.org/jira/browse/METRON-2322 ## Pull Request Checklist ### For all

[jira] [Created] (METRON-2322) Add Ambari connection check to upgrade_helper script

2019-11-19 Thread Michael Miklavcic (Jira)
Michael Miklavcic created METRON-2322: - Summary: Add Ambari connection check to upgrade_helper script Key: METRON-2322 URL: https://issues.apache.org/jira/browse/METRON-2322 Project: Metron

[jira] [Updated] (METRON-2319) [UI] Detailed view of parser config is overflows on the bottom of the page

2019-11-19 Thread Tibor Meller (Jira)
[ https://issues.apache.org/jira/browse/METRON-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-2319: - Description: Please find the attached screenshot. I investigated the issue and it turned out

[GitHub] [metron] nickwallen opened a new pull request #1565: METRON-2321 Remove Legacy AWS Deployment Path

2019-11-19 Thread GitBox
nickwallen opened a new pull request #1565: METRON-2321 Remove Legacy AWS Deployment Path URL: https://github.com/apache/metron/pull/1565 The automated AWS deployment mechanism (`metron-deployment/amazon-ec2`) should be removed. It is no longer the preferred installation path for

[jira] [Updated] (METRON-2319) [UI] Detailed view of parser config is overflows on the bottom of the page

2019-11-19 Thread Tibor Meller (Jira)
[ https://issues.apache.org/jira/browse/METRON-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-2319: - Description: Please find the attached screenshot. I investigated the issue and it turned out

[jira] [Updated] (METRON-2321) Remove Legacy AWS Deployment Path

2019-11-19 Thread Nick Allen (Jira)
[ https://issues.apache.org/jira/browse/METRON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-2321: --- Summary: Remove Legacy AWS Deployment Path (was: Remove Legacy "amazon-aws" Deployment Path) >

[jira] [Created] (METRON-2321) Remove Legacy "amazon-aws" Deployment Path

2019-11-19 Thread Nick Allen (Jira)
Nick Allen created METRON-2321: -- Summary: Remove Legacy "amazon-aws" Deployment Path Key: METRON-2321 URL: https://issues.apache.org/jira/browse/METRON-2321 Project: Metron Issue Type: Bug

[GitHub] [metron] mmiklavc commented on issue #1561: METRON-2311: Remove JUnit from all our uber jars

2019-11-19 Thread GitBox
mmiklavc commented on issue #1561: METRON-2311: Remove JUnit from all our uber jars URL: https://github.com/apache/metron/pull/1561#issuecomment-54552 +1 This is an automated message from the Apache Git Service. To

[GitHub] [metron] sardell edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
sardell edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-38282 @nickwallen Thanks for your help and the hot tip about running the failing part of the build to get better/more readable

[GitHub] [metron] sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-38282 @nickwallen Thanks for your help and the hot tip about running the failing part of the build to get better/more readable

[GitHub] [metron] nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-10328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so

[GitHub] [metron] nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-10328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so

[GitHub] [metron] nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-10328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so

[GitHub] [metron] nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-19 Thread GitBox
nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-10328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so what I

[jira] [Updated] (METRON-2320) [UI] metron-config npm install failing by copy-ace step

2019-11-19 Thread Tibor Meller (Jira)
[ https://issues.apache.org/jira/browse/METRON-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-2320: - Description: The error message pasted below does not always show up. Depending on the npm

[jira] [Updated] (METRON-2320) [UI] metron-config npm install failing by copy-ace step

2019-11-19 Thread Tibor Meller (Jira)
[ https://issues.apache.org/jira/browse/METRON-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Meller updated METRON-2320: - Description: The error message pasted below does not always show up. Depending on the npm

[jira] [Created] (METRON-2320) [UI] metron-config npm install failing by copy-ace step

2019-11-19 Thread Tibor Meller (Jira)
Tibor Meller created METRON-2320: Summary: [UI] metron-config npm install failing by copy-ace step Key: METRON-2320 URL: https://issues.apache.org/jira/browse/METRON-2320 Project: Metron

[jira] [Created] (METRON-2319) [UI] Detailed view of parser config is overflows on the bottom of the page

2019-11-19 Thread Tibor Meller (Jira)
Tibor Meller created METRON-2319: Summary: [UI] Detailed view of parser config is overflows on the bottom of the page Key: METRON-2319 URL: https://issues.apache.org/jira/browse/METRON-2319 Project: