Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/531
Just to be clear @basvdl, you are the only one who can close this PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/338
-1
There has been no response from contributor. This PR will be closed
according to the [Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/670
-1
There has been no response from the contributor. This PR will be closed
per the [Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r187948446
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.e2e-spec.ts
---
@@ -19,139 +19,142 @@
import { MetronAlertsPage
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/278
-1 Based on the [Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
on Inactive PR. Missing contributor feedback. I will open an Apache
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1004
Please fix the formatting issue with the README. I have mentioned in
another thread, but you might have missed it.
---
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/1012
METRON-1551 Profiler Should Not Use Java Serialization
When running the Profiler in a topology where serialization occurs, the
following error happens. This can occur when the number
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1012
Reopen for unrelated failure. Will open a bug for what seems to be an
intermittent test failure.
```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1012
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1012
I made two updates.
* I added the additional test check to `StellarProcessorUtils` to ensure
the value returned is Java serializable. There were a few classes that I had
to update
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187161369
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -166,6 +185,139
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187160397
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -166,6 +185,139
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187162573
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -88,9 +108,7
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1004
Maybe I am wrong, but I thought these tests used to run headless. It looks
to me that these are running "headful" now. :)
Either way, can these tests run headless or is the
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r184750091
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/alert-status/alerts-list-status.e2e-spec.ts
---
@@ -44,84 +45,84 @@ describe('metron-alerts
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r184750333
--- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts
---
@@ -272,63 +308,149 @@ export class MetronAlertsPage
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1007
METRON-1543 Unable to Set Parser Output Topic in Sensor Config
The only way to alter the output topic for a Parser topology is to manually
launch the topology using the CLI with the `-ot
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1004
@sardell What is the status of this? Are you happy with what you have?
I was able to run the e2e tests successfully without any interventions this
time. It took a couple of automated
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187344126
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -88,9 +108,7
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r187350501
--- Diff: metron-interface/metron-alerts/README.md ---
@@ -126,7 +126,14 @@ The application will be available at http://host:4201
assuming the port
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r187350891
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
@@ -97,21 +155,24 @@ export class TreeViewPage
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187404376
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -166,6 +185,139
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187404078
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -166,6 +185,139
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1003
> @justinleet Are we good to kill the old enrichment.properties.j2 files?
Yes, I should have deleted that file in #984 .
Thanks @justinleet for the clean
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1003
Sorry for the delay. My email filters are clearly filtering out my Github
notifications.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1012
METRON-1551 Profiler Should Not Use Java Serialization
When running the Profiler in a topology where serialization occurs, the
following error happens. This can occur when the number
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1013
METRON-1553 Validate JIRA Script Error
The `dev-utilities/release-utils/validate-jira-for-release` script has a
minor error when run.
```
$ ./validate-jira-for-release --version
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1009
+1 This looks good. Thanks!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/954
@sardell Thanks.
@xyztdanid4 Please let us know if you feel this PR is still relevant. If
not, please close the PR. Otherwise, the PR may be closed as inactive
according to the Metron
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/956
@sardell Thanks.
@xyztdanid4 Please let us know if you feel this PR is still relevant. If
not, please close the PR. Otherwise, the PR may be closed as inactive
according to the Metron
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1015
METRON-1544 Flaky test: org.apache.metron.stellar.common.CachingStellâ¦
This fixes the `CachingStellarProcessorTest` which is failing
intermittently.
```
Running
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/952
@sardell Thanks.
@xyztdanid4 Please let us know if you feel this PR is still relevant. If
not, please close the PR. Otherwise, the PR may be closed as inactive
according to the Metron
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
> @ben-manes Youâre code shouldnât make assumptions on what is evicted
as we will try to maximize the hit rate using various techniques.
That makes a ton of sense. Tha
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
In the latest, I removed the problematic test case. There is no need to
test the eviction policy of the underlying cache, which is effectively what is
happening. If anyone can find gaps
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/1015
METRON-1544 Flaky test: org.apache.metron.stellar.common.CachingStellâ¦
This fixes the `CachingStellarProcessorTest` which is failing
intermittently.
```
Running
GitHub user nickwallen reopened a pull request:
https://github.com/apache/metron/pull/1015
METRON-1544 Flaky test: org.apache.metron.stellar.common.CachingStellâ¦
This fixes the `CachingStellarProcessorTest` which is failing
intermittently.
```
Running
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
> @mmiklavc: Can you call out the lines relevant to the fix for reviewers?
I provided some more color in the description this time. Also, copied
below.
> The core p
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1015
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
Daft. Still a problem. In master, run repetitively the test fails easily
3/10 times for me. With the latest in this PR, it is failing 1/40 times or so,
so I'm still not there.
So
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1022
METRON-1569 Allow user to change field name conversion when indexing â¦
The `ElasticsearchWriter` has a mechanism to transform the field names of a
message before it is written
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/754
@ottobackwards Did you or anyone else happen to test this on a Mac? I
believe @mmiklavc runs a Mac and it is not working for him. I am curious if
this is working for anyone on a Mac.
---
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1000
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1000
I made a bunch of enhancements based on the feedback I outlined above. I
am in the process of breaking that work out into multiple PRs so that it can be
reviewed more easily.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1024
METRON-1572 Enhance KAFKA_PUT function
Note: This PR is built on the shoulders of #1023. To review the change
specific to this PR, review the changes made in the second commit or wait until
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1025
METRON-1533 Create KAFKA_FIND Stellar function
This PR is built on #1024 and #1023. Dig into the last commit to review
the changes for this PR alone.
### Changes
I
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190950314
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190949109
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1001
+1 Thanks @sardell
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190926866
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1022
FYI - I also confirmed that the configuration value can be changed using
the Advanced mode in the Management UI.
![screen shot 2018-05-25 at 11 31 17
am](https://user
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1034
METRON-1580 Release candidate check script requires Bro Plugin
Not all Metron releases will include a new version of the Bro Plugin. The
release candidate script currently requires it though
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190977652
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190964321
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1030
METRON-1573 Enhance KAFKA_* functions to return partition and offset details
### Changes
* Updated KAFKA_GET, KAFKA_TAIL, and KAFKA_FIND so that they can each
return a "rich&
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1029
+1 Thanks
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190701068
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190702283
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190737770
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190715353
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r190742938
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/CachedFieldNameConverterFactory.java
---
@@ -0,0
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
@mmiklavc bump. Did I answer your question? How is this looking?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1015
Ok, now its really working.
The second problem was that there is some variability in which items get
expired from the cache according to the LRU algorithm. In about 1/250 runs
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1026
+1 Looks good @justinleet Thanks!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1018
+1 Thanks @merrimanr
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1035
I have a [theory as to why this is
happening](https://github.com/apache/metron/pull/1045#issuecomment-394033676)
that should be fixed thanks to #1045.
That being said, I am not sure
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1045#discussion_r193392088
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/kafka/KafkaWriter.java
---
@@ -156,33 +172,61 @@ public void configure
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1045
@mmiklavc FYI You've got a TODO comment in `ConfiguredIndexingBolt.java`
that seems like something you wanted to address before merging.
Usually good to at least give a chance for all
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1045
I was still going through it. Not sure where @ottobackwards landed on
this.
Besides the open TODO comment, I am not sure how much testing we did around
the Profiler or testing
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1030
> [Stellar]>>> KAFKA_TAIL("mytopic")
> []
KAFKA_TAIL always seeks to the end of the topic. So the consumer offset
was set to the end of the topic (off
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1055
FYI - There is also another `source.type.field` reference that would be an
easy update
[here](https://github.com/apache/metron/blob/71a015fabc47b23ea0c5400fa239fee9f5c0d194/metron-interface
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1053
+1 Thanks @justinleet. I spun-up the site locally and poked around.
Everything looks kosher.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1055#discussion_r193850059
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -151,7 +152,7 @@ public
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1056
METRON-1609 Elasticsearch settings in Ambari should not be required if Solr
is the Indexer
NOTE: This PR has been submitted against the Solr feature branch; not
master
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1055#discussion_r193849566
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -720,4 +719,12
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1055
+1 looks good. Thanks
I wouldn't worry about that constant. Not worth it.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196184150
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/alerts_ui_master.py
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1066
METRON-1622 Allow user to define global property
'threat.triage.score.field' in Ambari
Based on #1055 and #1062 , the user can specify the name of the field
containing the threat triage score
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196140639
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/alerts_ui_master.py
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196132728
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
---
@@ -137,4
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196141302
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
---
@@ -137,4
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196130055
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
---
@@ -137,4
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1047#discussion_r196130319
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
---
@@ -137,4
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1056
Thanks @merrimanr. Good catch. I will fix that.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1057
+1 Thanks!
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1036
METRON-1584 Indexing Topology Crashes with Invalid Message
If the indexing topology receives a message containing invalid JSON, the
topology will crash. The topology needs to handle
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1014
> Should assignment be = or :=?
Ultimately, I'd like to see us move to supporting `=` as that is just way
more intuitive for most people. Maybe that means supporting b
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1014
> I am not sure how this PR impacts all the places where Stellar is used
and assignment .. Or maybe that is left to a future PR?
Sorry, its a little hard to digest that old PR, bu
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r191585931
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/field/FieldNameConverters.java
---
@@ -0,0 +1,98
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191587917
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191588328
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191596670
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/953
-1 as this has become an abandoned PR. I will open a request to close
this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/830
-1 as this PR has been abandoned.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1022
All review feedback should have been addressed. Let me know if there is
anything else @mmiklavc @cestella
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191590539
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/954
-1 as this has become an abandoned PR. I will open a request to close
this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/951
-1 as this has become an abandoned PR. I will open a request to close this
PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/956
-1 as this has become an abandoned PR. I will open a request to close this
PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/952
-1 as this has become an abandoned PR. I will open a request to close
this.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1042
METRON-1592 Unable to use third party parser with Storm versions >= 1.1.0
When launching a third party parser using
`$METRON_HOME/bin/start_parser_topology.sh` in HDP 2.6, Storm 1.
1 - 100 of 706 matches
Mail list logo
