Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240249191
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,105 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240248699
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1292
@nickwallen What I mean is that the returned value has the query parameters
in it, so you have the data and the query you used for it. Please excuse me if
that is already the case
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
ok, this is fixed. The bashSupport formatter in IntelliJ break the array
assignment. Sorry, i didn't redeploy after a format and document run.
Also, I don&#x
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239860797
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239859491
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239847486
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1245
Given we have the 5424 parser, and the 3164 parser in PR already, with
chaining, perhaps this parser would be cleaner and easier to configure and
understand if it was re-positioned ( wrt
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1292
Could the return be a full json document, that includes the query
parameters? I can see doing these things and writing to file, and wanting more
than just the data, but having the meta data
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@nickwallen @JonZeolla, with the readme done, this is now ready for review
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@nickwallen @JonZeolla, with the readme done, this is now ready for review
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1291
+1 pending updating the dependency csv file
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
current send to end cmd is:
```bash
./scripts/download_sample_pcaps.sh --data-path=A_FULL_PATH &&
./example_script.sh --skip-docker-build --leave-runnin
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r239090484
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238851540
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850336
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850284
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850232
--- Diff: docker/scripts/cleanup_containers.sh ---
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238848200
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@JonZeolla , I was going to ask you about that, what do you think the best
practice is for these permissions?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238827202
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
i changed it
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238826943
--- Diff: docker/scripts/process_data_docker.sh ---
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238806017
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805671
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805529
--- Diff: docker/scripts/create_docker_network.sh ---
@@ -0,0 +1,73 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805123
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804842
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804501
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803331
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
so the idea is that
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803083
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238802060
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238801412
--- Diff: docker/in_docker_scripts/process_data_dir.sh ---
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
We will also have scripts that do docker exec etc to read from kafka etc.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
The idea, at least at this point is that when in the container you will
have the 'built in scripts' that we have, and whatever scripts you have mapped
into the con
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238431951
--- Diff: docker/containers/bro-localbuild-container/Dockerfile ---
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238431923
--- Diff: docker/in_docker_scripts/build_bro.sh ---
@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
--- End diff --
all set
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
I had a lot of trouble with compose, so I did it with plain run and a
shared network.
We can look at compose later.
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
METRON-1911 [WIP] Docker setup for testing bro plugin
Status>
To try:
```
î° ~/src/apache/forks/metron-bro-plugin-kafka î° î docker î° cd docker
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1288
Can we step back? What dependencies where not present? That may be the
real issue for the users.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1288
In my mind we don't have a current state where Stellar is running but not
all the functions in the class path are loaded. This is different. Before we
would have crashed starting up.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1288
@cestella should check in on this
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1288
So, my main concern here is the state of stellar _after_ loading in this
condition. What happens if you call a function that failed to load? What
happens if it is nested in a match or a
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1287
typo in PR title
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1287
what breaks specifically?
having all the metron ports etc point to localhost seems to me that it
would also break things or have conflicts etc.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
The base option is like quick dev, but quick dev also had metron installed,
so starting it involved replacing the bits that where in there, we didn't
maintain quick dev ansible w/o the m
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236385492
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236375985
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
I think spellcheck is integrated into travis, so what we _can_ do is make
shellcheck a build dependency and execute it through maven in the poms
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@mmiklavc I have it integrated into IntelliJ, though it isn't as obvious as
java errors
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
Let's go with what @nickwallen said
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236301587
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236292888
--- Diff:
metron-deployment/development/centos6_docker_build/docker_run_ansible.sh ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236262632
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236262449
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236262354
--- Diff:
metron-deployment/development/centos6_docker_build/ansible/inventory/group_vars/all
---
@@ -0,0 +1,86 @@
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236262118
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236261928
--- Diff:
metron-deployment/development/centos6_docker_build/docker_run_ansible.sh ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236261518
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236261064
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236260538
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236260621
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1279#discussion_r236062925
--- Diff: metron-platform/metron-parsers/src/main/resources/META-INF/NOTICE
---
@@ -37,4 +37,18 @@ Copyright 2006-2011 Google, Inc
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1279
METRON-1893 Syslog RFC-3164 parser
This PR adds a new parser for Syslog RFC-3164
This PR also moves from simple-syslog-5424 to simple-syslog, which has both
RFC parsers in it. So
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@nickwallen Done
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@nickwallen, yeah, I did prompts as I went along debugging. I was
thinking that folks may not like them.
I'll parameterize things.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
If you create an issue for your vagrant base machine with our hadoop /
ambari already in it, you can assign it to me. @justinleet
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
It is possible to imagine a number of scenarios, including that, but also
needing to build with new hadoop versions ( can't loose build from scratch ).
There are a number of thin
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1277
METRON-1890 disable audio in vm so it does not grab the mic and trigger
security â¦
â¦software like microsnitch
Run the vagrant ups, should be normal, but you won't get
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
wait, you don't have a plan??? lol. nm. just wondering. I have some old
things around this, maybe I'll follow on.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
I was going to suggest that we may want do it, but your use of _conflating_
has dissuaded me.
Have you a list of 'post' things to add that to perhaps?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
All the hard coded paths for test resources should be removed. Similar to
how we build the test data paths for the integration tests.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Thanks for the taking the time you did to submit the PR @dopheide-esnet.
-1
Filling out the template to say "Yes reviewer, I tested, built, and check
th
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1271
Hi, thanks for the contribution! Can you have a look at filling out the pr
template? This this it is especially important to look at the part about
saying you have tried:
`mvn -q clean
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1268
+1, great job
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234305980
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234293803
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234290697
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234289745
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -219,14 +220,23 @@ public Object
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
Then maybe a function to evaluate stellar
EVALUATE_TRANSFORM(config,PARSER_PARSE(parser, input)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
maybe that can be a follow on, it would be much better to load from disk ->
split lines than to open an editor and cut and past from your sample log.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1249#discussion_r234230655
--- Diff: README.md ---
@@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus.
Some high level links to the relevant
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
Can we test parser chains?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
Can we load files from disk? It would be nice to not have had to setup
kafka etc.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1249#discussion_r233920015
--- Diff: README.md ---
@@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus.
Some high level links to the relevant
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
anyone have any ideas of the best way to time these things?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
We could also use more tags, for example I may want to skip building the
java, but not skip building the RPMs. Think of a dev flow -> I make my change,
run my local tests and want to spin
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@nickwallen That is an option, but not something I would pick as the goal
from the outset if you know what I mean.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
@justinleet I'm fine with that
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1260
+1, sorry I missed this
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
The integration test failure has to do with the profiler tests and seem
unrelated.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@mmiklavc That is basically correct. Except that the ansible version is
2.5, since it only applies to this build, and allows for the yaml log
formatting.
Also, in the latest
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1261
@nickwallen I did not think of that. I was improving the process that
stands today. I think in a world where the posted image exists, we would still
want the ability to try the latest ( to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1260
What did you seen before that is fix now?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1249
I'm ok with changing parsing to something else, just not parsers.
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1261
METRON-1860 [WIP] new developer option for ansible in docker to deploy to
vagrant
The goal of this PR is to provide a new "full_dev" option for new and old
users that does not
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1171
@nickwallen can we get a +1 on this? @JonZeolla you are a +1 but not
explicitly?
---
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/1014
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1014
This is in, not sure why it isn't closed
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1258
I think that the test logically tests what we are concerned about, that the
format of the produced string matches the desired format. Testing that the
value is explicitly x,y,z isn't te
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/1258
METRON-1864 fix issue where daylight savings breaks tests
Thanks to @justinleet for the fix. I would have use a totally awesome but
overdone regex.
### For all changes:
- [x
1 - 100 of 385 matches
Mail list logo
