szaszm closed pull request #960:
URL: https://github.com/apache/nifi-minifi-cpp/pull/960
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
szaszm closed pull request #958:
URL: https://github.com/apache/nifi-minifi-cpp/pull/958
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
szaszm closed pull request #962:
URL: https://github.com/apache/nifi-minifi-cpp/pull/962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
octarice opened a new pull request #4742:
URL: https://github.com/apache/nifi/pull/4742
Support microsecond resolution for Avro Logical Type timestamp-micros. Fixes
NIFI-8104
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR
exceptionfactory commented on pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#issuecomment-754329946
@pvillard31 Thanks for the feedback and changes, looks good.
This is an automated message from the Apache
NissimShiman commented on pull request #4563:
URL: https://github.com/apache/nifi/pull/4563#issuecomment-754282945
@markap14 Your point about text boxes not able to hold a uuid (without an
ellipsis) is a good catch. :)
I could make the entire Search Events pop up a little wider
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754256434
@joewitt, sorry for the confusion
This is an automated message from the Apache Git Service.
To respond to
exceptionfactory commented on pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#issuecomment-754246017
@turcsanyip Thanks for making the changes, everything looks good.
This is an automated message from the
exceptionfactory commented on a change in pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#discussion_r551593919
##
File path:
nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java
##
@@ -153,70
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754241916
cool that looks better. lets see if it builds
This is an automated message from the Apache Git Service.
To respond
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754240419
ok, should be set
This is an automated message from the Apache Git Service.
To respond to the message,
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754238275
sure thing!
This is an automated message from the Apache Git Service.
To respond to the message, please
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754237356
I think the merge thing done might have messed it up. You might want to
rebase the two real commits to the latest main then force push without any
merge commits.
joewitt commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754237132
This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be
performed automatically due to conflicts encountered while
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754233638
https://user-images.githubusercontent.com/551/103581840-c61b0b00-4eaa-11eb-95a8-f867eb663484.png;>
???
pcgrenier commented on pull request #4554:
URL: https://github.com/apache/nifi/pull/4554#issuecomment-754222109
Or as you said, shared code and create a RestObjectLookupService
This is an automated message from the Apache
pcgrenier edited a comment on pull request #4554:
URL: https://github.com/apache/nifi/pull/4554#issuecomment-754219414
Yeah, I thought about the default current behavior. It just seems "wrong" or
not intuitive to return the first element in the array. The only processor that
I found that
pcgrenier commented on pull request #4554:
URL: https://github.com/apache/nifi/pull/4554#issuecomment-754219414
Yeah, I thought about the default current behavior. It just seems "wrong" or
not intuitive to return the first element in the array. The only processor that
I found that used
NissimShiman commented on pull request #4563:
URL: https://github.com/apache/nifi/pull/4563#issuecomment-754217587
Thank you for your feedback @markap14! (and for reviewing/merging
https://issues.apache.org/jira/browse/NIFI-7225 as well)
markap14 commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754210723
@ottobackwards changes look good to me. I'm a +1 on this, but it looks like
it has some conflicts. Can you resolve and ping me? Then I'll be happy to
merge. Happy new year!
markap14 commented on pull request #4554:
URL: https://github.com/apache/nifi/pull/4554#issuecomment-754208111
I don't think we can accept this change into the codebase. It has the
potential to break a lot of things. Any component that previously declared a
property to reference a
pvillard31 commented on pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#issuecomment-754200530
Thanks for the review @exceptionfactory and @markap14 - I made some changes
following your recommendations.
pvillard31 commented on a change in pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#discussion_r551547883
##
File path:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##
@@ -124,6 +148,45
markap14 commented on pull request #4563:
URL: https://github.com/apache/nifi/pull/4563#issuecomment-754196454
Thanks for the pull request @NissimShiman! I think this is a helpful
feature. Looking at the PR, the code looks good. I think the UI needs a bit of
tweaking, though. This results
pvillard31 commented on a change in pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#discussion_r551542640
##
File path:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##
@@ -322,14
pvillard31 commented on a change in pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#discussion_r551539908
##
File path:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
##
@@ -322,14
ottobackwards commented on a change in pull request #4656:
URL: https://github.com/apache/nifi/pull/4656#discussion_r551536622
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java
ottobackwards commented on a change in pull request #4656:
URL: https://github.com/apache/nifi/pull/4656#discussion_r551536261
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java
[
https://issues.apache.org/jira/browse/NIFI-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-7937:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258438#comment-17258438
]
ASF subversion and git services commented on NIFI-7937:
---
Commit
markap14 merged pull request #4609:
URL: https://github.com/apache/nifi/pull/4609
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4609:
URL: https://github.com/apache/nifi/pull/4609#issuecomment-754165178
Thanks @exceptionfactory! All looks good to me. +1 merging to main.
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/NIFI-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-7932:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
markap14 merged pull request #4605:
URL: https://github.com/apache/nifi/pull/4605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4605:
URL: https://github.com/apache/nifi/pull/4605#issuecomment-754162394
I would definitely favor parameters in this situation. In general, we want
to avoid having to do lots of code updates to add support for variables for
this property and that. But
markap14 commented on a change in pull request #4682:
URL: https://github.com/apache/nifi/pull/4682#discussion_r551502899
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java
##
@@ -78,4 +77,15 @@
[
https://issues.apache.org/jira/browse/NIFI-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-8110.
--
Resolution: Not A Problem
We're not doing anything specific here and Java date patterns should
[
https://issues.apache.org/jira/browse/NIFI-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-8062.
--
Fix Version/s: 1.13.0
Resolution: Fixed
> Tabbs plugin is not accessible by keyboard
>
[
https://issues.apache.org/jira/browse/NIFI-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-7225:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258413#comment-17258413
]
ASF subversion and git services commented on NIFI-7225:
---
Commit
markap14 merged pull request #4627:
URL: https://github.com/apache/nifi/pull/4627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4627:
URL: https://github.com/apache/nifi/pull/4627#issuecomment-754144923
Thanks for the update @tlsmith109 ! And thanks for the review @NissimShiman
. All looks good to me as well. +1 will merge to main.
ottobackwards commented on a change in pull request #4262:
URL: https://github.com/apache/nifi/pull/4262#discussion_r551493870
##
File path:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/FieldValueLogicalPathBuilder.java
##
@@ -0,0 +1,124 @@
+/*
markap14 commented on a change in pull request #4656:
URL: https://github.com/apache/nifi/pull/4656#discussion_r551492094
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java
markap14 commented on pull request #4720:
URL: https://github.com/apache/nifi/pull/4720#issuecomment-754125862
Hi @s9514171 . Thanks for the Pull Request! Looking at this, though, I'm
having a bit of trouble understanding what the changes are that you're
proposing. NIFI-1440 is about
markap14 commented on pull request #4723:
URL: https://github.com/apache/nifi/pull/4723#issuecomment-754112797
I'm having trouble verifying this one. I tried clicking on the Processor
Name label in the Configure Processor dialog. Then pressed tab, hoping it would
select the 'Enabled'
turcsanyip commented on pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#issuecomment-754105034
@exceptionfactory Thanks for your thorough review. Committed the changes.
This is an automated message from the
turcsanyip commented on a change in pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#discussion_r551455310
##
File path:
nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java
##
@@ -85,18 +89,20
turcsanyip commented on a change in pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#discussion_r551454345
##
File path:
nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java
##
@@ -85,18 +89,20
turcsanyip commented on a change in pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#discussion_r551451724
##
File path:
nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java
##
@@ -153,70 +162,83
hunyadi-dev opened a new pull request #968:
URL: https://github.com/apache/nifi-minifi-cpp/pull/968
No functional changes were introduced in this PR, just separating
integration test components into python modules based on their functionality
(and wrapping config serializers into
turcsanyip commented on a change in pull request #4733:
URL: https://github.com/apache/nifi/pull/4733#discussion_r551448672
##
File path:
nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/InvokeGRPC.java
##
@@ -240,13 +262,11
markap14 merged pull request #4724:
URL: https://github.com/apache/nifi/pull/4724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4724:
URL: https://github.com/apache/nifi/pull/4724#issuecomment-754092276
Verified that I'm able to switch between tabs in the processor config dialog
and in the Controller Settings dialog. Based on the code changes, I think this
should apply to all
[
https://issues.apache.org/jira/browse/MINIFICPP-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi resolved MINIFICPP-1424.
--
Resolution: Fixed
> Stabilize several flaky test suites
>
Adam Hunyadi created MINIFICPP-1445:
---
Summary: Clean up docker integration test framework
Key: MINIFICPP-1445
URL: https://issues.apache.org/jira/browse/MINIFICPP-1445
Project: Apache NiFi MiNiFi
markap14 commented on pull request #4738:
URL: https://github.com/apache/nifi/pull/4738#issuecomment-754049914
Thanks for the improvement @pvillard31. I think this will give us MUCH
better performance for any MQTT related use cases. @exceptionfactory had a few
comments but otherwise I'm a
markap14 commented on a change in pull request #4262:
URL: https://github.com/apache/nifi/pull/4262#discussion_r551367649
##
File path:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/FieldValueLogicalPathBuilder.java
##
@@ -0,0 +1,124 @@
+/*
+ *
markap14 commented on pull request #4262:
URL: https://github.com/apache/nifi/pull/4262#issuecomment-754021366
Happy New Year @ottobackwards ! Should be able to review this this week.
This is an automated message from the
markap14 commented on pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#issuecomment-754007982
Thanks @exceptionfactory for reviewing. Pushed a new commit that I believe
addresses all feedback above.
This is
markap14 commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r551349831
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSinkTask.java
##
@@ -0,0
ottobackwards commented on pull request #4262:
URL: https://github.com/apache/nifi/pull/4262#issuecomment-754007637
Happy New Year!
This is an automated message from the Apache Git Service.
To respond to the message, please
markap14 commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r551349476
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessKafkaConnectorUtil.java
##
@@
ottobackwards commented on pull request #4384:
URL: https://github.com/apache/nifi/pull/4384#issuecomment-754007304
Happy New Year!
This is an automated message from the Apache Git Service.
To respond to the message, please
markap14 commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r551349263
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessKafkaConnectorUtil.java
##
@@
ottobackwards commented on pull request #4513:
URL: https://github.com/apache/nifi/pull/4513#issuecomment-754007115
Happy New Year!
This is an automated message from the Apache Git Service.
To respond to the message, please
ottobackwards commented on pull request #4656:
URL: https://github.com/apache/nifi/pull/4656#issuecomment-754006853
Happy New Year!
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/NIFI-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8100:
---
Issue Type: Improvement (was: Bug)
> Provide a /health endpoint that do not require
arpadboda closed pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
arpadboda commented on pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#issuecomment-753985192
Merged in scope of
https://github.com/apache/nifi-minifi-cpp/commit/24d16c1c92d1bf818e5cbba7e91f7eb0688dfcb2
exceptionfactory commented on a change in pull request #4709:
URL: https://github.com/apache/nifi/pull/4709#discussion_r551308940
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/CertificateUtils.java
##
@@ -469,6 +472,14 @@ public
exceptionfactory commented on a change in pull request #4709:
URL: https://github.com/apache/nifi/pull/4709#discussion_r551308940
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/CertificateUtils.java
##
@@ -469,6 +472,14 @@ public
exceptionfactory commented on a change in pull request #4739:
URL: https://github.com/apache/nifi/pull/4739#discussion_r551295426
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
exceptionfactory commented on pull request #4741:
URL: https://github.com/apache/nifi/pull/4741#issuecomment-753950251
Thank you for submitting the PR. Please review the output of the automated
checks, there are unit test failures in
`TestJsonQualifierAndValueRowSerializer`.
fgerlits commented on a change in pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#discussion_r551273890
##
File path: .github/workflows/ci.yml
##
@@ -259,8 +249,7 @@ jobs:
ubuntu-16.04-shared-ccache-refs/heads/main-
- id:
fgerlits commented on a change in pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#discussion_r551273890
##
File path: .github/workflows/ci.yml
##
@@ -259,8 +249,7 @@ jobs:
ubuntu-16.04-shared-ccache-refs/heads/main-
- id:
fgerlits commented on pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#issuecomment-753903736
You will also need to cherry-pick #925 because of the `set-env` deprecation
in GitHub Actions.
This is
fgerlits commented on pull request #966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/966#issuecomment-753903252
Same as #952, which is already in main, so should be safe to merge.
This is an automated message from
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r551217433
##
File path: libminifi/include/core/TypedValues.h
##
@@ -128,72 +130,35 @@ class DataSizeValue : public TransformableValue, public
szaszm commented on pull request #967:
URL: https://github.com/apache/nifi-minifi-cpp/pull/967#issuecomment-753839177
figuring out test linker errors...
This is an automated message from the Apache Git Service.
To respond to
80 matches
Mail list logo
