exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564220978
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##
@@ -26,12 +27,12 @@
import
exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564220393
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@
exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564218876
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java
##
@@ -679,11
exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564218598
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r563670164
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,294 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ *
szaszm commented on pull request #978:
URL: https://github.com/apache/nifi-minifi-cpp/pull/978#issuecomment-766835726
And thanks for your first contribution. The general workflow is that we
merge after every comment is resolved, there are 2-3 approvals on the pull
request, no conflicts
mtien-apache commented on pull request #4727:
URL: https://github.com/apache/nifi/pull/4727#issuecomment-767129880
@exceptionfactory +1 LGTM. Confirmed that the deprecation warning is
removed. I'm able to build successfully on JDK 8 and 11, run a secure instance,
and transfer data through
lordgamez commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r563790242
##
File path: libminifi/include/core/state/UpdateController.h
##
@@ -148,7 +148,16 @@ class UpdateRunner : public utils::AfterExecute {
joewitt commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766831700
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
markap14 commented on a change in pull request #4748:
URL: https://github.com/apache/nifi/pull/4748#discussion_r563786001
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/main/java/org/apache/nifi/BootstrapListener.java
##
@@ -215,6 +220,12
exceptionfactory closed pull request #4734:
URL: https://github.com/apache/nifi/pull/4734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564073721
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@
exceptionfactory commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766910732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
thenatog closed pull request #314:
URL: https://github.com/apache/nifi-registry/pull/314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mtien-apache commented on pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#issuecomment-767021987
@exceptionfactory Thanks for reviewing again! Will go over your comments
soon.
This is an automated message
markap14 commented on a change in pull request #4714:
URL: https://github.com/apache/nifi/pull/4714#discussion_r563904084
##
File path:
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/QuerySplunkIndexingStatus.java
##
exceptionfactory commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r563924527
##
File path:
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560990362
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,579 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
exceptionfactory edited a comment on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766962393
> Yeah true they do have a pretty broad impact. However, we have to be
extremely careful about which dependencies end up in our 'all things
classloader' since
lordgamez commented on pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#issuecomment-766708979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
exceptionfactory commented on pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#issuecomment-767157976
Closing in favor of implementation in #4781
This is an automated message from the Apache Git Service.
To
szaszm commented on pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#issuecomment-766801370
Please don't forget to update the [C2
Design](https://cwiki.apache.org/confluence/display/MINIFI/C2+Design) wiki page.
szaszm commented on a change in pull request #978:
URL: https://github.com/apache/nifi-minifi-cpp/pull/978#discussion_r563733304
##
File path:
extensions/standard-processors/tests/integration/TLSClientSocketSupportedProtocolsTest.cpp
##
@@ -0,0 +1,221 @@
+/**
+ *
+ * Licensed
lordgamez commented on pull request #977:
URL: https://github.com/apache/nifi-minifi-cpp/pull/977#issuecomment-766691614
> LGTM,
> but we should think about a way to reduce the duplication of all of the
options to ease maintenance. It's starting to become too easy to forget one or
two
szaszm commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r563694487
##
File path: libminifi/include/core/state/UpdateController.h
##
@@ -148,7 +148,16 @@ class UpdateRunner : public utils::AfterExecute {
JonathanKessler commented on pull request #3923:
URL: https://github.com/apache/nifi/pull/3923#issuecomment-766970172
> @JonathanKessler This is a really neat ticket/PR request that many nifi
admins will find invaluable (I know I would have many times in the past).
>
> I was kicking
sushilkm commented on pull request #4492:
URL: https://github.com/apache/nifi/pull/4492#issuecomment-767180491
looks good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564115761
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestInvokeHttpTwoWaySSL.java
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564092023
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##
@@ -26,12 +27,12 @@
import
Snorlaxa closed pull request #4760:
URL: https://github.com/apache/nifi/pull/4760
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564171223
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListenHTTP.java
##
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564169470
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestInvokeHttpTwoWaySSL.java
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564149146
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java
##
@@ -366,4 +461,133 @@ public static
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564149011
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java
##
@@ -366,4 +461,133 @@ public static
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564138178
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@ private
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564138178
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@ private
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564119427
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/util/TestInvokeHttpCommon.java
mtien-apache commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r564115761
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestInvokeHttpTwoWaySSL.java
sushilkm commented on pull request #4492:
URL: https://github.com/apache/nifi/pull/4492#issuecomment-767180491
looks good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564103224
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java
##
@@ -679,11 +680,12
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564103224
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java
##
@@ -679,11 +680,12
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564092771
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@ private
turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564092023
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##
@@ -26,12 +27,12 @@
import
exceptionfactory commented on pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#issuecomment-767157976
Closing in favor of implementation in #4781
This is an automated message from the Apache Git Service.
To
exceptionfactory closed pull request #4734:
URL: https://github.com/apache/nifi/pull/4734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
exceptionfactory commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564073721
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1087,28 @@
[
https://issues.apache.org/jira/browse/NIFI-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271710#comment-17271710
]
Peter Turcsanyi commented on NIFI-8023:
---
Implemented a solution which solves NIFI-7996 without
[
https://issues.apache.org/jira/browse/NIFI-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8172:
---
Status: Patch Available (was: In Progress)
> PutDatabaseRecord ignores schema name when getting
mattyb149 opened a new pull request #4782:
URL: https://github.com/apache/nifi/pull/4782
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The call to DatabaseMetaData.getPrimaryKeys() was
turcsanyip opened a new pull request #4781:
URL: https://github.com/apache/nifi/pull/4781
…ed forms before/after database operations
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
[
https://issues.apache.org/jira/browse/NIFI-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-8172:
--
Assignee: Matt Burgess
> PutDatabaseRecord ignores schema name when getting primary keys
>
mtien-apache commented on pull request #4727:
URL: https://github.com/apache/nifi/pull/4727#issuecomment-767129880
@exceptionfactory +1 LGTM. Confirmed that the deprecation warning is
removed. I'm able to build successfully on JDK 8 and 11, run a secure instance,
and transfer data through
Matt Burgess created NIFI-8172:
--
Summary: PutDatabaseRecord ignores schema name when getting
primary keys
Key: NIFI-8172
URL: https://issues.apache.org/jira/browse/NIFI-8172
Project: Apache NiFi
mtien-apache commented on pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#issuecomment-767021987
@exceptionfactory Thanks for reviewing again! Will go over your comments
soon.
This is an automated message
markap14 commented on a change in pull request #4714:
URL: https://github.com/apache/nifi/pull/4714#discussion_r563904084
##
File path:
nifi-nar-bundles/nifi-splunk-bundle/nifi-splunk-processors/src/main/java/org/apache/nifi/processors/splunk/QuerySplunkIndexingStatus.java
##
exceptionfactory commented on a change in pull request #4767:
URL: https://github.com/apache/nifi/pull/4767#discussion_r563924527
##
File path:
JonathanKessler commented on pull request #3923:
URL: https://github.com/apache/nifi/pull/3923#issuecomment-766970172
> @JonathanKessler This is a really neat ticket/PR request that many nifi
admins will find invaluable (I know I would have many times in the past).
>
> I was kicking
joewitt commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766965220
no. just verbalizing what i was focusing on . i think your changes don't
change it since you just operated on 'dependency management' rather than
'dependency' sections except as
exceptionfactory edited a comment on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766962393
> Yeah true they do have a pretty broad impact. However, we have to be
extremely careful about which dependencies end up in our 'all things
classloader' since
exceptionfactory commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766962393
> Yeah true they do have a pretty broad impact. However, we have to be
extremely careful about which dependencies end up in our 'all things
classloader' since every
thenatog closed pull request #314:
URL: https://github.com/apache/nifi-registry/pull/314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
joewitt commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766914667
Yeah true they do have a pretty broad impact. However, we have to be
extremely careful about which dependencies end up in our 'all things
classloader' since every subordinate
exceptionfactory commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766910732
> looked through each of the dep updates. Since they are generally updating
only dependency management it is probably fair game to elevate the specific
declaration to the
[
https://issues.apache.org/jira/browse/NIFI-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271378#comment-17271378
]
David Handermann commented on NIFI-8171:
[~joewitt] The initial PR run for JDK 11 improved the
lordgamez commented on pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#issuecomment-766894988
> > I think we should investigate the CI failure here:
> > ```
> > C2PauseResumeTest:
markap14 commented on a change in pull request #4748:
URL: https://github.com/apache/nifi/pull/4748#discussion_r563786001
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/main/java/org/apache/nifi/BootstrapListener.java
##
@@ -215,6 +220,12
lordgamez commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r563790242
##
File path: libminifi/include/core/state/UpdateController.h
##
@@ -148,7 +148,16 @@ class UpdateRunner : public utils::AfterExecute {
JonathanKessler opened a new pull request #4780:
URL: https://github.com/apache/nifi/pull/4780
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds total queued duration and max queued
szaszm commented on pull request #978:
URL: https://github.com/apache/nifi-minifi-cpp/pull/978#issuecomment-766835726
And thanks for your first contribution. The general workflow is that we
merge after every comment is resolved, there are 2-3 approvals on the pull
request, no conflicts
szaszm commented on a change in pull request #978:
URL: https://github.com/apache/nifi-minifi-cpp/pull/978#discussion_r563733304
##
File path:
extensions/standard-processors/tests/integration/TLSClientSocketSupportedProtocolsTest.cpp
##
@@ -0,0 +1,221 @@
+/**
+ *
+ * Licensed
joewitt commented on pull request #4779:
URL: https://github.com/apache/nifi/pull/4779#issuecomment-766831700
looked through each of the dep updates. Since they are generally updating
only dependency management it is probably fair game to elevate the specific
declaration to the top level
[
https://issues.apache.org/jira/browse/NIFI-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8171:
---
Status: Patch Available (was: Open)
> Upgrade Bouncy Castle bcprov-jdk15on to 1.68
>
[
https://issues.apache.org/jira/browse/NIFI-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee resolved NIFI-7357.
---
Resolution: Duplicate
> Make Zookeeper TLS Properties Available via nifi.properties
>
[
https://issues.apache.org/jira/browse/NIFI-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee resolved NIFI-7203.
---
Fix Version/s: 1.13.0
Resolution: Fixed
> Add support for ZooKeeper TLS
>
exceptionfactory opened a new pull request #4779:
URL: https://github.com/apache/nifi/pull/4779
Description of PR
NIFI-8171 Upgrades Bouncy Castle Security Provider and related libraries
from 1.66 to 1.68. This PR also centralizes the managed dependency version in
the root
[
https://issues.apache.org/jira/browse/NIFI-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271316#comment-17271316
]
Joe Witt commented on NIFI-7263:
Well nevermind I see this in the JIRA description. As long as we make
[
https://issues.apache.org/jira/browse/NIFI-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271314#comment-17271314
]
Joe Witt commented on NIFI-7263:
The challenge I have with these descriptions is that with no tracking
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r563728844
##
File path: extensions/aws/s3/S3Wrapper.cpp
##
@@ -30,46 +37,253 @@ namespace minifi {
namespace aws {
namespace s3 {
[
https://issues.apache.org/jira/browse/MINIFICPP-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271309#comment-17271309
]
Martin Zink commented on MINIFICPP-1453:
After investigating this issue, it turns out that
martinzink opened a new pull request #978:
URL: https://github.com/apache/nifi-minifi-cpp/pull/978
Currently org::apache::nifi:minifi::io::TLSSocket
(which, among other things, handles communications with C2)
only accept TLSv1.2 protocol (hardcoded behaviour)
Added integration
[
https://issues.apache.org/jira/browse/NIFI-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271306#comment-17271306
]
Joe Witt commented on NIFI-8171:
David does this fix the issue that popped up with tests in Github CI?
[
https://issues.apache.org/jira/browse/NIFI-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-8171:
---
Fix Version/s: 1.13.0
> Upgrade Bouncy Castle bcprov-jdk15on to 1.68
>
szaszm commented on pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#issuecomment-766801370
Please don't forget to update the [C2
Design](https://cwiki.apache.org/confluence/display/MINIFI/C2+Design) wiki page.
szaszm commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r563694487
##
File path: libminifi/include/core/state/UpdateController.h
##
@@ -148,7 +148,16 @@ class UpdateRunner : public utils::AfterExecute {
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r563688979
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,294 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ *
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r563670164
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,294 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ *
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560990362
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,579 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
lordgamez commented on pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#issuecomment-766708979
> I think we should investigate the CI failure here:
>
> ```
> C2PauseResumeTest:
lordgamez commented on pull request #977:
URL: https://github.com/apache/nifi-minifi-cpp/pull/977#issuecomment-766691614
> LGTM,
> but we should think about a way to reduce the duplication of all of the
options to ease maintenance. It's starting to become too easy to forget one or
two
Gabor Gyimesi created MINIFICPP-1454:
Summary: Reduce duplication of CMake parameters in docker arguments
Key: MINIFICPP-1454
URL: https://issues.apache.org/jira/browse/MINIFICPP-1454
Project:
90 matches
Mail list logo
