[jira] [Updated] (NIFI-10623) Several Related Flaky Tests in TestHttpClient

2022-12-09 Thread Yiteng Zhang (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiteng Zhang updated NIFI-10623: Description: These tests: {code:java}

[GitHub] [nifi] Kerr0220 opened a new pull request, #6508: NIFI-10623 fix flaky tests in TestHttpClient

2022-12-09 Thread GitBox
Kerr0220 opened a new pull request, #6508: URL: https://github.com/apache/nifi/pull/6508 # Summary [NIFI-10623](https://issues.apache.org/jira/browse/NIFI-10623) These flaky tests were caused by the feature of Map since the

[GitHub] [nifi] Kerr0220 commented on pull request #6508: NIFI-10623 fix flaky tests in TestHttpClient

2022-12-09 Thread GitBox
Kerr0220 commented on PR #6508: URL: https://github.com/apache/nifi/pull/6508#issuecomment-1344843580 @exceptionfactory Hi, could you please reopen this PR? I've pushed a new commit to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044871408 ## extensions/jni/jvm/JniReferenceObjects.h: ## @@ -299,24 +278,26 @@ class JniSessionFactory : public core::WeakReference { } } - jobject

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044842683 ## libminifi/test/unit/FileStreamTests.cpp: ## @@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") { stream.seek(0); } -#if

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044840784 ## extensions/sftp/tests/ListThenFetchSFTPTests.cpp: ## @@ -121,7 +120,7 @@ class ListThenFetchSFTPTestsFixture { plan->setProperty(list_sftp, "Minimum

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044839048 ## extensions/sftp/tests/PutSFTPTests.cpp: ## @@ -244,7 +240,7 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP bad password", "[PutSFTP][authent }

[jira] [Resolved] (NIFI-10453) Cannot set AnnotationData while processor is running

2022-12-09 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-10453. --- Resolution: Fixed > Cannot set AnnotationData while processor is running >

[jira] [Updated] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2

2022-12-09 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10877: Status: Patch Available (was: In Progress) > Refactor nifi-framework-bundle to use JUnit

[GitHub] [nifi] dan-s1 opened a new pull request, #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-09 Thread GitBox
dan-s1 opened a new pull request, #6775: URL: https://github.com/apache/nifi/pull/6775 …unit5 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following

[GitHub] [nifi] exceptionfactory closed pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute

2022-12-09 Thread GitBox
exceptionfactory closed pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute URL: https://github.com/apache/nifi/pull/6517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (NIFI-10576) ParquetRecordSetWriter doesn't write avro schema

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10576. - Fix Version/s: 1.20.0 Resolution: Fixed > ParquetRecordSetWriter doesn't write

[jira] [Commented] (NIFI-10576) ParquetRecordSetWriter doesn't write avro schema

2022-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645478#comment-17645478 ] ASF subversion and git services commented on NIFI-10576: Commit

[jira] [Comment Edited] (NIFI-9894) Enhance InvokeHTTP process - Send content through body variable

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645470#comment-17645470 ] David Handermann edited comment on NIFI-9894 at 12/9/22 7:43 PM: - No new

[jira] [Commented] (NIFI-9894) Enhance InvokeHTTP process - Send content through body variable

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645470#comment-17645470 ] David Handermann commented on NIFI-9894: No new activity right now. This is an issue where it

[jira] [Commented] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645467#comment-17645467 ] David Handermann commented on NIFI-10877: - Thanks for the update and work on this [~dstiegli1]!

[GitHub] [nifi] NissimShiman commented on pull request #6725: NIFI-10888: When inferring a schema using a Record Reader, buffer up …

2022-12-09 Thread GitBox
NissimShiman commented on PR #6725: URL: https://github.com/apache/nifi/pull/6725#issuecomment-1344673531 This is a really nice enhancement. Tested with csv files being converted to json files before and after fix for csv files of 21 and 63 bytes, there was 25 -30% speed up in

[jira] [Updated] (NIFI-10958) Documentation is not generated for some components in Java 17

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10958: Affects Version/s: 1.19.1 Status: Patch Available (was: Open) >

[GitHub] [nifi] exceptionfactory opened a new pull request, #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

2022-12-09 Thread GitBox
exceptionfactory opened a new pull request, #6774: URL: https://github.com/apache/nifi/pull/6774 # Summary [NIFI-10958](https://issues.apache.org/jira/browse/NIFI-10958) Adjusts Script Engine property handling in `ScriptingComponentsHelper` to avoid exceptions on Java 17 during

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044702728 ## extensions/sftp/tests/ListThenFetchSFTPTests.cpp: ## @@ -121,7 +120,7 @@ class ListThenFetchSFTPTestsFixture { plan->setProperty(list_sftp, "Minimum

[GitHub] [nifi] thenatog commented on pull request #6517: NIFI-10576 - ParquetRecordSetWriter doesn't write avro schema to attribute

2022-12-09 Thread GitBox
thenatog commented on PR #6517: URL: https://github.com/apache/nifi/pull/6517#issuecomment-1344598862 Thanks, if the avro.schema attribute is coming through on flowfiles coming out of the runner, then that sounds good to me. The simplest test would be to see that the attributes are now

[jira] [Comment Edited] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2

2022-12-09 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645405#comment-17645405 ] Daniel Stieglitz edited comment on NIFI-10877 at 12/9/22 5:25 PM: --

[jira] [Updated] (MINIFICPP-2010) The systemd extension shouldn't be available on mac

2022-12-09 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2010: Resolution: Fixed Status: Resolved (was: Patch Available) > The systemd

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044661369 ## libminifi/test/unit/FileStreamTests.cpp: ## @@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") { stream.seek(0); } -#if !defined(WIN32)

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044660504 ## libminifi/test/rocksdb-tests/RocksDBTests.cpp: ## @@ -232,9 +231,9 @@ void withDefaultEnv(minifi::internal::Writable& db_opts) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044659717 ## libminifi/test/rocksdb-tests/EncryptionTests.cpp: ## @@ -77,8 +75,8 @@ TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates checkpoint and loads

[jira] [Commented] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2

2022-12-09 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645405#comment-17645405 ] Daniel Stieglitz commented on NIFI-10877: - [~exceptionfactory] I have almost completed converting

[jira] [Assigned] (NIFI-10942) TestGenerateTableFetch.testMultipleColumnTypeMissing is a flaky test

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-10942: --- Assignee: Haoran Jiang > TestGenerateTableFetch.testMultipleColumnTypeMissing is a

[jira] [Assigned] (NIFI-10637) TestParseCEF.testCustomValidator is a flaky test

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-10637: --- Assignee: Haoran Jiang > TestParseCEF.testCustomValidator is a flaky test >

[jira] [Resolved] (NIFI-10942) TestGenerateTableFetch.testMultipleColumnTypeMissing is a flaky test

2022-12-09 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10942. - Fix Version/s: 1.20.0 (was: 1.19.0) Resolution: Fixed

[jira] [Commented] (NIFI-10637) TestParseCEF.testCustomValidator is a flaky test

2022-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645393#comment-17645393 ] ASF subversion and git services commented on NIFI-10637: Commit

[GitHub] [nifi] exceptionfactory closed pull request #6754: NIFI-10637 Fixing Flaky Test In TestGenerateTableFetch

2022-12-09 Thread GitBox
exceptionfactory closed pull request #6754: NIFI-10637 Fixing Flaky Test In TestGenerateTableFetch URL: https://github.com/apache/nifi/pull/6754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6480: NIFI-10585: Add GenerateFakeRecord processor

2022-12-09 Thread GitBox
exceptionfactory commented on code in PR #6480: URL: https://github.com/apache/nifi/pull/6480#discussion_r1044616560 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateFakeRecord.java: ## @@ -0,0 +1,1021

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1470: MINIFICPP-2010 Disable systemd on non-linux

2022-12-09 Thread GitBox
arpadboda closed pull request #1470: MINIFICPP-2010 Disable systemd on non-linux URL: https://github.com/apache/nifi-minifi-cpp/pull/1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044596070 ## extensions/sftp/tests/ListSFTPTests.cpp: ## @@ -139,15 +139,8 @@ class ListSFTPTestsFixture { std::fstream file; std::stringstream ss; ss

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044593149 ## extensions/standard-processors/tests/unit/TailFileTests.cpp: ## @@ -99,18 +89,16 @@ TEST_CASE("TailFile reads the file until the first delimiter",

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044592592 ## libminifi/src/core/ProcessSessionReadCallback.cpp: ## @@ -22,18 +22,19 @@ #include #include #include +#include #include

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044592071 ## libminifi/test/rocksdb-tests/EncryptionTests.cpp: ## @@ -77,8 +75,8 @@ TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates checkpoint and loads

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044591718 ## libminifi/test/rocksdb-tests/RocksDBTests.cpp: ## @@ -232,9 +231,9 @@ void withDefaultEnv(minifi::internal::Writable& db_opts) { }

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044590030 ## minifi_main/MainHelper.cpp: ## @@ -133,43 +128,41 @@ std::string determineMinifiHome(const std::shared_ptr& logger) return ""; }(); - if

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044589812 ## minifi_main/MainHelper.cpp: ## @@ -133,43 +128,41 @@ std::string determineMinifiHome(const std::shared_ptr& logger) return ""; }(); - if

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044587720 ## libminifi/test/unit/FileStreamTests.cpp: ## @@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") { stream.seek(0); } -#if

[jira] [Updated] (MINIFICPP-2010) The systemd extension shouldn't be available on mac

2022-12-09 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2010: Affects Version/s: 0.13.0 > The systemd extension shouldn't be available on mac >

[jira] [Updated] (MINIFICPP-2010) The systemd extension shouldn't be available on mac

2022-12-09 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2010: Fix Version/s: 0.14.0 > The systemd extension shouldn't be available on mac >

[jira] [Updated] (MINIFICPP-2010) The systemd extension shouldn't be available on mac

2022-12-09 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2010: Status: Patch Available (was: Open)

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1470: MINIFICPP-2010 Disable systemd on non-linux

2022-12-09 Thread GitBox
szaszm opened a new pull request, #1470: URL: https://github.com/apache/nifi-minifi-cpp/pull/1470 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044576534 ## libminifi/include/core/ConfigurableComponent.h: ## @@ -59,6 +59,18 @@ class ConfigurableComponent { template bool getProperty(const std::string

[jira] [Created] (MINIFICPP-2010) The systemd extension shouldn't be available on mac

2022-12-09 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2010: --- Summary: The systemd extension shouldn't be available on mac Key: MINIFICPP-2010 URL: https://issues.apache.org/jira/browse/MINIFICPP-2010 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044570304 ## extensions/standard-processors/tests/unit/GenerateFlowFileTests.cpp: ## @@ -57,9 +57,9 @@ TEST_CASE("GenerateFlowFileTest", "[generateflowfiletest]") {

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044569637 ## extensions/standard-processors/processors/GetFile.cpp: ## @@ -154,36 +154,32 @@ void GetFile::onTrigger(core::ProcessContext* /*context*/,

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044566428 ## extensions/sftp/processors/FetchSFTP.cpp: ## @@ -87,12 +87,11 @@ void FetchSFTP::onTrigger(const std::shared_ptr , return; } - /* Parse

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044565861 ## extensions/script/tests/TestExecuteScriptProcessorWithPythonScript.cpp: ## @@ -295,124 +291,119 @@ TEST_CASE("Python: Test Update Attribute",

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044561423 ## extensions/script/tests/TestExecuteScriptProcessorWithLuaScript.cpp: ## @@ -421,8 +412,10 @@ TEST_CASE("Lua: Test Module Directory property",

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044558281 ## extensions/script/python/PythonCreator.h: ## @@ -140,26 +136,18 @@ class PythonCreator : public minifi::core::CoreComponent { return python_package;

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044557769 ## extensions/jni/jvm/JniReferenceObjects.h: ## @@ -244,23 +228,24 @@ class JniSession : public core::WeakReference { } bool prune() { -

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044557458 ## extensions/http-curl/tests/C2VerifyServeResults.cpp: ## @@ -82,8 +82,8 @@ class VerifyC2Server : public HTTPIntegrationBase { } protected: -

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044555660 ## extensions/expression-language/tests/ExpressionLanguageTests.cpp: ## @@ -218,7 +216,7 @@ TEST_CASE("GetFile PutFile dynamic attribute",

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-09 Thread GitBox
martinzink commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044555022 ## Windows.md: ## @@ -93,7 +93,7 @@ A basic working CMake configuration can be inferred from the `win_build_vs.bat`. ``` mkdir build cd build -cmake -G

[GitHub] [nifi] NissimShiman commented on pull request #6750: NIFI-10934 Adding uniqueness check for Regisrty Client creation

2022-12-09 Thread GitBox
NissimShiman commented on PR #6750: URL: https://github.com/apache/nifi/pull/6750#issuecomment-1344334227 reviewing/testing pr... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6589: NIFI-10710 implement processor for AWS Polly, Textract, Translate, Tr…

2022-12-09 Thread GitBox
exceptionfactory commented on code in PR #6589: URL: https://github.com/apache/nifi/pull/6589#discussion_r1044467172 ## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/ml/polly/GetAwsPollyJobStatus.java: ## @@ -0,0 +1,115 @@ +/*

[jira] [Assigned] (NIFI-9677) LookUpRecord record path evaluation is "breaking" the next evaluation in case data is missing

2022-12-09 Thread Tamas Horvath (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Horvath reassigned NIFI-9677: --- Assignee: (was: Tamas Horvath) > LookUpRecord record path evaluation is "breaking" the

[jira] [Assigned] (NIFI-10885) ConsumeMQTT should stop client threads

2022-12-09 Thread Nandor Soma Abonyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Soma Abonyi reassigned NIFI-10885: - Assignee: Nandor Soma Abonyi > ConsumeMQTT should stop client threads >

[jira] [Updated] (NIFI-10929) NiFi generated certificates (e.g. Single User, or nifi-toolkit) are not compatible with OpenSSL 3.x+

2022-12-09 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-10929: - Affects Version/s: 1.19.1 > NiFi generated certificates (e.g. Single User, or nifi-toolkit) are

[jira] [Updated] (NIFI-10932) NiFi Toolkit CLI cannot connect to NiFi - trustAnchors parameter must be non-empty

2022-12-09 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-10932: - Affects Version/s: 1.19.1 > NiFi Toolkit CLI cannot connect to NiFi - trustAnchors parameter