[GitHub] nifi issue #3200: NIFI-5826 WIP Fix back-slash escaping at Lexers

2018-12-05 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3200 Reviewing... ---

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-12-04 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3183#discussion_r238642945 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java --- @@ -39,4 +39,52 @@ public static String

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-11-29 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3183#discussion_r237529258 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java --- @@ -39,4 +39,52 @@ public static String

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-11-27 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3183#discussion_r236843474 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java --- @@ -39,4 +39,44 @@ public static String

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-11-27 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3183#discussion_r236829982 --- Diff: nifi-commons/nifi-record-path/src/test/java/org/apache/nifi/record/path/TestRecordPath.java --- @@ -1008,12 +1008,16 @@ public void

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-11-27 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3183#discussion_r236789857 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/util/RecordPathUtils.java --- @@ -39,4 +39,44 @@ public static String

[GitHub] nifi pull request #3183: NIFI-5826 Fix to escaped backslash

2018-11-27 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3183 NIFI-5826 Fix to escaped backslash Fixing escaped backslash by unescaping it in java just before compiling regex. - For a consistency with expression language regex-based evaluators, all

[GitHub] nifi issue #1953: NIFI-4130 Add lookup controller service in TransformXML to...

2018-11-14 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/1953 +1 LGTM. Tested on local env, with XSLT as a file (regression), with lookup service, cache size 0 and >0, all works as expected. Ready for merge. @mattyb149 , please could you please give a fi

[GitHub] nifi pull request #1953: NIFI-4130 Add lookup controller service in Transfor...

2018-11-13 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/1953#discussion_r233016908 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java --- @@ -82,12

[GitHub] nifi pull request #1953: NIFI-4130 Add lookup controller service in Transfor...

2018-11-13 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/1953#discussion_r233019686 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java --- @@ -82,12

[GitHub] nifi issue #1953: NIFI-4130 Add lookup controller service in TransformXML to...

2018-11-12 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/1953 Reviewing... ---

[GitHub] nifi pull request #3164: NIFI-5810 Add UserName EL support to JMS processors

2018-11-09 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3164 NIFI-5810 Add UserName EL support to JMS processors Adding EL support to a property "User Name" to ConsumeJMS and PublishJSM Thank you for submitting a contribution to A

[GitHub] nifi pull request #3117: NIFI-5770 Fix Memory Leak in ExecuteScript on Jytho...

2018-10-31 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3117 NIFI-5770 Fix Memory Leak in ExecuteScript on Jython Moved module appending (aka classpath in python) into init stage instead of running each time onTrigger. Thank you for submitting

[GitHub] nifi pull request #3098: NIFI-5728 XML Writer to populate record tag name pr...

2018-10-20 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3098 NIFI-5728 XML Writer to populate record tag name properly All the changes are tested against - "Use Schema Text" (regression) - "AvroSchemaRegistry" Controller Servic

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3078 @joewitt , @patricker While working on implementations, I faced a problem of penalization on failure. Some processors are penalizing FF on failure, some do only on rollback, some gives you

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3078 +1 LGTM Pulled the changes, tested on local env, all looks good to go. @markap14 , @alopresto , any additional comments? ---

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226029162 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226028831 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226029040 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226028907 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226035394 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3078 @patricker , the code looks good. I'll test them locally later today and will provide my feedback. ---

[GitHub] nifi pull request #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3078#discussion_r226004572 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PenalizeFlowFile.java --- @@ -0,0

[GitHub] nifi issue #3078: NIFI-4805 Allow Delayed Transfer

2018-10-17 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3078 @patricker, this PR doesn't implement all the features requested originally in NIFI-4805, and discussed throughout the thread. Please take a look on comments from Andy, Mark and Martin

[GitHub] nifi issue #2954: NIFI-5514: Fixed bugs in MergeRecord around minimum thresh...

2018-09-24 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2954 +1 LGTM. Test case updated. Live test on local env (up to date) succeeded. Works as expected. Travis is failing for JP only (US and FR are OK). Can be merged. ---

[GitHub] nifi pull request #2954: NIFI-5514: Fixed bugs in MergeRecord around minimum...

2018-09-22 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2954#discussion_r219683471 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeRecord.java --- @@ -304,13

[GitHub] nifi issue #2954: NIFI-5514: Fixed bugs in MergeRecord around minimum thresh...

2018-09-20 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2954 Reviewing... ---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-19 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3005 +1. Ready for merge. Tested JNDI lookup with Tibco Context Factory (with authentication). Successfully pulled records from my queue. ---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3005 I'll test it and will let you know results (I have JNDI server with authentication for JMS queues). ---

[GitHub] nifi pull request #3005: NIFI-5598: Allow JMS Processors to lookup Connectio...

2018-09-18 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3005#discussion_r218387623 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProvider.java --- @@ -0,0 +1,165

[GitHub] nifi pull request #3005: NIFI-5598: Allow JMS Processors to lookup Connectio...

2018-09-18 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/3005#discussion_r218386884 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProvider.java --- @@ -0,0 +1,165

[GitHub] nifi issue #3008: NIFI-5492_EXEC Adding UDF to EL

2018-09-16 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/3008 @joewitt , @alopresto , @mattyb149 Since we had discussions on this topic before, I would like to get your opinion. I've addressed all the issues related to security (separate class loader

[GitHub] nifi pull request #3008: NIFI-5492_EXEC Adding UDF to EL

2018-09-16 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/3008 NIFI-5492_EXEC Adding UDF to EL **this PR adds new functinoality to expression language - user defined funtions.** Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2639 @bbende , thank you for your comments! I've made the changes to address all your concerns. Please review once you have a time. ---

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2639#discussion_r195907971 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java --- @@ -0,0 +1,803

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2639#discussion_r195906907 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java --- @@ -0,0 +1,803

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2639#discussion_r195906819 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java --- @@ -0,0 +1,803

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2639#discussion_r195906462 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java --- @@ -0,0 +1,803

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-06-16 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2639#discussion_r195905944 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java --- @@ -0,0 +1,803

[GitHub] nifi issue #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-28 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2711 @joetrite , no more comments from my side, thanks for addressing code review comments! @MikeThomsen , LGTM. Could you please give a second look on it now? I believe it's ready

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-25 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190992414 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi issue #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-24 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2711 @joetrite , @MikeThomsen , So, I tested the processor. It works OK. But I've got a question. In JSON it's easy - json structure will include both attribute name and attribute value. in CSV

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-24 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190750155 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2695: NIFI-5044 SelectHiveQL accept only one statement

2018-05-24 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2695#discussion_r190653106 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestSelectHiveQL.java --- @@ -198,6 +200,51

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190298869 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190301498 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190301930 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190305079 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190297210 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190296854 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190303622 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190300030 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190297408 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190296970 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java --- @@ -0,0

[GitHub] nifi issue #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2711 @joetrite , while AttributesToJSON has regex support for attributes, new AttributesToCSV doesn't have it - is there a reason for not keeping consistency? ---

[GitHub] nifi issue #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2711 @joetrite , I would like to mention it under the current PR - there was a discussion about having ["record-aware" output](https://github.com/apache/nifi/pull/1589#issuecomment

[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2734#discussion_r190286397 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2734#discussion_r190283975 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-05-18 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r189422180 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro

[GitHub] nifi pull request #2695: NIFI-5044 SelectHiveQL accept only one statement

2018-05-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2695#discussion_r189075604 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -311,7 +340,15

[GitHub] nifi pull request #2695: NIFI-5044 SelectHiveQL accept only one statement

2018-05-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2695#discussion_r189008316 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -113,6 +126,17

[GitHub] nifi pull request #2695: NIFI-5044 SelectHiveQL accept only one statement

2018-05-17 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2695#discussion_r189005203 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -113,6 +126,17

[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-05-15 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2679 +1. No more comments from my side. ---

[GitHub] nifi issue #2701: NIFI-5194: Ensure that even if calling KafkaConsumer.resum...

2018-05-14 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2701 +1 LGTM. For committers: Related to Kafka 0.9 only. Other implementations (0.10,0.11 and 1.0) don't use consumer's "resume" API explicitly. ---

[GitHub] nifi pull request #2695: NIFI-5044 SelectHiveQL accept only one statement

2018-05-12 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2695 NIFI-5044 SelectHiveQL accept only one statement SelectHiveQL support only single SELECT statement. This change adds support for pre- and post- select statements. It will be useful

[GitHub] nifi pull request #2679: NIFI-5141: Updated regex for doubles to allow for n...

2018-05-07 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2679#discussion_r186609421 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java --- @@ -60,19 +60,19 @@ private

[GitHub] nifi pull request #2639: NIFI-4906 Add GetHDFSFileInfo

2018-04-17 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2639 NIFI-4906 Add GetHDFSFileInfo NIFI-4906: Added support to scan HDFS to get files and directories information without pulling the files. --- Thank you for submitting a contribution

[GitHub] nifi pull request #2584: NIFI-4388: Modules Not Honored

2018-03-26 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2584 NIFI-4388: Modules Not Honored Modules aren't honored. The bug is not reproducible in Jython (it handles modules with every script reload). But Groovy loads JARs and dirs with classes only on setup

[GitHub] nifi issue #2537: fix printing indefinite log errors

2018-03-12 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2537 @mattyb149 , can you please review the changes? ---

[GitHub] nifi pull request #2537: fix printing indefinite log errors

2018-03-12 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2537 fix printing indefinite log errors Added fix to avoid printing indefinite errors to logs in customValidate after first failed validation until any property is modified. - Thank you

[GitHub] nifi issue #2527: FetchHBaseRow - log level and displayName

2018-03-11 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2527 @pvillard31 , @bbende In case we want to have bulletin to be generated, we can change "Bulletin Level" of the component to "DEBUG". But then bulletin will be generated even i

[GitHub] nifi issue #2527: FetchHBaseRow - log level and displayName

2018-03-09 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2527 oh, I see now. so it was about my first commit, when I added "displayName" and changed the "name" as per standard. But after Pierre's comment removed those fixes. Thanks for taking a look anyway! ---

[GitHub] nifi issue #2527: FetchHBaseRow - log level and displayName

2018-03-09 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2527 @MikeThomsen , I think since it is already in 1.5 and ppl started using it, it could be a case, when implementation can use rest APIs to work with these processors. And since we are changing "

[GitHub] nifi pull request #2527: FetchHBaseRow - log level and displayName

2018-03-09 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2527 FetchHBaseRow - log level and displayName update log level for "not found" to DEBUG instead of ERROR, and added displayName to all property descriptors. - Thank you for

[GitHub] nifi issue #2478: NIFI-4833 Add scanHBase Processor

2018-03-07 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2478 @bbende , Bryan, committed the changes. Tested on a cluster, works as expected. When have a time, please review. ---

[GitHub] nifi issue #2478: NIFI-4833 Add scanHBase Processor

2018-03-05 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2478 @bbende , thank you! Both comments make sense. Will commit these changes soon. ---

[GitHub] nifi issue #2478: NIFI-4833 Add scanHBase Processor

2018-02-26 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2478 @bbende , I addressed all the comments. Thank you and let me know if you see more issues or have some recommendations/suggestions. ---

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-26 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r170700319 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-26 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r170697126 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-21 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r169749383 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,562

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-21 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r169732184 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,562

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-21 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r169680760 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/TestScanHBase.java --- @@ -0,0 +1,375

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-21 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r169677516 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/TestScanHBase.java --- @@ -0,0 +1,375

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-19 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2478#discussion_r169176478 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,562

[GitHub] nifi issue #2478: NIFI-4833 Add scanHBase Processor

2018-02-17 Thread bdesert
Github user bdesert commented on the issue: https://github.com/apache/nifi/pull/2478 @MikeThomsen , are you available to re-review this PR? I have addressed you comment regarding branch and the rest (except for labels, which can be added later in bulk for all the HBase related

[GitHub] nifi pull request #2478: NIFI-4833 Add scanHBase Processor

2018-02-17 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2478 NIFI-4833 Add scanHBase Processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-17 Thread bdesert
Github user bdesert closed the pull request at: https://github.com/apache/nifi/pull/2446 ---

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165449601 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165449486 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165448494 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread bdesert
Github user bdesert commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165447440 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-01-31 Thread bdesert
GitHub user bdesert opened a pull request: https://github.com/apache/nifi/pull/2446 NIFI-4833 Add ScanHBase processor ### Description: Add new processor ScanHBase and a test package. -- Thank you