[GitHub] nifi-registry issue #149: NIFIREG-215 Extension Bundle Improvements

2018-12-13 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/149 Thanks, @bbende! +1, merged to master. ---

[GitHub] nifi-registry pull request #149: NIFIREG-215 Extension Bundle Improvements

2018-12-12 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241217517 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java --- @@ -41,6 +41,8

[GitHub] nifi-registry pull request #149: NIFIREG-215 Extension Bundle Improvements

2018-12-12 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241172387 --- Diff: nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionResource.java --- @@ -93,15 +94,25

[GitHub] nifi-registry pull request #149: NIFIREG-215 Extension Bundle Improvements

2018-12-12 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241166717 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java --- @@ -41,6 +41,8

[GitHub] nifi-registry issue #149: NIFIREG-215 Extension Bundle Improvements

2018-12-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/149 Reviewing... ---

[GitHub] nifi-registry issue #151: Bugfix overriding db props via environment variabl...

2018-12-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/151 Thanks for the contribution @jgondron. Will review this when I get a chance! ---

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-29 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r237568373 --- Diff: nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/extension/StandardExtensionService.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236810679 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/repo/ExtensionRepoVersion.java --- @@ -0,0

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236808042 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236827312 --- Diff: nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionRepositoryResource.java --- @@ -0,0

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236826377 --- Diff: nifi-registry-core/nifi-registry-framework/src/main/resources/db/migration/V3__AddExtensions.sql --- @@ -0,0 +1,62 @@ +-- Licensed

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236837704 --- Diff: nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/extension/StandardExtensionService.java

[GitHub] nifi-minifi-cpp issue #438: MINIFICPP-675: Fix issue with hearder evaluation...

2018-11-14 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/438 Thanks a lot for the quick turn around on this @phrocker! ---

[GitHub] nifi issue #3129: NIFI-5748 Fixed proxy header support to use X-Forwarded-Ho...

2018-11-12 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3129 Thanks, @jtstorck! Will review... ---

[GitHub] nifi-registry issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersisten...

2018-10-30 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/144 This is a fun new feature @bbende. It will be nice for DR or as a mechanism to populate NiFi Registry instances in new environments with some canned flows. I looked at the code and tried

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 +1 thanks! Merged to master... ---

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-03 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 Thansk @pepov. I had one minor comment regarding logging, but aside from that these changes look good to me ---

[GitHub] nifi pull request #3043: NIFI-5656 Remove "Node Group" from the default File...

2018-10-03 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/3043#discussion_r222308394 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java

[GitHub] nifi issue #3043: NIFI-5656 Remove "Node Group" from the default FileAccessP...

2018-10-02 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/3043 Thanks @pepov! I'll re-review the PR when your changes are in. ---

[GitHub] nifi-registry issue #143: NIFIREG-201 Refactoring project structure to bette...

2018-09-21 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/143 Will review... ---

[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/142 Good catch @alopresto. I was simply trying to pin a single version of Guava as we were using 18.0 but 17.0 was being pulled in transitively. But I don't see any reason not to pin version

[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/142 @bbende if you could review this when you get a chance that would be appreciated ---

[GitHub] nifi-registry pull request #142: NIFIREG-200 Update dependencies

2018-09-20 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/142 NIFIREG-200 Update dependencies - Update Jetty to version 9.4.11.v20180605 - Update Spring Boot to version 2.0.4.RELEASE - Update Spring Security to version 5.0.7.RELEASE

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

2018-09-20 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/131#discussion_r219256607 --- Diff: nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/README.md --- @@ -0,0 +1,131 @@ + +# NiFi Registry

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

2018-09-18 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/131#discussion_r218507868 --- Diff: nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/README.md --- @@ -0,0 +1,131 @@ + +# NiFi Registry

[GitHub] nifi-registry issue #140: NIFIREG-199 - Adding interfaces to represent confi...

2018-09-18 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/140 Reviewing... ---

[GitHub] nifi pull request #2983: NIFI-5566 Improve HashContent processor and standar...

2018-09-17 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2983#discussion_r218085671 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/security/util/crypto/HashServiceTest.groovy

[GitHub] nifi-registry pull request #139: NIFIREG-198 Fix VersionedRemoteProcessGroup...

2018-09-07 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/139 NIFIREG-198 Fix VersionedRemoteProcessGroup targetUri bug VersionedRemoteProcessGroup has two fields: targetUri and targetUris. They do not have simple getters, but rather each

[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...

2018-08-29 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2970 Yes, that should work fine to lookup group by name. Good point regarding the field name of the Group object. Thanks for looking into this! ---

[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...

2018-08-29 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2970 Ok, thanks @pepov -- that clears up the intention of these changes to me. For naming of variables/properties I'm good with either _identity_ or _name_, as you suggest - both are clear to me

[GitHub] nifi pull request #2970: NIFI-5542 Added support for node groups to FileAcce...

2018-08-28 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2970#discussion_r213438246 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java

[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event

2018-08-21 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/134 +1, looks good and verified event is triggered when expected. Thanks for the contribution @jdye64! ---

[GitHub] nifi-registry issue #135: [NIFIREG-193] upgrade superagent

2018-08-20 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/135 @scottyaslan corrected with an [empty commit](https://github.com/apache/nifi-registry/commit/ead0ea6e66f7bba21c65769bacc387beaf1a185a). ---

[GitHub] nifi-registry issue #134: NIFIREG-192: Implement REGISTRY_START event

2018-08-20 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/134 @jdye64 Thanks for that change. Now that #133 is merged, could you updated the documentation to add your new `REGISTRY_START` event type to the _Whitelisted Event Type x_ property value

[GitHub] nifi-registry issue #131: NIFIREG-186: Adding Ranger authorizer

2018-08-20 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/131 @ijokarumawak Thanks for the update. I'll review the most recent commits sometime over the next few days and test with those additional configurations. I'll watch the Ranger PR

[GitHub] nifi-registry issue #131: NIFIREG-186: Adding Ranger authorizer

2018-08-11 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/131 > The improvement at Ranger side is under review, but not merged yet. I think we can wait until Ranger side gets merged. In the mean while, let's confirm it works with Kerberos and HDF au

[GitHub] nifi-registry issue #133: NIFIREG-190

2018-08-10 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/133 A couple of other things I thought of: - The default [providers.xml](https://github.com/apache/nifi-registry/blob/7e4e9713406f3bb3ac1544b6ad69fbdd437f794c/nifi-registry-resources/src

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r209136065 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractEventHookProvider.java --- @@ -0,0 +1,72

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r209032885 --- Diff: nifi-registry-provider-api/src/main/java/org/apache/nifi/registry/hook/EventHookProvider.java --- @@ -36,4 +36,18

[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/134#discussion_r208977230 --- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/NiFiRegistryResourceConfig.java --- @@ -44,6 +48,14

[GitHub] nifi-registry pull request #134: NIFIREG-192: Implement REGISTRY_START event

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/134#discussion_r208965183 --- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/NiFiRegistryApiApplication.java --- @@ -54,6 +63,15 @@ protected

[GitHub] nifi-registry issue #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/133 Thanks @jdye64! That sounds good, I'll give it another look when those changes are ready. ---

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r208955763 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractHookProvider.java --- @@ -0,0 +1,70

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r208955444 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/LoggingEventHookProvider.java --- @@ -36,6 +36,10 @@ public

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r208955153 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractHookProvider.java --- @@ -0,0 +1,70

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r208954806 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractHookProvider.java --- @@ -0,0 +1,70

[GitHub] nifi-registry pull request #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/133#discussion_r208953844 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1094,3 +1094,63 @@ Here is the data model version histories: |2

[GitHub] nifi-registry issue #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/133 If we are allowing each implementation to decide the logic in the handle method, I don't see the value in the "share property" concept as documented: > There are certa

[GitHub] nifi-registry issue #133: NIFIREG-190

2018-08-09 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/133 Will review... ---

[GitHub] nifi-registry issue #131: NIFIREG-186: Adding Ranger authorizer

2018-08-01 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/131 Thanks @ijokarumawak! I'll finish up my review based on your latest changes & comments. ---

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

2018-07-23 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/131#discussion_r204467213 --- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ConfigResource.java --- @@ -0,0 +1,106 @@ +/* + * Licensed

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

2018-07-23 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/131#discussion_r204468072 --- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ConfigResource.java --- @@ -0,0 +1,106 @@ +/* + * Licensed

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

2018-07-23 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/131#discussion_r204477299 --- Diff: nifi-registry-ranger/src/test/resources/ranger/ranger-nifi-registry-security.xml --- @@ -0,0 +1,84

[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...

2018-06-25 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/130#discussion_r197978101 --- Diff: minifi-docker/dockerhub/Dockerfile --- @@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME RUN apk --no-cache add curl +ADD sh

[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...

2018-06-25 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/130#discussion_r197976141 --- Diff: minifi-docker/dockerhub/Dockerfile --- @@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME RUN apk --no-cache add curl +ADD sh

[GitHub] nifi-minifi pull request #130: MINIFI-441 Update Docker configuration and do...

2018-06-25 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/130#discussion_r197971051 --- Diff: minifi-docker/dockerhub/Dockerfile --- @@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME RUN apk --no-cache add curl +ADD sh

[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI

2018-06-13 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/119 @bbende I updated the copyright date range and also made a couple other updates to the README files while I was there. Let me know if you are good with these changes. Thanks! ---

[GitHub] nifi-registry issue #124: NIFIREG-174 Fixing start-up to look for the system...

2018-06-13 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/124 reviewing... ---

[GitHub] nifi-registry issue #119: NIFIREG-172 Adds Swagger UI

2018-06-13 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/119 Good eye, will update. And thanks for the review! ---

[GitHub] nifi-registry issue #122: NIFIREG-173 Improving logic for detecting existenc...

2018-06-06 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/122 Reviewing... ---

[GitHub] nifi-registry pull request #121: NIFIREG-173 Refactor metadata DB to be inde...

2018-06-04 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/121#discussion_r192790706 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -867,12 +867,32 @@ content of the flows saved to the registry

[GitHub] nifi-registry pull request #121: NIFIREG-173 Refactor metadata DB to be inde...

2018-06-04 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/121#discussion_r192790400 --- Diff: nifi-registry-framework/src/main/resources/db/migration/V2__Initial.sql --- @@ -0,0 +1,58 @@ +-- Licensed to the Apache Software

[GitHub] nifi-registry pull request #121: NIFIREG-173 Refactor metadata DB to be inde...

2018-06-04 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/121#discussion_r192781546 --- Diff: nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/CustomFlywayMigrationStrategy.java --- @@ -0,0 +1,147

[GitHub] nifi-minifi-cpp pull request #351: MINIFICPP-523 Fixes bootstrap continue wi...

2018-06-03 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/351 MINIFICPP-523 Fixes bootstrap continue with plan prompt Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[GitHub] nifi-registry issue #121: NIFIREG-173 Refactor metadata DB to be independent...

2018-06-01 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/121 Will review... ---

[GitHub] nifi-registry pull request #119: NIFIREG-172 Adds Swagger UI

2018-05-29 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/119 NIFIREG-172 Adds Swagger UI Contains the following changes: - Adds self-hosted Swagger UI to nifi-registry-web-api WAR at /swagger/ui.html - Updates NOTICE for included ALv2

[GitHub] nifi-registry issue #112: NIFIREG-162: Support Git backed PersistenceProvide...

2018-05-08 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/112 Nice work @ijokarumawak and everyone who contributed to this. This is a major feature to have as part of NiFi Registry and will certainly be useful. ---

[GitHub] nifi issue #2685: NIFI-5163 Clearing version control info when creating a te...

2018-05-07 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2685 Thanks for the quick jira & patch @bbende. Reviewing... ---

[GitHub] nifi pull request #2683: NIFI-5146 Only support HTTP or HTTPS operation for ...

2018-05-07 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2683#discussion_r186499568 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java

[GitHub] nifi-registry pull request #112: NIFIREG-162: Support Git backed Persistence...

2018-04-27 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/112#discussion_r184700563 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -895,3 +895,167 @@ Providing 2 total locations, including

[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Aside from the issue with the ./secure_hash.key file being created in an odd location, all other issues should be addressed now. If someone can verify (the more platforms we have coverage

[GitHub] nifi pull request #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2648#discussion_r182941468 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/pom.xml --- @@ -167,10 +167,12 @@ org.apache.rat apache-rat

[GitHub] nifi pull request #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2648#discussion_r182934721 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/pom.xml --- @@ -167,10 +167,12 @@ org.apache.rat apache-rat

[GitHub] nifi pull request #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi/pull/2648#discussion_r182931924 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/pom.xml --- @@ -167,10 +167,12 @@ org.apache.rat apache-rat

[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Ok, thanks. good to know. I'll make that change and also fix or disable those tests. Will update soon ---

[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Thanks for taking a look @joewitt. I'll try a build on Linux and try to reproduce that. I agree on placing the consoleOutput=true setting in the root pom. Does it also need to be included

[GitHub] nifi pull request #2648: NIFI-4942 Fix unit test salt assertion regex

2018-04-19 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi/pull/2648 NIFI-4942 Fix unit test salt assertion regex Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi-registry issue #89: NIFIREG-120 Basic Docker Image Support

2018-04-10 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/89 FYI to those following this PR. Thanks to @apiri an image built using these scripts has been published to DockerHub under the Apache group: https://hub.docker.com/r/apache/nifi-registry/tags/ ---

[GitHub] nifi-registry pull request #108: NIFIREG-158 Added ability to retrieve flow ...

2018-04-09 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/108#discussion_r180112539 --- Diff: nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/FlowResource.java --- @@ -62,4 +85,214 @@ public Response

[GitHub] nifi-registry issue #108: NIFIREG-158 Added ability to retrieve flow directl...

2018-04-06 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/108 @bbende alright will wait until it's ready. thanks for letting me know! ---

[GitHub] nifi-registry issue #108: NIFIREG-158 Added ability to retrieve flow directl...

2018-04-06 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/108 Will review... ---

[GitHub] nifi-minifi pull request #120: MINIFI-448 C2 server functionality and intern...

2018-04-02 Thread kevdoran
Github user kevdoran closed the pull request at: https://github.com/apache/nifi-minifi/pull/120 ---

[GitHub] nifi-minifi pull request #120: MINIFI-448 C2 server functionality and intern...

2018-03-28 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/120#discussion_r177852495 --- Diff: minifi-c2/minifi-c2-framework/src/test/groovy/org/apache/nifi/minifi/c2/core/service/StandardC2ProtocolServiceSpec.groovy --- @@ -0,0

[GitHub] nifi-minifi pull request #120: MINIFI-448 C2 server functionality and intern...

2018-03-28 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/120#discussion_r177827045 --- Diff: minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/core/service/StandardC2Service.java --- @@ -0,0 +1,494

[GitHub] nifi-minifi pull request #120: MINIFI-448 C2 server functionality and intern...

2018-03-28 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/120#discussion_r177824172 --- Diff: minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/api/provider/device/DevicePersistenceProvider.java --- @@ -0,0 +1,78

[GitHub] nifi-registry issue #107: NIFIREG-157 Adding boolean to VersionedPropertyDes...

2018-03-28 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/107 Looks good, will merge to master. Thanks for adding this @bbende ---

[GitHub] nifi-minifi pull request #120: MINIFI-448 C2 server functionality and intern...

2018-03-27 Thread kevdoran
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-minifi/pull/120 MINIFI-448 C2 server functionality and internal interfaces The C2 service layer is the part of the C2 framework that backs the REST API to provide the business logic. This commit

[GitHub] nifi-minifi pull request #119: MINIFI-447 - Adding FlowMapper and FlowRetrie...

2018-03-23 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/119#discussion_r176803697 --- Diff: minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/core/service/flow/client/NiFiRegistryClientFactory.java --- @@ -0,0

[GitHub] nifi-minifi pull request #119: MINIFI-447 - Adding FlowMapper and FlowRetrie...

2018-03-23 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/119#discussion_r176815905 --- Diff: minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/core/service/flow/mapping/FlowMapper.java --- @@ -0,0 +1,37

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-22 Thread kevdoran
Github user kevdoran closed the pull request at: https://github.com/apache/nifi-minifi/pull/118 ---

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176297389 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java --- @@ -0,0 +1,85

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176286360 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/FlowUri.java --- @@ -0,0 +1,54 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176281479 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/FlowUri.java --- @@ -0,0 +1,54 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176280748 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/FlowStatus.java --- @@ -0,0 +1,51 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176279968 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/BundleManifest.java --- @@ -0,0 +1,65

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176278810 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/C2Operation.java --- @@ -0,0 +1,99 @@ +/* + * Licensed

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-21 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r176278082 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/ExtensionComponent.java --- @@ -0,0 +1,85

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-20 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175938847 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/AgentRepositoryStatus.java --- @@ -0,0 +1,63

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-20 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175844957 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/BundleManifest.java --- @@ -0,0 +1,65

[GitHub] nifi-minifi pull request #118: MINIFI-444 C2 Data Model and REST API

2018-03-20 Thread kevdoran
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/118#discussion_r175843712 --- Diff: minifi-c2/minifi-c2-commons/src/main/java/org/apache/nifi/minifi/c2/model/extension/DefinedType.java --- @@ -0,0 +1,69

  1   2   3   4   >