[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378095180 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r377584537 ## File path: extensions/sql/data/MaxCollector.h ## @@ -0,0 +1,172 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378208898 ## File path: extensions/sql/data/WriteCallback.h ## @@ -0,0 +1,47 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378213435 ## File path: win_build_vs.bat ## @@ -77,4 +81,4 @@ goto :eof :usage @echo "Usage: %0 options" -exit /B 1 +exit /B 1

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378130935 ## File path: extensions/sql/services/ODBCConnector.h ## @@ -0,0 +1,127 @@ +/** + * + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378131050 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378203621 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378128633 ## File path: extensions/sql/SQLLoader.h ## @@ -0,0 +1,81 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378129066 ## File path: extensions/sql/data/JSONSQLWriter.h ## @@ -0,0 +1,65 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378128845 ## File path: extensions/sql/SQLLoader.h ## @@ -0,0 +1,81 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378128964 ## File path: extensions/sql/data/DatabaseConnectors.h ## @@ -0,0 +1,106 @@ +/** + * + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378128742 ## File path: extensions/sql/SQLLoader.h ## @@ -0,0 +1,81 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #733: MINIFICPP-1155 - Rocksdb repos print invalid stats

2020-02-12 Thread GitBox
arpadboda closed pull request #733: MINIFICPP-1155 - Rocksdb repos print invalid stats URL: https://github.com/apache/nifi-minifi-cpp/pull/733 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143395 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143506 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143151 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378146683 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378147512 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -553,6 +577,20 @@ void

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378133280 ## File path: win_build_vs.bat ## @@ -22,10 +22,12 @@ if [%1]==[] goto usage set builddir=%1 set skiptests=OFF set

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378188116 ## File path: extensions/sql/data/MaxCollector.h ## @@ -0,0 +1,172 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378188245 ## File path: extensions/sql/data/SQLRowsetProcessor.h ## @@ -0,0 +1,62 @@ +/** + * + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378203621 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378188342 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378188464 ## File path: extensions/sql/SQLLoader.h ## @@ -0,0 +1,81 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378188642 ## File path: extensions/sql/services/ODBCConnector.h ## @@ -0,0 +1,127 @@ +/** + * + * Licensed to the Apache Software

[jira] [Created] (MINIFICPP-1159) Fix unstable processor integration tests and clean up code duplication

2020-02-12 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1159: - Summary: Fix unstable processor integration tests and clean up code duplication Key: MINIFICPP-1159 URL: https://issues.apache.org/jira/browse/MINIFICPP-1159

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #736: MINIFICPP-1159 - Fix unstable processor integration tests and clean u…

2020-02-12 Thread GitBox
arpadboda opened a new pull request #736: MINIFICPP-1159 - Fix unstable processor integration tests and clean u… URL: https://github.com/apache/nifi-minifi-cpp/pull/736 …p code duplication Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to

[GitHub] [nifi-registry] bbende opened a new pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables

2020-02-12 Thread GitBox
bbende opened a new pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables URL: https://github.com/apache/nifi-registry/pull/258 - Remove framework authorizer - Introduce ProxyChainAuthorizable to wrap all Authorizables - Introduce

[jira] [Created] (MINIFICPP-1158) Event driven processors can starve each other

2020-02-12 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1158: - Summary: Event driven processors can starve each other Key: MINIFICPP-1158 URL: https://issues.apache.org/jira/browse/MINIFICPP-1158 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378223401 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378230298 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378226346 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -643,16 +704,7 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378222396 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378225328 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378230978 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -643,16 +704,7 @@

[jira] [Updated] (NIFI-7109) Unit tests should be able to determine if item validator was called

2020-02-12 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7109: --- Status: Patch Available (was: Open) > Unit tests should be able to determine if item validator was

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #735: MINIFICPP-1158 - Event driven processors can starve each other

2020-02-12 Thread GitBox
arpadboda opened a new pull request #735: MINIFICPP-1158 - Event driven processors can starve each other URL: https://github.com/apache/nifi-minifi-cpp/pull/735 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution

[jira] [Commented] (NIFI-7109) Unit tests should be able to determine if item validator was called

2020-02-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035494#comment-17035494 ] ASF subversion and git services commented on NIFI-7109: --- Commit

[GitHub] [nifi] asfgit closed pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa…

2020-02-12 Thread GitBox
asfgit closed pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa… URL: https://github.com/apache/nifi/pull/4043 This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi] mattyb149 commented on issue #4043: NIFI-7109 Unit tests should be able to determine if item validator wa…

2020-02-12 Thread GitBox
mattyb149 commented on issue #4043: NIFI-7109 Unit tests should be able to determine if item validator wa… URL: https://github.com/apache/nifi/pull/4043#issuecomment-585289520 +1 LGTM (Travis failures are unrelated), ran contrib-check, everything looks good. Thanks for the improvement!

[jira] [Updated] (NIFI-7109) Unit tests should be able to determine if item validator was called

2020-02-12 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7109: --- Fix Version/s: 1.12.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [nifi-registry] bbende commented on a change in pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables

2020-02-12 Thread GitBox
bbende commented on a change in pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables URL: https://github.com/apache/nifi-registry/pull/258#discussion_r378295031 ## File path:

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
phrocker commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585261190 @msharee9 taking a look, thanks. This is an automated

[GitHub] [nifi-minifi-cpp] phrocker edited a comment on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
phrocker edited a comment on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585281331 @msharee9 Could you have a different endpoint that is used for a full posting and then another endpoint for a

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
phrocker commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585281331 @msharee9 Why not have a different endpoint that is used for a full posting and then another endpoint for a lightweight HB.

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378458847 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378443443 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -553,6 +577,20 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585369988 > @msharee9 Could you have a different endpoint that is used for a full posting and then another endpoint for a lightweight

[GitHub] [nifi-minifi-cpp] msharee9 commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585365334 > This seems to be a bit complicated and introduce some code duplication. > > Why can't we simply extend

[GitHub] [nifi-minifi-cpp] msharee9 edited a comment on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 edited a comment on issue #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#issuecomment-585369988 > @msharee9 Could you have a different endpoint that is used for a full posting and then another endpoint for a

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378462016 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378462225 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378441353 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70

[GitHub] [nifi] mattyb149 commented on issue #4026: NIFI-7087: Use FlowManager.findAllConnections() when available

2020-02-12 Thread GitBox
mattyb149 commented on issue #4026: NIFI-7087: Use FlowManager.findAllConnections() when available URL: https://github.com/apache/nifi/pull/4026#issuecomment-585427244 Sorry for the force-push override of the commit, but with the merge conflict it was just easier. All changes should be

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378529132 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -643,16 +704,7

[jira] [Updated] (NIFI-7139) Add Error Message To Flow File Attribute for Record Processors

2020-02-12 Thread Shawn Weeks (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Weeks updated NIFI-7139: -- Description: Add an attribute to flow files that fail during record processing containing the error

[jira] [Commented] (NIFI-7123) onPropertyModified() is called on nifi start up even when properties have never been modified

2020-02-12 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035736#comment-17035736 ] Nissim Shiman commented on NIFI-7123: - More details as to where this is biting us: Currently on

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378537631 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi] markap14 commented on a change in pull request #4026: NIFI-7087: Use FlowManager.findAllConnections() when available

2020-02-12 Thread GitBox
markap14 commented on a change in pull request #4026: NIFI-7087: Use FlowManager.findAllConnections() when available URL: https://github.com/apache/nifi/pull/4026#discussion_r378495549 ## File path:

[GitHub] [nifi] markap14 commented on a change in pull request #4026: NIFI-7087: Use FlowManager.findAllConnections() when available

2020-02-12 Thread GitBox
markap14 commented on a change in pull request #4026: NIFI-7087: Use FlowManager.findAllConnections() when available URL: https://github.com/apache/nifi/pull/4026#discussion_r378495890 ## File path:

[jira] [Created] (NIFI-7139) Add Error Message To Flow File Attribute for Record Processors

2020-02-12 Thread Shawn Weeks (Jira)
Shawn Weeks created NIFI-7139: - Summary: Add Error Message To Flow File Attribute for Record Processors Key: NIFI-7139 URL: https://issues.apache.org/jira/browse/NIFI-7139 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378537631 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378603638 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378603638 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #732: MINIFICPP-1013

2020-02-12 Thread GitBox
am-c-p-p commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378603638 ## File path: extensions/sql/processors/QueryDatabaseTable.cpp ## @@ -0,0 +1,475 @@ +/** + * @file QueryDatabaseTable.cpp + *

[jira] [Created] (NIFI-7140) PutSql support database transaction rollback

2020-02-12 Thread ZhangCheng (Jira)
ZhangCheng created NIFI-7140: Summary: PutSql support database transaction rollback Key: NIFI-7140 URL: https://issues.apache.org/jira/browse/NIFI-7140 Project: Apache NiFi Issue Type:

[jira] [Updated] (NIFI-7140) PutSql support database transaction rollback when is false

2020-02-12 Thread ZhangCheng (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangCheng updated NIFI-7140: - Description: For PutSQL processor,if the 'Support Fragmented Transactions' is true, the processor will

[jira] [Updated] (NIFI-7140) PutSql support database transaction rollback when is false

2020-02-12 Thread ZhangCheng (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangCheng updated NIFI-7140: - Description: For PutSQL processor,if the 'Support Fragmented Transactions' is true, the processor will

[jira] [Updated] (NIFI-7140) PutSql support database transaction rollback

2020-02-12 Thread ZhangCheng (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangCheng updated NIFI-7140: - Description: For PutSQL processor,if the 'Support Fragmented Transactions' is true, the processor will