[GitHub] [nifi] adarmiento commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language
adarmiento commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#issuecomment-522878697 I think there's not much to do here since this component already has the Lang dependency, I just used the "original" methods, without having to reimplement or borrow them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315527725
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
Thanks to you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ijokarumawak commented on issue #3621: NIFI-6509 - Date related issue in unit test VolatileComponentStatusRe…
ijokarumawak commented on issue #3621: NIFI-6509 - Date related issue in unit test VolatileComponentStatusRe… URL: https://github.com/apache/nifi/pull/3621#issuecomment-522834404 Hi @tpalfy, thanks for sending the PR! Another JIRA NIFI-6508 and its patch were submitted before this PR, so I merged NIFI-6508 to address the timezone issue at the test. Please take a look at this commit https://github.com/apache/nifi/commit/00f0f84856226ac39c92807c01945bb017e99bb4 I noticed your PR addresses the issue as well as does some refactoring to improve code readability. I like more self-descriptive variable naming like you did in the PR. Now the PR has conflict, if you can address conflict, I'm happy to keep reviewing so that your change can also be merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6508) Test failures caused by timezone differences
[
https://issues.apache.org/jira/browse/NIFI-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura resolved NIFI-6508.
-
Fix Version/s: 1.10.0
Resolution: Fixed
Thank you [~malthe] for fixing the test! The change looks good, +1. Merged to
master. Also, I've added NiFi Jira 'Contributor' role to your account. You can
assign yourself to any NiFi Jira now.
> Test failures caused by timezone differences
>
>
> Key: NIFI-6508
> URL: https://issues.apache.org/jira/browse/NIFI-6508
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
>Reporter: Malthe Borch
>Assignee: Malthe Borch
>Priority: Minor
> Fix For: 1.10.0
>
> Attachments:
> 0001-NIFI-6508-Fix-test-failure-caused-by-timezone-and-or.patch
>
>
> Some tests in {{VolatileComponentStatusRepositoryTest}} fail due to incorrect
> timezone conversion, for example {{testFilterDatesUsingStartFilter}}:
> {{java.lang.AssertionError: expected: but
> was: at
> org.apache.nifi.controller.status.history.VolatileComponentStatusRepositoryTest.testFilterDatesUsingStartFilter(VolatileComponentStatusRepositoryTest.java:132)}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (NIFI-6508) Test failures caused by timezone differences
[
https://issues.apache.org/jira/browse/NIFI-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura reassigned NIFI-6508:
---
Assignee: Malthe Borch
> Test failures caused by timezone differences
>
>
> Key: NIFI-6508
> URL: https://issues.apache.org/jira/browse/NIFI-6508
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
>Reporter: Malthe Borch
>Assignee: Malthe Borch
>Priority: Minor
> Attachments:
> 0001-NIFI-6508-Fix-test-failure-caused-by-timezone-and-or.patch
>
>
> Some tests in {{VolatileComponentStatusRepositoryTest}} fail due to incorrect
> timezone conversion, for example {{testFilterDatesUsingStartFilter}}:
> {{java.lang.AssertionError: expected: but
> was: at
> org.apache.nifi.controller.status.history.VolatileComponentStatusRepositoryTest.testFilterDatesUsingStartFilter(VolatileComponentStatusRepositoryTest.java:132)}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (NIFI-6508) Test failures caused by timezone differences
[
https://issues.apache.org/jira/browse/NIFI-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910951#comment-16910951
]
ASF subversion and git services commented on NIFI-6508:
---
Commit 00f0f84856226ac39c92807c01945bb017e99bb4 in nifi's branch
refs/heads/master from Malthe Borch
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=00f0f84 ]
NIFI-6508 - Fix test failure caused by timezone and/or DST difference
Signed-off-by: Koji Kawamura
> Test failures caused by timezone differences
>
>
> Key: NIFI-6508
> URL: https://issues.apache.org/jira/browse/NIFI-6508
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
>Reporter: Malthe Borch
>Priority: Minor
> Attachments:
> 0001-NIFI-6508-Fix-test-failure-caused-by-timezone-and-or.patch
>
>
> Some tests in {{VolatileComponentStatusRepositoryTest}} fail due to incorrect
> timezone conversion, for example {{testFilterDatesUsingStartFilter}}:
> {{java.lang.AssertionError: expected: but
> was: at
> org.apache.nifi.controller.status.history.VolatileComponentStatusRepositoryTest.testFilterDatesUsingStartFilter(VolatileComponentStatusRepositoryTest.java:132)}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (NIFI-6477) The 'operate the component' policy is not removed when component is removed
[ https://issues.apache.org/jira/browse/NIFI-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura updated NIFI-6477: Fix Version/s: 1.10.0 Resolution: Fixed Status: Resolved (was: Patch Available) > The 'operate the component' policy is not removed when component is removed > --- > > Key: NIFI-6477 > URL: https://issues.apache.org/jira/browse/NIFI-6477 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Mark Bean >Assignee: Koji Kawamura >Priority: Major > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The 'operate the component' access policy is not properly cleaned up when its > corresponding component is removed. Specifically, the policy still remains in > authorizations.xml. > This makes it impossible to view the user's set of policies. In the UI, when > selecting the key icon for the user (in the full users list), the policy > window does not appear - presumably due to some exception that gets > swallowed. Nothing reported in the logs either. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (NIFI-6477) The 'operate the component' policy is not removed when component is removed
[ https://issues.apache.org/jira/browse/NIFI-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910914#comment-16910914 ] ASF subversion and git services commented on NIFI-6477: --- Commit 1cb1b00c090afc85e5c4024a0339d5b508c231f8 in nifi's branch refs/heads/master from Koji Kawamura [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1cb1b00 ] NIFI-6477 Delete operate policy when its component is deleted +1 from markobean. This closes #3653. Signed-off-by: Koji Kawamura > The 'operate the component' policy is not removed when component is removed > --- > > Key: NIFI-6477 > URL: https://issues.apache.org/jira/browse/NIFI-6477 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Mark Bean >Assignee: Koji Kawamura >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The 'operate the component' access policy is not properly cleaned up when its > corresponding component is removed. Specifically, the policy still remains in > authorizations.xml. > This makes it impossible to view the user's set of policies. In the UI, when > selecting the key icon for the user (in the full users list), the policy > window does not appear - presumably due to some exception that gets > swallowed. Nothing reported in the logs either. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] asfgit closed pull request #3653: NIFI-6477 Delete operate policy when its component is deleted
asfgit closed pull request #3653: NIFI-6477 Delete operate policy when its component is deleted URL: https://github.com/apache/nifi/pull/3653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] ijokarumawak commented on issue #3653: NIFI-6477 Delete operate policy when its component is deleted
ijokarumawak commented on issue #3653: NIFI-6477 Delete operate policy when its component is deleted URL: https://github.com/apache/nifi/pull/3653#issuecomment-522820364 @markobean Thanks for reviewing! Backed by your +1, I'm going to merge this to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6502) Add padLeft() and padRight() functions to RecordPath
[
https://issues.apache.org/jira/browse/NIFI-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-6502.
Fix Version/s: 1.10.0
Resolution: Fixed
> Add padLeft() and padRight() functions to RecordPath
> -
>
> Key: NIFI-6502
> URL: https://issues.apache.org/jira/browse/NIFI-6502
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
> Fix For: 1.10.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Record path
> functions|https://nifi.apache.org/docs/nifi-docs/html/record-path-guide.html#functions]
> don't provide anything to perform string padding
> h1. Improvement Proposal
> - Support two new recordPath functions
> -- padLeft:
> --- padLeft(string field, int desiredLength) will prepend a default character
> to the input string until it reaches the length desiredLength
> --- padLeft(String field, int desiredLength, char c) will prepend the c
> characters to the input string until it reaches the length n
> -- padRight:
> --- padRight(string field, int desiredLength) will append a default character
> to the input string until it reaches the length desiredLength
> --- padRight(String field, int desiredLength, char c) will append the c
> characters to the input string until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> {
> "name" : "john smith"
> }
>
> `padLeft(/name, 15, '@')` => @john smith
> `padLeft(/name, 15)` => _john smith
> `padRight(/name, 15, '@')` => john smith@
> `padRight(/name, 15)`=> john smith_
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (NIFI-6572) Groovy Date.minus blocks GetMongoRecordIT from initializing
[ https://issues.apache.org/jira/browse/NIFI-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910889#comment-16910889 ] ASF subversion and git services commented on NIFI-6572: --- Commit e822a1612b9121106a2644931e0717ddf8804bfe in nifi's branch refs/heads/master from Mike Thomsen [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e822a16 ] NIFI-6572 Added a workaround for GetMongoRecordIT that fixes a weird issue with Groovy where the Groovy addons don't appear to be getting recognized for java.util.Date. > Groovy Date.minus blocks GetMongoRecordIT from initializing > --- > > Key: NIFI-6572 > URL: https://issues.apache.org/jira/browse/NIFI-6572 > Project: Apache NiFi > Issue Type: Bug >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > > There appears to be a bug with Groovy or the Groovy compiler plugin that is > preventing this from working, throwing an error saying there is no method > minus for Date which takes an integer argument (there is in the Groovy docs): > Calendar.instance.time - 1 > > This is a quick patch to fix GetMongoRecordIT so that it can run again while > we figure out what is going on. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (NIFI-6572) Groovy Date.minus blocks GetMongoRecordIT from initializing
Mike Thomsen created NIFI-6572: -- Summary: Groovy Date.minus blocks GetMongoRecordIT from initializing Key: NIFI-6572 URL: https://issues.apache.org/jira/browse/NIFI-6572 Project: Apache NiFi Issue Type: Bug Reporter: Mike Thomsen Assignee: Mike Thomsen There appears to be a bug with Groovy or the Groovy compiler plugin that is preventing this from working, throwing an error saying there is no method minus for Date which takes an integer argument (there is in the Groovy docs): Calendar.instance.time - 1 This is a quick patch to fix GetMongoRecordIT so that it can run again while we figure out what is going on. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] MikeThomsen commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language
MikeThomsen commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#issuecomment-522773524 Merged your previous contribution, so you're good to go on rebasing off of those changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6502) Add padLeft() and padRight() functions to RecordPath
[
https://issues.apache.org/jira/browse/NIFI-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910788#comment-16910788
]
ASF subversion and git services commented on NIFI-6502:
---
Commit 81136bf5502458521eb4841be7e45b3f6223241b in nifi's branch
refs/heads/master from Alessandro D'Armiento
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81136bf ]
NIFI-6502 RecordPath padding functions:
- PadLeft(label, desiredLength, paddingChar) prepends the paddingChar (or the
default value '_' if a paddingChar is not provided) to the label string until
desiredLength is reached.
- PadRight(label, desiredLength, paddingChar) appends the paddingChar (or the
default value '_' if a paddingChar is not provided) to the label string until
desiredLength is reached.
Added Apache license disclaimers
checkstyle fixes
Replaced functional interface with abstract method
Fixes and Further test cases:
- Returns null if the input string is null
- Returns a string full of padding if the input string is empty
wip support padding string
In order to be consistent with the feature introduced in #3615, RecordPath
padLeft and padRight supports String padding.
Since nifi-record-path doesn't have the Apache Commons StringUtils dependency,
the padding methods have been added to the available NiFi commons StringUtils
class.
NIFI-6502 Updated top level NOTICE file to include citation for code borrowed
from commons-lang3.
borrowed pad methods from lang3 StringUtils
Replaced `PadLeft` and `PadRight` record path functions with borrowed Apache
Lang `StringUtils` padding methods and updated `nifi-assembly/NOTICE`
accordingly
This closes #3613
Signed-off-by: Mike Thomsen
> Add padLeft() and padRight() functions to RecordPath
> -
>
> Key: NIFI-6502
> URL: https://issues.apache.org/jira/browse/NIFI-6502
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Record path
> functions|https://nifi.apache.org/docs/nifi-docs/html/record-path-guide.html#functions]
> don't provide anything to perform string padding
> h1. Improvement Proposal
> - Support two new recordPath functions
> -- padLeft:
> --- padLeft(string field, int desiredLength) will prepend a default character
> to the input string until it reaches the length desiredLength
> --- padLeft(String field, int desiredLength, char c) will prepend the c
> characters to the input string until it reaches the length n
> -- padRight:
> --- padRight(string field, int desiredLength) will append a default character
> to the input string until it reaches the length desiredLength
> --- padRight(String field, int desiredLength, char c) will append the c
> characters to the input string until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> {
> "name" : "john smith"
> }
>
> `padLeft(/name, 15, '@')` => @john smith
> `padLeft(/name, 15)` => _john smith
> `padRight(/name, 15, '@')` => john smith@
> `padRight(/name, 15)`=> john smith_
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (NIFI-6502) Add padLeft() and padRight() functions to RecordPath
[
https://issues.apache.org/jira/browse/NIFI-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910789#comment-16910789
]
ASF subversion and git services commented on NIFI-6502:
---
Commit 81136bf5502458521eb4841be7e45b3f6223241b in nifi's branch
refs/heads/master from Alessandro D'Armiento
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81136bf ]
NIFI-6502 RecordPath padding functions:
- PadLeft(label, desiredLength, paddingChar) prepends the paddingChar (or the
default value '_' if a paddingChar is not provided) to the label string until
desiredLength is reached.
- PadRight(label, desiredLength, paddingChar) appends the paddingChar (or the
default value '_' if a paddingChar is not provided) to the label string until
desiredLength is reached.
Added Apache license disclaimers
checkstyle fixes
Replaced functional interface with abstract method
Fixes and Further test cases:
- Returns null if the input string is null
- Returns a string full of padding if the input string is empty
wip support padding string
In order to be consistent with the feature introduced in #3615, RecordPath
padLeft and padRight supports String padding.
Since nifi-record-path doesn't have the Apache Commons StringUtils dependency,
the padding methods have been added to the available NiFi commons StringUtils
class.
NIFI-6502 Updated top level NOTICE file to include citation for code borrowed
from commons-lang3.
borrowed pad methods from lang3 StringUtils
Replaced `PadLeft` and `PadRight` record path functions with borrowed Apache
Lang `StringUtils` padding methods and updated `nifi-assembly/NOTICE`
accordingly
This closes #3613
Signed-off-by: Mike Thomsen
> Add padLeft() and padRight() functions to RecordPath
> -
>
> Key: NIFI-6502
> URL: https://issues.apache.org/jira/browse/NIFI-6502
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Record path
> functions|https://nifi.apache.org/docs/nifi-docs/html/record-path-guide.html#functions]
> don't provide anything to perform string padding
> h1. Improvement Proposal
> - Support two new recordPath functions
> -- padLeft:
> --- padLeft(string field, int desiredLength) will prepend a default character
> to the input string until it reaches the length desiredLength
> --- padLeft(String field, int desiredLength, char c) will prepend the c
> characters to the input string until it reaches the length n
> -- padRight:
> --- padRight(string field, int desiredLength) will append a default character
> to the input string until it reaches the length desiredLength
> --- padRight(String field, int desiredLength, char c) will append the c
> characters to the input string until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> {
> "name" : "john smith"
> }
>
> `padLeft(/name, 15, '@')` => @john smith
> `padLeft(/name, 15)` => _john smith
> `padRight(/name, 15, '@')` => john smith@
> `padRight(/name, 15)`=> john smith_
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [nifi] asfgit closed pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
asfgit closed pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions URL: https://github.com/apache/nifi/pull/3613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language
MikeThomsen commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#issuecomment-522763917 When the other one gets merged, please rebase off of that so we reuse the same functionality you brought in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6571) TLS toolkit server mode - check token length at startup
[ https://issues.apache.org/jira/browse/NIFI-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-6571: - Status: Patch Available (was: Open) > TLS toolkit server mode - check token length at startup > --- > > Key: NIFI-6571 > URL: https://issues.apache.org/jira/browse/NIFI-6571 > Project: Apache NiFi > Issue Type: Sub-task > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > It is possible to start the TLS toolkit in server mode with a token length > below the required 16 bits. But when the client is performing the request, > it'll be denied with the message "Token does not meet minimum size of 16 > bytes". This task is about preventing the TLS toolkit to start in server mode > when the token is below 16 bytes. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (NIFI-6571) TLS toolkit server mode - check token length at startup
[ https://issues.apache.org/jira/browse/NIFI-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-6571: - Labels: tls tls-toolkit (was: ) > TLS toolkit server mode - check token length at startup > --- > > Key: NIFI-6571 > URL: https://issues.apache.org/jira/browse/NIFI-6571 > Project: Apache NiFi > Issue Type: Sub-task > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Labels: tls, tls-toolkit > Time Spent: 10m > Remaining Estimate: 0h > > It is possible to start the TLS toolkit in server mode with a token length > below the required 16 bits. But when the client is performing the request, > it'll be denied with the message "Token does not meet minimum size of 16 > bytes". This task is about preventing the TLS toolkit to start in server mode > when the token is below 16 bytes. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] pvillard31 opened a new pull request #3659: NIFI-6571 - TLS toolkit server mode - check token length at startup
pvillard31 opened a new pull request #3659: NIFI-6571 - TLS toolkit server mode
- check token length at startup
URL: https://github.com/apache/nifi/pull/3659
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
It is possible to start the TLS toolkit in server mode with a token length
below the required 16 bits. But when the client is performing the request,
it'll be denied with the message "Token does not meet minimum size of 16
bytes". This PR is about preventing the TLS toolkit to start in server mode
when the token is below 16 bytes.
In order to streamline the review of the contribution we ask you to ensure
the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] MikeThomsen commented on issue #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
MikeThomsen commented on issue #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions URL: https://github.com/apache/nifi/pull/3613#issuecomment-522761298 I have to run a full build locally before merging. Probably be about 35-45 minutes if it succeeds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315416196
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
I think we can leave them as-is. We have the top level attribution for the
code, so I'm going to merge. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (NIFI-5839) Identity mapping is not applied to LDAP group member DNs
[ https://issues.apache.org/jira/browse/NIFI-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910760#comment-16910760 ] Matt Gilman commented on NIFI-5839: --- PR #3657 addresses the underlying issue here by introducing a new property to configure the LdapUserGroupProvider to conditionally enforce case-sensitivity when making group membership decisions. > Identity mapping is not applied to LDAP group member DNs > > > Key: NIFI-5839 > URL: https://issues.apache.org/jira/browse/NIFI-5839 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Damian Morgan >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Attachments: 0001-Apply-identity-mappings-to-group-members.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The identity mappings specified in nifi.properties are not applied to user > identities returned from LDAP groups. This means that if the LDAP group > member DN does not (for example) have the same capitalisation as the user's > actual DN, then the user is not recognised as a member of that group. > The attached patch fixes the issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (NIFI-5839) Identity mapping is not applied to LDAP group member DNs
[ https://issues.apache.org/jira/browse/NIFI-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-5839. --- Fix Version/s: 1.10.0 Assignee: Matt Gilman Resolution: Fixed > Identity mapping is not applied to LDAP group member DNs > > > Key: NIFI-5839 > URL: https://issues.apache.org/jira/browse/NIFI-5839 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Damian Morgan >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Attachments: 0001-Apply-identity-mappings-to-group-members.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The identity mappings specified in nifi.properties are not applied to user > identities returned from LDAP groups. This means that if the LDAP group > member DN does not (for example) have the same capitalisation as the user's > actual DN, then the user is not recognised as a member of that group. > The attached patch fixes the issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (NIFI-5839) Identity mapping is not applied to LDAP group member DNs
[ https://issues.apache.org/jira/browse/NIFI-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910754#comment-16910754 ] ASF subversion and git services commented on NIFI-5839: --- Commit 326bc91405aefadc7a86f8d4bb0ad3be54024faa in nifi's branch refs/heads/master from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=326bc91 ] NIFI-5839: - Introducing case insensitive group membership. - Ensuring user identity and group name mapping is applied when the user identity or group name is inferred through group membership decisions. This closes #3657. Signed-off-by: Bryan Bende > Identity mapping is not applied to LDAP group member DNs > > > Key: NIFI-5839 > URL: https://issues.apache.org/jira/browse/NIFI-5839 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Damian Morgan >Priority: Major > Attachments: 0001-Apply-identity-mappings-to-group-members.patch > > Time Spent: 1h > Remaining Estimate: 0h > > The identity mappings specified in nifi.properties are not applied to user > identities returned from LDAP groups. This means that if the LDAP group > member DN does not (for example) have the same capitalisation as the user's > actual DN, then the user is not recognised as a member of that group. > The attached patch fixes the issue. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] asfgit closed pull request #3657: NIFI-5839: Support case insensitive membership decisions in LdapUserGroupProvider
asfgit closed pull request #3657: NIFI-5839: Support case insensitive membership decisions in LdapUserGroupProvider URL: https://github.com/apache/nifi/pull/3657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on issue #3657: NIFI-5839: Support case insensitive membership decisions in LdapUserGroupProvider
bbende commented on issue #3657: NIFI-5839: Support case insensitive membership decisions in LdapUserGroupProvider URL: https://github.com/apache/nifi/pull/3657#issuecomment-522752815 +1 Code looks good and tested the various scenarios using Apache Directory Studio's LDAP, going to merge, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6571) TLS toolkit server mode - check token length at startup
Pierre Villard created NIFI-6571: Summary: TLS toolkit server mode - check token length at startup Key: NIFI-6571 URL: https://issues.apache.org/jira/browse/NIFI-6571 Project: Apache NiFi Issue Type: Sub-task Components: Tools and Build Reporter: Pierre Villard Assignee: Pierre Villard It is possible to start the TLS toolkit in server mode with a token length below the required 16 bits. But when the client is performing the request, it'll be denied with the message "Token does not meet minimum size of 16 bytes". This task is about preventing the TLS toolkit to start in server mode when the token is below 16 bytes. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-registry] bbende commented on issue #220: NIFIREG-310: Support case insensitive membership decisions in LdapUserGroupProvider
bbende commented on issue #220: NIFIREG-310: Support case insensitive membership decisions in LdapUserGroupProvider URL: https://github.com/apache/nifi-registry/pull/220#issuecomment-522740826 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless init from flow xml
dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless
init from flow xml
URL: https://github.com/apache/nifi/pull/3651#discussion_r315394272
##
File path:
nifi-stateless/nifi-stateless-core/src/main/java/org/apache/nifi/stateless/core/StatelessFlow.java
##
@@ -99,6 +122,194 @@ public StatelessFlow(final List
roots) {
this.componentFactory = null;
}
+public StatelessFlow(final ProcessGroupDTO flow, final ExtensionManager
extensionManager, final VariableRegistry variableRegistry, final List
failureOutputPorts,
Review comment:
Added a new compatibility package to reconcile the differences between these
classes and eliminate the code duplication
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless init from flow xml
dbkegley commented on a change in pull request #3651: NIFI-6539 Nifi stateless
init from flow xml
URL: https://github.com/apache/nifi/pull/3651#discussion_r315394316
##
File path:
nifi-stateless/nifi-stateless-core/src/test/java/org/apache/nifi/stateless/core/InitFromFlowXmlIT.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.stateless.core;
+
+
+//import com.google.gson.JsonObject;
+//import com.google.gson.JsonParser;
+//import org.apache.nifi.bundle.Bundle;
+//import org.apache.nifi.bundle.BundleCoordinate;
+//import org.apache.nifi.controller.exception.ProcessorInstantiationException;
+//import org.apache.nifi.controller.serialization.FlowEncodingVersion;
+//import org.apache.nifi.controller.serialization.FlowFromDOMFactory;
+//import org.apache.nifi.encrypt.StringEncryptor;
+//import org.apache.nifi.nar.ExtensionManager;
+//import org.apache.nifi.nar.NarUnpacker;
+//import org.apache.nifi.parameter.Parameter;
+//import org.apache.nifi.parameter.ParameterContext;
+//import org.apache.nifi.registry.VariableDescriptor;
+//import org.apache.nifi.reporting.InitializationException;
+//import org.apache.nifi.stateless.bootstrap.ExtensionDiscovery;
+//import org.apache.nifi.util.NiFiProperties;
+//import org.apache.nifi.web.api.dto.ProcessGroupDTO;
+//import org.glassfish.jersey.internal.jsr166.Flow;
+//import org.w3c.dom.Document;
+//import org.w3c.dom.Element;
+//
+//import javax.net.ssl.SSLContext;
+//import java.io.File;
+//import java.io.FileNotFoundException;
+//import java.io.IOException;
+//import java.net.MalformedURLException;
+//import java.net.URL;
+//import java.net.URLClassLoader;
+//import java.nio.file.Path;
+//import java.nio.file.Paths;
+//import java.util.*;
+//
+//import static org.mockito.ArgumentMatchers.anyString;
+//import static org.mockito.Mockito.mock;
+//import static org.mockito.Mockito.when;
+
+public class InitFromFlowXmlIT {
+
+//private NiFiProperties getNiFiProperties() {
Review comment:
Added FlowXml parser test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] mcgilman opened a new pull request #220: NIFIREG-310: Support case insensitive membership decisions in LdapUserGroupProvider
mcgilman opened a new pull request #220: NIFIREG-310: Support case insensitive membership decisions in LdapUserGroupProvider URL: https://github.com/apache/nifi-registry/pull/220 NIFIREG-310: - Introducing case insensitive group membership. - Ensuring user identity and group name mapping is applied when the user identity or group name is inferred through group membership decisions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315376717
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
I updated the `StringUtils` class with the borrowed Lang methods, I picked
the javadoc of those methods as well, do you think I should edit the javadoc
removing other Lang stuff references (for example [the @since annotations right
and
there](https://github.com/apache/nifi/pull/3613/files#diff-fa10041e6362efbee8ea547b922febccR135))?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315376717
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
I updated the `StringUtils` class with the borrowed Lang methods, I picked
the javadoc of those methods as well, do you think I should edit the javadoc
removing other Lang stuff references, (for example [the @since annotations
right and
there](https://github.com/apache/nifi/pull/3613/files#diff-fa10041e6362efbee8ea547b922febccR135))?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315376717
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
I updated the `StringUtils` class with the borrowed Lang methods, I picked
the javadoc of those methods as well, do you think I should edit the javadoc
removing other Lang stuff references?(for example [the @since annotations right
and
there](https://github.com/apache/nifi/pull/3613/files#diff-fa10041e6362efbee8ea547b922febccR135)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] markap14 commented on issue #3580: NIFI-6436 Fix NPE at StandardPublicPort
markap14 commented on issue #3580: NIFI-6436 Fix NPE at StandardPublicPort URL: https://github.com/apache/nifi/pull/3580#issuecomment-522722640 Thanks @ijokarumawak - all looks good! +1 merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] asfgit closed pull request #3580: NIFI-6436 Fix NPE at StandardPublicPort
asfgit closed pull request #3580: NIFI-6436 Fix NPE at StandardPublicPort URL: https://github.com/apache/nifi/pull/3580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6436) StandardPublicPort throws NullPointerException when it reports a bulletin event
[ https://issues.apache.org/jira/browse/NIFI-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910686#comment-16910686 ] ASF subversion and git services commented on NIFI-6436: --- Commit e32689a60262110c9ff0ee6c4c9a3623ea789e57 in nifi's branch refs/heads/master from Koji Kawamura [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e32689a ] NIFI-6436 Fix NPE at StandardPublicPort Removing unnecessary ProcessGroup from PublicPort constructor. This closes #3580. Signed-off-by: Mark Payne > StandardPublicPort throws NullPointerException when it reports a bulletin > event > --- > > Key: NIFI-6436 > URL: https://issues.apache.org/jira/browse/NIFI-6436 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.10.0 >Reporter: Koji Kawamura >Assignee: Koji Kawamura >Priority: Major > Attachments: image-2019-07-12-18-45-11-524.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > NIFI-2933 changed StandardPublicPort to use the 'processGroup' variable > passed as its constructor argument at the EventReporter.reportEvent() method, > but that variable is null when a public port is instantiated. > EventReporter.reportEvent() should get the current ProcessGroup by calling > getProcessGroup() method each time. > If an error occurred while a public port is processing request, it fails to > report a bulletin event due to this NullPointerException. Due to this issue, > public ports can not report error detail to users with bulletin messages like > following screenshot. > !image-2019-07-12-18-45-11-524.png|width=680! -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (NIFI-6570) Site-to-Site listener not starting if standalone and no Root Group Ports exist
[ https://issues.apache.org/jira/browse/NIFI-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910683#comment-16910683 ] Mark Payne commented on NIFI-6570: -- Addressed in PR 3658. This PR addresses both NIFI-6569 and NIFI-6570 because I encountered 6570 when testing the fix for 6569 and needed to address it in order to complete the testing. > Site-to-Site listener not starting if standalone and no Root Group Ports exist > -- > > Key: NIFI-6570 > URL: https://issues.apache.org/jira/browse/NIFI-6570 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.10.0 > > > I created a flow that has a Site-to-Site input port within a Process Group > but no ports at the root group. When I tried to send to the instance via > site-to-site, I could not connect to the instance. Thread dumps show that the > Site-to-Site listener had not yet begun to accept connections because no > Input Ports or Output Ports exist at the root level and the instance is not > clustered. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (NIFI-6570) Site-to-Site listener not starting if standalone and no Root Group Ports exist
[ https://issues.apache.org/jira/browse/NIFI-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6570: - Fix Version/s: 1.10.0 Status: Patch Available (was: Open) > Site-to-Site listener not starting if standalone and no Root Group Ports exist > -- > > Key: NIFI-6570 > URL: https://issues.apache.org/jira/browse/NIFI-6570 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.10.0 > > > I created a flow that has a Site-to-Site input port within a Process Group > but no ports at the root group. When I tried to send to the instance via > site-to-site, I could not connect to the instance. Thread dumps show that the > Site-to-Site listener had not yet begun to accept connections because no > Input Ports or Output Ports exist at the root level and the instance is not > clustered. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (NIFI-6569) Site-to-Site not timing out when reading from remote NiFi
[ https://issues.apache.org/jira/browse/NIFI-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6569: - Fix Version/s: 1.10.0 Status: Patch Available (was: Open) > Site-to-Site not timing out when reading from remote NiFi > - > > Key: NIFI-6569 > URL: https://issues.apache.org/jira/browse/NIFI-6569 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > I created two simple flows: > Remote Input Port -> LogAttribute > GenerateFlowFile -> RemoteProcessGroup (pointing to self) > So that I can simply feed generated FlowFiles to the RPG to the LogAttribute. > When I ran this using Java 11, the listener failed to start (known issue, > NIFI-5952). However, what I noticed is that the RPG would not stop when I > clicked Disable Transmission. Instead, the web request to disable would hang. > Thread dumps show the call to try to find out which nodes are in the cluster > are never timing out. This seems to be related to NIFI-4461, though it's not > entirely clear at this point. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] markap14 opened a new pull request #3658: NIFI-6569, NIFI-6570: Fixed bug that caused read timeouts not to occu…
markap14 opened a new pull request #3658: NIFI-6569, NIFI-6570: Fixed bug that
caused read timeouts not to occu…
URL: https://github.com/apache/nifi/pull/3658
…r with site-to-site. Fixed bug that caused site-to-site listener not to
accept connections if there are no input/output ports on the root group - this
used to be a valid check and was done to prevent spawning extra threads and
doing extra work if no ports exist but now that we have site-to-site ports
outside of the root group it's no longer a reasonable condition to check.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6570) Site-to-Site listener not starting if standalone and no Root Group Ports exist
Mark Payne created NIFI-6570: Summary: Site-to-Site listener not starting if standalone and no Root Group Ports exist Key: NIFI-6570 URL: https://issues.apache.org/jira/browse/NIFI-6570 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne I created a flow that has a Site-to-Site input port within a Process Group but no ports at the root group. When I tried to send to the instance via site-to-site, I could not connect to the instance. Thread dumps show that the Site-to-Site listener had not yet begun to accept connections because no Input Ports or Output Ports exist at the root level and the instance is not clustered. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (NIFI-6569) Site-to-Site not timing out when reading from remote NiFi
Mark Payne created NIFI-6569: Summary: Site-to-Site not timing out when reading from remote NiFi Key: NIFI-6569 URL: https://issues.apache.org/jira/browse/NIFI-6569 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne I created two simple flows: Remote Input Port -> LogAttribute GenerateFlowFile -> RemoteProcessGroup (pointing to self) So that I can simply feed generated FlowFiles to the RPG to the LogAttribute. When I ran this using Java 11, the listener failed to start (known issue, NIFI-5952). However, what I noticed is that the RPG would not stop when I clicked Disable Transmission. Instead, the web request to disable would hang. Thread dumps show the call to try to find out which nodes are in the cluster are never timing out. This seems to be related to NIFI-4461, though it's not entirely clear at this point. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] rfellows commented on a change in pull request #3606: [WIP] Nifi 6282
rfellows commented on a change in pull request #3606: [WIP] Nifi 6282
URL: https://github.com/apache/nifi/pull/3606#discussion_r315368517
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##
@@ -0,0 +1,2092 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* global define, module, require, exports */
+
+(function (root, factory) {
+if (typeof define === 'function' && define.amd) {
+define(['jquery',
+'Slick',
+'d3',
+'nf.Client',
+'nf.Dialog',
+'nf.Storage',
+'nf.Common',
+'nf.CanvasUtils',
+'nf.ng.Bridge',
+'nf.ErrorHandler',
+'nf.FilteredDialogCommon',
+'nf.Shell',
+'nf.ComponentState',
+'nf.ComponentVersion',
+'nf.PolicyManagement',
+'nf.Processor',
+'nf.ProcessGroup',
+'nf.ProcessGroupConfiguration'],
+function ($, Slick, d3, nfClient, nfDialog, nfStorage, nfCommon,
nfCanvasUtils, nfNgBridge, nfErrorHandler, nfFilteredDialogCommon, nfShell,
nfComponentState, nfComponentVersion, nfPolicyManagement, nfProcessor,
nfProcessGroup, nfProcessGroupConfiguration) {
+return (nf.ParameterContexts = factory($, Slick, d3, nfClient,
nfDialog, nfStorage, nfCommon, nfCanvasUtils, nfNgBridge, nfErrorHandler,
nfFilteredDialogCommon, nfShell, nfComponentState, nfComponentVersion,
nfPolicyManagement, nfProcessor, nfProcessGroup, nfProcessGroupConfiguration));
+});
+} else if (typeof exports === 'object' && typeof module === 'object') {
+module.exports = (nf.ParameterContexts =
+factory(require('jquery'),
+require('Slick'),
+require('d3'),
+require('nf.Client'),
+require('nf.Dialog'),
+require('nf.Storage'),
+require('nf.Common'),
+require('nf.CanvasUtils'),
+require('nf.ng.Bridge'),
+require('nf.ErrorHandler'),
+require('nf.FilteredDialogCommon'),
+require('nf.Shell'),
+require('nf.ComponentState'),
+require('nf.ComponentVersion'),
+require('nf.PolicyManagement'),
+require('nf.Processor'),
+require('nf.ProcessGroup'),
+require('nf.ProcessGroupConfiguration')));
+} else {
+nf.ParameterContexts = factory(root.$,
+root.Slick,
+root.d3,
+root.nf.Client,
+root.nf.Dialog,
+root.nf.Storage,
+root.nf.Common,
+root.nf.CanvasUtils,
+root.nf.ng.Bridge,
+root.nf.ErrorHandler,
+root.nf.FilteredDialogCommon,
+root.nf.Shell,
+root.nf.ComponentState,
+root.nf.ComponentVersion,
+root.nf.PolicyManagement,
+root.nf.Processor,
+root.nf.ProcessGroup,
+root.nf.ProcessGroupConfiguration);
+}
+}(this, function ($, Slick, d3, nfClient, nfDialog, nfStorage, nfCommon,
nfCanvasUtils, nfNgBridge, nfErrorHandler, nfFilteredDialogCommon, nfShell,
nfComponentState, nfComponentVersion, nfPolicyManagement, nfProcessor,
nfProcessGroup, nfProcessGroupConfiguration) {
+'use strict';
+
+var config = {
+urls: {
+parameterContexts: '../nifi-api/parameter-contexts'
+}
+};
+
+var parameterContextsGridOptions = {
+forceFitColumns: true,
+enableTextSelectionOnCells: true,
+enableCellNavigation: true,
+enableColumnReorder: false,
+autoEdit: false,
+multiSelect: false,
+rowHeight: 24
+};
+
+var parametersGridOptions = {
+forceFitColumns: true,
+enableTextSelectionOnCells: true,
+enableCellNavigation: true,
+enableColumnReorder: false,
+editable: false,
+enableAddRow: false,
+autoEdit: false,
+
[jira] [Updated] (MINIFICPP-1009) Create Kafka connector C API for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1009: --- Description: Create Kafka connector C API to integrate with nanofi ecu SDK. Also come up with implementation details for kerberized access to kafka service. (was: Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at kerberized acces to kafka service.) > Create Kafka connector C API for nanofi ecu > --- > > Key: MINIFICPP-1009 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1009 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > Create Kafka connector C API to integrate with nanofi ecu SDK. Also come up > with implementation details for kerberized access to kafka service. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1009) Create Kafka connector C API for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1009: --- Description: Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at kerberized acces to kafka service. (was: Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at the kerberized acces to kafka service.) > Create Kafka connector C API for nanofi ecu > --- > > Key: MINIFICPP-1009 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1009 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at > kerberized acces to kafka service. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1009) Create Kafka connector C API for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1009: --- Description: Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at the kerberized acces to kafka service. (was: Create Kafka connector C API to integrate with nanofi ecu SDK.) > Create Kafka connector C API for nanofi ecu > --- > > Key: MINIFICPP-1009 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1009 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > Create Kafka connector C API to integrate with nanofi ecu SDK. Also look at > the kerberized acces to kafka service. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-minifi] GCHQ-NiFi opened a new pull request #167: MINIFI-424: Centralise Bootstrap config
GCHQ-NiFi opened a new pull request #167: MINIFI-424: Centralise Bootstrap config URL: https://github.com/apache/nifi-minifi/pull/167 I've consolidated the bootstrap transformation code into a new BootstrapTransformation class, and simplified the transformConfigFile function to accept bootstrap properties instead of individual schemas. This should allow for simpler config overwriting in the future (currently supports SSL and provenance reporting). I've piggybacked on an existing ticket that references similar changes - but am happy to raise a new one if needed! Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MINIFICPP-1010) Create MQTT connecter API for nanofi ecu
Murtuza Shareef created MINIFICPP-1010: -- Summary: Create MQTT connecter API for nanofi ecu Key: MINIFICPP-1010 URL: https://issues.apache.org/jira/browse/MINIFICPP-1010 Project: Apache NiFi MiNiFi C++ Issue Type: Story Reporter: Murtuza Shareef Create MQTT connector C API to integrate with nanofi ecu. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1010) Create MQTT connecter API for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1010: --- Labels: CAPI ECU nanofi (was: ) > Create MQTT connecter API for nanofi ecu > > > Key: MINIFICPP-1010 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1010 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > Create MQTT connector C API to integrate with nanofi ecu. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1009) Create Kafka connector C API for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1009: --- Labels: CAPI ECU nanofi (was: ) > Create Kafka connector C API for nanofi ecu > --- > > Key: MINIFICPP-1009 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1009 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > Create Kafka connector C API to integrate with nanofi ecu SDK. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (MINIFICPP-1009) Create Kafka connector C API for nanofi ecu
Murtuza Shareef created MINIFICPP-1009: -- Summary: Create Kafka connector C API for nanofi ecu Key: MINIFICPP-1009 URL: https://issues.apache.org/jira/browse/MINIFICPP-1009 Project: Apache NiFi MiNiFi C++ Issue Type: Story Reporter: Murtuza Shareef Assignee: Murtuza Shareef Create Kafka connector C API to integrate with nanofi ecu SDK. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1008) Implement ECU C API SDK and integrate with C2
[ https://issues.apache.org/jira/browse/MINIFICPP-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1008: --- Labels: CAPI ECU nanofi (was: ) > Implement ECU C API SDK and integrate with C2 > - > > Key: MINIFICPP-1008 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1008 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > A C API SDK allows users to create ECUs and run them. The C2 API and the CoAP > communication implementation will be implemented as part of another story. > The goal of this story is to develop a minimal C API as an SDK to build out > an ECU and then integrate it with the communication layer (C2/CoAP layer) to > be fully integrated with CoAP server (EFM). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1008) Implement ECU C API SDK and integrate with C2
[ https://issues.apache.org/jira/browse/MINIFICPP-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1008: --- Description: A C API SDK allows users to create ECUs and run them. The C2 API and the CoAP communication implementation will be implemented as part of another story. MINIFICPP-1007 The goal of this story is to develop a minimal C API as an SDK to build out an ECU and then integrate it with the communication layer (C2/CoAP layer) to be fully integrated with CoAP server (EFM). was: A C API SDK allows users to create ECUs and run them. The C2 API and the CoAP communication implementation will be implemented as part of another story. The goal of this story is to develop a minimal C API as an SDK to build out an ECU and then integrate it with the communication layer (C2/CoAP layer) to be fully integrated with CoAP server (EFM). > Implement ECU C API SDK and integrate with C2 > - > > Key: MINIFICPP-1008 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1008 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > A C API SDK allows users to create ECUs and run them. The C2 API and the CoAP > communication implementation will be implemented as part of another story. > MINIFICPP-1007 > The goal of this story is to develop a minimal C API as an SDK to build out > an ECU and then integrate it with the communication layer (C2/CoAP layer) to > be fully integrated with CoAP server (EFM). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (MINIFICPP-1008) Implement ECU C API SDK and integrate with C2
Murtuza Shareef created MINIFICPP-1008: -- Summary: Implement ECU C API SDK and integrate with C2 Key: MINIFICPP-1008 URL: https://issues.apache.org/jira/browse/MINIFICPP-1008 Project: Apache NiFi MiNiFi C++ Issue Type: Story Reporter: Murtuza Shareef Assignee: Murtuza Shareef A C API SDK allows users to create ECUs and run them. The C2 API and the CoAP communication implementation will be implemented as part of another story. The goal of this story is to develop a minimal C API as an SDK to build out an ECU and then integrate it with the communication layer (C2/CoAP layer) to be fully integrated with CoAP server (EFM). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (NIFIREG-310) LdapUserGroupProvider - Allow for case insensitive membership decisions
Matt Gilman created NIFIREG-310: --- Summary: LdapUserGroupProvider - Allow for case insensitive membership decisions Key: NIFIREG-310 URL: https://issues.apache.org/jira/browse/NIFIREG-310 Project: NiFi Registry Issue Type: Improvement Reporter: Matt Gilman Assignee: Matt Gilman Whether or not a directory server enforces case sensitivity is typically something that is implementation-dependent, often it is configurable. NiFi and NiFi Registry currently enforce case. This JIRA is to introduce a new property that supports telling the Registry whether or not it should enforce case when making these membership decisions. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1007) CoAP/C2 API integration for nanofi ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1007: --- Labels: CAPI ECU nanofi (was: ) > CoAP/C2 API integration for nanofi ecu > -- > > Key: MINIFICPP-1007 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1007 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > The goal of this story is to implement a C2 protocol C API over CoAP > protocol. At the end of this story we should be able to demonstrate the > following: > # Configure tailfile ecu with input and output parameters. > # Start and Stop the tailfile ecu via C2 protocol. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (MINIFICPP-1007) CoAP/C2 API integration for nanofi tailfile ecu
[ https://issues.apache.org/jira/browse/MINIFICPP-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtuza Shareef updated MINIFICPP-1007: --- Summary: CoAP/C2 API integration for nanofi tailfile ecu (was: CoAP/C2 API integration for nanofi ecu) > CoAP/C2 API integration for nanofi tailfile ecu > --- > > Key: MINIFICPP-1007 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1007 > Project: Apache NiFi MiNiFi C++ > Issue Type: Story >Reporter: Murtuza Shareef >Assignee: Murtuza Shareef >Priority: Major > Labels: CAPI, ECU, nanofi > > The goal of this story is to implement a C2 protocol C API over CoAP > protocol. At the end of this story we should be able to demonstrate the > following: > # Configure tailfile ecu with input and output parameters. > # Start and Stop the tailfile ecu via C2 protocol. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (MINIFICPP-1007) CoAP/C2 API integration for nanofi ecu
Murtuza Shareef created MINIFICPP-1007: -- Summary: CoAP/C2 API integration for nanofi ecu Key: MINIFICPP-1007 URL: https://issues.apache.org/jira/browse/MINIFICPP-1007 Project: Apache NiFi MiNiFi C++ Issue Type: Story Reporter: Murtuza Shareef Assignee: Murtuza Shareef The goal of this story is to implement a C2 protocol C API over CoAP protocol. At the end of this story we should be able to demonstrate the following: # Configure tailfile ecu with input and output parameters. # Start and Stop the tailfile ecu via C2 protocol. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-minifi] asfgit closed pull request #158: MINIFI-478 Fix broken OrderedProperties and OrderedPropertiesTest
asfgit closed pull request #158: MINIFI-478 Fix broken OrderedProperties and OrderedPropertiesTest URL: https://github.com/apache/nifi-minifi/pull/158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6568) Surface time-to-back-pressure and initial predictions in the UI.
Robert Fellows created NIFI-6568: Summary: Surface time-to-back-pressure and initial predictions in the UI. Key: NIFI-6568 URL: https://issues.apache.org/jira/browse/NIFI-6568 Project: Apache NiFi Issue Type: Sub-task Reporter: Robert Fellows Assignee: Robert Fellows Back pressure predictions should be made visible in the flow designer and in the connection summary table. * Add indicators on connection widgets for predicted count and size of connection queues. * Add prediction information on the tooltips for those queues * Add time to back pressure prediction to the connection summary table. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-minifi] apiri commented on issue #158: MINIFI-478 Fix broken OrderedProperties and OrderedPropertiesTest
apiri commented on issue #158: MINIFI-478 Fix broken OrderedProperties and OrderedPropertiesTest URL: https://github.com/apache/nifi-minifi/pull/158#issuecomment-52267 Going to make the suggested changes and include as I believe the functionality to be correct as discussed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3509: NIFI-6295 fix deserialization issues with NiFiRecordSerDe for hive3streaming
mattyb149 commented on a change in pull request #3509: NIFI-6295 fix
deserialization issues with NiFiRecordSerDe for hive3streaming
URL: https://github.com/apache/nifi/pull/3509#discussion_r315321834
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/NiFiRecordSerDe.java
##
@@ -142,7 +138,27 @@ public SerDeStats getSerDeStats() {
public Object deserialize(Writable writable) throws SerDeException {
ObjectWritable t = (ObjectWritable) writable;
Record record = (Record) t.get();
-List r = new
ArrayList<>(Collections.nCopies(columnNames.size(), null));
+return deserialize(record, schema, true);
+}
+
+/**
+ * Deserialize a record object into a Hive struct.
+ * @param record The record to deserialize, can be null
+ * @param structTypeInfo The hive table column info that corresponds to
the Hive struct
+ * @param isParentStruct Whether or not this struct is the one contained
by the Writable
+ */
+Object deserialize(Record record, StructTypeInfo structTypeInfo, boolean
isParentStruct) throws SerDeException{
+if(record == null){
+return null;
+}
+Map fieldPositionMap = null;
+try {
+fieldPositionMap = populateFieldPositionMap(record.getSchema(),
structTypeInfo, log);
Review comment:
Looks like I over-simplified the NiFiRecordSerDe code while porting from
JsonSerDe. The latter had broken up the tasks of getting field names,
extracting field values, and possibly recursively calling one or both of those
methods for nested structures. I think we should look at
[JsonSerDe](https://github.com/apache/hive/blob/rel/release-3.1.0/serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java)
and do NiFiRecordSerDe likewise. It can result in getting that
fieldPositionMap called multiple times per flow file, but like you said I think
we need to do it. However they have a pretty good modular approach to which
methods do which things, all we should have to do is map our Record methods to
JsonSerDe's JSON parsing methods (`nextToken()` and such). Thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi] apiri commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
apiri commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in… URL: https://github.com/apache/nifi-minifi/pull/166#issuecomment-522671333 @GCHQ-NiFi no worries! Been guilty of it a few times myself in the past. Thanks for the contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3602: NIFI-5839 Applied identity mapping to user lookups and group members
mcgilman commented on issue #3602: NIFI-5839 Applied identity mapping to user lookups and group members URL: https://github.com/apache/nifi/pull/3602#issuecomment-522671299 @dtmo I just posted my PR [1] which introduces a new flag that allows the user to configure whether NiFi should use case sensitivity when making group membership decisions. I want to retain the current approach with regards to how often the directory server would be queried so I left the basic structure intact and just ensured that membership decisions considered case conditionally. I was not aware that we could consider querying the directory server for which matching rules were enabled. Is this something that we could reliably depend on? I'm tempted to leave the configuration on the NiFi side for cases when a directory server implements something slightly differently from another implementation. [1] https://github.com/apache/nifi/pull/3657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi] GCHQ-NiFi commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
GCHQ-NiFi commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in… URL: https://github.com/apache/nifi-minifi/pull/166#issuecomment-522669615 @apiri Apologies, will do the contrib-check before my next pull request! Thanks a lot :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6559) FlowFile Repo Journal Recovery Should not Fail if External Overflow Files are Missing
[ https://issues.apache.org/jira/browse/NIFI-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910571#comment-16910571 ] Mark Payne commented on NIFI-6559: -- I don't think we can change something like this from within NiFi or from a separate utility. It would generate the same effect. Can you better explain the end goal here? If I remember correctly, this was tied to a mailing list thread about OutOfMemoryError's. Was the desire to delete these files in order to sacrifice some of the data but not all? Or to avoid these particular updates because they were known to be particularly memory-intensive updates? Or something entirely different? I could imagine perhaps having a utility that might purge data from a particular queue, or perhaps flowfiles that have attributes that exceed 65 KB or something like that... but we'd have to be super careful in a situation like that also because we'd have to ensure that we kept around a Set of all FlowFiles that were removed so that any further updates to those FlowFiles would not be included, etc. > FlowFile Repo Journal Recovery Should not Fail if External Overflow Files are > Missing > - > > Key: NIFI-6559 > URL: https://issues.apache.org/jira/browse/NIFI-6559 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > When NiFi is journaling the FlowFile repository changes to disk it sometimes > writes Overflow files if it exceeds a certain memory threshold. > These files are tracked inside of the *.journal files as External File > References. If one of these external file references is deleted or lost the > entire journal fails to recover. > Instead, I feel this should work more like FlowFile's that lose their queue, > or Content in the Content Repository that has lost it's FlowFile. Log it, > and move on. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-minifi] asfgit closed pull request #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
asfgit closed pull request #166: MINIFI-511: Provenance reporting config can now be overridden using values set in… URL: https://github.com/apache/nifi-minifi/pull/166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman opened a new pull request #3657: NIFI-5839: Support case insensitive membership decisions
mcgilman opened a new pull request #3657: NIFI-5839: Support case insensitive membership decisions URL: https://github.com/apache/nifi/pull/3657 NIFI-5839: - Introducing case insensitive group membership. - Ensuring user identity and group name mapping is applied when the user identity or group name is inferred through group membership decisions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi] apiri commented on a change in pull request #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
apiri commented on a change in pull request #166: MINIFI-511: Provenance reporting config can now be overridden using values set in… URL: https://github.com/apache/nifi-minifi/pull/166#discussion_r315283017 ## File path: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java ## @@ -83,6 +84,8 @@ import java.util.concurrent.locks.ReentrantLock; import static java.nio.file.StandardCopyOption.REPLACE_EXISTING; +import static org.apache.nifi.minifi.commons.schema.RemoteProcessGroupSchema.TIMEOUT_KEY; +import static org.apache.nifi.minifi.commons.schema.common.CommonPropertyKeys.*; Review comment: minor: * imports are not allowed for code in the project standards and leads to an issue with contrib-check (-Pcontrib-check) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi] apiri commented on a change in pull request #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
apiri commented on a change in pull request #166: MINIFI-511: Provenance
reporting config can now be overridden using values set in…
URL: https://github.com/apache/nifi-minifi/pull/166#discussion_r315282673
##
File path:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
##
@@ -95,23 +95,32 @@ public static void transformConfigFile(String sourceFile,
String destPath, Secur
final File ymlConfigFile = new File(sourceFile);
final InputStream ios = new FileInputStream(ymlConfigFile);
-transformConfigFile(ios, destPath, securityProperties);
+transformConfigFile(ios, destPath, securityProperties, null);
}
+public static void transformConfigFile(String sourceFile, String destPath,
SecurityPropertiesSchema securityProperties, ProvenanceReportingSchema
provenanceReportingProperties) throws Exception {
+final File ymlConfigFile = new File(sourceFile);
+final InputStream ios = new FileInputStream(ymlConfigFile);
+
+transformConfigFile(ios, destPath, securityProperties,
provenanceReportingProperties);
+}
public static void transformConfigFile(InputStream sourceStream, String
destPath) throws Exception {
-transformConfigFile(sourceStream, destPath, null);
+transformConfigFile(sourceStream, destPath, null, null);
}
-public static void transformConfigFile(InputStream sourceStream, String
destPath, SecurityPropertiesSchema securityProperties) throws Exception {
+public static void transformConfigFile(InputStream sourceStream, String
destPath, SecurityPropertiesSchema securityProperties,
ProvenanceReportingSchema provenanceReportingProperties) throws Exception {
Review comment:
minor: This is longer than the specified project standard of 200 characters
and leads to an issue with contrib-check (-Pcontrib-check)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (NIFIREG-303) TypeError: Cannot read property 'innerHTML' of undefined occurs with español browser
[ https://issues.apache.org/jira/browse/NIFIREG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFIREG-303. - Resolution: Fixed > TypeError: Cannot read property 'innerHTML' of undefined occurs with español > browser > > > Key: NIFIREG-303 > URL: https://issues.apache.org/jira/browse/NIFIREG-303 > Project: NiFi Registry > Issue Type: Bug >Reporter: Koji Kawamura >Assignee: Koji Kawamura >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > NiFi Registry UI throws a TypeError when it's accessed with a browser using > Spanish español. > UI tries to load a translation XML config file if user's browser locale is > not 'en-US'. Currently translation for español (es) is only available. With > other languages, the translation part will not be activated. > The UI expects messages.es.xlf is returned as a XML dom object, and access > its data with "documentElement.innerHTML". But the returned object is a > String. > [https://github.com/apache/nifi-registry/blob/master/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/nf-registry-bootstrap.js#L64] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi-registry] scottyaslan commented on issue #215: NIFIREG-303 Fix translation config file parsing
scottyaslan commented on issue #215: NIFIREG-303 Fix translation config file parsing URL: https://github.com/apache/nifi-registry/pull/215#issuecomment-522652821 Thanks @ijokarumawak this has been merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] asfgit closed pull request #215: NIFIREG-303 Fix translation config file parsing
asfgit closed pull request #215: NIFIREG-303 Fix translation config file parsing URL: https://github.com/apache/nifi-registry/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies
bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies URL: https://github.com/apache/nifi-registry/pull/207#discussion_r315298695 ## File path: nifi-registry-core/nifi-registry-framework/pom.xml ## @@ -294,12 +294,17 @@ com.h2database h2 -1.4.196 +1.4.199 Review comment: I noticed that this version is newer than what Flyway knows about so we get this warning on start up: `2019-08-19 12:19:17,793 WARN [main] o.f.core.internal.database.base.Database Flyway upgrade recommended: H2 1.4.199 is newer than this version of Flyway and support has not been tested. ` We can't upgrade Flyway yet because we need spring-boot to upgrade their Flyway support first. It looks like 1.4.197 is the last version that doesn't produce this warning, we were on 196 before. Even though everything seems to work fine with 199, I don't love everyone getting this warning in their logs every time they start, so I'm leaning towards going with 197. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies
bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies URL: https://github.com/apache/nifi-registry/pull/207#discussion_r315277009 ## File path: nifi-registry-core/nifi-registry-framework/pom.xml ## @@ -294,12 +294,17 @@ com.h2database h2 -1.4.196 +1.4.199 org.eclipse.jgit org.eclipse.jgit -4.11.0.201803080745-r +5.4.0.201906121030-r Review comment: I get a test failure when building with this version: ``` testLoadCommitHistories(org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider) Time elapsed: 0.501 sec <<< ERROR! org.eclipse.jgit.api.errors.JGitInternalException: no matching secret key found in legacy secring.gpg for key or user id: git-u...@example.com at org.eclipse.jgit.lib.internal.BouncyCastleGpgKeyLocator.findSecretKey(BouncyCastleGpgKeyLocator.java:279) at org.eclipse.jgit.lib.internal.BouncyCastleGpgSigner.locateSigningKey(BouncyCastleGpgSigner.java:124) at org.eclipse.jgit.lib.internal.BouncyCastleGpgSigner.sign(BouncyCastleGpgSigner.java:133) at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:271) at org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:407) at org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:171) at org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadCommitHistories$6(TestGitFlowPersistenceProvider.java:152) at org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:111) at org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories(TestGitFlowPersistenceProvider.java:139) ``` I tried with the latest 4.x version and it seems to work - 4.11.8.201904181247-r Not sure if there was a reason we need to upgrade to 5.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies
bbende commented on a change in pull request #207: NIFIREG-286 - Upgrading various dependencies URL: https://github.com/apache/nifi-registry/pull/207#discussion_r315279072 ## File path: pom.xml ## @@ -158,7 +159,7 @@ ch.qos.logback logback-classic -1.1.3 +1.2.3 Review comment: I noticed that when running `./bin/nifi-registry.sh stop` the output is now different. It used to just say: ``` Java home: /path/to/1.8.0.201 NiFi Registry home: /path/to/nifi-registry-0.5.0-SNAPSHOT Bootstrap Config File: /path/to/nifi-registry-0.5.0-SNAPSHOT/conf/bootstrap.conf 2019-08-19 11:36:00,959 INFO [main] o.apache.nifi.registry.bootstrap.Command Apache NiFi Registry has accepted the Shutdown Command and is shutting down now 2019-08-19 11:36:01,179 INFO [main] o.apache.nifi.registry.bootstrap.Command NiFi Registry has finished shutting down. ``` Now, after the line that starts with "Bootstrap Config File", there is a bunch of logback stuff that wasn't there before. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315293061
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
ah wow, thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] adarmiento commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language
adarmiento commented on issue #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#issuecomment-522645151 cc @MikeThomsen could you please take a look also at this one? I think this feature would be nice coupled with #3613 Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315292045
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
I also sent you a pull request for the verbiage for the top level `NOTICE`
file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6567) HandleHttpRequest does not shutdown HTTP server in some circumstances
Peter Wicks created NIFI-6567: - Summary: HandleHttpRequest does not shutdown HTTP server in some circumstances Key: NIFI-6567 URL: https://issues.apache.org/jira/browse/NIFI-6567 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Peter Wicks Assignee: Peter Wicks (Dependent on NIFI-6562) If multiple cluster nodes are running on a single host, then there will be port conflicts in HandleHttpRequest. To avoid this users may choose to run in Primary Only scheduling mode. If there is a primary node change, the processor does not properly shutdown the old Http server instance before the new primary node tries to startup it's own local copy. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] patricker opened a new pull request #3656: NIFI-6562 Expose ExecutionNode in ProcessContext
patricker opened a new pull request #3656: NIFI-6562 Expose ExecutionNode in ProcessContext URL: https://github.com/apache/nifi/pull/3656 ## Description of PR In some circumstances it can be helpful to know if a processor is schedule to run on All nodes or only the Primary node, and take appropriate action when the primary node changes based on this context. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315286174
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
Ah ok, I misunderstood the last comment.
Ok, I'm going ahead with this solution then
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6566) Decouple status analytics model from connection status analytics objects
Yolanda M. Davis created NIFI-6566: -- Summary: Decouple status analytics model from connection status analytics objects Key: NIFI-6566 URL: https://issues.apache.org/jira/browse/NIFI-6566 Project: Apache NiFi Issue Type: Sub-task Components: Core Framework Reporter: Yolanda M. Davis Assignee: Yolanda M. Davis Currently the connection status analytics object is tightly coupled with the type of model used for prediction. This should be refactored to allow flexibility for model selection. Users should also be able to configure the model used via nifi.properties as described below: nifi.analytics.connection.model=OrdinaryLeastSquaresMSAM nifi.analytics.connection.online=true nifi.analytics.connection.model.[param]= -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
MikeThomsen commented on a change in pull request #3613: NIFI-6502 Add
padLeft() and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315278981
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
@adarmiento Joe wants to avoid the dependency for now:
> If we want to avoid a binary dependency (**and I think we do** given that
we have our own StringUtil in this module for this purpose [*Emphasis mine* -
Mike]
So feel free to just copy the left/right pad methods from `commons-lang3`
into our `StringUtils` and add the Javadoc lines I gave you. I'll take a look
at the LICENSE and NOTICE files at the root level and give you any updates I
think you need to add.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi] apiri commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in…
apiri commented on issue #166: MINIFI-511: Provenance reporting config can now be overridden using values set in… URL: https://github.com/apache/nifi-minifi/pull/166#issuecomment-522625634 reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6364) CLI - Add commands to interact with parameter contexts
[ https://issues.apache.org/jira/browse/NIFI-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6364: - Resolution: Fixed Status: Resolved (was: Patch Available) > CLI - Add commands to interact with parameter contexts > -- > > Key: NIFI-6364 > URL: https://issues.apache.org/jira/browse/NIFI-6364 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Once the back-end is available, we should add CLI commands for CRUD of > parameter contexts, as well as setting the assigned context on a process > group. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] markap14 commented on issue #3628: NIFI-6364 - Add CLI commands for parameter contexts
markap14 commented on issue #3628: NIFI-6364 - Add CLI commands for parameter contexts URL: https://github.com/apache/nifi/pull/3628#issuecomment-522624357 Thanks @bbende. I looked over the code and all looks good. Tried it out, especially around creating/deleting contexts, changing param values, creating new params, deleting params, and updating only the description or only the value of a param. All worked as expected. +1 merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6364) CLI - Add commands to interact with parameter contexts
[ https://issues.apache.org/jira/browse/NIFI-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910477#comment-16910477 ] ASF subversion and git services commented on NIFI-6364: --- Commit 16f3dbdc6a2ac2d1b666f060792a29c7fc9eec89 in nifi's branch refs/heads/master from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=16f3dbd ] NIFI-6364 - Add CLI commands for parameter contexts This closes #3628. Signed-off-by: Mark Payne > CLI - Add commands to interact with parameter contexts > -- > > Key: NIFI-6364 > URL: https://issues.apache.org/jira/browse/NIFI-6364 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Once the back-end is available, we should add CLI commands for CRUD of > parameter contexts, as well as setting the assigned context on a process > group. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [nifi] asfgit closed pull request #3628: NIFI-6364 - Add CLI commands for parameter contexts
asfgit closed pull request #3628: NIFI-6364 - Add CLI commands for parameter contexts URL: https://github.com/apache/nifi/pull/3628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft() and padRight() functions to RecordPath functions
adarmiento commented on a change in pull request #3613: NIFI-6502 Add padLeft()
and padRight() functions to RecordPath functions
URL: https://github.com/apache/nifi/pull/3613#discussion_r315265221
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##
@@ -78,25 +78,63 @@ public static String join(final Collection collection,
String delimiter) {
return sb.toString().substring(0, sb.lastIndexOf(delimiter));
}
-public static String padLeft(final String source, int length, char
padding) {
-if (source != null) {
+public static String padLeft(final String source, int length, String
padding) {
Review comment:
Thanks @joewitt . IIUC then you'd go for adding the dependency. I am fine
doing it. Shall we go ahead that way @MikeThomsen, do you agree on this ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] bbende merged pull request #219: NIFI-309: Added Difference Types PROPERTY_PARAMETERIZED and PROPERTY_…
bbende merged pull request #219: NIFI-309: Added Difference Types PROPERTY_PARAMETERIZED and PROPERTY_… URL: https://github.com/apache/nifi-registry/pull/219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on issue #219: NIFI-309: Added Difference Types PROPERTY_PARAMETERIZED and PROPERTY_…
bbende commented on issue #219: NIFI-309: Added Difference Types PROPERTY_PARAMETERIZED and PROPERTY_… URL: https://github.com/apache/nifi-registry/pull/219#issuecomment-522596416 Looks good, going to merge, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
