[jira] [Created] (MINIFICPP-1297) TestSuite called "Tests" should have a more talkative name

2020-07-16 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1297: - Summary: TestSuite called "Tests" should have a more talkative name Key: MINIFICPP-1297 URL: https://issues.apache.org/jira/browse/MINIFICPP-1297 Project: Apache NiF

[jira] [Resolved] (MINIFICPP-1272) Graceful shutdown on flow update

2020-07-16 Thread Adam Debreceni (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni resolved MINIFICPP-1272. --- Assignee: Adam Debreceni Resolution: Fixed > Graceful shutdown on flow upda

[GitHub] [nifi] dazhitchman commented on pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property

2020-07-16 Thread GitBox
dazhitchman commented on pull request #3956: URL: https://github.com/apache/nifi/pull/3956#issuecomment-659813809 Any progress on this ? also noting NIFI-3096 refers to https://github.com/simonellistonball/nifi-webdav-bundle (Apache 2 license) that could be leveraged to add functionality.

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456157198 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/test/resources/nifi-administration-context.xml ## @@ -0,0 +1,4

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456156909 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ## @@

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456156307 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/service/impl/StandardKeyService.java #

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456156132 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/dao/impl/StandardKeyDAO.java #

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456155950 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/dao/impl/StandardKeyDAO.java #

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456155695 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/pom.xml ## @@ -86,5 +86,11 @@ org.apache.commons

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456120213 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/dao/impl/StandardKeyDAO.java #

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #833: MINIFICPP-1272 - Graceful shutdown on flow update

2020-07-16 Thread GitBox
arpadboda closed pull request #833: URL: https://github.com/apache/nifi-minifi-cpp/pull/833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [nifi] alopresto commented on a change in pull request #4377: NIFI-7568 - Fixing Kerberos mappings

2020-07-16 Thread GitBox
alopresto commented on a change in pull request #4377: URL: https://github.com/apache/nifi/pull/4377#discussion_r456113916 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java ## @@

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
arpadboda closed pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [nifi] markap14 commented on pull request #4405: NIFI-7633: Added FlowFileConcurrency of SINGLE_BATCH_PER_NODE to allo…

2020-07-16 Thread GitBox
markap14 commented on pull request #4405: URL: https://github.com/apache/nifi/pull/4405#issuecomment-659652687 Thanks Pierre. Fixed. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (NIFI-7655) Add note to UI when editing property that Ctrl + Space provides auto-complete

2020-07-16 Thread Mark Payne (Jira)
Mark Payne created NIFI-7655: Summary: Add note to UI when editing property that Ctrl + Space provides auto-complete Key: NIFI-7655 URL: https://issues.apache.org/jira/browse/NIFI-7655 Project: Apache NiF

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455927688 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455927688 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455927688 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[jira] [Updated] (NIFI-7654) Deprecate Client Auth property on AMQP processors

2020-07-16 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-7654: -- Status: Patch Available (was: Open) > Deprecate Client Auth property on AMQP processors > -

[GitHub] [nifi] turcsanyip opened a new pull request #4412: NIFI-7654: Deprecated Client Auth property on AMQP processors

2020-07-16 Thread GitBox
turcsanyip opened a new pull request #4412: URL: https://github.com/apache/nifi/pull/4412 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[GitHub] [nifi] pvillard31 commented on a change in pull request #4405: NIFI-7633: Added FlowFileConcurrency of SINGLE_BATCH_PER_NODE to allo…

2020-07-16 Thread GitBox
pvillard31 commented on a change in pull request #4405: URL: https://github.com/apache/nifi/pull/4405#discussion_r455825865 ## File path: nifi-docs/src/main/asciidoc/user-guide.adoc ## @@ -774,6 +779,25 @@ in the dataflow (i.e., the next component outside of the Process Group)

[jira] [Created] (NIFI-7654) Deprecate Client Auth property on AMQP processors

2020-07-16 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-7654: - Summary: Deprecate Client Auth property on AMQP processors Key: NIFI-7654 URL: https://issues.apache.org/jira/browse/NIFI-7654 Project: Apache NiFi Issue T

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455882026 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_hou

[jira] [Updated] (NIFI-7647) Improve accessibility for assistive technology users

2020-07-16 Thread Shane Ardell (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated NIFI-7647: --- Description: Currently, Nifi's UI is not very accessible for assistive technology users, most notably

[jira] [Updated] (NIFI-7647) Improve accessibility for assistive technology users

2020-07-16 Thread Shane Ardell (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated NIFI-7647: --- Summary: Improve accessibility for assistive technology users (was: Improve accessibility for keyboar

[jira] [Commented] (NIFI-7650) UI is not navigable with a keyboard

2020-07-16 Thread Shane Ardell (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159295#comment-17159295 ] Shane Ardell commented on NIFI-7650: I realize this can be a really big task, especial

[jira] [Created] (NIFI-7653) Global menu items cannot be accessed with keyboard or screenreader

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7653: -- Summary: Global menu items cannot be accessed with keyboard or screenreader Key: NIFI-7653 URL: https://issues.apache.org/jira/browse/NIFI-7653 Project: Apache NiFi

[jira] [Created] (NIFI-7652) Nifi logo needs aria label

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7652: -- Summary: Nifi logo needs aria label Key: NIFI-7652 URL: https://issues.apache.org/jira/browse/NIFI-7652 Project: Apache NiFi Issue Type: Sub-task Compo

[jira] [Updated] (NIFI-7651) Modal windows need focus when opened

2020-07-16 Thread Shane Ardell (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated NIFI-7651: --- Component/s: Core UI > Modal windows need focus when opened > > >

[jira] [Created] (NIFI-7651) Modal windows need focus when opened

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7651: -- Summary: Modal windows need focus when opened Key: NIFI-7651 URL: https://issues.apache.org/jira/browse/NIFI-7651 Project: Apache NiFi Issue Type: Sub-task

[jira] [Created] (NIFI-7650) UI is not navigable with a keyboard

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7650: -- Summary: UI is not navigable with a keyboard Key: NIFI-7650 URL: https://issues.apache.org/jira/browse/NIFI-7650 Project: Apache NiFi Issue Type: Sub-task

[jira] [Created] (NIFI-7649) The language of the document is not identified

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7649: -- Summary: The language of the document is not identified Key: NIFI-7649 URL: https://issues.apache.org/jira/browse/NIFI-7649 Project: Apache NiFi Issue Type: Sub-

[jira] [Created] (NIFI-7648) UI needs landmark elements and heading structure

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7648: -- Summary: UI needs landmark elements and heading structure Key: NIFI-7648 URL: https://issues.apache.org/jira/browse/NIFI-7648 Project: Apache NiFi Issue Type: Su

[jira] [Created] (NIFI-7647) Improve accessibility for keyboard and screen reader users

2020-07-16 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7647: -- Summary: Improve accessibility for keyboard and screen reader users Key: NIFI-7647 URL: https://issues.apache.org/jira/browse/NIFI-7647 Project: Apache NiFi Issu

[jira] [Updated] (NIFI-7647) Improve accessibility for keyboard and screen reader users

2020-07-16 Thread Shane Ardell (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated NIFI-7647: --- Issue Type: Task (was: Improvement) > Improve accessibility for keyboard and screen reader users > --

[jira] [Created] (NIFI-7646) Improve performance of MergeContent / others that read content of many small FlowFiles

2020-07-16 Thread Mark Payne (Jira)
Mark Payne created NIFI-7646: Summary: Improve performance of MergeContent / others that read content of many small FlowFiles Key: NIFI-7646 URL: https://issues.apache.org/jira/browse/NIFI-7646 Project: A

[jira] [Resolved] (MINIFICPP-1172) Fix flickery http test cases

2020-07-16 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda resolved MINIFICPP-1172. --- Resolution: Fixed > Fix flickery http test cases > > >

[jira] [Assigned] (NIFI-7640) HandleHttpRequest - define temporary files location

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth reassigned NIFI-7640: - Assignee: Tamás Bunth > HandleHttpRequest - define temporary files location > ---

[jira] [Commented] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159222#comment-17159222 ] Tamás Bunth commented on NIFI-7643: --- Setting version to Nifi 2.0 because of API change.

[jira] [Updated] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth updated NIFI-7643: -- Labels: (was: NIFI) > Unpackcontent writing absolute path property does not make sense > -

[jira] [Updated] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth updated NIFI-7643: -- Fix Version/s: 2.0.0 > Unpackcontent writing absolute path property does not make sense > --

[jira] [Updated] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth updated NIFI-7643: -- Priority: Minor (was: Major) > Unpackcontent writing absolute path property does not make sense > -

[jira] [Updated] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth updated NIFI-7643: -- Labels: NIFI (was: ) > Unpackcontent writing absolute path property does not make sense > -

[jira] [Updated] (MINIFICPP-1296) All tests should use volatile state storage

2020-07-16 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1296: -- Labels: MiNiFi-CPP-Hygiene (was: ) > All tests should use volatile state storage > ---

[jira] [Updated] (MINIFICPP-1172) Fix flickery http test cases

2020-07-16 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1172: -- Priority: Minor (was: Major) > Fix flickery http test cases >

[jira] [Created] (MINIFICPP-1296) All tests should use volatile state storage

2020-07-16 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1296: - Summary: All tests should use volatile state storage Key: MINIFICPP-1296 URL: https://issues.apache.org/jira/browse/MINIFICPP-1296 Project: Apache NiFi MiNiFi C++

[jira] [Updated] (MINIFICPP-1295) ListenHTTP tests are unstable

2020-07-16 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1295: -- Labels: MiNiFi-CPP-Hygiene (was: ) > ListenHTTP tests are unstable > -

[jira] [Created] (MINIFICPP-1295) ListenHTTP tests are unstable

2020-07-16 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1295: - Summary: ListenHTTP tests are unstable Key: MINIFICPP-1295 URL: https://issues.apache.org/jira/browse/MINIFICPP-1295 Project: Apache NiFi MiNiFi C++ Issue

[jira] [Resolved] (MINIFICPP-1183) Cleanup C2 Update tests

2020-07-16 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ádám Markovics resolved MINIFICPP-1183. --- Resolution: Fixed > Cleanup C2 Update tests > --- > >

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455754334 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455734975 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455734975 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_h

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455722904 ## File path: libminifi/include/utils/TimeUtil.h ## @@ -108,23 +144,9 @@ inline int64_t parseDateTimeStr(const std::string &str) { timeinfo.tm_hou

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r455686258 ## File path: libminifi/include/core/FlowFile.h ## @@ -35,9 +35,56 @@ namespace minifi { namespace core { class FlowFile : public core::Connectab

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454913192 ## File path: libminifi/include/core/FlowFile.h ## @@ -35,9 +36,58 @@ namespace minifi { namespace core { class FlowFile : public core::Connectab

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455658255 ## File path: LICENSE ## @@ -258,23 +258,27 @@ This product bundles 'spdlog' which is available under an MIT license. Copyright (c)

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

2020-07-16 Thread GitBox
szaszm commented on a change in pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455647101 ## File path: LICENSE ## @@ -258,23 +258,27 @@ This product bundles 'spdlog' which is available under an MIT license. Copyright (c)

[jira] [Resolved] (MINIFICPP-1248) Unit test CWEL using WIN API

2020-07-16 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1248. --- Resolution: Fixed > Unit test CWEL using WIN API > >

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

2020-07-16 Thread GitBox
hunyadi-dev commented on a change in pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455637198 ## File path: libminifi/include/core/PropertyValidation.h ## @@ -202,7 +202,7 @@ class UnsignedIntValidator : public PropertyValidator { clas

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455632531 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -40,7 +40,7 @@ uint64_t FileUtils::computeChecksum(const std::string &file_name, uint64

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.7.0

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r455631883 ## File path: libminifi/include/core/PropertyValidation.h ## @@ -202,7 +202,7 @@ class UnsignedIntValidator : public PropertyValidator { class L

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
arpadboda commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455592632 ## File path: libminifi/test/unit/TimeUtilTests.cpp ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-16 Thread GitBox
fgerlits commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455576871 ## File path: libminifi/test/unit/TimeUtilTests.cpp ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #835: MINIFICPP-1281 - Improve test performance by using event polling instead of sleep by sync

2020-07-16 Thread GitBox
hunyadi-dev commented on a change in pull request #835: URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r44339 ## File path: libminifi/include/utils/IntegrationTestUtils.h ## @@ -0,0 +1,66 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #835: MINIFICPP-1281 - Improve test performance by using event polling instead of sleep by sync

2020-07-16 Thread GitBox
hunyadi-dev commented on a change in pull request #835: URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r44004 ## File path: libminifi/include/utils/IntegrationTestUtils.h ## @@ -0,0 +1,66 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) u