[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r529266987 ## File path: libminifi/include/utils/StringView.h ## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r529261449 ## File path: libminifi/include/c2/C2Payload.h ## @@ -164,10 +161,9 @@ class C2Payload : public state::Update { bool isContainer() const

[jira] [Commented] (NIFI-7988) Prometheus Remote Write Processor

2020-11-23 Thread Javi Roman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237891#comment-17237891 ] Javi Roman commented on NIFI-7988: -- An easy way of testing this processor is using docker compose

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4646: URL: https://github.com/apache/nifi/pull/4646#discussion_r529080745 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDeduplicateRecords.java

[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2020-11-23 Thread GitBox
joewitt commented on pull request #4513: URL: https://github.com/apache/nifi/pull/4513#issuecomment-732465379 Understood - thanks This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (NIFI-8038) Potential deadlock when updating parameter contexts

2020-11-23 Thread Mark Payne (Jira)
Mark Payne created NIFI-8038: Summary: Potential deadlock when updating parameter contexts Key: NIFI-8038 URL: https://issues.apache.org/jira/browse/NIFI-8038 Project: Apache NiFi Issue Type:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4683: NIFI-8029 Adding StringEscapeUtils.escapeJava() to correct value with…

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4683: URL: https://github.com/apache/nifi/pull/4683#discussion_r529011729 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java ##

[GitHub] [nifi] markap14 commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
markap14 commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r529003694 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r528996539 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] mattyb149 commented on a change in pull request #4635: NIFI-7821 Added Cassandra-based DMC.

2020-11-23 Thread GitBox
mattyb149 commented on a change in pull request #4635: URL: https://github.com/apache/nifi/pull/4635#discussion_r528962136 ## File path:

[GitHub] [nifi] markap14 commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
markap14 commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r528981434 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] chcharlet commented on pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord

2020-11-23 Thread GitBox
chcharlet commented on pull request #3953: URL: https://github.com/apache/nifi/pull/3953#issuecomment-732411933 @MikeThomsen I'd be happy to do that. In fact I think we should split it into two, if I remember correctly what I wrote originally. There is an issue with 1.8 support which is

[GitHub] [nifi] MikeThomsen commented on pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2020-11-23 Thread GitBox
MikeThomsen commented on pull request #4646: URL: https://github.com/apache/nifi/pull/4646#issuecomment-732402943 @mattyb149 thanks for taking a look. I'll try to carve out some time in the evening to address. This is an

[GitHub] [nifi] alfprado commented on a change in pull request #4683: NIFI-8029 Adding StringEscapeUtils.escapeJava() to correct value with…

2020-11-23 Thread GitBox
alfprado commented on a change in pull request #4683: URL: https://github.com/apache/nifi/pull/4683#discussion_r528963481 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java ## @@

[GitHub] [nifi] mattyb149 commented on a change in pull request #4646: NIFI-6047 Add DeduplicateRecords (combines 6047 and 6014)

2020-11-23 Thread GitBox
mattyb149 commented on a change in pull request #4646: URL: https://github.com/apache/nifi/pull/4646#discussion_r528945585 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DeduplicateRecords.java ##

[jira] [Assigned] (NIFI-7662) Add unit tests for Java 8 update 262 TLS v1.3 handling for different vendors

2020-11-23 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-7662: -- Assignee: David Handermann > Add unit tests for Java 8 update 262 TLS v1.3 handling

[jira] [Updated] (NIFI-7937) Refactor FlowFile Media Type Strings to Enumeration

2020-11-23 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-7937: --- Priority: Trivial (was: Minor) > Refactor FlowFile Media Type Strings to Enumeration >

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r528946998 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] anaylor commented on pull request #4641: NIFI-6394 - Ability to export contents of a List Queue

2020-11-23 Thread GitBox
anaylor commented on pull request #4641: URL: https://github.com/apache/nifi/pull/4641#issuecomment-732376543 Our use case would be for tracking specific files throughout the system. Sometimes we get asked about where a specific file is on our system, with a queue limit of 100 we don't

[GitHub] [nifi] markap14 commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
markap14 commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r528940181 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] markap14 commented on a change in pull request #4669: NIFI-7897: Refactored NiFi Stateless to make use of existing NiFi classes

2020-11-23 Thread GitBox
markap14 commented on a change in pull request #4669: URL: https://github.com/apache/nifi/pull/4669#discussion_r528938390 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md ## @@ -0,0 +1,405 @@ + + +# Introduction + +The Apache NiFi

[GitHub] [nifi] mattyb149 commented on a change in pull request #4683: NIFI-8029 Adding StringEscapeUtils.escapeJava() to correct value with…

2020-11-23 Thread GitBox
mattyb149 commented on a change in pull request #4683: URL: https://github.com/apache/nifi/pull/4683#discussion_r528931706 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java ## @@

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #924: MINIFICPP-1389 - Upgrade librdkafka to version 1.5.0

2020-11-23 Thread GitBox
szaszm commented on pull request #924: URL: https://github.com/apache/nifi-minifi-cpp/pull/924#issuecomment-732347261 I'm pretty sure the answer is yes: we need to include all transitive dependencies' licenses and notices. Otherwise it would be trivial to circumvent these requirements by

[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2020-11-23 Thread GitBox
ottobackwards commented on pull request #4513: URL: https://github.com/apache/nifi/pull/4513#issuecomment-732336116 Ok, added. I would like to say why I didn't do so at the start, but I've forgotten This is an automated

[jira] [Updated] (NIFI-8029) InvokeHTTP throwing illegalArgumentException when dynamic property has accent

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8029: --- Affects Version/s: (was: 1.12.1) Status: Patch Available (was: Open) > InvokeHTTP

[jira] [Commented] (NIFI-7958) Add support for decimal to ConvertAvroToORC

2020-11-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237557#comment-17237557 ] ASF subversion and git services commented on NIFI-7958: --- Commit

[jira] [Updated] (NIFI-7958) Add support for decimal to ConvertAvroToORC

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7958: --- Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [nifi] mattyb149 closed pull request #4628: NIFI-7958 ConvertAvroToORC - decimal support

2020-11-23 Thread GitBox
mattyb149 closed pull request #4628: URL: https://github.com/apache/nifi/pull/4628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] mattyb149 commented on pull request #4628: NIFI-7958 ConvertAvroToORC - decimal support

2020-11-23 Thread GitBox
mattyb149 commented on pull request #4628: URL: https://github.com/apache/nifi/pull/4628#issuecomment-732328696 +1 LGTM, verified the issue without the PR and that Hive/ORC decimal fields can be supported by ConvertAvroToORC (even though it uses a version of Avro that doesn't have logical

[jira] [Updated] (NIFI-7958) Add support for decimal to ConvertAvroToORC

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7958: --- Affects Version/s: (was: 1.12.1) Labels: (was: pull-request-available)

[GitHub] [nifi] alfprado opened a new pull request #4683: NIFI-8029 Adding StringEscapeUtils.escapeJava() to correct value with…

2020-11-23 Thread GitBox
alfprado opened a new pull request #4683: URL: https://github.com/apache/nifi/pull/4683 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: NIFI-8029 Provides update on InvokeHTTP.class it was throwing

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #837: MINIFICPP-1121 - Upgrade spdlog to version 1.8.0

2020-11-23 Thread GitBox
hunyadi-dev commented on pull request #837: URL: https://github.com/apache/nifi-minifi-cpp/pull/837#issuecomment-732312187 > I got rid of the cmake issue in `make debian`. > > * by upgrading to debian 10 buster:

[GitHub] [nifi] ottobackwards commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2020-11-23 Thread GitBox
ottobackwards commented on pull request #4513: URL: https://github.com/apache/nifi/pull/4513#issuecomment-732308802 I think there is only `ITestHandleHttpRequest`, which I took to be an integration test. I will add something there

[jira] [Updated] (NIFI-7973) Oracle JDBC - ExecuteSqlRecord and other components fail on zero precision

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7973: --- Status: Patch Available (was: In Progress) > Oracle JDBC - ExecuteSqlRecord and other components

[GitHub] [nifi] mattyb149 opened a new pull request #4682: NIFI-7973: Add default precision and scale properties to remaining SQL-based components

2020-11-23 Thread GitBox
mattyb149 opened a new pull request #4682: URL: https://github.com/apache/nifi/pull/4682 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Some SQL-based components were missing Default

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
szaszm commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528782733 ## File path: encrypt-config/CommandException.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (NIFI-7973) Oracle JDBC - ExecuteSqlRecord and other components fail on zero precision

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237459#comment-17237459 ] Matt Burgess commented on NIFI-7973: The other SQL Query components (DatabaseRecordLookupService,

[jira] [Updated] (NIFI-7973) Oracle JDBC - ExecuteSqlRecord and other components fail on zero precision

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7973: --- Summary: Oracle JDBC - ExecuteSqlRecord and other components fail on zero precision (was: Oracle

[GitHub] [nifi] NissimShiman commented on a change in pull request #4627: NIFI-7225 FetchSFTP processor routing to not.found error given when P…

2020-11-23 Thread GitBox
NissimShiman commented on a change in pull request #4627: URL: https://github.com/apache/nifi/pull/4627#discussion_r528817029 ## File path: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java ## @@ -848,8 +849,8 @@ public

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4594: NIFI-3669 Add SSL Support to CaptureChangeMySQL

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4594: URL: https://github.com/apache/nifi/pull/4594#discussion_r528797353 ## File path:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4681: added userGroupsFilterExpression to allow per user LDAP filters

2020-11-23 Thread GitBox
exceptionfactory commented on a change in pull request #4681: URL: https://github.com/apache/nifi/pull/4681#discussion_r528769423 ## File path:

[GitHub] [nifi] joewitt commented on pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2020-11-23 Thread GitBox
joewitt commented on pull request #4513: URL: https://github.com/apache/nifi/pull/4513#issuecomment-732221327 @ottobackwards this processor doesn't have unit tests or this new thing is too difficult to have a unit test for?

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528764869 ## File path: encrypt-config/EncryptConfig.cpp ## @@ -42,81 +40,119 @@ namespace nifi { namespace minifi { namespace encrypt_config {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528764113 ## File path: encrypt-config/ArgParser.cpp ## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528763519 ## File path: encrypt-config/ArgParser.h ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
adamdebreceni commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528763519 ## File path: encrypt-config/ArgParser.h ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Updated] (NIFI-7973) Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema - Decimal types

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7973: --- Priority: Major (was: Blocker) > Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema -

[jira] [Updated] (NIFI-7973) Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema - Decimal types

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7973: --- Affects Version/s: (was: 1.12.1) > Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro

[jira] [Updated] (NIFI-7973) Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema - Decimal types

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7973: --- Component/s: (was: Core Framework) Extensions > Oracle JDBC - ExcecuteSqlRecord

[jira] [Assigned] (NIFI-7973) Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema - Decimal types

2020-11-23 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-7973: -- Assignee: Matt Burgess > Oracle JDBC - ExcecuteSqlRecord - Unable to determine Avro Schema -

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #941: MINIFICPP-1411 - Convert \n newline characters to tags in the docs generation

2020-11-23 Thread GitBox
hunyadi-dev opened a new pull request #941: URL: https://github.com/apache/nifi-minifi-cpp/pull/941 When agent documentation generation is run, processor property descriptions that contain `\n` characters are not properly generated, as manual linebreaks in github markdown tables are not

[jira] [Resolved] (NIFI-5866) Cluster gets out of sync: "X is not the most up-to-date revision."

2020-11-23 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-5866. -- Fix Version/s: 1.13.0 Resolution: Duplicate This is a duplicate of NIFI-7920, which was fixed in

[GitHub] [nifi] markap14 commented on pull request #4602: NIFI-7920: When node that is connected to cluster is asked to reconne…

2020-11-23 Thread GitBox
markap14 commented on pull request #4602: URL: https://github.com/apache/nifi/pull/4602#issuecomment-732200676 To provide a clearer explanation of what this change is doing (since looking at the code change doesn't make it clear that anything related to component revisions changed)...

[jira] [Updated] (NIFI-7920) When enabling Controller Services, if Cluster Coordinator fails to enable, can result in service becoming unmodifiable with error "Revision ... is not the most up-to-date

2020-11-23 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-7920: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available) > When

[jira] [Created] (MINIFICPP-1411) Replace \n characters with in agent docs generation

2020-11-23 Thread Adam Hunyadi (Jira)
Adam Hunyadi created MINIFICPP-1411: --- Summary: Replace \n characters with in agent docs generation Key: MINIFICPP-1411 URL: https://issues.apache.org/jira/browse/MINIFICPP-1411 Project: Apache NiFi

[jira] [Created] (NIFI-8037) Support TLS 1.3 in SSLContextService on Java 8

2020-11-23 Thread David Handermann (Jira)
David Handermann created NIFI-8037: -- Summary: Support TLS 1.3 in SSLContextService on Java 8 Key: NIFI-8037 URL: https://issues.apache.org/jira/browse/NIFI-8037 Project: Apache NiFi Issue

[jira] [Assigned] (MINIFICPP-1367) Add cmake flag for disabling building nanofi

2020-11-23 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi reassigned MINIFICPP-1367: --- Assignee: (was: Adam Hunyadi) > Add cmake flag for disabling building

[GitHub] [nifi] MikeThomsen commented on pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord

2020-11-23 Thread GitBox
MikeThomsen commented on pull request #3953: URL: https://github.com/apache/nifi/pull/3953#issuecomment-732155204 @chcharlet if you want to send a PR to my branch, that would work too. This is an automated message from the

[GitHub] [nifi] MikeThomsen commented on pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord

2020-11-23 Thread GitBox
MikeThomsen commented on pull request #3953: URL: https://github.com/apache/nifi/pull/3953#issuecomment-732140486 @chcharlet thanks for poking us on this. I'll try to find some time to factor in your feedback on Jira. This

[jira] [Created] (NIFI-8036) PutElasticsearchHttp could add failure reason as an attribute

2020-11-23 Thread Joseph Gresock (Jira)
Joseph Gresock created NIFI-8036: Summary: PutElasticsearchHttp could add failure reason as an attribute Key: NIFI-8036 URL: https://issues.apache.org/jira/browse/NIFI-8036 Project: Apache NiFi

[GitHub] [nifi] chcharlet commented on pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord

2020-11-23 Thread GitBox
chcharlet commented on pull request #3953: URL: https://github.com/apache/nifi/pull/3953#issuecomment-732122931 This is as an absolutely awesome feature, but I'm not sure how alive this branch still is? I have tried using this branch and I think there are some minor kinks to be

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528653994 ## File path: libminifi/test/unit/StringUtilsTests.cpp ## @@ -50,6 +50,16 @@ TEST_CASE("TestStringUtils::split4", "[test split classname]") {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528651838 ## File path: libminifi/test/TestBase.h ## @@ -200,7 +199,7 @@ class LogTestController { } my_properties_->set("logger.root",

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528648823 ## File path: libminifi/test/TestBase.cpp ## @@ -61,78 +62,51 @@ TestPlan::~TestPlan() { for (auto& processor : configured_processors_) {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528647463 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -35,7 +35,11 @@ std::string StringUtils::trim(std::string s) { return

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #937: MINIFICPP-1402 - Encrypt flow configuration and change encryption key

2020-11-23 Thread GitBox
arpadboda commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r528639539 ## File path: encrypt-config/ArgParser.h ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528642934 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #940: MINIFICPP-1389 - Implement ConsumeKafka

2020-11-23 Thread GitBox
hunyadi-dev opened a new pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940 Notes: 1. This Pull request depends on having the librdkafka version updated (#924). 1. The testing performed so far was run manually only. by having a kafka broker running locally

[GitHub] [nifi-minifi-cpp] hunyadi-dev edited a comment on pull request #924: MINIFICPP-1389 - Upgrade librdkafka to version 1.5.0

2020-11-23 Thread GitBox
hunyadi-dev edited a comment on pull request #924: URL: https://github.com/apache/nifi-minifi-cpp/pull/924#issuecomment-732088845 > I think we need to update the LICENSE file with the new versions of the licenses. Updated the included librdkafka license files. However I am not sure

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #924: MINIFICPP-1389 - Upgrade librdkafka to version 1.5.0

2020-11-23 Thread GitBox
hunyadi-dev commented on pull request #924: URL: https://github.com/apache/nifi-minifi-cpp/pull/924#issuecomment-732088845 > I think we need to update the LICENSE file with the new versions of the licenses. Updated the librdkafka license files. However I am not sure if we should