[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364408883 > What did you have in mind for implementing a literal null as a function argument? I only question if it is more clearer than specifying to users to use an empty string which we

[jira] [Created] (NIFI-11006) Refactor nifi-framework-bundle to use JUnit 5 Part 4

2022-12-23 Thread Daniel Stieglitz (Jira)
Daniel Stieglitz created NIFI-11006: --- Summary: Refactor nifi-framework-bundle to use JUnit 5 Part 4 Key: NIFI-11006 URL: https://issues.apache.org/jira/browse/NIFI-11006 Project: Apache NiFi

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364270877 @exceptionfactory I am fine with only implementing the the seven argument constructor. What did you have in mind for implementing a literal null as a function argument? I only question if it

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364267630 Thanks for the reply @dan-s1. As you observed, the Expression Language parser does not support a literal `null` as a function argument. It would take a bit more work, but it

[jira] [Commented] (NIFI-10979) Refactor nifi-framework-bundle to use JUnit 5 Part 3

2022-12-23 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651708#comment-17651708 ] David Handermann commented on NIFI-10979: - Thanks the work [~dstiegli1]! Since

[jira] [Updated] (NIFI-10979) Refactor nifi-framework-bundle to use JUnit 5 Part 3

2022-12-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10979: Status: Patch Available (was: Open) > Refactor nifi-framework-bundle to use JUnit 5 Part

[GitHub] [nifi] dan-s1 opened a new pull request, #6806: [NIFI-10979] Made changes to upgrade to JUnit5.

2022-12-23 Thread GitBox
dan-s1 opened a new pull request, #6806: URL: https://github.com/apache/nifi/pull/6806 # Summary [NIFI-10979](https://issues.apache.org/jira/browse/NIFI-10979) # Tracking Please complete the following tracking steps

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364180293 > Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. > > With that background, do you need all of the possible constructor

[jira] [Commented] (NIFI-10979) Refactor nifi-framework-bundle to use JUnit 5 Part 3

2022-12-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651705#comment-17651705 ] Daniel Stieglitz commented on NIFI-10979: - [~exceptionfactory] I have made changes to the above

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364167903 Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. With that background, do you need all of the possible constructor

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056535336 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/ResultOutputStrategy.java:

[jira] [Updated] (NIFI-11005) Add Illegal and Redundant Import Modules to Checkstyle Configuration

2022-12-23 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11005: -- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-11005) Add Illegal and Redundant Import Modules to Checkstyle Configuration

2022-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651699#comment-17651699 ] ASF subversion and git services commented on NIFI-11005: Commit

[GitHub] [nifi] asfgit closed pull request #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration

2022-12-23 Thread GitBox
asfgit closed pull request #6804: NIFI-11005 Add New Import Modules to Checkstyle Configuration URL: https://github.com/apache/nifi/pull/6804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (NIFI-10988) Using multiple ConsumeGCPubSubLite processors causes misrouting of messages

2022-12-23 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10988: -- Affects Version/s: 1.19.1 1.19.0 1.18.0

[jira] [Resolved] (NIFI-10988) Using multiple ConsumeGCPubSubLite processors causes misrouting of messages

2022-12-23 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-10988. --- Fix Version/s: 1.20.0 Assignee: Eric Bernard Resolution: Fixed > Using

[jira] [Commented] (NIFI-10988) Using multiple ConsumeGCPubSubLite processors causes misrouting of messages

2022-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651698#comment-17651698 ] ASF subversion and git services commented on NIFI-10988: Commit

[GitHub] [nifi] asfgit closed pull request #6788: NIFI-10988 - Fix `ConsumeGCPubSubLite` processors delivering incorrect messages

2022-12-23 Thread GitBox
asfgit closed pull request #6788: NIFI-10988 - Fix `ConsumeGCPubSubLite` processors delivering incorrect messages URL: https://github.com/apache/nifi/pull/6788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi] exceptionfactory commented on pull request #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6805: URL: https://github.com/apache/nifi/pull/6805#issuecomment-1364127208 Thanks for the feedback and suggestions @Lehel44, I updated the wording in several places and included links to OWASP and Spring Security reference pages. -- This is an automated

[GitHub] [nifi] exceptionfactory commented on pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6802: URL: https://github.com/apache/nifi/pull/6802#issuecomment-1364109162 > Why do we need to update nifi-resources.pom? Thanks for the feedback @Lehel44. The updates to `pom.xml` in `nifi-resources` sets the default value for the `nifi.properties`

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1460: MINIFICPP-1995 Add configuring path for flowfile_checkpoint directory

2022-12-23 Thread GitBox
fgerlits commented on code in PR #1460: URL: https://github.com/apache/nifi-minifi-cpp/pull/1460#discussion_r1056437169 ## extensions/rocksdb-repos/FlowFileRepository.h: ## @@ -100,11 +100,17 @@ class FlowFileRepository : public ThreadedRepository, public SwapManager {

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6802: URL: https://github.com/apache/nifi/pull/6802#discussion_r1056363577 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -503,6 +503,9 @@ JSON Web Key (JWK) provided through the jwks_uri in the metadata found at the di

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6803: NIFI-10998: Fix SplitJson to always compile new JsonPath when property changes

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6803: URL: https://github.com/apache/nifi/pull/6803#discussion_r1056360444 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitJson.java: ## @@ -112,6 +112,43 @@ public

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6805: NIFI-10855 Add Documentation on CSRF Protection

2022-12-23 Thread GitBox
Lehel44 commented on code in PR #6805: URL: https://github.com/apache/nifi/pull/6805#discussion_r1056337558 ## nifi-docs/src/main/asciidoc/administration-guide.adoc: ## @@ -582,6 +582,36 @@ The following settings can be configured in _nifi.properties_ to control JSON We

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
dan-s1 commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363956081 > Thanks for working on this new feature @dan-s1. Although most of the implementation makes sense, it raises some questions about treating blanks strings as nulls. Although the

[jira] [Commented] (MINIFICPP-2011) Add the CollectKubernetesPodMetrics processor to PROCESSORS.md

2022-12-23 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651637#comment-17651637 ] Ferenc Gerlits commented on MINIFICPP-2011: --- Cancelled in favor of

[jira] [Resolved] (MINIFICPP-2011) Add the CollectKubernetesPodMetrics processor to PROCESSORS.md

2022-12-23 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-2011. --- Fix Version/s: (was: 0.14.0) Resolution: Duplicate > Add the

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1483: MINIFICPP-2019 Fix auto-generation of PROCESSORS.md

2022-12-23 Thread GitBox
fgerlits opened a new pull request, #1483: URL: https://github.com/apache/nifi-minifi-cpp/pull/1483 https://issues.apache.org/jira/browse/MINIFICPP-2019 The `PROCESSORS.md` file included in this PR is almost auto-generated (by merging the output of `minifi docs ...` on Linux and on

[jira] [Created] (MINIFICPP-2021) Enable auto-generation of everything in PROCESSORS.md

2022-12-23 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-2021: - Summary: Enable auto-generation of everything in PROCESSORS.md Key: MINIFICPP-2021 URL: https://issues.apache.org/jira/browse/MINIFICPP-2021 Project: Apache

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056252416 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/PaginationType.java:

[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

2022-12-23 Thread GitBox
ChrisSamo632 commented on code in PR #6687: URL: https://github.com/apache/nifi/pull/6687#discussion_r1056252276 ## nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/api/ResultOutputStrategy.java:

[jira] [Commented] (NIFI-11003) PutIceberg Failes to write to S3

2022-12-23 Thread Mark Bathori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651588#comment-17651588 ] Mark Bathori commented on NIFI-11003: - Unfortunately you need to make a custom build from

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

2022-12-23 Thread GitBox
fgerlits commented on code in PR #1481: URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1055622646 ## libminifi/include/core/logging/LoggerConfiguration.h: ## @@ -133,16 +132,21 @@ class LoggerConfiguration { class LoggerImpl : public Logger {